cistern 2.8.1 → 2.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6949d6bf767316892c02a7ae3ae1f14afc2cff8331b4fc0a72bf93295e126e7a
-  data.tar.gz: d2a27bae1d717ec47ed4f6135cc7fa4e635423a1f81e7facd2b616cf33eed3ef
+  metadata.gz: 13428a2696bc1c11c76ec323e498a73268070325702dac6b5107ac16786537a8
+  data.tar.gz: 58c19d84a3d6f0b9fd347a10c916aa925136896f91f49634a9c2bbbcc011ed26
 SHA512:
-  metadata.gz: '02565729c04cff5108f5b3b7547e635b3c3a56dd239d00bb3108b8106a05ad7a50d79b03992dddea1a136bf66552d97a3c140d282a1218c73c5b0e4df1116b2a'
-  data.tar.gz: aa96a0b7dd8ad8e985e4ee8c9f1d22f8c8ca673b9ef9346d7771a4b853440791a7acef4a9f95fb6cb2c86b69f0d969bc8c8cc8f62f9a92c793798781601631cc
+  metadata.gz: 4f8642906b69eb047b6f907b786a3a42c14e6313ba177f5c314994abdc652285dabbba8cd594e8661c651f3fbf4e926dd82d788bf8a3ae2fb9a902e25a3ad604
+  data.tar.gz: 406ed32508a96668915a3485e61dc9f7abd9fc68a9989ff9c1f2ccfb16d5646400501fbad4c29cfdd8d6ee82ef3fe9fffc577d947bcdff4eaf510529e090b22f

data/lib/cistern/associations.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 module Cistern::Associations
-
   def self.extended(klass)
     def klass.association_overlay
       @association_overlay ||= const_set(:Associations, Module.new)
@@ -15,7 +14,7 @@ module Cistern::Associations
   # Lists the associations defined on the resource
   # @return [Hash{Symbol=>Array}] mapping of association type to name
   def associations
-    @associations ||= Hash.new { |h,k| h[k] = [] }
+    @associations ||= Hash.new { |h, k| h[k] = [] }
   end
 
   # Define an assocation that references a collection.
@@ -51,9 +50,15 @@ module Cistern::Associations
 
     association_overlay.module_eval do
       define_method writer_method do |models|
-        attributes[name] = Array(models).map do |model|
-          model.respond_to?(:attributes) ? model.attributes : model
-        end
+        previous_value = attributes[name_sym]
+        new_value =
+          attributes[name_sym] = Array(models).map do |model|
+            model.respond_to?(:attributes) ? model.attributes : model
+          end
+
+        changed!(name_sym, previous_value, new_value)
+
+        new_value
       end
     end
 
@@ -90,9 +95,13 @@ module Cistern::Associations
 
     association_overlay.module_eval do
       define_method writer_method do |model|
-        data = model.respond_to?(:attributes) ? model.attributes : model
-        attributes[name_sym] = data
-        model
+        previous_value = attributes[name_sym]
+        new_value = model.respond_to?(:attributes) ? model.attributes : model
+        attributes[name_sym] = new_value
+
+        changed!(name_sym, previous_value, new_value)
+
+        new_value
       end
     end
 

data/lib/cistern/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Cistern
-  VERSION = '2.8.1'
+  VERSION = '2.8.2'
 end

data/spec/dirty_spec.rb

@@ -3,18 +3,35 @@
 require 'spec_helper'
 
 describe 'Cistern::Model#dirty' do
-  subject {
+  subject do
     Class.new(Sample::Model) do
       identity :id
 
       attribute :name
       attribute :properties, type: :array
 
+      has_many :many, -> { [] }
+      belongs_to :one, -> { true }
+
       def save
         merge_attributes(attributes)
       end
     end
-  }
+  end
+
+  it 'marks has_many associations as dirty' do
+    model = subject.new(many: [1, 2])
+    expect(model.changed).to be_empty
+    expect { model.many = [3, 4] }.to change { model.dirty? }.to(true)
+    expect(model.changed).to eq(many: [[1, 2], [3, 4]])
+  end
+
+  it 'marks belongs_to associations as dirty' do
+    model = subject.new(one: 1)
+    expect(model.changed).to be_empty
+    expect { model.one = 2 }.to change { model.dirty? }.to(true)
+    expect(model.changed).to eq(one: [1, 2])
+  end
 
   it 'should mark a existing record as dirty' do
     model = subject.new(id: 1, name: 'steve')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cistern
 version: !ruby/object:Gem::Version
-  version: 2.8.1
+  version: 2.8.2
 platform: ruby
 authors:
 - Josh Lane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-01 00:00:00.000000000 Z
+date: 2018-05-02 00:00:00.000000000 Z
 dependencies: []
 description: API client framework extracted from Fog
 email: