cistern 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62a24a469ced62056ea61f768a991144ea7dad32
-  data.tar.gz: 30ca44a90ed296c9018078bf7e7ea4ee47e0925f
+  metadata.gz: 51ecc36c328ba3a9a404a952c76144db023edfa3
+  data.tar.gz: 0a7a965f9b3a3c37b78cd78802456537e251e3b8
 SHA512:
-  metadata.gz: e6099df1553e5ffe2545dacf6b5b0ed30962aa8a34fa5411c657e6346cf38a129d8905d2d49e8b1eb64ef105acaccdb04013acd5791e9e4e8899305a7864a333
-  data.tar.gz: ea06d0083d50711092a437b8a3af93de9ee947138c273670a45553690d2c4944214a5d2e93e778fefaead17744f9688f41333cf8de0cc1318453c23df35dec43
+  metadata.gz: f668e16c9431a22a14fcc628872b337835c9873fde7e75fc9099f6eb257d4c5cf30657e4b0513efad785d567be9ef2650d29db5d2acabc9d2dd6cdc232e4845f
+  data.tar.gz: ecf04f9577df53a188eb09496d34c01a6a8696af93377a5ef45982afe6f63d5f96ba1af4c1d80d4cf585794c53c600524b42c6d8cc9a8b9de000289f3f85707f

data/lib/cistern/attributes.rb

@@ -173,11 +173,21 @@ module Cistern::Attributes
     end
 
     def identity
-      send(self.class.instance_variable_get('@identity'))
+      key = self.class.instance_variable_get('@identity')
+
+      if key
+        public_send(key)
+      end
     end
 
     def identity=(new_identity)
-      send("#{self.class.instance_variable_get('@identity')}=", new_identity)
+      key = self.class.instance_variable_get('@identity')
+
+      if key
+        public_send("#{key}=", new_identity)
+      else
+        raise ArgumentError, "Identity not specified"
+      end
     end
 
     def merge_attributes(new_attributes = {})
@@ -222,7 +232,7 @@ module Cistern::Attributes
     end
 
     def new_record?
-      !identity
+      identity.nil?
     end
 
     # check that the attributes specified in args exist and is not nil
@@ -257,7 +267,7 @@ module Cistern::Attributes
     protected
 
     def missing_attributes(args)
-      ([:service] | args).select{|arg| send("#{arg}").nil?}
+      ([:service] | args).select { |arg| send("#{arg}").nil? }
     end
 
     def changed!(attribute, from, to)

data/lib/cistern/version.rb

@@ -1,3 +1,3 @@
 module Cistern
-  VERSION = "2.0.3"
+  VERSION = "2.0.4"
 end

data/spec/model_spec.rb

@@ -20,6 +20,23 @@ describe "Cistern::Model" do
     end
   end
 
+  context "#new_record?" do
+    it "does not require identity" do
+      identity_less = Class.new(Sample::Model)
+
+      expect(identity_less.new.new_record?).to eq(true)
+    end
+
+    it "is false if identity is set" do
+      identity_full = Class.new(Sample::Model) {
+        identity :id
+      }
+
+      expect(identity_full.new.new_record?).to eq(true)
+      expect(identity_full.new(id: 1).new_record?).to eq(false)
+    end
+  end
+
   it "should set singular resource service method" do
     class ModelService < Cistern::Service
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cistern
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Josh Lane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-27 00:00:00.000000000 Z
+date: 2015-09-10 00:00:00.000000000 Z
 dependencies: []
 description: API client framework extracted from Fog
 email: