cisco_node_utils 1.9.0 → 1.10.0

data/tests/ciscotest.rb

@@ -223,8 +223,15 @@ class CiscoTestCase < TestCase
   end
 
   def skip_legacy_defect?(pattern, msg)
+    if pattern.is_a?(String)
+      pattern = [pattern]
+    elsif !pattern.is_a?(Array)
+      fail 'Argument: pattern must be a String or Array object'
+    end
     msg = "Defect in legacy image: [#{msg}]"
-    skip(msg) if Utils.image_version?(Regexp.new(pattern))
+    pattern.each do |pat|
+      skip(msg) if Utils.image_version?(Regexp.new(pat))
+    end
   end
 
   def step_unless_legacy_defect(pattern, msg)

data/tests/test_ace.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2015-2016 Cisco and/or its affiliates.
+# Copyright (c) 2015-2018 Cisco and/or its affiliates.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -57,7 +57,7 @@ class TestAce < CiscoTestCase
     end
   rescue CliError => e
     skip('This property is not supported on this platform') if
-      e.message[/(Invalid parameter detected|Invalid command)/]
+      e.message[/(Invalid parameter detected|Invalid command|Invalid number)/]
     flunk(e.message)
   end
 
@@ -83,7 +83,7 @@ class TestAce < CiscoTestCase
   def test_proto
     %w(ipv4 ipv6).each do |afi|
       # Sampling of proto's
-      %w(ip tcp udp).each do |val|
+      %w(ip tcp udp icmp).each do |val|
         val = 'ipv6' if val[/ip/] && afi[/ipv6/]
         a = ace_helper(afi, proto: val)
         assert_equal(val, a.proto)
@@ -149,6 +149,15 @@ class TestAce < CiscoTestCase
     end
   end
 
+  def test_vlan
+    %w(ipv4 ipv6).each do |afi|
+      %w(10 100).each do |val|
+        a = ace_helper(afi, proto: 'icmp', vlan: val)
+        assert_equal(val, a.vlan)
+      end
+    end
+  end
+
   def test_tcp_flags
     %w(ipv4 ipv6).each do |afi|
       %w(ack fin urg syn psh rst) + [
@@ -187,6 +196,34 @@ class TestAce < CiscoTestCase
     end
   end
 
+  def test_log_proto_option
+    %w(ipv4 ipv6).each do |afi|
+      refute(ace_helper(afi).log)
+      a = ace_helper(afi, proto: 'icmp', proto_option: 'redirect', log: true)
+      assert(a.log)
+    end
+  end
+
+  def test_proto_option
+    %w(ipv4 ipv6).each do |afi|
+      refute(ace_helper(afi).log)
+      a = ace_helper(afi, proto: 'icmp', proto_option: 'time-exceeded')
+      assert_equal(a.proto_option, 'time-exceeded')
+      a = ace_helper(afi, proto: 'icmp', dscp: 'af11', proto_option: 'echo-reply')
+      assert_equal(a.proto_option, 'echo-reply')
+      assert_equal(a.dscp, 'af11')
+    end
+  end
+
+  def test_redirect_proto_option
+    afi = 'ipv4'
+    val = 'port-channel1,port-channel2'
+    a = ace_helper(afi, proto: 'icmp', proto_option: 'redirect',
+                   redirect: val, log: true, set_erspan_dscp: '3', set_erspan_gre_proto: '33')
+    assert_equal(val, a.redirect)
+    assert_equal('redirect', a.proto_option)
+  end
+
   def test_precedence
     afi = 'ipv4'
     %w(critical flash flash-override immediate internet network
@@ -244,4 +281,24 @@ class TestAce < CiscoTestCase
          'CSCuy47463: access-list ttl does not nvgen') if a.ttl.nil?
     assert_equal(val, a.ttl)
   end
+
+  def test_set_erspan_dscp
+    afi = 'ipv4'
+    val = 'port-channel1,port-channel2'
+    a = ace_helper(afi, proto: 'icmp', proto_option: 'redirect',
+                   redirect: val, log: true, set_erspan_dscp: '3', set_erspan_gre_proto: '33')
+    assert_equal('redirect', a.proto_option)
+    assert_equal(val, a.redirect)
+    assert_equal('3', a.set_erspan_dscp)
+  end
+
+  def test_set_erspan_gre_proto
+    afi = 'ipv4'
+    val = 'port-channel1,port-channel2'
+    a = ace_helper(afi, proto: 'icmp', proto_option: 'redirect',
+                   redirect: val, log: true, set_erspan_gre_proto: '33')
+    assert_equal('redirect', a.proto_option)
+    assert_equal(val, a.redirect)
+    assert_equal('33', a.set_erspan_gre_proto)
+  end
 end

data/tests/test_banner.rb

@@ -0,0 +1,85 @@
+#
+# Minitest for Banner class
+#
+# Copyright (c) 2014-2018 Cisco and/or its affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require_relative 'ciscotest'
+require_relative '../lib/cisco_node_utils/banner'
+
+# TestBanner - Minitest for Banner node utility.
+class TestBanner < CiscoTestCase
+  def setup
+    # setup runs at the beginning of each test
+    super
+    no_motd
+  end
+
+  def teardown
+    # teardown runs at the end of each test
+    no_motd
+    super
+  end
+
+  def no_motd
+    # Turn the feature off for a clean test.
+    config('no banner motd')
+  end
+
+  # TESTS
+
+  def test_single_motd
+    id = 'default'
+
+    banner = Cisco::Banner.new(id)
+    assert_includes(Cisco::Banner.banners, id)
+    assert_equal(Cisco::Banner.banners[id], banner)
+
+    assert_equal(banner.default_motd, Cisco::Banner.banners['default'].motd)
+    assert_equal(banner.default_motd, banner.motd)
+
+    banner.motd = 'Test banner!'
+    assert_equal(Cisco::Banner.banners['default'].motd,
+                 'Test banner!')
+    assert_equal(Cisco::Banner.banners['default'].motd,
+                 banner.motd)
+
+    banner.motd = nil
+    assert_equal(banner.default_motd, Cisco::Banner.banners['default'].motd)
+    assert_equal(banner.default_motd, banner.motd)
+  end
+
+  def test_multiline_motd
+    skip_versions = ['7.0.3.I[2-6]', '7.0.3.I7.[1-3]', '7.3', '8.[1-3]']
+    skip_legacy_defect?(skip_versions, 'multiline banner configuration using nxapi not supported')
+    id = 'default'
+
+    banner = Cisco::Banner.new(id)
+    assert_includes(Cisco::Banner.banners, id)
+    assert_equal(Cisco::Banner.banners[id], banner)
+
+    assert_equal(banner.default_motd, Cisco::Banner.banners['default'].motd)
+    assert_equal(banner.default_motd, banner.motd)
+
+    banner.motd = 'This is\na sweet\n\nmultiline\nbanner!\n'
+    assert_equal(Cisco::Banner.banners['default'].motd,
+                 "This is\na sweet\n\nmultiline\nbanner!\n")
+    assert_equal(Cisco::Banner.banners['default'].motd,
+                 banner.motd)
+
+    banner.motd = nil
+    assert_equal(banner.default_motd, Cisco::Banner.banners['default'].motd)
+    assert_equal(banner.default_motd, banner.motd)
+  end
+end

data/tests/test_bgp_af.rb

@@ -175,7 +175,7 @@ class TestBgpAF < CiscoTestCase
           expect = :runtime if test == :additional_paths_receive && Platform.image_version[/8.0|8.1/]
         when /I5.2|I5.3|I6/
           expect = :success if test == :maximum_paths || test == :maximum_paths_ibgp
-        when /I7/
+        when /I7|9\.2/
           expect = :success if test == :maximum_paths ||
                                test == :maximum_paths_ibgp ||
                                test == :additional_paths_send ||

data/tests/test_hostname.rb

@@ -0,0 +1,64 @@
+#
+# Minitest for HostName class
+#
+# Copyright (c) 2014-2018 Cisco and/or its affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require_relative 'ciscotest'
+require_relative '../lib/cisco_node_utils/hostname'
+
+# TestHostname - Minitest for SyslogSetting node utility.
+class TestHostName < CiscoTestCase
+  def setup
+    # setup runs at the beginning of each test
+    super
+    hostname_setup
+  end
+
+  def teardown
+    # teardown runs at the end of each test
+    hostname_teardown
+    super
+  end
+
+  @current_hostname = ''
+
+  def hostname_setup
+    hostname_output = Cisco::Client.filter_cli(
+      cli_output: config('show running-config | include ^hostname'),
+      value:      /hostname (.*)/)
+    @current_hostname = hostname_output.first unless hostname_output.nil?
+    # Turn the feature off for a clean test.
+    config('no hostname')
+  end
+
+  def hostname_teardown
+    if @current_hostname != ''
+      config("hostname #{@current_hostname}")
+    else
+      config('no hostname')
+    end
+  end
+
+  # TESTS
+
+  def test_hostname_name
+    hostname_setting = Cisco::HostName.new('testhost')
+    assert_equal(Cisco::HostName.hostname['testhost'], hostname_setting)
+    hostname_setting = Cisco::HostName.new('testhost2')
+    assert_equal(Cisco::HostName.hostname['testhost2'], hostname_setting)
+    hostname_setting.send('hostname=', nil)
+    assert_nil(Cisco::HostName.hostname['testhost2'])
+  end
+end

data/tests/test_interface.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2013-2017 Cisco and/or its affiliates.
+# Copyright (c) 2013-2018 Cisco and/or its affiliates.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -1250,6 +1250,27 @@ class TestInterface < CiscoTestCase
                  'Error: ip redirects default get value mismatch')
   end
 
+  def test_ipv6_redirects
+    interface = create_interface
+    interface.switchport_mode = :disabled if platform == :nexus
+
+    # check default value
+    assert_equal(interface.default_ipv6_redirects, interface.ipv6_redirects,
+                 'Error: ipv6 redirects default get value mismatch')
+
+    # set with value false
+    interface.ipv6_redirects = false
+    assert_equal(interface.ipv6_redirects, false)
+
+    # set with value true
+    interface.ipv6_redirects = true
+    assert_equal(interface.ipv6_redirects, true)
+
+    # get default and set
+    interface.ipv6_redirects = interface.default_ipv6_redirects
+    assert_equal(interface.ipv6_redirects, interface.default_ipv6_redirects)
+  end
+
   def config_from_hash(inttype_h)
     inttype_h.each do |k, v|
       config('feature interface-vlan') if (/^Vlan\d./).match(k.to_s)

data/tests/test_interface_hsrp_group.rb

@@ -109,8 +109,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
   def test_auth_type_clear
     skip_legacy_defect?('7.3.0.D1.1', 'CSCuh90262: hsrp indentation')
     ihg = create_interface_hsrp_group_ipv4
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
     attrs = {}
     attrs[:authentication_auth_type] = 'cleartext'
     attrs[:authentication_string] = 'Test'
@@ -119,8 +118,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('Test', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
 
     ihg = create_interface_hsrp_group_ipv6
     attrs[:authentication_auth_type] = 'cleartext'
@@ -130,8 +128,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('Test', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_type_md5
@@ -147,8 +144,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('MyMD5Password', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
     ihg = create_interface_hsrp_group_ipv6
     attrs[:authentication_string] = 'MyMD5Password'
     ihg.authentication_set(attrs)
@@ -157,8 +153,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('MyMD5Password', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_0
@@ -178,8 +173,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('7', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
     ihg = create_interface_hsrp_group_ipv6
     attrs[:authentication_string] = '7'
     ihg.authentication_set(attrs)
@@ -189,8 +183,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('7', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_7
@@ -217,8 +210,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal('12345678901234567890', ihg.authentication_string)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_7_compat_timeout_ipv4
@@ -250,8 +242,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal(false, ihg.authentication_compatibility)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_7_compat_timeout_ipv6
@@ -283,8 +274,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal(false, ihg.authentication_compatibility)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_0_compat_timeout_ipv4
@@ -315,8 +305,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal(3333, ihg.authentication_timeout)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_auth_key_string_enc_0_compat_timeout_ipv6
@@ -347,8 +336,7 @@ class TestInterfaceHsrpGroup < CiscoTestCase
     assert_equal(3333, ihg.authentication_timeout)
     attrs[:authentication_string] = ihg.default_authentication_string
     ihg.authentication_set(attrs)
-    assert_equal(ihg.default_authentication_string,
-                 ihg.authentication_string)
+    assert_nil(ihg.authentication_string)
   end
 
   def test_preempt_ipv4

data/tests/test_ip_multicast.rb

@@ -38,31 +38,42 @@ class TestIpMulticast < CiscoTestCase
     super
   end
 
-  def test_ip_multicast
+  def test_overlay_distributed_dr
+    skip_legacy_defect?('7.0.3.I7.4', 'CSCvk01535')
+
+    ipm = IpMulticast.new
+
+    # Test Defaults
+    have = ipm.overlay_distributed_dr
+    should = ipm.default_overlay_distributed_dr
+    assert_equal(have, should, 'overlay_distributed_dr does not match default value')
+
+    # Test property set
+    ipm.overlay_distributed_dr = true
+    assert_equal(ipm.overlay_distributed_dr, true, 'overlay_distributed_dr was not set')
+
+    # Test property unset
+    ipm.overlay_distributed_dr = false
+    assert_equal(ipm.overlay_distributed_dr, false, 'overlay_distributed_dr was not unset')
+
+    ipm.destroy
+  end
+
+  def test_overlay_spt_only
     ipm = IpMulticast.new
-    opts = %w(overlay_distributed_dr overlay_spt_only)
 
-    # test defaults
-    opts.each do |opt|
-      have = ipm.send("#{opt}")
-      should = ipm.send("default_#{opt}")
-      assert_equal(have, should, "#{opt} doesn't match the default")
-    end
+    # Test Defaults
+    have = ipm.overlay_spt_only
+    should = ipm.default_overlay_spt_only
+    assert_equal(have, should, 'overlay_spt_only does not match default value')
 
-    # test property set
-    opts.each do |opt|
-      ipm.send("#{opt}=", true)
-      should = 'ip multicast ' + opt.tr('_', '-')
-      assert_equal(ipm.send("#{opt}"), should, "#{opt} was not set")
-    end
+    # Test property set
+    ipm.overlay_spt_only = true
+    assert_equal(ipm.overlay_spt_only, true, 'overlay_spt_only was not set')
 
-    # unset property
-    opts.each do |opt|
-      ipm.send("#{opt}=", false)
-      should = false
-      assert_equal(ipm.send("#{opt}"), should, "#{opt} was not unset")
-      assert_equal(ipm.send("#{opt}"), ipm.send("default_#{opt}"), "#{opt} doesn't match default")
-    end
+    # Test property unset
+    ipm.overlay_spt_only = false
+    assert_equal(ipm.overlay_spt_only, false, 'overlay_spt_only was not unset')
 
     ipm.destroy
   end