cisco_node_utils 1.1.0 → 1.2.0

data/tests/test_bgp_neighbor.rb

@@ -3,7 +3,7 @@
 #
 # Jie Yang, August 2015
 #
-# Copyright (c) 2015 Cisco and/or its affiliates.
+# Copyright (c) 2015-2016 Cisco and/or its affiliates.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -21,22 +21,25 @@ require_relative 'ciscotest'
 require_relative '../lib/cisco_node_utils/bgp'
 require_relative '../lib/cisco_node_utils/bgp_neighbor'
 
-# TestRouterBgpNeighbor - Minitest for RouterBgpNeighbor node utility class
-class TestRouterBgpNeighbor < CiscoTestCase
+# TestBgpNeighbor - Minitest for RouterBgpNeighbor node utility class
+class TestBgpNeighbor < CiscoTestCase
   # rubocop:disable Style/ClassVars
   @@asn = 55
   @@addr = '1.1.1.1'
+  @@pre_clean_needed = true
   # rubocop:enable Style/ClassVars
 
   def setup
-    # Disable feature bgp before each test to ensure we
-    # are starting with a clean slate for each test.
     super
-    config('no feature bgp', 'feature bgp', 'router bgp 55')
+    remove_all_bgps if @@pre_clean_needed
+    @@pre_clean_needed = false # rubocop:disable Style/ClassVars
+    # BGP Neighbor requires the presence of a basic bgp global config
+    RouterBgp.new(@@asn)
   end
 
   def teardown
-    config('no feature bgp')
+    super
+    remove_all_bgps
   end
 
   def get_bgpneighbor_match_line(addr, vrf='default')
@@ -52,13 +55,13 @@ class TestRouterBgpNeighbor < CiscoTestCase
     line
   end
 
-  def test_bgpneighbor_collection_empty
+  def test_collection_empty
     config('no feature bgp')
     neighbors = RouterBgpNeighbor.neighbors
     assert_empty(neighbors, 'BGP neighbor collection is not empty')
   end
 
-  def test_bgpneighbor_collection_not_empty
+  def test_collection_not_empty
     config('router bgp 55',
            'neighbor 1.1.1.1',
            'vrf red',
@@ -84,7 +87,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_create_destroy
+  def test_create_destroy
     address = { '1.1.1.1'            => '1.1.1.1',
                 '2.2.2.2/24'         => '2.2.2.0/24',
                 '2000::2'            => '2000::2',
@@ -103,7 +106,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_description
+  def test_description
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       description = "tested by mini test for vrf #{vrf}"
@@ -117,7 +120,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_multiple_descriptions
+  def test_multiple_descriptions
     # First create multiple routers with multiple desriptions.
     address = ['1.1.1.1', '2.2.2.0/24', '2000::2', '2000:123:38::/64']
     vrfs = %w(default red)
@@ -142,7 +145,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_connected_check
+  def test_connected_check
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_connected_check]
@@ -154,7 +157,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_capability_negotiation
+  def test_capability_negotiation
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_capability_negotiation]
@@ -166,7 +169,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_dynamic_capability
+  def test_dynamic_capability
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_dynamic_capability]
@@ -178,7 +181,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_ebgp_multihop
+  def test_ebgp_multihop
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       ttls = [24, neighbor.default_ebgp_multihop]
@@ -190,27 +193,23 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_local_as
+  def test_local_as
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
-      local_asnum = [42, '52', '1.1', neighbor.default_local_as]
-      local_asnum.each do |asnum|
+      [42, '52', '1.1', neighbor.default_local_as].each do |asnum|
         neighbor.local_as = asnum
-        if asnum == '52'
-          assert_equal(asnum.to_i, neighbor.local_as)
-        else
-          assert_equal(asnum, neighbor.local_as)
-        end
+        assert_equal(asnum.to_s, neighbor.local_as)
       end
+
       # test a negative value
-      assert_raises(ArgumentError) do
+      assert_raises(CliError) do
         neighbor.local_as = '52 15'
       end
       neighbor.destroy
     end
   end
 
-  def test_bgpneighbor_set_get_log_neighbor_changes
+  def test_log_neighbor_changes
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [:enable, :disable, :inherit, 'enable', 'disable', 'inherit',
@@ -223,7 +222,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_low_memory_exempt
+  def test_low_memory_exempt
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_low_memory_exempt]
@@ -235,7 +234,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_maximum_peers
+  def test_maximum_peers
     # only "address/prefix" type of neighbor address will accept
     # maximum_peers command
     addr = '1.1.1.0/24'
@@ -250,7 +249,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_password
+  def test_password
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       passwords = {}
@@ -278,7 +277,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_default_password_type
+  def test_set_default_password_type
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       password = 'test'
@@ -304,19 +303,18 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_remote_as
+  def test_remote_as
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
-      remote_asnum = [42, '1.1', neighbor.default_remote_as]
-      remote_asnum.each do |asnum|
+      [42, '1.1', neighbor.default_remote_as].each do |asnum|
         neighbor.remote_as = asnum
-        assert_equal(asnum, neighbor.remote_as)
+        assert_equal(asnum.to_s, neighbor.remote_as)
       end
       neighbor.destroy
     end
   end
 
-  def test_bgpneighbor_set_get_remove_private_as_options
+  def test_remove_private_as_options
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       options = [:enable, :disable, :all, :"replace-as", 'enable', 'disable',
@@ -333,7 +331,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_shutdown
+  def test_shutdown
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_shutdown]
@@ -345,7 +343,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_suppress_4_byte_as
+  def test_suppress_4_byte_as
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_suppress_4_byte_as]
@@ -357,7 +355,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_timers
+  def test_timers
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       timers = [{ keep: 40, hold: 90 },
@@ -376,7 +374,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_transport_passive_only
+  def test_transport_passive_only
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       check = [true, false, neighbor.default_transport_passive_only]
@@ -388,7 +386,7 @@ class TestRouterBgpNeighbor < CiscoTestCase
     end
   end
 
-  def test_bgpneighbor_set_get_update_source
+  def test_update_source
     %w(default test_vrf).each do |vrf|
       neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)
       interfaces = ['loopback1', 'Ethernet1/1', 'ethernet1/1',

data/tests/test_bgp_neighbor_af.rb

@@ -3,7 +3,7 @@
 #
 # August 2015 Chris Van Heuveln
 #
-# Copyright (c) 2015 Cisco and/or its affiliates.
+# Copyright (c) 2015-2016 Cisco and/or its affiliates.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -22,20 +22,38 @@ require_relative '../lib/cisco_node_utils/cisco_cmn_utils'
 require_relative '../lib/cisco_node_utils/bgp'
 require_relative '../lib/cisco_node_utils/bgp_neighbor'
 require_relative '../lib/cisco_node_utils/bgp_neighbor_af'
+require_relative '../lib/cisco_node_utils/feature'
 
-# TestRouterBgpNeighborAF - Minitest for RouterBgpNeighborAF class
-class TestRouterBgpNeighborAF < CiscoTestCase
-  @@reset_feat = true # rubocop:disable Style/ClassVars
+# TestBgpNeighborAF - Minitest for RouterBgpNeighborAF class
+class TestBgpNeighborAF < CiscoTestCase
+  # rubocop:disable Style/ClassVars
+  @@pre_clean_needed = true
+  @@evpn_unsupported = false
+  # rubocop:enable Style/ClassVars
 
   def setup
     super
-    if @@reset_feat
-      config('no feature bgp', 'feature bgp')
-      @@reset_feat = false # rubocop:disable Style/ClassVars
-    else
-      # Just ensure that feature is enabled
-      config('feature bgp')
-    end
+    remove_all_bgps if @@pre_clean_needed
+    @@pre_clean_needed = false # rubocop:disable Style/ClassVars
+    setup_nv_overlay_evpn
+  end
+
+  def teardown
+    super
+    remove_all_bgps
+  end
+
+  def setup_nv_overlay_evpn
+    Feature.bgp_enable
+
+    # l2vpn evpn tests require 'nv overlay evpn' but it is not supported on
+    # all platforms
+    Feature.nv_overlay_evpn_enable unless @@evpn_unsupported
+  rescue Cisco::UnsupportedError => e
+    @@evpn_unsupported = true if # rubocop:disable Style/ClassVars
+      e.message[/unsupported on this node/]
+    # Remove the evpn AF from the test matrix
+    @@matrix.delete(:evpn)
   end
 
   def clean_af(af_args, ebgp=true)
@@ -61,22 +79,23 @@ class TestRouterBgpNeighborAF < CiscoTestCase
 
   # AF test matrix
   @@matrix = { # rubocop:disable Style/ClassVars
-    # 1  => [1, 'default', '10:1::1', %w(ipv4 multicast)], # UNSUPPORTED
-    # 2  => [1, 'default', '10:1::1', %w(ipv4 unicast)],
-    # 3  => [1, 'default', '10:1::1', %w(ipv6 multicast)],
-    # 4  => [1, 'default', '10:1::1', %w(ipv6 unicast)],
-    # 5  => [1, 'default', '1.1.1.1', %w(ipv4 multicast)],
-    6 => [1, 'default', '1.1.1.1', %w(ipv4 unicast)],
-    # 7  => [1, 'default', '1.1.1.1', %w(ipv6 multicast)],
-    8 => [1, 'default', '1.1.1.1', %w(ipv6 unicast)],
-    # 9  => [1, 'aa', '2.2.2.2', %w(ipv4 multicast)],
-    # 10 => [1, 'aa', '2.2.2.2', %w(ipv4 unicast)],
-    # 11 => [1, 'bb', '2.2.2.2', %w(ipv6 multicast)],
-    # 12 => [1, 'bb', '2.2.2.2', %w(ipv6 unicast)],
-    # 13 => [1, 'cc', '10:1::2', %w(ipv4 multicast)], # UNSUPPORTED
-    # 14 => [1, 'cc', '10:1::2', %w(ipv4 unicast)],
-    # 15 => [1, 'cc', '10:1::2', %w(ipv6 multicast)],
-    # 16 => [1, 'cc', '10:1::2', %w(ipv6 unicast)],
+    # 1     => [1, 'default', '10:1::1', %w(ipv4 multicast)], # UNSUPPORTED
+    # 2     => [1, 'default', '10:1::1', %w(ipv4 unicast)],
+    # 3     => [1, 'default', '10:1::1', %w(ipv6 multicast)],
+    # 4     => [1, 'default', '10:1::1', %w(ipv6 unicast)],
+    # 5     => [1, 'default', '1.1.1.1', %w(ipv4 multicast)],
+    6     => [1, 'default', '1.1.1.1', %w(ipv4 unicast)],
+    # 7     => [1, 'default', '1.1.1.1', %w(ipv6 multicast)],
+    8     => [1, 'default', '1.1.1.1', %w(ipv6 unicast)],
+    # 9     => [1, 'aa', '2.2.2.2', %w(ipv4 multicast)],
+    # 10    => [1, 'aa', '2.2.2.2', %w(ipv4 unicast)],
+    # 11    => [1, 'bb', '2.2.2.2', %w(ipv6 multicast)],
+    # 12    => [1, 'bb', '2.2.2.2', %w(ipv6 unicast)],
+    # 13    => [1, 'cc', '10:1::2', %w(ipv4 multicast)], # UNSUPPORTED
+    # 14    => [1, 'cc', '10:1::2', %w(ipv4 unicast)],
+    # 15    => [1, 'cc', '10:1::2', %w(ipv6 multicast)],
+    # 16    => [1, 'cc', '10:1::2', %w(ipv6 unicast)],
+    :evpn => [1, 'default', '1.1.1.1', %w(l2vpn evpn)],
   }
 
   # ---------------------------------
@@ -133,7 +152,7 @@ class TestRouterBgpNeighborAF < CiscoTestCase
       refute(afs[asn][vrf][nbr_munged].key?(af),
              "#{dbg} Failed to destroy AF")
     end
-    @@reset_feat = true # rubocop:disable Style/ClassVars
+    @@pre_clean_needed = true # rubocop:disable Style/ClassVars
   end
 
   # ---------------------------------
@@ -155,6 +174,8 @@ class TestRouterBgpNeighborAF < CiscoTestCase
       :suppress_inactive,
     ]
 
+    props = [:disable_peer_as_check] if dbg.include?('l2vpn/evpn')
+
     # Call setter to false, then validate with getter
     props.each { |k| af.send("#{k}=", false) }
     props.each do |k|
@@ -198,6 +219,8 @@ class TestRouterBgpNeighborAF < CiscoTestCase
       unsuppress_map:  'unsupp-map-name',
     }
 
+    props.delete(:unsuppress_map) if dbg.include?('l2vpn/evpn')
+
     props.each do |k, v|
       # Call setter.
       af.send("#{k}=", v)
@@ -222,10 +245,17 @@ class TestRouterBgpNeighborAF < CiscoTestCase
   #   additional_paths_receive
   #   additional_paths_send
   #   soft_reconfiguration_in
+
+  def supports_soft_reconfig_always?
+    return true if node.product_id[/N(3|9)K/]
+    false
+  end
+
   def test_tri_states
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
 
+      next if dbg.include?('l2vpn/evpn')
       %w(additional_paths_receive additional_paths_send).each do |k|
         [:enable, :disable, :inherit, 'enable', 'disable', 'inherit',
          af.send("default_#{k}")
@@ -235,10 +265,17 @@ class TestRouterBgpNeighborAF < CiscoTestCase
         end
       end
 
+      # The 'always' keyword is not supported on N6K / N7K
       %w(soft_reconfiguration_in).each do |k|
-        [:enable, :always, :inherit, 'enable', 'always', 'inherit',
-         af.send("default_#{k}")
-        ].each do |val|
+        if supports_soft_reconfig_always?
+          array = [:enable, :always, :inherit, 'enable', 'always', 'inherit',
+                   af.send("default_#{k}")]
+        else
+          array = [:enable, :inherit, 'enable', 'inherit',
+                   af.send("default_#{k}")]
+        end
+
+        array.each do |val|
           af.send("#{k}=", val)
           assert_equal(val.to_sym, af.send(k), "#{dbg} Error: #{k}")
         end
@@ -250,6 +287,7 @@ class TestRouterBgpNeighborAF < CiscoTestCase
   def test_advertise_map
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
+      next if dbg.include?('l2vpn/evpn')
       advertise_map(af, dbg)
     end
   end
@@ -319,6 +357,7 @@ class TestRouterBgpNeighborAF < CiscoTestCase
   def test_default_originate
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
+      next if dbg.include?('l2vpn/evpn')
       default_originate(af, dbg)
     end
   end
@@ -489,7 +528,7 @@ class TestRouterBgpNeighborAF < CiscoTestCase
       af, dbg = clean_af(af_args)
       send_community(af, dbg)
     end
-    @@reset_feat = true # rubocop:disable Style/ClassVars
+    @@pre_clean_needed = true # rubocop:disable Style/ClassVars
   end
 
   def send_community(af, dbg)
@@ -586,4 +625,25 @@ class TestRouterBgpNeighborAF < CiscoTestCase
     assert_empty(af.soo,
                  "Test 4. #{dbg} Failed to set default '#{val}'")
   end
+
+  # --------------------------------
+  def test_weight
+    @@matrix.values.each do |af_args|
+      af, dbg = clean_af(af_args)
+      weight(af, dbg) unless dbg.include?('l2vpn/evpn')
+    end
+  end
+
+  def weight(af, dbg)
+    # check the default value before set
+    assert_equal(af.default_weight, af.weight,
+                 "Test 1. #{dbg} Error: should be default value")
+
+    af.weight = 22
+    assert_equal(22, af.weight, "Test 2. #{dbg} Failed to set weight")
+
+    af.weight = af.default_weight
+    assert_equal(af.default_weight, af.weight,
+                 "Test 3. #{dbg} Failed to remove weight")
+  end
 end