cirneco 0.9.14 → 0.9.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca288d421311719334b7a9d38849732549f5f2d3
-  data.tar.gz: 5d9b99265570d9ab485b463e9287f9d5e16fdd01
+  metadata.gz: 85c9f4ddb0364ea1d4a8135eb041b34751100ef8
+  data.tar.gz: fd5d0569d6592f8c3f0dd56a450d9db3066634aa
 SHA512:
-  metadata.gz: c604f57226dbc7ff543575bf1226605ac887bfb070d0789755fcbe6f0d146d90370798f3618f82e9ec35002a0b520d6a84fb3ca6712698acfec0e4fe6696f305
-  data.tar.gz: 93f67ce51ff86fe67be5c24f61c9bae6a22318e747015e12f6a87978ef3179554bd88337f47c5c245a9570efd91844d32a4e0c1105555cbfeedcd23458f89263
+  metadata.gz: 598c9c2ef3815d6d35cc7a5d6fdc738cf568abd27d456b778db615732220cbe933cd1b4d8a282201524592b8346f46516f243c84e2cbe809c9ab902c78301e0e
+  data.tar.gz: bc9a3797516b6f4b5f647adb19222371776975e84be7b0202cdb8c8e3500d3f7c6123411f03712e617a9c9e7ba7c169f0016dfecf261cc18bf776fd785a84b0d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cirneco (0.9.14)
+    cirneco (0.9.15)
       activesupport (>= 4.2.5, < 6)
       base32-crockford-checksum (~> 0.2.2)
       bergamasco (~> 0.3)
@@ -36,7 +36,7 @@ GEM
       safe_yaml (~> 1.0, >= 1.0.4)
     bibtex-ruby (4.4.4)
       latex-decode (~> 0.0)
-    bolognese (0.9.34)
+    bolognese (0.9.36)
       activesupport (>= 4.2.5, < 6)
       benchmark_methods (~> 0.7)
       bibtex-ruby (~> 4.1)

data/lib/cirneco/utils.rb

@@ -20,16 +20,19 @@ module Cirneco
 
     def decode_doi(doi)
       prefix, string = doi.split('/', 2)
-      Base32::Crockford.decode(string, checksum: true).to_i
+      Base32::Crockford.decode(string.upcase, checksum: true).to_i
     end
 
     def encode_doi(prefix, options={})
+      prefix = validate_prefix(prefix)
+      return nil unless prefix.present?
+
       number = options[:number].to_s.scan(/\d+/).first.to_i
       number = SecureRandom.random_number(UPPER_LIMIT) unless number > 0
       shoulder = options[:shoulder].to_s
 
       length = shoulder.length > 0 ? 6 : 8
-      split = shoulder.length > 0 ? nil: 4
+      split = shoulder.length > 0 ? nil : 4
       prefix.to_s + "/" + shoulder + Base32::Crockford.encode(number, split: split, length: length, checksum: true).downcase
     end
 

data/lib/cirneco/version.rb

@@ -1,3 +1,3 @@
 module Cirneco
-  VERSION = "0.9.14"
+  VERSION = "0.9.15"
 end

data/spec/fixtures/cool-dois.html.md

@@ -8,8 +8,8 @@ tags:
 accession_number: MS-123
 image: https://blog.datacite.org/images/2016/12/cool-dois.png
 published: false
-doi: 10.5438/0000-03vc
 date: '2016-12-15'
+doi: 10.5438/0000-03vc
 ---
 In 1998 Tim Berners-Lee coined the term cool URIs [-@https://www.w3.org/Provider/Style/URI], that is URIs that don’t change. We know that URLs referenced in the scholarly literature are often not cool, leading to link rot [@https://doi.org/10.1371/journal.pone.0115253] and making it hard or impossible to find the referenced resource.READMORE
 

data/spec/utils_spec.rb

@@ -50,11 +50,22 @@ describe Cirneco::DataCenter, vcr: true, :order => :defined do
       expect(subject.encode_doi(prefix)).to start_with("10.5438")
     end
 
+    it 'should not encode invalid prefix' do
+      prefix = "20.5438"
+      expect(subject.encode_doi(prefix)).to be_nil
+    end
+
     it 'should encode doi with shoulder' do
       number = 7654321
       shoulder = "dryad."
       expect(subject.encode_doi(prefix, number: number, shoulder: shoulder)).to eq("10.5438/dryad.79jxhm")
     end
+
+    it 'should encode doi with empty shoulder' do
+      number = 7654321
+      shoulder = nil
+      expect(subject.encode_doi(prefix, number: number, shoulder: shoulder)).to eq("10.5438/0079-jxhm")
+    end
   end
 
   context "accession_number" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cirneco
 version: !ruby/object:Gem::Version
-  version: 0.9.14
+  version: 0.9.15
 platform: ruby
 authors:
 - Martin Fenner