cinnamon_serial 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85e032792b5bfaa51e52499f47b3c43c8367342330a43e4d3995b0c6eeb3437e
-  data.tar.gz: 7795256430a84d39483ceb14ea8d1c9c35eee2d20d67912076762080d3373ca7
+  metadata.gz: d35225e3e4f4abb62cd06761e5c234f6f3cbe2a05ade35e82ae94540c9217e65
+  data.tar.gz: 5c7ec11ad1c3fa6fe2ddb11a8b884025d03ba27290b2f0f77367b3d649b36b4f
 SHA512:
-  metadata.gz: f847c7f35e95f58b59348c337700ed0a05fa231f5586a384e2613583d8ad0b2ba090b64f74a9dadf76b1f60b3cfa582e2a3403f9ce8956604acc8238d829f14b
-  data.tar.gz: 001d1ab8ad80bc2eaf7f64bc8702472f8cb0c6f30c2826e1454b131db52319bea44a50b8a9e41e94321a9968b3cd5bc8cef4be7352f410b69c16774a6d483981
+  metadata.gz: 98072ebc41f42fd7f7e6c515a4e0a5928fc28219564592e46e6f7b6404b142374b9c85f19cebd0d356dbe1ca2a1536dab9984d0bda4d58ffbba32bf9f59203f3
+  data.tar.gz: e5af2239c945aeee36fcfc4f55061ea8df2a1e2e4d619b7624468c3ce38672130b42dfa3275581b613619e5b026d78b58fc074e140cb48a37f3c338617c349cc

data/.rubocop_todo.yml

@@ -21,7 +21,7 @@ Metrics/BlockLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 111
+  Max: 112
 
 # Offense count: 2
 Metrics/CyclomaticComplexity:

data/.ruby-version

@@ -1 +1 @@
-2.6.0
+2.6.3

data/.travis.yml

@@ -7,7 +7,7 @@ rvm:
   - 2.3.8
   - 2.4.5
   - 2.5.3
-  - 2.6.0
+  - 2.6.3
 cache: bundler
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 2.1.2 (May 1st, 2019)
+
+Fixes:
+
+ * The serializer "as" option now supports serializing ActiveRecord::Relations in newer versions of Rails.
+ * Support the two parameter version of respond_to_missing? for classes which inherit from CinnamonSerial::Base.
+
 # 2.1.1 (January 30th, 2019)
 
 Maintenance Release

data/Gemfile.lock

@@ -1,13 +1,14 @@
 PATH
   remote: .
   specs:
-    cinnamon_serial (2.1.1)
+    cinnamon_serial (2.1.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ansi (1.5.0)
     ast (2.4.0)
+    byebug (11.0.1)
     coderay (1.1.2)
     diff-lcs (1.3)
     docile (1.3.1)
@@ -47,6 +48,9 @@ GEM
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    pry-byebug (3.7.0)
+      byebug (~> 11.0)
+      pry (~> 0.10)
     rainbow (3.0.0)
     rb-fsevent (0.10.3)
     rb-inotify (0.10.0)
@@ -93,10 +97,12 @@ PLATFORMS
 DEPENDENCIES
   cinnamon_serial!
   guard-rspec (~> 4.7)
+  pry
+  pry-byebug (~> 3)
   rspec (~> 3.8)
   rubocop (~> 0.63.1)
   simplecov (~> 0.16.1)
   simplecov-console (~> 0.4.2)
 
 BUNDLED WITH
-   1.17.2
+   1.17.3

data/Guardfile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-guard :rspec, cmd: 'bundle exec rspec' do
+guard :rspec, cmd: 'DISABLE_SIMPLECOV=true bundle exec rspec --format=documentation' do
   require 'guard/rspec/dsl'
   dsl = Guard::RSpec::Dsl.new(self)
 

data/cinnamon_serial.gemspec

@@ -22,6 +22,8 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.3.8'
 
   s.add_development_dependency('guard-rspec', '~>4.7')
+  s.add_development_dependency('pry')
+  s.add_development_dependency('pry-byebug', '~> 3')
   s.add_development_dependency('rspec', '~> 3.8')
   s.add_development_dependency('rubocop', '~>0.63.1')
   s.add_development_dependency('simplecov', '~>0.16.1')

data/lib/cinnamon_serial/base.rb

@@ -40,7 +40,7 @@ module CinnamonSerial
       data
     end
 
-    def respond_to_missing?(method_sym)
+    def respond_to_missing?(method_sym, include_private = false)
       data.key?(method_sym.to_s) || super
     end
 

data/lib/cinnamon_serial/resolver.rb

@@ -118,12 +118,10 @@ module CinnamonSerial
       # This will prevent endless cycles / loops.
       return nil if presenter.klasses.include?(class_constant.to_s)
 
-      # We do not want to create a hard dependency on ActiveRecord/Rails in this gem,
-      # but we can still create a soft dependency in case it was included as a peer.
-      value = value.to_a if value.class.name == 'ActiveRecord::Relation'
-
       new_klasses = presenter.klasses + Set[class_constant.to_s]
 
+      value = value_to_array_or_scalar(value)
+
       if value.is_a?(Array)
         value.map { |v| class_constant.new(v, presenter.opts, new_klasses) }
       else
@@ -131,6 +129,16 @@ module CinnamonSerial
       end
     end
 
+    def value_to_array_or_scalar(value)
+      # We do not want to create a hard dependency on ActiveRecord/Rails in this gem,
+      # but we can still create a soft dependency in case it was included as a peer.
+      if Module.const_defined?('ActiveRecord') && value.is_a?(ActiveRecord::Relation)
+        value.to_a
+      else
+        value
+      end
+    end
+
     def as_class_name
       return nil unless as
 

data/lib/cinnamon_serial/version.rb

@@ -8,5 +8,5 @@
 #
 
 module CinnamonSerial
-  VERSION = '2.1.1'
+  VERSION = '2.1.2'
 end

data/spec/cinnamon_serial/resolver_spec.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+#
+# Copyright (c) 2018-present, Blue Marble Payroll, LLC
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+#
+
+require './spec/spec_helper'
+require './spec/examples'
+
+describe CinnamonSerial::Resolver do
+  let(:presented_employee) do
+    CinnamonSerial::Base.new(
+      OpenStruct.new(
+        name: 'employee',
+        manager: OpenStruct.new(id: 2, name: 'manager')
+      )
+    )
+  end
+
+  let(:presented_manager_employees_array) do
+    CinnamonSerial::Base.new(
+      OpenStruct.new(
+        name: 'manager',
+        employees: [
+          OpenStruct.new(id: 1, name: 'employee 1'),
+          OpenStruct.new(id: 2, name: 'employee 2')
+        ]
+      )
+    )
+  end
+
+  let(:presented_manager_employees_active_record_relation) do
+    # Stub this out so this gem does not have to depends directly on ActiveRecord:
+    module ActiveRecord
+      class Relation
+      end
+    end
+
+    module CinnamonSerial
+      class ResolverSpecFakeRelation < ActiveRecord::Relation
+        def initialize(data)
+          @data = data
+        end
+
+        def to_a
+          @data
+        end
+      end
+    end
+
+    CinnamonSerial::Base.new(
+      OpenStruct.new(
+        name: 'manager',
+        employees: CinnamonSerial::ResolverSpecFakeRelation.new(
+          [
+            OpenStruct.new(id: 1, name: 'employee 1'),
+            OpenStruct.new(id: 2, name: 'employee 2')
+          ]
+        )
+      )
+    )
+  end
+
+  describe '"as" resolving' do
+    let(:subject) { described_class.new(as: SimpleEmployeeSerializer) }
+
+    it 'single instance resolves to an instance of the specified class' do
+      value = subject.resolve(presented_employee, 'manager')
+
+      expect(value).to be_a SimpleEmployeeSerializer
+      expect(value.data).to eq('id' => 2, 'name' => 'manager')
+    end
+
+    it 'wraps each element of an array in the presenter as specified' do
+      value = subject.resolve(presented_manager_employees_array, :employees)
+
+      expect(value).to be_a Array
+      expect(value.map(&:class).uniq).to eq [SimpleEmployeeSerializer]
+
+      expect(value[0].data).to eq('id' => 1, 'name' => 'employee 1')
+      expect(value[1].data).to eq('id' => 2, 'name' => 'employee 2')
+    end
+
+    it 'wraps each element of an ActiveRecord::Relation in the presenter as specified' do
+      value = subject.resolve(presented_manager_employees_active_record_relation, :employees)
+
+      expect(value).to be_a Array
+      expect(value.map(&:class).uniq).to eq [SimpleEmployeeSerializer]
+
+      expect(value[0].data).to eq('id' => 1, 'name' => 'employee 1')
+      expect(value[1].data).to eq('id' => 2, 'name' => 'employee 2')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -9,10 +9,16 @@
 
 require 'date'
 require 'pry'
+require 'pry-byebug'
 
-require 'simplecov'
-require 'simplecov-console'
-SimpleCov.formatter = SimpleCov::Formatter::Console
-SimpleCov.start
+unless ENV['DISABLE_SIMPLECOV'] == 'true'
+  require 'simplecov'
+  require 'simplecov-console'
+
+  SimpleCov.formatter = SimpleCov::Formatter::Console
+  SimpleCov.start do
+    add_filter %r{\A/spec/}
+  end
+end
 
 require './lib/cinnamon_serial'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cinnamon_serial
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Matthew Ruggio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-05 00:00:00.000000000 Z
+date: 2019-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec
@@ -24,6 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -112,6 +140,7 @@ files:
 - lib/cinnamon_serial/version.rb
 - spec/cinnamon_serial/base_spec.rb
 - spec/cinnamon_serial/dsl_spec.rb
+- spec/cinnamon_serial/resolver_spec.rb
 - spec/examples.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bluemarblepayroll/cinnamon_serial
@@ -133,12 +162,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Domain-specific language for serialization specification.
 test_files:
 - spec/cinnamon_serial/base_spec.rb
 - spec/cinnamon_serial/dsl_spec.rb
+- spec/cinnamon_serial/resolver_spec.rb
 - spec/examples.rb
 - spec/spec_helper.rb