cineworld_uk 4.3.0 → 4.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b966798e50231ceceb95b749b8c3e9e962db5cc12edc7fb31e98ee40e110078d
-  data.tar.gz: f26069f75b3de854af94f90758b0d479faa8ef7f2923dfb3c6ed66d16a681432
+  metadata.gz: e9b36bfd98b2897bc7794dafb17c958be5ce416ca6062da97d51f90cfd9d87c8
+  data.tar.gz: cc34427384559cb5f7392923a9df9d53a223fd339aa1d78ef900c1d776694c73
 SHA512:
-  metadata.gz: 2d38f7b625fe0625160948172925120d2763ba1f9235acc683f58bf5c4b1fdeca4a6176734884e400dadfa34ed53c5d1a745af7b11ecbf52468884c1bc92d378
-  data.tar.gz: 71d23a661ac05b7eb340877e6c371ceae53cc4b757048a75d3ebfa4d713258ca7faae8cb74d7c360ecdf5da8655351c7c1167b920c10125a1dc43d6f434b2405
+  metadata.gz: 299579ed67952c0cca4f19dcf893779678cdc393cd49832c1f7f1d9d8c0fb0abedb2c1c6ee31e026de8142695a78344821379cf7d0081e0669a1f56ba48fdde7
+  data.tar.gz: 2917230374b9201b42d259991317174218e72ff971a026f13657508e47251e93f6ba54c3ba8b0f0c646896146adef347c86e13fbffde6190002c3931b7945063

data/.github/workflows/release.yml

@@ -0,0 +1,73 @@
+name: Release Gem
+
+on:
+  workflow_dispatch:
+
+jobs:
+  package:
+    strategy:
+      matrix:
+        include:
+          - runner: ubuntu-latest
+            platform: x86_64-linux-gnu
+          - runner: ubuntu-24.04-arm
+            platform: aarch64-linux-gnu
+          - runner: macos-15
+            platform: arm64-darwin
+          - runner: macos-15-intel
+            platform: x86_64-darwin
+    runs-on: ${{ matrix.runner }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0'
+          bundler-cache: true
+      - run: bundle exec rake 'package:native[${{ matrix.platform }}]'
+      - run: CINEWORLD_PACKAGE="$(echo pkg/*.gem)" bundle exec ruby test/package_test.rb
+      - uses: actions/upload-artifact@v4
+        with:
+          name: gem-${{ matrix.platform }}
+          path: pkg/*.gem
+
+  release:
+    needs: package
+    runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0'
+          bundler-cache: true
+      - run: bundle exec rake test
+      - run: bundle exec rake build
+      - uses: actions/download-artifact@v4
+        with:
+          path: pkg
+          pattern: gem-*
+          merge-multiple: true
+      - uses: rubygems/configure-rubygems-credentials@v1.0.0
+      - name: Push the source and platform gems
+        run: |
+          for gem in pkg/*.gem; do
+            if output=$(gem push "$gem" 2>&1); then
+              echo "$output"
+            elif echo "$output" | grep -q "Repushing of gem versions is not allowed"; then
+              echo "Already published: $gem"
+            else
+              echo "$output"
+              exit 1
+            fi
+          done
+      - name: Tag the release
+        run: |
+          tag="v$(ruby -e 'print Gem::Specification.load(Dir["*.gemspec"].first).version')"
+          if git ls-remote --exit-code --tags origin "$tag" >/dev/null; then
+            echo "$tag already exists"
+          else
+            git tag "$tag"
+            git push origin "$tag"
+          fi

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 4.3.2 - 2026-10-22
+
+### Changed
+- Reuse one Vista client, and so one kept-alive connection, per thread instead of opening a TLS connection for every request. Requires cinebase 5.5. A cinema day now takes about 0.19s rather than 0.37s.
+
+## 4.3.1 - 2026-10-22
+
+### Fixed
+- Publish the platform gems that bundle curl-impersonate. 4.3.0 shipped only the source gem. No code changes.
+
 ## 4.3.0 - 2026-10-22
 
 ### Added

data/README.md

@@ -229,7 +229,7 @@ To build and check just one platform on a matching host:
 
 ```sh
 bundle exec rake 'package:native[x86_64-linux-gnu]'
-CINEWORLD_PACKAGE=pkg/cineworld_uk-4.3.0-x86_64-linux-gnu.gem bundle exec ruby test/package_test.rb
+CINEWORLD_PACKAGE=pkg/cineworld_uk-4.3.2-x86_64-linux-gnu.gem bundle exec ruby test/package_test.rb
 ```
 
 Native packaging downloads pinned upstream archives at **build time**, verifies
@@ -239,6 +239,11 @@ and installation-tests each platform on its corresponding runner and saves the
 gems as workflow artifacts; it does not publish them. Publish the source and
 platform gems together for automatic platform selection to work for users.
 
+To release, bump the version, merge, then run the **Release Gem** workflow in
+GitHub Actions. It builds the source and four platform gems, publishes them
+through RubyGems trusted publishing (no MFA code needed) and tags the release.
+Versions already on RubyGems are skipped, so a failed run can be rerun.
+
 ## Contributing
 
 1. Fork it

data/cineworld_uk.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '< 1'
   spec.add_development_dependency 'webmock'
 
-  spec.add_runtime_dependency 'cinebase', '~> 5.4'
+  spec.add_runtime_dependency 'cinebase', '~> 5.5'
   spec.add_runtime_dependency 'nokogiri', '>= 1.11'
 end

data/lib/cineworld_uk/internal/api_response.rb

@@ -86,8 +86,17 @@ module CineworldUk
       private
 
       def fetch(path, query = {})
-        Cinebase::Vista::Client.new(base_url: BASE_URL, region_code: "GB",
-                                    token: CineworldUk.token).get(path, query)
+        client.get(path, query)
+      end
+
+      # One client keeps one connection open, so reuse it until the token changes.
+      def client
+        token = CineworldUk.token
+        if @client.nil? || @client_token != token
+          @client_token = token
+          @client = Cinebase::Vista::Client.new(base_url: BASE_URL, region_code: "GB", token: token)
+        end
+        @client
       end
     end
   end

data/lib/cineworld_uk/performance.rb

@@ -56,9 +56,13 @@ module CineworldUk
 
     # private
 
+    API = :cineworld_uk_performance_api
+
     # @api private
+    # One API, and so one kept-alive connection, per thread: job runners
+    # import several cinemas at once.
     def self.api
-      @api ||= Internal::ApiResponse.new
+      Thread.current[API] ||= Internal::ApiResponse.new
     end
     private_class_method :api
 

data/lib/cineworld_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.cineworld.co.uk
-# @version 4.3.0
+# @version 4.3.2
 module CineworldUk
   # Gem version
-  VERSION = "4.3.0".freeze
+  VERSION = "4.3.2".freeze
 end

data/test/lib/cineworld_uk/internal/api_response_test.rb

@@ -14,6 +14,45 @@ class CineworldUk::Internal::ApiResponseTest < Minitest::Test
     super
   end
 
+  def test_reuses_one_client_while_the_token_holds
+    stub_request(:get, "#{BASE_URL}sites").to_return(body: '{"sites":[]}')
+    api = CineworldUk::Internal::ApiResponse.new
+
+    clients = count_clients { 3.times { api.cinema_list } }
+
+    assert_equal 1, clients
+  end
+
+  def test_builds_a_new_client_for_a_new_token
+    stub_request(:get, "#{BASE_URL}sites").to_return(body: '{"sites":[]}')
+    api = CineworldUk::Internal::ApiResponse.new
+
+    clients = count_clients do
+      api.cinema_list
+      CineworldUk.token = "renewed-token"
+      api.cinema_list
+    end
+
+    assert_equal 2, clients
+  end
+
+  def test_each_thread_has_its_own_performance_api
+    main = CineworldUk::Performance.send(:api)
+
+    other = Thread.new { CineworldUk::Performance.send(:api) }.value
+
+    assert_same main, CineworldUk::Performance.send(:api)
+    refute_same main, other
+  end
+
+  def count_clients
+    clients = 0
+    original = Cinebase::Vista::Client.method(:new)
+    counting = ->(**options) { clients += 1; original.call(**options) }
+    Cinebase::Vista::Client.stub(:new, counting) { yield }
+    clients
+  end
+
   def test_rejects_missing_token
     CineworldUk.token = nil
 

data/test/support/vista_fixtures.rb

@@ -53,6 +53,7 @@ module Support
       [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
         klass.instance_variables.each { |name| klass.remove_instance_variable(name) }
       end
+      Thread.current[CineworldUk::Performance::API] = nil if defined?(CineworldUk::Performance::API)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.2
 platform: ruby
 authors:
 - Andy Croll
@@ -113,14 +113,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.4'
+        version: '5.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.4'
+        version: '5.5'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -143,6 +143,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".agents/setup"
+- ".github/workflows/release.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
 - ".ruby-version"