cineworld_uk 4.1.0-x86_64-linux-gnu → 4.3.1-x86_64-linux-gnu

data/test/lib/cineworld_uk/internal/title_sanitizer_test.rb

@@ -1,153 +1,127 @@
 require_relative '../../../test_helper'
 
-describe CineworldUk::Internal::TitleSanitizer do
-  let(:described_class) { CineworldUk::Internal::TitleSanitizer }
-
-  describe '#sanitized' do
-    subject { described_class.new(title).sanitized }
-
-    describe 'with 2d in title' do
-      let(:title) { 'Iron Man 3 2D' }
-
-      it 'removes dimension' do
-        _(subject).must_equal('Iron Man 3')
-      end
-    end
+class CineworldUk::Internal::TitleSanitizerTest < Minitest::Test
+  def test_removes_2d
+    assert_sanitized 'Iron Man 3', 'Iron Man 3 2D'
+  end
 
-    describe 'with 3d in title' do
-      let(:title) { 'Iron Man 3 3d' }
+  def test_removes_3d
+    assert_sanitized 'Iron Man 3', 'Iron Man 3 3d'
+  end
 
-      it 'removes dimension' do
-        _(subject).must_equal('Iron Man 3')
-      end
-    end
+  def test_removes_language
+    assert_sanitized 'Bang Bang!', 'Bang Bang! (Hindi)'
+    assert_sanitized 'Deadline', 'Deadline (Mandarin)'
+  end
 
-    describe 'in hindi' do
-      let(:title) { 'Bang Bang! (Hindi)' }
+  def test_removes_dub_version
+    assert_sanitized 'Kung Fu Soccer', 'Kung Fu Soccer (Dubbed)'
+  end
 
-      it 'removes language' do
-        _(subject).must_equal('Bang Bang!')
-      end
-    end
+  def test_removes_unlimited_screening
+    assert_sanitized 'Nightcrawler', 'Nightcrawler - Unlimited Screening'
+  end
 
-    describe 'Unlimited Screening' do
-      let(:title) { 'Nightcrawler - Unlimited Screening' }
+  def test_removes_autism_prefix
+    assert_sanitized 'Dolphin Tale 2', 'Autism Friendly Screening: Dolphin Tale 2'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Nightcrawler')
-      end
-    end
+  def test_keeps_bolshoi_ballet
+    assert_sanitized 'Bolshoi Ballet: The Legend of Love', 'Bolshoi Ballet: The Legend of Love'
+  end
 
-    describe 'Austism screening' do
-      let(:title) { 'Autism Friendly Screening: Dolphin Tale 2' }
+  def test_eno
+    assert_sanitized 'English National Opera: La Traviata', 'ENO: La Traviata '
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Dolphin Tale 2')
-      end
-    end
+  def test_removes_imax_prefix
+    assert_sanitized 'Fury', '(IMAX) Fury'
+  end
 
-    describe 'Bolshoi screening' do
-      let(:title) { 'Bolshoi Ballet: The Legend of Love' }
+  def test_met_opera
+    assert_sanitized 'Met Opera: Le Nozze Di Figaro', 'MET Opera - Le Nozze Di Figaro'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Bolshoi Ballet: The Legend of Love')
-      end
-    end
+  def test_nt_live_encore
+    assert_sanitized 'National Theatre: Frankenstein (starring Benedict Cumberbatch)',
+                     'NT Live Encore: Frankenstein (starring Benedict Cumberbatch)'
+  end
 
-    describe 'English National Opera screening' do
-      let(:title) { 'ENO: La Traviata ' }
+  def test_nt_live
+    assert_sanitized 'National Theatre: Treasure Island', 'NT Live: Treasure Island'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('English National Opera: La Traviata')
-      end
-    end
+  def test_nt_live_with_encore_suffix
+    assert_sanitized 'National Theatre: A Streetcar Named Desire (Young Vic)',
+                     'NT Live: A Streetcar Named Desire (Young Vic) - Encore'
+  end
 
-    describe 'with IMAX' do
-      let(:title) { '(IMAX) Fury' }
+  def test_roh
+    assert_sanitized 'Royal Opera House: I Due Foscari', 'ROH - I Due Foscari'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Fury')
-      end
-    end
+  def test_rbo_season
+    assert_sanitized 'Royal Ballet and Opera: Manon', 'RBO Cinema Season 2026-27: Manon'
+  end
 
-    describe 'Met Opera screening' do
-      let(:title) { 'MET Opera - Le Nozze Di Figaro' }
+  def test_rsc
+    assert_sanitized "Royal Shakespeare Company: Love's Labour's Lost",
+                     "RSC Live: Love's Labour's Lost"
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Met Opera: Le Nozze Di Figaro')
-      end
-    end
+  def test_removes_sciscreen
+    assert_sanitized 'Dallas Buyers Club', 'SciScreen: Dallas Buyers Club'
+  end
 
-    describe 'NT Live screening' do
-      let(:title) { 'NT Live Encore: Frankenstein (starring Benedict Cumberbatch)' }
+  def test_removes_special_performance
+    assert_sanitized 'Billy Elliot The Musical Live',
+                     'Billy Elliot The Musical Live - Special Performance'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('National Theatre: Frankenstein (starring Benedict Cumberbatch)')
-      end
-    end
+  def test_removes_take_2
+    assert_sanitized 'Boyhood', 'Take 2 - Boyhood'
+  end
 
-    describe 'National Theatre screening' do
-      let(:title) { 'NT Live: Treasure Island' }
+  def test_removes_singalong_and_movies_for_juniors
+    assert_sanitized 'Frozen', 'Frozen Sing-Along - Movies For Juniors'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('National Theatre: Treasure Island')
-      end
-    end
+  def test_keeps_sing_along_within_title
+    assert_sanitized 'Bebefinn Sing-Along Movie', 'Bebefinn Sing-Along Movie'
+  end
 
-    describe 'National Theatre Encore screening' do
-      let(:title) { 'NT Live: A Streetcar Named Desire (Young Vic) - Encore' }
+  def test_removes_format_prefix
+    assert_sanitized 'Wildwood', '(4DX) Wildwood'
+    assert_sanitized 'Wildwood', '(ScreenX) Wildwood'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('National Theatre: A Streetcar Named Desire (Young Vic)')
-      end
-    end
+  def test_removes_movies_for_juniors_prefix
+    assert_sanitized 'Paw Patrol: The Mighty Movie', 'M4J: Paw Patrol: The Mighty Movie'
+  end
 
-    describe 'ROH screening' do
-      let(:title) { 'ROH - I Due Foscari' }
+  def test_removes_family_films_prefix
+    assert_sanitized 'Paw Patrol: The Dino Movie', '£2 Family Films : Paw Patrol: The Dino Movie'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Royal Opera House: I Due Foscari')
-      end
-    end
-
-    describe 'RSC screening' do
-      let(:title) { "RSC Live: Love's Labour's Lost" }
+  def test_removes_film_year
+    assert_sanitized 'Street Fighter', 'Street Fighter (2026)'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal("Royal Shakespeare Company: Love's Labour's Lost")
-      end
-    end
-
-    describe 'SciScreen screening' do
-      let(:title) { 'SciScreen: Dallas Buyers Club' }
+  def test_removes_season_prefix_and_year
+    assert_sanitized 'From Dusk Till Dawn', 'Horror Season 2026 From Dusk Till Dawn (1996)'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Dallas Buyers Club')
-      end
-    end
-
-    describe 'special screening' do
-      let(:title) { 'Billy Elliot The Musical Live - Special Performance' }
+  def test_removes_re_release
+    assert_sanitized 'Zindagi Na Milegi Dobara', 'Zindagi Na Milegi Dobara (Re-release) (Hindi)'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Billy Elliot The Musical Live')
-      end
-    end
-
-    describe 'Take 2 screening' do
-      let(:title) { 'Take 2 - Boyhood' }
+  def test_removes_festival_prefix
+    assert_sanitized 'Scum Of The Earth', 'Cine-Excess 2026: Scum Of The Earth'
+  end
 
-      it 'removes prefix' do
-        _(subject).must_equal('Boyhood')
-      end
-    end
-
-    describe 'singalong and movies for juniors' do
-      let(:title) { 'Frozen Sing-Along - Movies For Juniors' }
+  private
 
-      it 'removes prefix' do
-        _(subject).must_equal('Frozen')
-      end
-    end
+  def assert_sanitized(expected, title)
+    assert_equal expected, CineworldUk::Internal::TitleSanitizer.new(title).sanitized
   end
 end

data/test/lib/cineworld_uk/performance_test.rb

@@ -1,183 +1,168 @@
 require_relative '../../test_helper'
-require_relative '../../support/fixture_reader'
-
-describe CineworldUk::Performance do
-  include Support::FixtureReader
-
-  let(:described_class) { CineworldUk::Performance }
-  let(:api_response) { Minitest::Mock.new }
-
-  before { WebMock.disable_net_connect! }
-  after { WebMock.allow_net_connect! }
-
-  describe '.at(cinema_id)' do
-    subject do
-      described_class.at(cinema_id, from: Date.today + 1, to: Date.today + 1)
-    end
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-      4.times { api_response.expect(:performances,
-                          performances_tomorrow_json(14),
-                          [14, Date.today + 1]) }
-    end
-
-    describe 'called with integer' do
-      let(:cinema_id) { 14 }
-
-      it 'returns an array of performances' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_be_instance_of(Array)
-          subject.each do |performance|
-            _(performance).must_be_instance_of(described_class)
-          end
-        end
-      end
-
-      it 'returns at least a sensible number' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject.count).must_be :>, 5
-        end
-      end
-    end
-
-    describe 'called with string' do
-      let(:cinema_id) { '14' }
-
-      it 'returns an array of performances' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_be_instance_of(Array)
-          subject.each do |performance|
-            _(performance).must_be_instance_of(described_class)
-          end
-        end
-      end
-
-      it 'returns at least a sensible number' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject.count).must_be :>, 5
-        end
-      end
-    end
-  end
-
-  describe '.new' do
-    subject { described_class.new(options) }
-
-    describe 'simple' do
-      let(:options) do
-        {
-          film_name:   'Iron Man 3',
-          cinema_id:   3,
-          cinema_name: 'Cineworld Brighton',
-          starting_at: Time.utc(2013, 9, 12, 11, 0)
-        }
-      end
-
-      it 'sets cinema name and film name' do
-        _(subject.film_name).must_equal 'Iron Man 3'
-        _(subject.cinema_name).must_equal 'Cineworld Brighton'
-      end
-
-      it 'booking url, dimension & varient are set to defaults' do
-        _(subject.booking_url).must_be_nil
-        _(subject.dimension).must_equal '2d'
-        _(subject.variant).must_equal []
-      end
-    end
-  end
-
-  describe '#dimension' do
-    let(:options) do
-      {
-        film_name:   'Iron Man 3',
-        dimension:   '3d',
-        cinema_id:   3,
-        cinema_name: 'Cineworld Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0)
-      }
-    end
-
-    subject { described_class.new(options).dimension }
-
-    it 'returns 2d or 3d' do
-      _(subject).must_be_instance_of(String)
-      _(subject).must_equal '3d'
-    end
-  end
-
-  describe '#starting_at' do
-    subject { described_class.new(options).starting_at }
-
-    describe 'with utc time' do
-      let(:options) do
-        {
-          film_name:   'Iron Man 3',
-          cinema_id:   3,
-          cinema_name: 'Cineworld Brighton',
-          starting_at: Time.utc(2013, 9, 12, 11, 0)
-        }
-      end
-
-      it 'returns UTC time' do
-        _(subject).must_be_instance_of Time
-        _(subject).must_equal Time.utc(2013, 9, 12, 11, 0)
-      end
-    end
-
-    describe 'with non-utc time' do
-      let(:options) do
-        {
-          film_name:   'Iron Man 3',
-          cinema_id:   3,
-          cinema_name: 'Cineworld Brighton',
-          starting_at: Time.new(2013, 9, 12, 11, 0)
-        }
-      end
-
-      it 'returns UTC time' do
-        _(subject).must_be_instance_of Time
-        _(subject).must_equal Time.utc(2013, 9, 12, 10, 0)
-        _(subject.utc?).must_equal(true)
-      end
-    end
-  end
-
-  describe '#showing_on' do
-    let(:options) do
-      {
-        film_name:   'Iron Man 3',
-        cinema_id:   3,
-        cinema_name: 'Cineworld Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0)
-      }
-    end
-
-    subject { described_class.new(options).showing_on }
-
-    it 'returns date of showing' do
-      _(subject).must_be_instance_of(Date)
-      _(subject).must_equal Date.new(2013, 9, 12)
-    end
-  end
-
-  describe '#variant' do
-    subject { described_class.new(options).variant }
-
-    let(:options) do
-      {
-        film_name:   'Iron Man 3',
-        cinema_id:   3,
-        cinema_name: 'Cineworld Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0),
-        variant:     ['Kids']
-      }
-    end
-
-    it 'is an alphabetically ordered array of lower-cased strings' do
-      _(subject).must_be_instance_of Array
-      subject.each { |element| _(element).must_be_instance_of String }
-      _(subject).must_equal %w(kids)
-    end
+
+class CineworldUk::PerformanceTest < Minitest::Test
+  include Support::VistaFixtures
+
+  DATE = Date.new(2026, 10, 24)
+
+  def setup
+    setup_vista
+  end
+
+  def teardown
+    teardown_vista
+    super
+  end
+
+  def test_at_returns_performances
+    performances = performances_on_date
+
+    assert(performances.all? { |p| p.instance_of?(CineworldUk::Performance) })
+    assert_equal 7, performances.count
+  end
+
+  def test_at_accepts_string_id
+    stub_showtimes(DATE)
+
+    assert_equal 7, CineworldUk::Performance.at('014', from: DATE, to: DATE).count
+  end
+
+  def test_at_parses_first_performance
+    performance = performances_on_date.first
+
+    assert_equal 14, performance.cinema_id
+    assert_equal 'Brighton', performance.cinema_name
+    assert_equal 'The Example Film', performance.film_name
+    assert_equal Time.utc(2026, 10, 24, 8, 0), performance.starting_at
+    assert_equal '2d', performance.dimension
+    assert_equal %w(audio_described), performance.variant
+    assert_equal 'https://web.cineworld.co.uk/order/showtimes/014-1001/seats',
+                 performance.booking_url
+  end
+
+  def test_at_keeps_format_per_session
+    performances = performances_on_date
+
+    assert_equal '3d', performances[1].dimension
+    assert_equal %w(imax), performances[1].variant
+    assert_equal '2d', performances.last.dimension
+  end
+
+  def test_at_returns_language_and_subtitles
+    performance = performances_on_date[2]
+
+    assert_equal 'Imaginary Picture', performance.film_name
+    assert_equal 'Tamil', performance.language
+    assert performance.subtitled?
+  end
+
+  def test_at_marks_movies_for_juniors_as_kids
+    performance = performances_on_date[3]
+
+    assert_equal 'Pretend Pups', performance.film_name
+    assert_equal %w(kids), performance.variant
+  end
+
+  def test_at_moves_festival_from_title
+    performance = performances_on_date[4]
+
+    assert_equal 'Scum Of The Earth', performance.film_name
+    assert_equal Cinebase::Festival.new(name: 'Cine-Excess', year: 2026), performance.festival
+  end
+
+  def test_at_parses_format_and_film_year
+    performance = performances_on_date[5]
+
+    assert_equal 'Wildwood', performance.film_name
+    assert_equal 2026, performance.film_year
+    assert_equal %w(4dx), performance.variant
+  end
+
+  def test_new_sets_film_year
+    assert_equal 1996, CineworldUk::Performance.new(options(film_year: 1996)).film_year
+  end
+
+  def test_at_keeps_after_midnight_on_next_utc_day
+    assert_equal Time.utc(2026, 10, 24, 23, 15), performances_on_date.last.starting_at
+  end
+
+  def test_at_includes_last_requested_day_without_fetching_sites
+    stub_showtimes(DATE, empty_showtimes_json)
+    stub_showtimes(DATE + 1)
+
+    performances = CineworldUk::Performance.at(14, from: DATE, to: DATE + 1)
+
+    assert_equal 7, performances.count
+    assert_not_requested :get, "#{BASE_URL}sites"
+  end
+
+  def test_at_defaults_to_fourteen_days
+    (DATE..DATE + 13).each { |date| stub_showtimes(date, empty_showtimes_json) }
+
+    assert_equal [], CineworldUk::Performance.at(14, from: DATE)
+    assert_requested :get, %r{showtimes/by-business-date/}, times: 14
+  end
+
+  def test_at_rejects_range_ending_before_start
+    assert_raises(ArgumentError) { CineworldUk::Performance.at(14, from: DATE, to: DATE - 1) }
+  end
+
+  def test_new_sets_names
+    performance = CineworldUk::Performance.new(options)
+
+    assert_equal 'Iron Man 3', performance.film_name
+    assert_equal 'Cineworld Brighton', performance.cinema_name
+  end
+
+  def test_new_sets_defaults
+    performance = CineworldUk::Performance.new(options)
+
+    assert_nil performance.booking_url
+    assert_equal '2d', performance.dimension
+    assert_nil performance.festival
+    assert_nil performance.language
+    refute performance.subtitled?
+    assert_equal [], performance.variant
+  end
+
+  def test_dimension
+    assert_equal '3d', CineworldUk::Performance.new(options(dimension: '3d')).dimension
+  end
+
+  def test_starting_at_keeps_utc
+    assert_equal Time.utc(2013, 9, 12, 11, 0), CineworldUk::Performance.new(options).starting_at
+  end
+
+  def test_starting_at_converts_local_time_to_utc
+    starting_at = CineworldUk::Performance.new(
+      options(starting_at: Time.new(2013, 9, 12, 11, 0))
+    ).starting_at
+
+    assert_equal Time.utc(2013, 9, 12, 10, 0), starting_at
+    assert starting_at.utc?
+  end
+
+  def test_showing_on
+    assert_equal Date.new(2013, 9, 12), CineworldUk::Performance.new(options).showing_on
+  end
+
+  def test_variant_is_sorted_and_lower_case
+    assert_equal %w(kids), CineworldUk::Performance.new(options(variant: ['Kids'])).variant
+  end
+
+  private
+
+  def options(overrides = {})
+    {
+      film_name:   'Iron Man 3',
+      cinema_id:   3,
+      cinema_name: 'Cineworld Brighton',
+      starting_at: Time.utc(2013, 9, 12, 11, 0)
+    }.merge(overrides)
+  end
+
+  def performances_on_date
+    stub_showtimes(DATE)
+    CineworldUk::Performance.at(14, from: DATE, to: DATE)
   end
 end

data/test/lib/cineworld_uk/version_test.rb

@@ -1,7 +1,7 @@
 require_relative '../../test_helper'
 
-describe CineworldUk do
-  it 'must be defined' do
-    _(CineworldUk::VERSION).wont_be_nil
+class CineworldUk::VersionTest < Minitest::Test
+  def test_version_is_defined
+    refute_nil CineworldUk::VERSION
   end
 end

data/test/live/api_shape_test.rb

@@ -0,0 +1,22 @@
+require_relative 'live_helper'
+
+class LiveApiShapeTest < Minitest::Test
+  include ApiShapes
+
+  def test_sites_are_readable
+    assert_sites_shape(client.get('sites'))
+  end
+
+  def test_showtimes_are_readable
+    date = (Date.today + 1).iso8601
+
+    assert_showtimes_shape(client.get("showtimes/by-business-date/#{date}", 'siteIds' => '014'))
+  end
+
+  private
+
+  def client
+    Cinebase::Vista::Client.new(base_url: CineworldUk::Internal::ApiResponse::BASE_URL,
+                                region_code: 'GB', token: CineworldUk.token)
+  end
+end