cineworld_uk 4.1.0-aarch64-linux-gnu → 4.2.0-aarch64-linux-gnu

data/test/lib/cineworld_uk/cinema_test.rb

@@ -1,249 +1,89 @@
 require_relative '../../test_helper'
-require_relative '../../support/fixture_reader'
-
-describe CineworldUk::Cinema do
-  include Support::FixtureReader
 
-  let(:described_class) { CineworldUk::Cinema }
-  let(:api_response) { Minitest::Mock.new }
+class CineworldUk::CinemaTest < Minitest::Test
+  include Support::VistaFixtures
 
-  before { WebMock.disable_net_connect! }
-  after { WebMock.allow_net_connect! }
-
-  describe '.all' do
-    subject { described_class.all }
-
-    before { api_response.expect(:cinema_list, cinema_list_json) }
-
-    it 'returns an Array of CineworldUK::Cinemas' do
-      CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        _(subject).must_be_instance_of(Array)
-        subject.each do |value|
-          _(value).must_be_instance_of(CineworldUk::Cinema)
-        end
-      end
-    end
-
-    it 'returns the correctly sized array' do
-      CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        _(subject.size).must_equal(87)
-      end
-    end
-  end
-
-  describe '#adr' do
-    subject { described_class.new(id).adr }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
-
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
-
-      it 'returns the address hash' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal(
-            street_address: 'Brighton Marina Village',
-            extended_address: nil,
-            locality: 'Brighton',
-            region: nil,
-            postal_code: 'BN2 5UF',
-            country: 'United Kingdom'
-          )
-        end
-      end
-    end
-  end
-
-  describe '#address' do
-    subject { described_class.new(id).address }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
-
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
-
-      it 'returns the address hash' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal(
-            street_address: 'Brighton Marina Village',
-            extended_address: nil,
-            locality: 'Brighton',
-            region: nil,
-            postal_code: 'BN2 5UF',
-            country: 'United Kingdom'
-          )
-        end
-      end
-    end
-  end
-
-  describe '#extended_address' do
-    subject { described_class.new(id).extended_address }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
-
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
-
-      it 'returns the address hash' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal('')
-        end
-      end
-    end
+  def setup
+    setup_vista
+    stub_sites
   end
 
-  describe '#full_name' do
-    subject { described_class.new(id).full_name }
-
-    before { api_response.expect(:cinema_list, cinema_list_json) }
-
-    describe 'simple name (Brighton)' do
-      let(:id) { 14 }
-
-      it 'returns the brand in the name' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'Cineworld Brighton'
-        end
-      end
-    end
-
-    describe 'simple name (Brighton) called with String' do
-      let(:id) { '14' }
-
-      it 'returns the brand in the name' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'Cineworld Brighton'
-        end
-      end
-    end
-
-    describe 'complex name (Glasgow Silverburn)' do
-      let(:id) { 88 }
-
-      it 'returns the brand in the name' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'Cineworld Glasgow: Silverburn'
-        end
-      end
-    end
+  def teardown
+    teardown_vista
+    super
   end
 
-  describe '#locality' do
-    subject { described_class.new(id).locality }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
-
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
-
-      it 'returns the town/city' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'Brighton'
-        end
-      end
-    end
-
-    describe 'London - Leicester Square (103)' do
-      let(:id) { 103 }
+  def test_all_returns_cinemas
+    cinemas = CineworldUk::Cinema.all
 
-      it 'returns borough of London' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'London'
-        end
-      end
-    end
-  end
+    assert(cinemas.all? { |cinema| cinema.instance_of?(CineworldUk::Cinema) })
+    assert_equal [14, 88, 103, 999], cinemas.map(&:id)
+  end
 
-  describe '#postal_code' do
-    subject { described_class.new(id).postal_code }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
-
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
+  def test_all_fetches_sites_once
+    CineworldUk::Cinema.all
+    CineworldUk::Cinema.new(14).name
 
-      it 'returns the post code' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'BN2 5UF'
-        end
-      end
-    end
+    assert_requested :get, "#{BASE_URL}sites", times: 1
   end
 
-  describe '#region' do
-    subject { described_class.new(id).region }
-
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
+  def test_adr
+    expected = {
+      street_address: '1 Example Marina',
+      extended_address: nil,
+      locality: 'Brighton',
+      region: 'East Sussex',
+      postal_code: 'BN2 0ZZ',
+      country: 'United Kingdom'
+    }
+
+    assert_equal expected, CineworldUk::Cinema.new(14).adr
+    assert_equal expected, CineworldUk::Cinema.new(14).address
+  end
 
-    describe 'no region - Brighton (14)' do
-      let(:id) { 14 }
+  def test_extended_address_is_empty
+    assert_equal '', CineworldUk::Cinema.new(14).extended_address
+  end
 
-      it 'returns the empty string is none exists' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal ''
-        end
-      end
-    end
+  def test_full_name
+    assert_equal 'Cineworld Brighton', CineworldUk::Cinema.new(14).full_name
+  end
 
-    describe 'London - Leicester Square (103)' do
-      let(:id) { 103 }
+  def test_full_name_accepts_string_id
+    assert_equal 'Cineworld Brighton', CineworldUk::Cinema.new('14').full_name
+  end
 
-      it 'returns "London"' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'London'
-        end
-      end
-    end
-  end
-
-  describe '#street_address' do
-    subject { described_class.new(id).street_address }
+  def test_full_name_with_multiple_words
+    assert_equal 'Cineworld Glasgow Silverburn', CineworldUk::Cinema.new(88).full_name
+  end
 
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
+  def test_name_replaces_dash_separator
+    assert_equal 'Example: Riverside', CineworldUk::Cinema.new(999).name
+  end
 
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
+  def test_locality
+    assert_equal 'Brighton', CineworldUk::Cinema.new(14).locality
+    assert_equal 'London', CineworldUk::Cinema.new(103).locality
+  end
 
-      it 'returns the first line of the Address' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal 'Brighton Marina Village'
-        end
-      end
-    end
+  def test_postal_code
+    assert_equal 'BN2 0ZZ', CineworldUk::Cinema.new(14).postal_code
   end
 
-  describe '#url' do
-    subject { described_class.new(id).url }
+  def test_region
+    assert_equal 'East Sussex', CineworldUk::Cinema.new(14).region
+  end
 
-    before do
-      api_response.expect(:cinema_list, cinema_list_json)
-    end
+  def test_region_defaults_to_london_for_london_cinemas
+    assert_equal 'London', CineworldUk::Cinema.new(103).region
+  end
 
-    describe 'Brighton (14)' do
-      let(:id) { 14 }
+  def test_street_address
+    assert_equal '1 Example Marina', CineworldUk::Cinema.new(14).street_address
+  end
 
-      it 'returns the url' do
-        CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          _(subject).must_equal(
-            "http://www.cineworld.co.uk/cinemas/#{id}/information"
-          )
-        end
-      end
-    end
+  def test_url
+    assert_equal 'http://www.cineworld.co.uk/cinemas/14/information',
+                 CineworldUk::Cinema.new(14).url
   end
 end

data/test/lib/cineworld_uk/internal/api_response_test.rb

@@ -1,207 +1,52 @@
 # frozen_string_literal: true
 
 require_relative "../../../test_helper"
-require "tmpdir"
 
-# This block groups independent Minitest cases, not application logic.
-describe "Vista retrieval" do # rubocop:disable Metrics/BlockLength
-  before do
-    CineworldUk.token = "test-guest-token"
-    [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
-      klass.instance_variables.each do |name|
-        klass.remove_instance_variable(name)
-      end
-    end
-    fixture = "../../../fixtures/api/vista-showtimes-brighton.json"
-    @capture = JSON.parse(File.read(File.expand_path(fixture, __dir__)))
-    @base = "https://digital-api.cineworld.co.uk/ocapi/v1/"
-    sites = @capture.fetch("relatedData").fetch("sites")
-    stub_request(:get, @base + "sites").with(
-      headers: {
-        "Authorization" => "Bearer test-guest-token",
-        "Connect-Region-Code" => "GB"
-      }
-    ).to_return(body: JSON.generate("sites" => sites))
-  end
-
-  after do
-    CineworldUk.token = nil
-    [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
-      klass.instance_variables.each do |name|
-        klass.remove_instance_variable(name)
-      end
-    end
-  end
-
-  def stub_day(day, body)
-    stub_request(:get, @base + "showtimes/by-business-date/#{day}").with(
-      query: { "siteIds" => "014" },
-      headers: { "Authorization" => "Bearer test-guest-token",
-                 "Connect-Region-Code" => "GB" }
-    ).to_return(body: JSON.generate(body))
-  end
+class CineworldUk::Internal::ApiResponseTest < Minitest::Test
+  include Support::VistaFixtures
 
-  it "retrieves cinemas and advertised session times from Vista" do
-    stub_day("2026-10-14", @capture)
-    cinema = CineworldUk::Cinema.all.first
-    _(cinema.id).must_equal 14
-    _(cinema.name).must_equal "Brighton"
-    _(cinema.postal_code).must_equal "BN2 5UF"
-    _(cinema.street_address).must_equal "Brighton Marina Village"
-    assert_requested :get, @base + "sites", times: 1
-    performances = CineworldUk::Performance.at(
-      14, from: Date.new(2026, 10, 14), to: Date.new(2026, 10, 14)
-    )
-    _(performances.size).must_equal 17
-    first = performances.first
-    _(first.film_name).must_equal "Other Mommy"
-    _(first.starting_at).must_equal Time.utc(2026, 10, 14, 14, 40)
-    _(first.booking_url).must_equal(
-      "https://web.cineworld.co.uk/order/showtimes/014-165507/seats"
-    )
-    _(first.variant).must_include "audio_described"
-    _(first.dimension).must_equal "2d"
-    assert_requested :get, @base + "sites", times: 1
-    assert_requested :get, @base + "showtimes/by-business-date/2026-10-14",
-                     query: { "siteIds" => "014" }, times: 1
+  def setup
+    setup_vista
   end
 
-  it "keeps format session-specific and includes the last requested day" do
-    @capture["showtimes"] =
-      [@capture["showtimes"].first,
-       Marshal.load(Marshal.dump(@capture["showtimes"].first))]
-    @capture["showtimes"][1]["id"] = "014-second"
-    @capture["showtimes"][1]["requires3dGlasses"] = true
-    @capture["showtimes"][1]["schedule"]["startsAt"] =
-      "2026-10-25T16:40:00+00:00"
-    stub_day("2026-10-24",
-             "showtimes" => [],
-             "relatedData" => { "films" => [], "attributes" => [],
-                                "sites" => [] })
-    stub_day("2026-10-25", @capture)
-    results = CineworldUk::Performance.at("014", from: Date.new(2026, 10, 24),
-                                                 to: Date.new(2026, 10, 25))
-    _(results.map(&:dimension)).must_equal %w[2d 3d]
-    _(results.last.starting_at).must_equal Time.utc(2026, 10, 25, 16, 40)
-    _(results.first.cinema_name).must_equal "Brighton"
-    assert_not_requested :get, @base + "sites"
+  def teardown
+    teardown_vista
+    super
   end
 
-  it "rejects missing and rejected tokens without exposing credentials" do
+  def test_rejects_missing_token
     CineworldUk.token = nil
-    assert_raises(CineworldUk::AuthenticationError) { CineworldUk::Cinema.all }
-    CineworldUk.token = "expired-secret"
-    stub_request(:get, @base + "sites").to_return(status: 401,
-                                                  body: "expired-secret")
-    error = assert_raises(CineworldUk::AuthenticationError) do
-      CineworldUk::Cinema.all
-    end
-    refute_includes error.message, "expired-secret"
-    CineworldUk.token = "replacement"
-    stub_request(:get, @base + "sites").with(
-      headers: { "Authorization" => "Bearer replacement" }
-    ).to_return(body: '{"sites":[]}')
-    _(CineworldUk::Cinema.all).must_equal []
-  end
 
-  it "defaults to fourteen days and rejects reversed ranges" do
-    day = Date.new(2026, 10, 14)
-    (day..day + 13).each do |date|
-      stub_day(date.iso8601,
-               "showtimes" => [],
-               "relatedData" => { "films" => [], "attributes" => [],
-                                  "sites" => [] })
-    end
-    _(CineworldUk::Performance.at(14, from: day)).must_equal []
-    assert_requested :get, %r{showtimes/by-business-date/}, times: 14
-    assert_raises(ArgumentError) do
-      CineworldUk::Performance.at(14, from: day, to: day - 1)
-    end
-    assert_not_requested :get, @base + "sites"
+    assert_raises(CineworldUk::AuthenticationError) { CineworldUk::Cinema.all }
   end
 
-  it "does not follow redirects or hide forbidden responses" do
-    [302, 403].each do |status|
-      stub_request(:get, @base + "sites").to_return(
-        status: status, headers: { "Location" => "https://example.com/" }
-      )
-      error = assert_raises(RuntimeError) { CineworldUk::Cinema.all }
-      assert_includes error.message, status.to_s
-    end
-  end
-end
+  def test_rejects_token_without_exposing_it
+    CineworldUk.token = "expired-secret"
+    stub_request(:get, "#{BASE_URL}sites").to_return(status: 401, body: "expired-secret")
 
-describe "Guest token acquisition" do
-  before do
-    @directory = Dir.mktmpdir("cineworld token ")
-    @curl = File.join(@directory, "curl-impersonate")
-    CineworldUk.token = "existing-token"
-  end
+    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk::Cinema.all }
 
-  after do
-    FileUtils.remove_entry(@directory)
-    CineworldUk.token = nil
+    refute_includes error.message, "expired-secret"
   end
 
-  def serve_token_page(html, status: 200, exit_code: 0)
-    output = "#{html}\n#{status}"
-    File.write(@curl, "#!#{RbConfig.ruby}\nSTDOUT.write(#{output.dump})\nexit #{exit_code}\n")
-    File.chmod(0o700, @curl)
-  end
+  def test_uses_replacement_token
+    CineworldUk.token = "replacement"
+    stub_request(:get, "#{BASE_URL}sites")
+      .with(headers: { "Authorization" => "Bearer replacement" })
+      .to_return(body: '{"sites":[]}')
 
-  def token_page(expires)
-    payload = Base64.urlsafe_encode64(JSON.generate("exp" => expires), padding: false)
-    token = "header.#{payload}.signature"
-    data = { "props" => { "pageProps" => { "environment" => { "gasToken" => token } } } }
-    ["<script type='application/json' id='__NEXT_DATA__'>#{JSON.generate(data)}</script>", token]
+    assert_equal [], CineworldUk::Cinema.all
   end
 
-  it "sets and returns the guest JWT from either a 200 or 404 page" do
-    html, token = token_page(Time.now.to_i + 3600)
-    [200, 404].each do |status|
-      serve_token_page(html, status: status)
-      _(CineworldUk.acquire_token!(curl: @curl)).must_equal token
-      _(CineworldUk.token).must_equal token
-    end
-  end
+  def test_does_not_follow_redirects_or_hide_forbidden_responses
+    [302, 403].each do |status|
+      reset_caches
+      stub_request(:get, "#{BASE_URL}sites")
+        .to_return(status: status, headers: { "Location" => "https://example.com/" })
 
-  it "rejects expired tokens including the expiry boundary without replacing the current token" do
-    now = Time.at(1_800_000_000)
-    Time.stub(:now, now) do
-      [-1, 0, 1].each do |offset|
-        html, token = token_page(now.to_i + offset)
-        serve_token_page(html)
-        if offset.positive?
-          _(CineworldUk.acquire_token!(curl: @curl)).must_equal token
-        else
-          assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
-          _(CineworldUk.token).must_equal "existing-token"
-        end
-      end
-    end
-  end
+      error = assert_raises(RuntimeError) { CineworldUk::Cinema.all }
 
-  it "reports blocked, redirected, missing and malformed page data without exposing the response" do
-    html, token = token_page(Time.now.to_i + 3600)
-    invalid_payload = Base64.urlsafe_encode64("broken-secret", padding: false)
-    [[html, 403], [html, 302], ["Cloudflare block", 200],
-     ["<script id='__NEXT_DATA__'>{</script>", 200],
-     ["<script id='__NEXT_DATA__'>{}</script>", 200],
-     [html.sub(token, "broken-secret"), 200],
-     [html.sub(token, "header.#{invalid_payload}.signature"), 200]].each do |body, status|
-      serve_token_page(body, status: status)
-      error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
-      refute_includes error.full_message, token
-      refute_includes error.full_message, "broken-secret"
-      _(CineworldUk.token).must_equal "existing-token"
+      assert_includes error.message, status.to_s
     end
   end
-
-  it "reports a missing executable or curl failure as an authentication error" do
-    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
-    assert_includes error.message, "Install curl-impersonate"
-    serve_token_page("", status: 0, exit_code: 28)
-    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
-    assert_includes error.message, "curl exit 28"
-  end
 end

data/test/lib/cineworld_uk/internal/fixture_shape_test.rb

@@ -0,0 +1,14 @@
+require_relative '../../../test_helper'
+
+class FixtureShapeTest < Minitest::Test
+  include Support::VistaFixtures
+  include ApiShapes
+
+  def test_sites_fixture_matches_shape
+    assert_sites_shape(JSON.parse(sites_json))
+  end
+
+  def test_showtimes_fixture_matches_shape
+    assert_showtimes_shape(JSON.parse(showtimes_json))
+  end
+end

data/test/lib/cineworld_uk/internal/guest_token_test.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "base64"
+require "tmpdir"
+
+class CineworldUk::Internal::GuestTokenTest < Minitest::Test
+  def setup
+    @directory = Dir.mktmpdir("cineworld token ")
+    @curl = File.join(@directory, "curl-impersonate")
+    CineworldUk.token = "existing-token"
+  end
+
+  def teardown
+    FileUtils.remove_entry(@directory)
+    CineworldUk.token = nil
+  end
+
+  def test_sets_and_returns_token_from_200_or_404_page
+    html, token = token_page(Time.now.to_i + 3600)
+
+    [200, 404].each do |status|
+      serve_token_page(html, status: status)
+
+      assert_equal token, CineworldUk.acquire_token!(curl: @curl)
+      assert_equal token, CineworldUk.token
+    end
+  end
+
+  def test_rejects_expired_tokens_including_boundary_and_keeps_current_token
+    now = Time.at(1_800_000_000)
+    Time.stub(:now, now) do
+      [-1, 0, 1].each do |offset|
+        html, token = token_page(now.to_i + offset)
+        serve_token_page(html)
+        if offset.positive?
+          assert_equal token, CineworldUk.acquire_token!(curl: @curl)
+        else
+          assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+          assert_equal "existing-token", CineworldUk.token
+        end
+      end
+    end
+  end
+
+  def test_reports_bad_pages_without_exposing_the_response
+    html, token = token_page(Time.now.to_i + 3600)
+    invalid_payload = Base64.urlsafe_encode64("broken-secret", padding: false)
+    [[html, 403], [html, 302], ["Cloudflare block", 200],
+     ["<script id='__NEXT_DATA__'>{</script>", 200],
+     ["<script id='__NEXT_DATA__'>{}</script>", 200],
+     [html.sub(token, "broken-secret"), 200],
+     [html.sub(token, "header.#{invalid_payload}.signature"), 200]].each do |body, status|
+      serve_token_page(body, status: status)
+
+      error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+
+      refute_includes error.full_message, token
+      refute_includes error.full_message, "broken-secret"
+      assert_equal "existing-token", CineworldUk.token
+    end
+  end
+
+  def test_reports_missing_executable_or_curl_failure
+    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+    assert_includes error.message, "Install curl-impersonate"
+
+    serve_token_page("", status: 0, exit_code: 28)
+    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+    assert_includes error.message, "curl exit 28"
+  end
+
+  private
+
+  def serve_token_page(html, status: 200, exit_code: 0)
+    output = "#{html}\n#{status}"
+    File.write(@curl, "#!#{RbConfig.ruby}\nSTDOUT.write(#{output.dump})\nexit #{exit_code}\n")
+    File.chmod(0o700, @curl)
+  end
+
+  def token_page(expires)
+    payload = Base64.urlsafe_encode64(JSON.generate("exp" => expires), padding: false)
+    token = "header.#{payload}.signature"
+    data = { "props" => { "pageProps" => { "environment" => { "gasToken" => token } } } }
+    ["<script type='application/json' id='__NEXT_DATA__'>#{JSON.generate(data)}</script>", token]
+  end
+end