cineworld_uk 3.1.0 → 4.0.0

data/test/live/integration_test.rb

@@ -6,6 +6,7 @@ Minitest::Reporters.use! [
 ]
 
 require File.expand_path('../../../lib/cineworld_uk.rb', __FILE__)
+CineworldUk.token = ENV.fetch("CINEWORLD_TOKEN")
 
 describe CineworldUk::Cinema do
   let(:described_class) { CineworldUk::Cinema }
@@ -14,19 +15,18 @@ describe CineworldUk::Cinema do
     subject { described_class.all }
 
     it 'returns an Array of CineworldUK::Cinemas' do
-      subject.must_be_instance_of(Array)
+      _(subject).must_be_instance_of(Array)
       subject.each do |value|
-        value.must_be_instance_of(CineworldUk::Cinema)
+        _(value).must_be_instance_of(CineworldUk::Cinema)
       end
     end
 
     it 'returns the correctly sized array' do
-      subject.size.must_be :>, 18
+      _(subject.size).must_be :>, 18
     end
 
     it 'returns the right cinemas' do
-      subject.first.name.must_equal 'Aberdeen: Queens Links'
-      subject.last.name.must_equal 'Yeovil'
+      _(subject.detect { |cinema| cinema.id == 14 }.name).must_equal "Brighton"
     end
   end
 end
@@ -35,17 +35,17 @@ describe CineworldUk::Performance do
   let(:described_class) { CineworldUk::Performance }
 
   describe '.at(cinema_id)' do
-    subject { described_class.at(3) }
+    subject { described_class.at(14, from: Date.today + 1, to: Date.today + 1) }
 
     it 'returns an array of screenings' do
-      subject.must_be_instance_of(Array)
+      _(subject).must_be_instance_of(Array)
       subject.each do |performance|
-        performance.must_be_instance_of(CineworldUk::Performance)
+        _(performance).must_be_instance_of(CineworldUk::Performance)
       end
     end
 
     it 'returns correct number of screenings' do
-      subject.count.must_be :>, 10
+      _(subject.count).must_be :>, 10
     end
   end
 end

data/test/support/fixture_reader.rb

@@ -9,24 +9,12 @@ module Support
       read_file("#{FIXTURE_PATH}/cinema-list.json")
     end
 
-    def cinema_detail_json(num)
-      read_file("#{FIXTURE_PATH}/cinema-detail-#{num}.json")
-    end
-
     def dates_json(num)
       read_file("#{FIXTURE_PATH}/dates-#{num}.json")
     end
 
     def fake_dates_tomorrow_json
-      { "dates": [tomorrow_s] }.to_json
-    end
-
-    def film_list_comingsoon_json
-      read_file("#{FIXTURE_PATH}/film-list-comingsoon.json")
-    end
-
-    def film_list_json
-      read_file("#{FIXTURE_PATH}/film-list.json")
+      { "body": { "dates": [tomorrow_s] } }.to_json
     end
 
     def performances_tomorrow_json(num)
@@ -38,7 +26,7 @@ module Support
     end
 
     def tomorrow_s
-      (Date.today + 1).strftime('%Y%m%d')
+      (Date.today + 1).strftime('%Y-%m-%d')
     end
   end
 end

data/test/test_helper.rb

@@ -1,7 +1,8 @@
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+require 'simplecov'
+SimpleCov.start
 
 require 'minitest/autorun'
+require 'minitest/mock'
 require 'minitest/reporters'
 reporter_options = { color: true, slow_count: 5 }
 Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]

metadata

@@ -1,31 +1,30 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Andy Croll
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-11 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: minitest-mock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -66,6 +65,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +99,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.11'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.11'
 description: Pull movie & cinema information from the Cineworld iOS API
 email:
 - andy@goodscary.com
@@ -101,8 +128,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".agents/setup"
+- ".github/workflows/test.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - COMM-LICENSE
 - Gemfile
@@ -115,25 +144,17 @@ files:
 - lib/cineworld_uk/internal/api_response.rb
 - lib/cineworld_uk/internal/parser/api/cinema_address.rb
 - lib/cineworld_uk/internal/parser/api/film.rb
-- lib/cineworld_uk/internal/parser/api/film_lookup.rb
 - lib/cineworld_uk/internal/parser/api/performance.rb
-- lib/cineworld_uk/internal/parser/api/performances_by_day.rb
 - lib/cineworld_uk/internal/title_sanitizer.rb
 - lib/cineworld_uk/performance.rb
 - lib/cineworld_uk/version.rb
-- test/fixtures/api/cinema-detail-10.json
-- test/fixtures/api/cinema-detail-21.json
-- test/fixtures/api/cinema-detail-3.json
-- test/fixtures/api/cinema-detail-96.json
 - test/fixtures/api/cinema-list.json
-- test/fixtures/api/dates-3.json
-- test/fixtures/api/film-list-comingsoon.json
-- test/fixtures/api/film-list.json
-- test/fixtures/api/performances-tomorrow-3.json
+- test/fixtures/api/dates-14.json
+- test/fixtures/api/performances-tomorrow-14.json
+- test/fixtures/api/vista-showtimes-brighton.json
 - test/lib/cineworld_uk/cinema_test.rb
 - test/lib/cineworld_uk/internal/api_response_test.rb
 - test/lib/cineworld_uk/internal/parser/api/cinema_address_test.rb
-- test/lib/cineworld_uk/internal/parser/api/film_lookup_test.rb
 - test/lib/cineworld_uk/internal/parser/api/film_test.rb
 - test/lib/cineworld_uk/internal/parser/api/performance_test.rb
 - test/lib/cineworld_uk/internal/title_sanitizer_test.rb
@@ -147,7 +168,6 @@ licenses:
 - AGPL
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -162,25 +182,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: It's a scraper, but a nice one
 test_files:
-- test/fixtures/api/cinema-detail-10.json
-- test/fixtures/api/cinema-detail-21.json
-- test/fixtures/api/cinema-detail-3.json
-- test/fixtures/api/cinema-detail-96.json
 - test/fixtures/api/cinema-list.json
-- test/fixtures/api/dates-3.json
-- test/fixtures/api/film-list-comingsoon.json
-- test/fixtures/api/film-list.json
-- test/fixtures/api/performances-tomorrow-3.json
+- test/fixtures/api/dates-14.json
+- test/fixtures/api/performances-tomorrow-14.json
+- test/fixtures/api/vista-showtimes-brighton.json
 - test/lib/cineworld_uk/cinema_test.rb
 - test/lib/cineworld_uk/internal/api_response_test.rb
 - test/lib/cineworld_uk/internal/parser/api/cinema_address_test.rb
-- test/lib/cineworld_uk/internal/parser/api/film_lookup_test.rb
 - test/lib/cineworld_uk/internal/parser/api/film_test.rb
 - test/lib/cineworld_uk/internal/parser/api/performance_test.rb
 - test/lib/cineworld_uk/internal/title_sanitizer_test.rb
@@ -189,4 +201,3 @@ test_files:
 - test/live/integration_test.rb
 - test/support/fixture_reader.rb
 - test/test_helper.rb
-has_rdoc: 

data/.travis.yml

@@ -1,10 +0,0 @@
-language: ruby
-rvm:
-- 2.2.4
-- 2.3.0
-addons:
-  code_climate:
-    repo_token: 52f46a80ce5154b027b4ee2f37d8abd7f428e1615a7bdbdfd5d35efd81586c34
-notifications:
-  slack:
-    secure: Cz8KU8SOjTgtMhU7F9JrlkoxNfvy/gon7rSzcIbMvQZKHwttmaMHrZlX0a+vrKlcVcLMGNzEJFNChNNrnhso4yYPhUwfF8XXbwvC7IwFwOQjx7Nw9GTRP6wZLsLPYg0zcOLlEZBBG3LNfy20D+PnT9/DiuxLcwr7Rb0/ClhHUnE=

data/lib/cineworld_uk/internal/parser/api/film_lookup.rb

@@ -1,38 +0,0 @@
-module CineworldUk
-  # @api private
-  module Internal
-    module Parser
-      module Api
-        # Parses a string to derive address
-        class FilmLookup
-          # @return [Hash{Integer => CineworldUk::Internal::Parser::Api::Film}]
-          # contains all films & upcoming films keyed by id
-          def to_hash
-            @to_hash ||= all_films.each_with_object({}) do |item, lookup|
-              next if item['edi'].nil?
-              lookup[item['edi']] = Film.new(item)
-            end
-          end
-
-          private
-
-          def all_films
-            films_data + comingsoon_data
-          end
-
-          def api
-            @api ||= CineworldUk::Internal::ApiResponse.new
-          end
-
-          def comingsoon_data
-            @comingsoon_data ||= JSON.parse(api.film_list_comingsoon)['films']
-          end
-
-          def films_data
-            @films_data ||= JSON.parse(api.film_list)['films']
-          end
-        end
-      end
-    end
-  end
-end

data/lib/cineworld_uk/internal/parser/api/performances_by_day.rb

@@ -1,54 +0,0 @@
-module CineworldUk
-  # @api private
-  module Internal
-    module Parser
-      module Api
-        # A day of performances, a parser for a single API call
-        class PerformancesByDay
-          def initialize(cinema_id, date, film_lookup)
-            @cinema_id = cinema_id
-            @date = date
-            @film_lookup = film_lookup
-          end
-
-          # Details of performance from single day
-          # @return [Array<Hash>] :booking_url, :dimension, :film_name,
-          # :starting_at, :variant
-          def to_a
-            performances.map do |performance|
-              film = @film_lookup[performance.film_id]
-              {
-                booking_url: performance.booking_url,
-                dimension: film.dimension,
-                film_name: film.name,
-                starting_at: utc(performance.starting_at),
-                variant: (performance.variant + film.variant).sort
-              }
-            end
-          end
-
-          private
-
-          def performances
-            parsed_response.map do |hash|
-              Internal::Parser::Api::Performance.new(hash)
-            end
-          end
-
-          def parsed_response
-            JSON.parse(response)['performances']
-          end
-
-          def response
-            Internal::ApiResponse.new.performances(@cinema_id, @date)
-          end
-
-          def utc(time)
-            time if time.utc?
-            TZInfo::Timezone.get('Europe/London').local_to_utc(time)
-          end
-        end
-      end
-    end
-  end
-end

data/test/fixtures/api/cinema-detail-10.json

@@ -1 +0,0 @@
-{"cinema":{"id":10,"name":"London - Chelsea","address":"279 Kings Road, Chelsea, London","postcode":"SW3 5EW","tel":"0871 200 2000","services":["con","ns","vh","3d","sb","hfr","etx","ad","dig","gdog","adv"]}}

data/test/fixtures/api/cinema-detail-21.json

@@ -1 +0,0 @@
-{"cinema":{"id":21,"name":"Edinburgh","address":"Fountain Park, 130/3 Dundee Street, Edinburgh","postcode":"EH11 1AF","tel":"0871 200 2000","services":["con","ns","cb","vh","ix","stb","dba","au","3d","dbp","sb","hfr","etx","ad","dig","m4j","bas","bar","gdog","adv"]}}

data/test/fixtures/api/cinema-detail-3.json

@@ -1 +0,0 @@
-{"cinema":{"id":3,"name":"Brighton","address":"Brighton Marina Village, Brighton","postcode":"BN2 5UF","tel":"0871 200 2000","services":["con","ns","vh","dba","au","3d","dbp","sb","hfr","etx","ad","dig","m4j","bas","gdog","adv"]}}

data/test/fixtures/api/cinema-detail-96.json

@@ -1 +0,0 @@
-{"cinema":{"id":96,"name":"Birmingham - NEC","address":"Resorts World, Pendigo Way, Birmingham","postcode":"B40 1PU","tel":"0871 200 2000","services":["con","ns","park","vh","ix","stb","dba","au","3d","dbp","sb","hfr","etx","ad","dig","m4j","bas","gdog","adv"]}}

data/test/fixtures/api/dates-3.json

@@ -1 +0,0 @@
-{"dates":["20160911","20160912","20160913","20160914","20160915","20160916","20160917","20160918","20160919","20160920","20160921","20160922","20161002","20161005","20161006","20161007","20161008","20161009","20161010","20161011","20161012","20161013","20161016","20161027","20161117","20161118","20161119","20161120","20161121","20161122","20161123","20161124","20161127"]}