cineworld_uk 2.1.6 → 3.0.0

data/test/lib/cineworld_uk/internal/parser/api/film_test.rb

@@ -0,0 +1,169 @@
+require_relative '../../../../../test_helper'
+require_relative '../../../../../support/fixture_reader'
+
+describe CineworldUk::Internal::Parser::Api::Film do
+  include Support::FixtureReader
+
+  let(:described_class) { CineworldUk::Internal::Parser::Api::Film }
+  let(:data) { random_film }
+
+  describe '#id' do
+    subject { described_class.new(data).id }
+
+    it 'is an integer' do
+      subject.must_be_instance_of(Fixnum)
+    end
+
+    it 'is the film id from the data' do
+      subject.must_equal(data['edi'])
+    end
+  end
+
+  describe '#dimension' do
+    subject { described_class.new(data).dimension }
+
+    it 'is a string' do
+      subject.must_be_instance_of(String)
+    end
+
+    it 'is 2d or 3d' do
+      subject.must_match(/[23]d/)
+    end
+
+    describe 'hash["format"] is "2D"' do
+      let(:data) { random_film.merge('format' => '2D') }
+
+      it 'is 2d' do
+        subject.must_equal('2d')
+      end
+    end
+
+    describe 'hash["format"] is "3D"' do
+      let(:data) { random_film.merge('format' => '3D') }
+
+      it 'is 3d' do
+        subject.must_equal('3d')
+      end
+    end
+
+    describe 'hash["format"] is "IMAX"' do
+      let(:data) { random_film.merge('format' => 'IMAX') }
+
+      it 'is 2d' do
+        subject.must_equal('2d')
+      end
+    end
+
+    describe 'hash["format"] is "IMAX3D"' do
+      let(:data) { random_film.merge('format' => 'IMAX3D') }
+
+      it 'is 3d' do
+        subject.must_equal('3d')
+      end
+    end
+  end
+
+  describe '#name' do
+    subject { described_class.new(data).name }
+
+    it 'is a string' do
+      subject.must_be_instance_of(String)
+    end
+
+    describe 'hash["originalTitle"] is different' do
+      let(:data) do
+        random_film.merge('originalTitle' => 'Original Title',
+                          'title' => 'Title')
+      end
+
+      it 'is the original title' do
+        subject.must_equal('Original Title')
+      end
+    end
+
+    describe 'original title is unsanitized' do
+      let(:data) { random_film.merge('originalTitle' => 'ROH: Something') }
+
+      it 'is sanitized' do
+        subject.must_equal('Royal Opera House: Something')
+      end
+    end
+  end
+
+  describe '#variant' do
+    subject { described_class.new(data).variant }
+
+    it 'is a sorted array of strings' do
+      subject.must_be_instance_of(Array)
+      subject.each { |element| element.must_be_instance_of(String) }
+      subject.sort.must_equal(subject)
+    end
+
+    describe 'hash["title"] includes "Movies For Juniors"' do
+      let(:data) do
+        random_film.merge('title' => 'Movies For Juniors - Something')
+      end
+
+      it 'includes "kids"' do
+        subject.must_include('kids')
+      end
+    end
+
+    describe 'hash["format"] is "IMAX3D"' do
+      let(:data) do
+        random_film.merge('title' => 'nothing', 'format' => 'IMAX3D')
+      end
+
+      it 'includes "imax"' do
+        subject.must_include('imax')
+      end
+    end
+
+    describe 'hash["format"] is "IMAX"' do
+      let(:data) do
+        random_film.merge('format' => 'IMAX')
+      end
+
+      it 'includes "imax"' do
+        subject.must_include('imax')
+      end
+    end
+
+    describe 'hash["title"] includes "Unlimited Screening"' do
+      let(:data) do
+        random_film.merge('title' => 'Something Unlimited Screening')
+      end
+
+      it 'includes "members"' do
+        subject.must_include('members')
+      end
+    end
+
+    describe 'hash["title"] includes "with Live Q And A"' do
+      let(:data) do
+        random_film.merge('title' => 'Something With Live Q And A')
+      end
+
+      it 'includes "q&a"' do
+        subject.must_include('q&a')
+      end
+    end
+
+    describe 'combination' do
+      let(:data) do
+        random_film.merge('format' => 'IMAX',
+                          'title' => 'Something Unlimited Screening')
+      end
+
+      it 'includes "members"' do
+        subject.must_include('imax', 'members')
+      end
+    end
+  end
+
+  private
+
+  def random_film
+    JSON.parse(film_list_json)['films'].sample
+  end
+end

data/test/lib/cineworld_uk/internal/parser/api/performance_test.rb

@@ -0,0 +1,62 @@
+require_relative '../../../../../test_helper'
+require_relative '../../../../../support/fixture_reader'
+
+describe CineworldUk::Internal::Parser::Api::Performance do
+  include Support::FixtureReader
+
+  let(:described_class) { CineworldUk::Internal::Parser::Api::Performance }
+  let(:data) { random_performance }
+
+  before { WebMock.disable_net_connect! }
+
+  describe '#booking_url' do
+    subject { described_class.new(data).booking_url }
+
+    it 'should be a url on the cineworld website' do
+      subject.must_match(%r{cineworld.co.uk/booking\?})
+    end
+  end
+
+  describe '#film_id' do
+    subject { described_class.new(data).film_id }
+
+    it 'should be a six digit integer' do
+      subject.must_be_instance_of(Fixnum)
+      subject.must_be :>, 10_000
+    end
+  end
+
+  describe '#starting_at' do
+    subject { described_class.new(data).starting_at }
+
+    it 'should be a time' do
+      subject.must_be_instance_of(Time)
+    end
+  end
+
+  describe '#variant' do
+    subject { described_class.new(data).variant }
+
+    describe 'has "ad" => true' do
+      let(:data) { random_performance.merge('ad' => true) }
+
+      it 'includes "audio_described"' do
+        subject.must_include('audio_described')
+      end
+    end
+
+    describe 'has "ss" => true' do
+      let(:data) { random_performance.merge('subtitled' => true) }
+
+      it 'includes "subtitled"' do
+        subject.must_include('subtitled')
+      end
+    end
+  end
+
+  private
+
+  def random_performance
+    JSON.parse(performances_tomorrow_json(3))['performances'].sample
+  end
+end

data/test/lib/cineworld_uk/internal/title_sanitizer_test.rb

@@ -50,7 +50,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Bolshoi Ballet: The Legend of Love' }
 
       it 'removes prefix' do
-        subject.must_equal('Bolshoi: The Legend of Love')
+        subject.must_equal('Bolshoi Ballet: The Legend of Love')
       end
     end
 

data/test/lib/cineworld_uk/{screening_test.rb → performance_test.rb}

@@ -1,38 +1,45 @@
 require_relative '../../test_helper'
+require_relative '../../support/fixture_reader'
 
-describe CineworldUk::Screening do
-  let(:website) { Minitest::Mock.new }
+describe CineworldUk::Performance do
+  include Support::FixtureReader
 
-  before do
-    WebMock.disable_net_connect!
-  end
+  let(:described_class) { CineworldUk::Performance }
+  let(:api_response) { Minitest::Mock.new }
+
+  before { WebMock.disable_net_connect! }
 
   describe '.at(cinema_id)' do
-    subject { CineworldUk::Screening.at(3) }
+    subject { described_class.at(3) }
 
     before do
-      website.expect(:whatson, whatson_html('brighton'), [3])
-      website.expect(:cinemas, cinemas_html)
+      api_response.expect(:cinema_list, cinema_list_json)
+      api_response.expect(:film_list, film_list_json)
+      api_response.expect(:film_list_comingsoon, film_list_comingsoon_json)
+      api_response.expect(:dates, fake_dates_tomorrow_json, [3])
+      api_response.expect(:performances,
+                          performances_tomorrow_json(3),
+                          [3, Date.today + 1])
     end
 
-    it 'returns an array of screenings' do
-      CineworldUk::Internal::Website.stub :new, website do
+    it 'returns an array of performances' do
+      CineworldUk::Internal::ApiResponse.stub :new, api_response do
         subject.must_be_instance_of(Array)
-        subject.each do |screening|
-          screening.must_be_instance_of(CineworldUk::Screening)
+        subject.each do |performance|
+          performance.must_be_instance_of(described_class)
         end
       end
     end
 
-    it 'returns correct number of screenings' do
-      CineworldUk::Internal::Website.stub :new, website do
-        subject.count.must_equal 217
+    it 'returns at least a sensible number' do
+      CineworldUk::Internal::ApiResponse.stub :new, api_response do
+        subject.count.must_be :>, 5
       end
     end
   end
 
   describe '.new' do
-    subject { CineworldUk::Screening.new(options) }
+    subject { described_class.new(options) }
 
     describe 'simple' do
       let(:options) do
@@ -40,7 +47,7 @@ describe CineworldUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.utc(2013, 9, 12, 11, 0)
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
         }
       end
 
@@ -64,11 +71,11 @@ describe CineworldUk::Screening do
         dimension:   '3d',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0)
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
       }
     end
 
-    subject { CineworldUk::Screening.new(options).dimension }
+    subject { described_class.new(options).dimension }
 
     it 'returns 2d or 3d' do
       subject.must_be_instance_of(String)
@@ -76,8 +83,8 @@ describe CineworldUk::Screening do
     end
   end
 
-  describe '#showing_at' do
-    subject { CineworldUk::Screening.new(options).showing_at }
+  describe '#starting_at' do
+    subject { described_class.new(options).starting_at }
 
     describe 'with utc time' do
       let(:options) do
@@ -85,7 +92,7 @@ describe CineworldUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.utc(2013, 9, 12, 11, 0)
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
         }
       end
 
@@ -101,13 +108,14 @@ describe CineworldUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.parse('2013-09-12 11:00')
+          starting_at: Time.new(2013, 9, 12, 11, 0)
         }
       end
 
       it 'returns UTC time' do
         subject.must_be_instance_of Time
         subject.must_equal Time.utc(2013, 9, 12, 10, 0)
+        subject.utc?.must_equal(true)
       end
     end
   end
@@ -118,11 +126,11 @@ describe CineworldUk::Screening do
         film_name:   'Iron Man 3',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0)
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
       }
     end
 
-    subject { CineworldUk::Screening.new(options).showing_on }
+    subject { described_class.new(options).showing_on }
 
     it 'returns date of showing' do
       subject.must_be_instance_of(Date)
@@ -131,42 +139,22 @@ describe CineworldUk::Screening do
   end
 
   describe '#variant' do
-    subject { CineworldUk::Screening.new(options).variant }
+    subject { described_class.new(options).variant }
 
     let(:options) do
       {
         film_name:   'Iron Man 3',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0),
+        starting_at: Time.utc(2013, 9, 12, 11, 0),
         variant:     ['Kids']
       }
     end
 
     it 'is an alphabetically ordered array of lower-cased strings' do
       subject.must_be_instance_of Array
-      subject.each do |tag|
-        tag.must_be_instance_of String
-      end
+      subject.each { |element| element.must_be_instance_of String }
       subject.must_equal %w(kids)
     end
   end
-
-  private
-
-  def cinemas_html
-    read_file('../../../fixtures/cinemas.html')
-  end
-
-  def information_html(filename)
-    read_file("../../../fixtures/information/#{filename}.html")
-  end
-
-  def read_file(filepath)
-    File.read(File.expand_path(filepath, __FILE__))
-  end
-
-  def whatson_html(filename)
-    read_file("../../../fixtures/whatson/#{filename}.html")
-  end
 end

data/test/support/fixture_reader.rb

@@ -0,0 +1,44 @@
+module Support
+  # Read fixture files from disk, for test support
+  module FixtureReader
+    private
+
+    FIXTURE_PATH = '../../fixtures/api'
+
+    def cinema_list_json
+      read_file("#{FIXTURE_PATH}/cinema-list.json")
+    end
+
+    def cinema_detail_json(num)
+      read_file("#{FIXTURE_PATH}/cinema-detail-#{num}.json")
+    end
+
+    def dates_json(num)
+      read_file("#{FIXTURE_PATH}/dates-#{num}.json")
+    end
+
+    def fake_dates_tomorrow_json
+      { "dates": [tomorrow_s] }.to_json
+    end
+
+    def film_list_comingsoon_json
+      read_file("#{FIXTURE_PATH}/film-list-comingsoon.json")
+    end
+
+    def film_list_json
+      read_file("#{FIXTURE_PATH}/film-list.json")
+    end
+
+    def performances_tomorrow_json(num)
+      read_file("#{FIXTURE_PATH}/performances-tomorrow-#{num}.json")
+    end
+
+    def read_file(filepath)
+      File.read(File.expand_path(filepath, __FILE__))
+    end
+
+    def tomorrow_s
+      (Date.today + 1).strftime('%Y%m%d')
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 2.1.6
+  version: 3.0.0
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2016-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -67,35 +67,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: cinebase
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: tzinfo
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: tzinfo-data
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -125,32 +111,34 @@ files:
 - cineworld_uk.gemspec
 - lib/cineworld_uk.rb
 - lib/cineworld_uk/cinema.rb
-- lib/cineworld_uk/film.rb
-- lib/cineworld_uk/internal/film_with_screenings_parser.rb
-- lib/cineworld_uk/internal/screening_parser.rb
+- lib/cineworld_uk/internal/api_response.rb
+- lib/cineworld_uk/internal/parser/api/cinema_address.rb
+- lib/cineworld_uk/internal/parser/api/film.rb
+- lib/cineworld_uk/internal/parser/api/film_lookup.rb
+- lib/cineworld_uk/internal/parser/api/performance.rb
+- lib/cineworld_uk/internal/parser/api/performances_by_day.rb
 - lib/cineworld_uk/internal/title_sanitizer.rb
-- lib/cineworld_uk/internal/website.rb
-- lib/cineworld_uk/internal/whatson_parser.rb
-- lib/cineworld_uk/screening.rb
+- lib/cineworld_uk/performance.rb
 - lib/cineworld_uk/version.rb
-- test/fixture_updater.rb
-- test/fixtures/cinemas.html
-- test/fixtures/information/brighton.html
-- test/fixtures/information/bristol.html
-- test/fixtures/whatson/brighton.html
-- test/fixtures/whatson/brighton/film_first.html
-- test/fixtures/whatson/brighton/film_last.html
-- test/fixtures/whatson/brighton/film_second.html
-- test/fixtures/whatson/glasgow-imax-at-gsc/film_first.html
-- test/fixtures/whatson/the-o2-greenwich/film_first.html
+- test/fixtures/api/cinema-detail-10.json
+- test/fixtures/api/cinema-detail-21.json
+- test/fixtures/api/cinema-detail-3.json
+- test/fixtures/api/cinema-detail-96.json
+- test/fixtures/api/cinema-list.json
+- test/fixtures/api/dates-3.json
+- test/fixtures/api/film-list-comingsoon.json
+- test/fixtures/api/film-list.json
+- test/fixtures/api/performances-tomorrow-3.json
 - test/lib/cineworld_uk/cinema_test.rb
-- test/lib/cineworld_uk/film_test.rb
-- test/lib/cineworld_uk/internal/film_with_screenings_parser_test.rb
+- test/lib/cineworld_uk/internal/api_response_test.rb
+- test/lib/cineworld_uk/internal/parser/api/cinema_address_test.rb
+- test/lib/cineworld_uk/internal/parser/api/film_lookup_test.rb
+- test/lib/cineworld_uk/internal/parser/api/film_test.rb
+- test/lib/cineworld_uk/internal/parser/api/performance_test.rb
 - test/lib/cineworld_uk/internal/title_sanitizer_test.rb
-- test/lib/cineworld_uk/internal/website_test.rb
-- test/lib/cineworld_uk/internal/whatson_parser_test.rb
-- test/lib/cineworld_uk/screening_test.rb
+- test/lib/cineworld_uk/performance_test.rb
 - test/lib/cineworld_uk/version_test.rb
+- test/support/fixture_reader.rb
 - test/test_helper.rb
 homepage: https://github.com/andycroll/cineworld_uk
 licenses:
@@ -172,28 +160,29 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Parses cinema and showing data from the cineworld.co.uk website
 test_files:
-- test/fixture_updater.rb
-- test/fixtures/cinemas.html
-- test/fixtures/information/brighton.html
-- test/fixtures/information/bristol.html
-- test/fixtures/whatson/brighton.html
-- test/fixtures/whatson/brighton/film_first.html
-- test/fixtures/whatson/brighton/film_last.html
-- test/fixtures/whatson/brighton/film_second.html
-- test/fixtures/whatson/glasgow-imax-at-gsc/film_first.html
-- test/fixtures/whatson/the-o2-greenwich/film_first.html
+- test/fixtures/api/cinema-detail-10.json
+- test/fixtures/api/cinema-detail-21.json
+- test/fixtures/api/cinema-detail-3.json
+- test/fixtures/api/cinema-detail-96.json
+- test/fixtures/api/cinema-list.json
+- test/fixtures/api/dates-3.json
+- test/fixtures/api/film-list-comingsoon.json
+- test/fixtures/api/film-list.json
+- test/fixtures/api/performances-tomorrow-3.json
 - test/lib/cineworld_uk/cinema_test.rb
-- test/lib/cineworld_uk/film_test.rb
-- test/lib/cineworld_uk/internal/film_with_screenings_parser_test.rb
+- test/lib/cineworld_uk/internal/api_response_test.rb
+- test/lib/cineworld_uk/internal/parser/api/cinema_address_test.rb
+- test/lib/cineworld_uk/internal/parser/api/film_lookup_test.rb
+- test/lib/cineworld_uk/internal/parser/api/film_test.rb
+- test/lib/cineworld_uk/internal/parser/api/performance_test.rb
 - test/lib/cineworld_uk/internal/title_sanitizer_test.rb
-- test/lib/cineworld_uk/internal/website_test.rb
-- test/lib/cineworld_uk/internal/whatson_parser_test.rb
-- test/lib/cineworld_uk/screening_test.rb
+- test/lib/cineworld_uk/performance_test.rb
 - test/lib/cineworld_uk/version_test.rb
+- test/support/fixture_reader.rb
 - test/test_helper.rb
 has_rdoc: