cinch-weatherman 0.0.1 → 1.0.0

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,6 +1,10 @@
-# Cinch::Weatherman
+# Cinch::Plugins::Weatherman
 
-TODO: Write a gem description
+[![Gem Version](https://badge.fury.io/rb/cinch-weatherman.png)](http://badge.fury.io/rb/cinch-weatherman)
+[![Dependency Status](https://gemnasium.com/canonical-hackers/cinch-weatherman.png)](https://gemnasium.com/canonical-hackers/cinch-weatherman)
+[![Build Status](https://travis-ci.org/canonical-hackers/cinch-weatherman.png?branch=master)](https://travis-ci.org/canonical-hackers/cinch-weatherman)
+[![Coverage Status](https://coveralls.io/repos/canonical-hackers/cinch-weatherman/badge.png?branch=master)](https://coveralls.io/r/canonical-hackers/cinch-weatherman?branch=master)
+[![Code Climate](https://codeclimate.com/github/canonical-hackers/cinch-weatherman.png)](https://codeclimate.com/github/canonical-hackers/cinch-weatherman)
 
 ## Installation
 

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-weatherman.gemspec

@@ -6,7 +6,7 @@ require 'cinch/plugins/weatherman/version'
 Gem::Specification.new do |gem|
   gem.name          = "cinch-weatherman"
   gem.version       = Cinch::Weatherman::VERSION
-  gem.authors       = ["Brian Haberer"]
+  gem.authors       = ["Brian Haberer", "Paul Visscher"]
   gem.email         = ["bhaberer@gmail.com"]
   gem.description   = %q{Cinch Plugin to get Weather data using the Weather-Underground gem}
   gem.summary       = %q{Cinch Plugin to get Weather data}
@@ -17,8 +17,13 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency 'cinch', '>= 2.0.0'
-  gem.add_dependency 'weather-underground', '>= 1.1.1'
-  gem.add_dependency 'time-lord', '1.0.1'
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
+  gem.add_development_dependency 'cinch-test'
+
+  gem.add_dependency 'cinch',                 '~> 2.0.5'
+  gem.add_dependency 'weather-underground',   '>= 1.1.1'
+  gem.add_dependency 'time-lord',             '~> 1.0.1'
   gem.add_dependency 'cinch-cooldown'
 end

data/lib/cinch-weatherman.rb

@@ -1,6 +1,2 @@
-require 'cinch-cooldown'
-require 'time-lord'
-require 'weather-underground'
-
 require 'cinch/plugins/weatherman/version'
 require 'cinch/plugins/weatherman/weatherman'

data/lib/cinch/plugins/weatherman/version.rb

@@ -1,5 +1,5 @@
 module Cinch
   module Weatherman
-    VERSION = "0.0.1"
+    VERSION = "1.0.0"
   end
 end

data/lib/cinch/plugins/weatherman/weatherman.rb

@@ -1,4 +1,9 @@
 # -*- coding: utf-8 -*-
+require 'cinch'
+require 'cinch-cooldown'
+require 'time-lord'
+require 'weather-underground'
+
 module Cinch::Plugins
   class Weatherman
     include Cinch::Plugin
@@ -7,8 +12,8 @@ module Cinch::Plugins
 
     self.help = "Use .w <location> to see information on the weather. (e.g. .w 94062)"
 
-    match /weather (.*)/
     match /w (.*)/
+    match /weather (.*)/
 
     def execute(m, query)
       m.reply get_weather(query)
@@ -17,24 +22,24 @@ module Cinch::Plugins
     private
 
     def get_weather(query)
-      @weather = WeatherUnderground::Base.new()
-      weather_data = @weather.CurrentObservations(query)
-
-      unless weather_data.temp_f == ""
-        location = weather_data.display_location[0].full
-        temp_f = weather_data.temp_f
-        conditions = weather_data.weather.downcase
-        last_updated = weather_data.observation_time.gsub(/Last Updated on/, "")
-        last_updated_ago = Time.parse(last_updated).ago.to_words
-
-        message = "In #{location} it is #{conditions} "
-        message << "and #{temp_f}°F "
-        message << "(last updated about #{last_updated_ago})"
-
-        return message
-      else
-        return "Sorry, couldn't find #{query}."
-      end
+      location, temp_f, conditions, updated = get_forcast(query)
+
+      message = "In #{location} it is #{conditions} "
+      message << "and #{temp_f}°F "
+      message << "(last updated about #{updated})"
+
+      return message
+    rescue ArgumentError
+      return "Sorry, couldn't find #{query}."
+    end
+
+    def get_forcast(query)
+      data = WeatherUnderground::Base.new.CurrentObservations(query)
+      weather = [ data.display_location.first.full,
+                  data.temp_f,
+                  data.weather.downcase,
+                  Time.parse(data.observation_time).ago.to_words ]
+      return weather
     end
   end
 end

data/spec/cinch-weatherman_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe Cinch::Plugins::Weatherman do
+
+  include Cinch::Test
+
+  before(:each) do
+    @bot = make_bot(Cinch::Plugins::Weatherman, {})
+  end
+
+  it 'should allow users to ask for weather by zip' do
+     msg = make_message(@bot, '!weather 94062')
+     get_replies(msg).last.chomp.
+      should include('In Redwood City, CA it is')
+  end
+
+  it 'should allow users to ask for weather by city, state' do
+     msg = make_message(@bot, '!weather redwood city, ca')
+     get_replies(msg).last.chomp.
+      should include('In Redwood City, CA it is')
+  end
+
+  it 'should allow users to ask for weather by airport code' do
+     msg = make_message(@bot, '!weather SFO')
+     get_replies(msg).last.chomp.
+      should include('In San Francisco International, CA it is')
+  end
+
+  it 'should return an error when location not found' do
+     msg = make_message(@bot, '!weather 34')
+     get_replies(msg).last.chomp.
+      should include('Sorry, couldn\'t find 34.')
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-weatherman'
+require 'cinch/test'
+

metadata

@@ -1,32 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: cinch-weatherman
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
 - Brian Haberer
+- Paul Visscher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-06 00:00:00.000000000 Z
+date: 2013-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: cinch
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
-  type: :runtime
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
 - !ruby/object:Gem::Dependency
   name: weather-underground
   requirement: !ruby/object:Gem::Requirement
@@ -48,7 +113,7 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.0.1
   type: :runtime
@@ -56,7 +121,7 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.0.1
 - !ruby/object:Gem::Dependency
@@ -83,6 +148,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -91,6 +157,8 @@ files:
 - lib/cinch-weatherman.rb
 - lib/cinch/plugins/weatherman/version.rb
 - lib/cinch/plugins/weatherman/weatherman.rb
+- spec/cinch-weatherman_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/canonical-hackers/cinch-weatherman
 licenses: []
 post_install_message: 
@@ -115,4 +183,7 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin to get Weather data
-test_files: []
+test_files:
+- spec/cinch-weatherman_spec.rb
+- spec/spec_helper.rb
+has_rdoc: