cinch-urbandict 0.0.3 → 1.0.0

data/.travis.yml

@@ -0,0 +1,5 @@
+nguage: ruby
+rvm:
+  - ruby-head
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,5 +1,11 @@
 # Cinch::Plugins::Urbandict
 
+[![Gem Version](https://badge.fury.io/rb/cinch-urbandict.png)](http://badge.fury.io/rb/cinch-urbandict)
+[![Dependency Status](https://gemnasium.com/bhaberer/cinch-urbandict.png)](https://gemnasium.com/bhaberer/cinch-urbandict)
+[![Build Status](https://travis-ci.org/bhaberer/cinch-urbandict.png?branch=master)](https://travis-ci.org/bhaberer/cinch-urbandict)
+[![Coverage Status](https://coveralls.io/repos/bhaberer/cinch-urbandict/badge.png?branch=master)](https://coveralls.io/r/bhaberer/cinch-urbandict?branch=master)
+[![Code Climate](https://codeclimate.com/github/bhaberer/cinch-urbandict.png)](https://codeclimate.com/github/bhaberer/cinch-urbandict)
+
 Simple Cinch Plugin to fetch Urbandictionary defs.
 
 ## Installation

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-urbandict.gemspec

@@ -17,6 +17,11 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency('cinch-toolbox', '>= 0.0.3')
-  gem.add_dependency('cinch-cooldown')
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
+
+  gem.add_dependency 'cinch',           '~> 2.0.4'
+  gem.add_dependency 'cinch-toolbox',   '>= 1.0.0'
+  gem.add_dependency 'cinch-cooldown',  '~> 1.0.0'
 end

data/lib/cinch/plugins/urbandict/urbandict.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+require 'cinch'
 require 'cinch-cooldown'
 require 'cinch-toolbox'
 
@@ -9,10 +10,11 @@ module Cinch::Plugins
     enforce_cooldown
 
     self.help = "Use .ud <term> to see the Urban Dictionary definition for that term."
+
     match /ud (.*)/
 
     def execute(m, term)
-      m.reply get_def(term)
+      m.reply get_def(term), true
     end
 
     private
@@ -23,16 +25,22 @@ module Cinch::Plugins
 
       url = "http://www.urbandictionary.com/define.php?term=#{term}"
 
-      # Grab the element
-      result = Cinch::Toolbox.get_html_element(url, '.definition')
+      if Cinch::Toolbox.get_html_element(url, '#not_defined_yet')
+        return "Urban Dictionary ∴ #{term}: No definition available."
+      else
+        # Grab the element
+        result = Cinch::Toolbox.get_html_element(url, '.definition')
+
+        result.gsub!(/[\n\r]/, ' - ')
 
-      #Make sure it's not terribly long
-      result = Cinch::Toolbox.truncate(result, 250)
+        #Make sure it's not terribly long
+        result = Cinch::Toolbox.truncate(result, 250)
+        url = Cinch::Toolbox.shorten(url)
 
-      return "Urban Dictionary ∴ #{term}: #{result} [#{Cinch::Toolbox.shorten(url)}]"
+        return "Urban Dictionary ∴ #{term}: #{result} [#{url}]"
+      end
     rescue NoMethodError
       debug "Caught a NoMethodError looking up #{term}"
-      return "Sorry I couldn't find that term."
     end
   end
 end

data/lib/cinch/plugins/urbandict/version.rb

@@ -1,7 +1,7 @@
 module Cinch
   module Plugins
     class UrbanDict
-      VERSION = "0.0.3"
+      VERSION = "1.0.0"
     end
   end
 end

data/spec/cinch-urbandict_spec.rb

@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe Cinch::Plugins::UrbanDict do
+
+  before(:all) do
+    @plugin = Cinch::Plugins::UrbanDict.new
+  end
+
+  it 'should allow users to search for words' do
+    @plugin.send(:get_def, 'dork').
+      should match('Someone who has odd interests')
+  end
+
+  it 'should not return nil for valid searches' do
+    @plugin.send(:get_def, 'dong').
+      should_not be_nil
+  end
+
+  it 'should return an error for invalid searches' do
+    @plugin.send(:get_def, '7zJ6t8rT8p384My').
+      should == "Urban Dictionary ∴ 7zJ6t8rT8p384My: No definition available."
+  end
+
+  it 'should not eturn multiple lines for a definition with breaks' do
+    response = @plugin.send(:get_def, 'dong')
+    response.should_not match("<br")
+    response.should_not match("\r")
+    response.should_not match("\n")
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,22 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-urbandict'
+
+def fake_bot
+  bot = Cinch::Bot.new
+  bot.loggers.level = :fatal
+  bot
+  return bot
+end
+
+module Cinch
+  module Plugin
+    def initialize(opts = {})
+      @bot = fake_bot
+      @handlers = []
+      @timers   = []
+      # Don't init the bot
+      # __register
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cinch-urbandict
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,33 +9,33 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-19 00:00:00.000000000 Z
+date: 2013-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: cinch-toolbox
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.3
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: cinch-cooldown
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -43,6 +43,70 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.4
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.4
+- !ruby/object:Gem::Dependency
+  name: cinch-toolbox
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: cinch-cooldown
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: Cinch Plugin to fetch definition data from Urban Dictionary
 email:
 - bhaberer@gmail.com
@@ -51,6 +115,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -59,6 +124,8 @@ files:
 - lib/cinch-urbandict.rb
 - lib/cinch/plugins/urbandict/urbandict.rb
 - lib/cinch/plugins/urbandict/version.rb
+- spec/cinch-urbandict_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/bhaberer/cinch-urbandict
 licenses: []
 post_install_message: 
@@ -83,4 +150,7 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin for Urban Dictionary
-test_files: []
+test_files:
+- spec/cinch-urbandict_spec.rb
+- spec/spec_helper.rb
+has_rdoc: