cinch-seen 0.0.2 → 1.0.0

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,5 +1,11 @@
 # Cinch::Plugins::Seen
 
+[![Gem Version](https://badge.fury.io/rb/cinch-seen.png)](http://badge.fury.io/rb/cinch-seen)
+[![Dependency Status](https://gemnasium.com/bhaberer/cinch-seen.png)](https://gemnasium.com/bhaberer/cinch-seen)
+[![Build Status](https://travis-ci.org/bhaberer/cinch-seen.png?branch=master)](https://travis-ci.org/bhaberer/cinch-seen)
+[![Coverage Status](https://coveralls.io/repos/bhaberer/cinch-seen/badge.png?branch=master)](https://coveralls.io/r/bhaberer/cinch-seen?branch=master)
+[![Code Climate](https://codeclimate.com/github/bhaberer/cinch-seen.png)](https://codeclimate.com/github/bhaberer/cinch-seen)
+
 Cinch Plugin to allow users to ask the bot when the last time it saw a given user was.
 
 ## Installation

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-seen.gemspec

@@ -16,10 +16,16 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
+  
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
 
-  gem.add_dependency 'cinch', '>= 2.0.0'
-  gem.add_dependency 'time-lord', '1.0.1'
-  gem.add_dependency 'cinch-toolbox'
-  gem.add_dependency 'cinch-storage'
-  gem.add_dependency 'cinch-cooldown'
+  gem.add_dependency 'cinch',           '~> 2.0.5'
+  gem.add_dependency 'cinch-test',      '~> 0.0.3'
+  gem.add_dependency 'cinch-toolbox',   '~> 1.0.0'
+  gem.add_dependency 'cinch-cooldown',  '~> 1.0.0'
+  gem.add_dependency 'time-lord',       '~> 1.0.1'
+  gem.add_dependency 'cinch-storage',   '~> 0.0.2'
+  gem.add_dependency 'cinch-cooldown',  '~> 1.0.0'
 end

data/lib/cinch/plugins/seen/seen.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+require 'cinch'
 require 'cinch-toolbox'
 require 'cinch-storage'
 require 'cinch-cooldown'
@@ -13,38 +14,46 @@ module Cinch::Plugins
     self.help = "Use .seen <name> to see the last time that nick was active."
 
     listen_to :channel
-    attr_accessor :storage
 
-    match /seen (.+)/
+    match /seen ([^\s]+)\z/
 
     def initialize(*args)
       super
       @storage = CinchStorage.new(config[:filename] || 'yaml/seen.yml')
-      @storage.data[:seen] ||= {}
+      @storage.data ||= {}
     end
 
     def listen(m)
-      @storage.data[:seen][m.channel.name] = {} unless @storage.data[:seen].key?(m.channel.name)
-      @storage.data[:seen][m.channel.name][m.user.nick.downcase] = Time.now
-
-      synchronize(:seen_save) do
-        @storage.save
-      end
+      channel = m.channel.name
+      @storage.data[channel] ||= Hash.new
+      @storage.data[channel][m.user.nick.downcase] = Time.now
+      @storage.synced_save(@bot)
     end
 
     def execute(m, nick)
-      if m.channel.nil?
-        m.user.msg "You must use that command in the main channel."
-        return
+      return if sent_via_pm?(m)
+      unless m.user.nick.downcase == nick.downcase
+        m.reply last_seen(m.channel.name, nick), true
       end
+    end
 
-      unless m.user.nick.downcase == nick.downcase
-        if @storage.data[:seen][m.channel.name].key?(nick.downcase)
-          m.reply "I last saw #{nick} #{@storage.data[:seen][m.channel.name][nick.downcase].ago.to_words}", true
-        else
-          m.reply "I've never seen #{nick} before, sorry!", true
-        end
+    private
+
+    def last_seen(channel, nick)
+      @storage.data[channel] ||= Hash.new
+      time = @storage.data[channel][nick.downcase]
+
+      if time.nil?
+        "I've never seen #{nick} before, sorry!"
+      else
+        "I last saw #{nick} #{time.ago.to_words}"
       end
     end
+
+    def sent_via_pm?(m)
+      return false unless m.channel.nil?
+      m.reply "You must use that command in the main channel."
+      true
+    end
   end
 end

data/lib/cinch/plugins/seen/version.rb

@@ -1,7 +1,7 @@
 module Cinch
   module Plugins
     class Seen
-      VERSION = "0.0.2"
+      VERSION = "1.0.0"
     end
   end
 end

data/spec/cinch-seen_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Cinch::Plugins::Seen do
+
+  include Cinch::Test
+
+  before(:each) do
+    @bot = make_bot(Cinch::Plugins::Seen, { :filename => '/dev/null' })
+  end
+
+  it 'should allow users to see when users were last active' do
+    get_replies(make_message(@bot, 'hello, world!', { :nick => 'foo', :channel => '#bar' }))
+    sleep 1 # time-lord hack
+    msg = make_message(@bot, '!seen foo', { :nick => 'baz', :channel => '#bar' })
+    get_replies(msg).last.
+      should match(/baz: I last saw foo \d seconds? ago/)
+  end
+
+  it 'should not respond to a users seen request for themselves' do
+    msg = make_message(@bot, '!seen foo', { :nick => 'foo', :channel => '#bar' })
+    get_replies(msg).
+      should be_empty
+  end
+
+  it 'should inform users when a person has not been seen before' do
+    msg = make_message(@bot, '!seen foo', { :channel => '#bar' })
+    get_replies(msg).first.
+      should == "test: I've never seen foo before, sorry!"
+  end
+
+  it 'should not let people make dumb jokes (or look for multiple people in one seen)' do
+    get_replies(make_message(@bot, '!seen your mom today', { :channel => '#bar' })).
+      should be_empty
+    get_replies(make_message(@bot, '!seen archer pam lana', { :channel => '#bar' })).
+      should be_empty
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-seen'
+require 'cinch/test'
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cinch-seen
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,49 +9,49 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-05 00:00:00.000000000 Z
+date: 2013-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: cinch
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: time-lord
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.1
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: cinch-toolbox
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -59,38 +59,118 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+- !ruby/object:Gem::Dependency
+  name: cinch-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+- !ruby/object:Gem::Dependency
+  name: cinch-toolbox
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: cinch-cooldown
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: time-lord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: cinch-storage
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.2
 - !ruby/object:Gem::Dependency
   name: cinch-cooldown
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
 description: Cinch Plugin to allow users to find out how long it's been since a user
   was active
 email:
@@ -100,6 +180,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -108,6 +189,8 @@ files:
 - lib/cinch-seen.rb
 - lib/cinch/plugins/seen/seen.rb
 - lib/cinch/plugins/seen/version.rb
+- spec/cinch-seen_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/bhaberer/cinch-seen
 licenses: []
 post_install_message: 
@@ -132,4 +215,7 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin for Seen
-test_files: []
+test_files:
+- spec/cinch-seen_spec.rb
+- spec/spec_helper.rb
+has_rdoc: