cinch-magic 0.0.1 → 1.0.0

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,5 +1,11 @@
 # Cinch::Plugins::Magic
 
+[![Gem Version](https://badge.fury.io/rb/cinch-magic.png)](http://badge.fury.io/rb/cinch-magic)
+[![Dependency Status](https://gemnasium.com/bhaberer/cinch-magic.png)](https://gemnasium.com/bhaberer/cinch-magic)
+[![Build Status](https://travis-ci.org/bhaberer/cinch-magic.png?branch=master)](https://travis-ci.org/bhaberer/cinch-magic)
+[![Coverage Status](https://coveralls.io/repos/bhaberer/cinch-magic/badge.png?branch=master)](https://coveralls.io/r/bhaberer/cinch-magic?branch=master)
+[![Code Climate](https://codeclimate.com/github/bhaberer/cinch-magic.png)](https://codeclimate.com/github/bhaberer/cinch-magic)
+
 Just a simple plugin that looks up card info.
 
 ## Installation

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-magic.gemspec

@@ -17,6 +17,12 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency 'cinch-toolbox'
-  gem.add_dependency 'cinch-cooldown'
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
+
+  gem.add_dependency 'cinch',           '~> 2.0.5'
+  gem.add_dependency 'cinch-test',      '~> 0.0.3'
+  gem.add_dependency 'cinch-toolbox',   '~> 1.0.2'
+  gem.add_dependency 'cinch-cooldown',  '~> 1.0.0'
 end

data/lib/cinch/plugins/magic/magic.rb

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
-require 'cinch-toolbox'
+require 'cinch'
+require 'cinch/toolbox'
 require 'cinch-cooldown'
 
 module Cinch::Plugins
@@ -35,11 +36,11 @@ module Cinch::Plugins
     end
 
     def get_card_info(data)
-      text = data.match(/<p[^>]*>([^<]+)<\/p>/)[1]
+      text = data[/<p[^>]*>([^<]+)<\/p>/, 1]
 
       # Replace Newlines, unicode lines, total mana, and large spaces.
       text = text.gsub(/\n/, '')
-      text = text.gsub(/—/, '·')
+      text = text.gsub(/\s—/, ', ')
       text = text.gsub(/\s\(\d*\)/, '')
       text = text.gsub(/\s{2,}/, ' ')
 
@@ -52,7 +53,7 @@ module Cinch::Plugins
     end
 
     def get_card_name(data)
-      return data.match(/<a href=[^>]*>([^<]+)<\/a>/)[1]
+      return data[/<a href=[^>]*>([^<]+)<\/a>/, 1]
     rescue
       debug "Error finding this card's name"
     end
@@ -70,7 +71,6 @@ module Cinch::Plugins
     end
 
     def get_card_data(term)
-      debug "#{term}" if term.nil?
       # URI Encode the term and build the URL
       term = URI.escape("!#{term}", Regexp.new("[^#{URI::PATTERN::UNRESERVED}]"))
       url = "http://magiccards.info/query?q=#{term}"
@@ -80,12 +80,11 @@ module Cinch::Plugins
 
       # Grab the html block because magiccards.info fucking loves tables
       # and hates helpful ids and classnames
-      begin
-        return Cinch::Toolbox.get_html_element(url, '//table[3]/tr/td[2]', 'xpath').to_html
-      rescue
-        debug "Error looking up card: #{term}"
-        return nil
-      end
+      return Cinch::Toolbox.get_html_element(url, '//table[3]/tr/td[2]', :xpath_full)
+
+    rescue
+      debug "Error looking up card: #{term}"
+      return nil
     end
   end
 end

data/lib/cinch/plugins/magic/version.rb

@@ -1,7 +1,7 @@
 module Cinch
   module Plugins
     class Magic
-      VERSION = "0.0.1"
+      VERSION = "1.0.0"
     end
   end
 end

data/spec/cinch-magic_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Cinch::Plugins::Magic do
+
+  include Cinch::Test
+
+  before(:each) do
+    @bot = make_bot(Cinch::Plugins::Magic)
+  end
+
+  it 'should allow users to lookup cards' do
+    get_replies(make_message(@bot, '!mtg forest')).first.
+      should include "[Magic] Forest [Basic Land, Forest] - ({T}: Add {G} to your mana pool.)"
+  end
+
+  it 'should return an error when a card is not found' do
+    get_replies(make_message(@bot, '!mtg random string that is probably not a real card')).first.
+      should == '[Magic] Card not found, or problem fetching page.'
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-magic'
+require 'cinch/test'
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cinch-magic
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,17 +9,17 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-03 00:00:00.000000000 Z
+date: 2013-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: cinch-toolbox
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -28,14 +28,30 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: cinch-cooldown
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -43,6 +59,70 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+- !ruby/object:Gem::Dependency
+  name: cinch-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+- !ruby/object:Gem::Dependency
+  name: cinch-toolbox
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+- !ruby/object:Gem::Dependency
+  name: cinch-cooldown
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: Cinch Plugin that searches http://magiccards.info/ for card information.
 email:
 - bhaberer@gmail.com
@@ -51,6 +131,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -59,6 +140,8 @@ files:
 - lib/cinch-magic.rb
 - lib/cinch/plugins/magic/magic.rb
 - lib/cinch/plugins/magic/version.rb
+- spec/cinch-magic_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/bhaberer/cinch-magic
 licenses: []
 post_install_message: 
@@ -79,8 +162,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin for Magic Cards
-test_files: []
+test_files:
+- spec/cinch-magic_spec.rb
+- spec/spec_helper.rb