cinch-karma 0.0.1 → 1.0.0

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,6 +1,12 @@
 # Cinch::Plugins::Karma
 
-Cinch PLugin to track Karma.
+[![Gem Version](https://badge.fury.io/rb/cinch-karma.png)](http://badge.fury.io/rb/cinch-karma)
+[![Dependency Status](https://gemnasium.com/bhaberer/cinch-karma.png)](https://gemnasium.com/bhaberer/cinch-karma)
+[![Build Status](https://travis-ci.org/bhaberer/cinch-karma.png?branch=master)](https://travis-ci.org/bhaberer/cinch-karma)
+[![Coverage Status](https://coveralls.io/repos/bhaberer/cinch-karma/badge.png?branch=master)](https://coveralls.io/r/bhaberer/cinch-karma?branch=master)
+[![Code Climate](https://codeclimate.com/github/bhaberer/cinch-karma.png)](https://codeclimate.com/github/bhaberer/cinch-karma)
+
+Cinch Plugin to track Karma.
 
 ## Installation
 

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-karma.gemspec

@@ -17,7 +17,12 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency 'cinch', '>= 2.0.0'
-  gem.add_dependency 'cinch-cooldown'
-  gem.add_dependency 'cinch-storage'
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
+  gem.add_development_dependency 'cinch-test'
+
+  gem.add_dependency 'cinch',           '~> 2.0.5'
+  gem.add_dependency 'cinch-cooldown',  '~> 1.0.0'
+  gem.add_dependency 'cinch-storage',   '~> 0.0.2'
 end

data/lib/cinch/plugins/karma/karma.rb

@@ -1,3 +1,4 @@
+require 'cinch'
 require 'cinch-cooldown'
 require 'cinch-storage'
 
@@ -22,47 +23,50 @@ module Cinch::Plugins
     def listen(m)
       if m.message.match(/\S+[\+\-]{2}/)
         channel = m.channel.name
-        @storage.data[channel] = Hash.new unless @storage.data.key?(channel)
-        updated = false
-
-        m.message.scan(/.*?((\w+)|\((.+?)\))(\+\+|--)(\s|\z)/).each do |karma|
-          debug "#{karma}"
-
-          if karma[0]
-            item = karma[1] || karma[2]
-            item.downcase!
-
-            @storage.data[channel][item] = 0 unless @storage.data[channel].key?(item)
-
-            if karma[3] == '++'
-              @storage.data[channel][item] += 1
-              updated = true
-            elsif karma[3] == '--'
-              @storage.data[channel][item] -= 1
-              updated = true
-            else
-              debug 'something went wrong matching karma!'
-            end
-          end
-        end
 
-        if updated
-          synchronize(:karma_save) do
-            @storage.save
-          end
+        # Scan messages for multiple karma items
+        m.message.scan(/(\s|\A)(\w+|\(.+?\))(\+\+|--)(\s|\z)/).each do |karma|
+          process_karma(channel, karma[1].gsub(/\(|\)/, '').downcase, karma[2])
         end
+
+        @storage.synced_save(@bot)
       end
     end
 
     def execute(m, item)
+      return if sent_via_pm?(m)
+
+      channel = m.channel.name
+      item.downcase!
+      init_karma(channel, item)
+
+      m.reply "Karma for #{item} is #{@storage.data[channel][item]}"
+    end
+
+    private
+
+    def process_karma(channel, item, operation)
+      # Ensure the item's Karma has been init
+      init_karma(channel, item)
+
+      case operation
+      when '++'
+        @storage.data[channel][item] += 1
+      when '--'
+        @storage.data[channel][item] -= 1
+      end
+    end
+
+    def sent_via_pm?(m)
       if m.channel.nil?
-        m.user.msg "You must use that command in the main channel."
-        return
+        m.reply "You must use that command in the main channel."
+        return true
       end
+    end
 
-      @storage.data[m.channel.name] = Hash.new unless @storage.data.key?(m.channel.name)
-      karma = @storage.data[m.channel.name][item.downcase] || 0
-      m.reply "Karma for #{item} is #{karma}"
+    def init_karma(channel, item = nil)
+      @storage.data[channel] ||= Hash.new
+      @storage.data[channel][item] ||= 0 unless item.nil?
     end
   end
 end

data/lib/cinch/plugins/karma/version.rb

@@ -1,7 +1,7 @@
 module Cinch
   module Plugins
     class Karma
-      VERSION = "0.0.1"
+      VERSION = "1.0.0"
     end
   end
 end

data/spec/cinch-karma_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+describe Cinch::Plugins::Karma do
+  include Cinch::Test
+
+  before(:each) do
+    @bot = make_bot(Cinch::Plugins::Karma, { :filename => '/dev/null' })
+  end
+
+  it 'should default to zero karma' do
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is 0"
+  end
+
+  it 'should allow users to add karma' do
+    msg = make_message(@bot, 'foo++', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is 1"
+  end
+
+  it 'should allow users to add karma mid message' do
+    msg = make_message(@bot, 'd asd asdasd foo++ dasdasd sadasd sad', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is 1"
+  end
+
+  it 'should allow users to add karma with items with spaces via ()' do
+    msg = make_message(@bot, '(foo bar)++', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo bar', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo bar is 1"
+  end
+
+  it 'should allow users to remove karma' do
+    msg = make_message(@bot, 'foo--', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is -1"
+  end
+
+  it 'should allow users to remove karma mid message' do
+    msg = make_message(@bot, 'd asd asdasd foo-- dasdasd sadasd sad', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is -1"
+  end
+
+  it 'should allow users to remove karma with items with spaces via ()' do
+    msg = make_message(@bot, '(foo bar)--', { :channel => '#foo' })
+    get_replies(msg)
+    msg = make_message(@bot, '!karma foo bar', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo bar is -1"
+  end
+  it 'should not allow users to check karam via pm' do
+    msg = make_message(@bot, '!karma foo')
+    get_replies(msg).first.should == "You must use that command in the main channel."
+  end
+
+  it 'should not allow users to add karma via pm' do
+    msg = make_message(@bot, 'foo++')
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is 0"
+  end
+
+  it 'should not allow users to remove karma via pm' do
+    msg = make_message(@bot, 'foo--')
+    msg = make_message(@bot, '!karma foo', { :channel => '#foo' })
+    get_replies(msg).first.should == "Karma for foo is 0"
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,4 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-karma'
+require 'cinch/test'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cinch-karma
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,33 +9,33 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-06 00:00:00.000000000 Z
+date: 2013-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: cinch
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: cinch-cooldown
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -44,14 +44,14 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: cinch-storage
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -59,6 +59,70 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+- !ruby/object:Gem::Dependency
+  name: cinch-cooldown
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: cinch-storage
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.0.2
 description: Cinch Plugin to track karma (item++ / item--) in the channel
 email:
 - bhaberer@gmail.com
@@ -67,6 +131,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -75,6 +140,8 @@ files:
 - lib/cinch-karma.rb
 - lib/cinch/plugins/karma/karma.rb
 - lib/cinch/plugins/karma/version.rb
+- spec/cinch-karma_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/bhaberer/cinch-karma
 licenses: []
 post_install_message: 
@@ -99,4 +166,7 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin to Track Karma
-test_files: []
+test_files:
+- spec/cinch-karma_spec.rb
+- spec/spec_helper.rb
+has_rdoc: