cinch-convert 0.0.1 → 1.0.0

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3
+before_install:
+ - sudo apt-get install units

data/README.md

@@ -1,5 +1,11 @@
 # Cinch::Plugins::Convert
 
+[![Gem Version](https://badge.fury.io/rb/cinch-convert.png)](http://badge.fury.io/rb/cinch-convert)
+[![Dependency Status](https://gemnasium.com/canonical-hackers/cinch-convert.png)](https://gemnasium.com/canonical-hackers/cinch-convert)
+[![Build Status](https://travis-ci.org/canonical-hackers/cinch-convert.png?branch=master)](https://travis-ci.org/canonical-hackers/cinch-convert)
+[![Coverage Status](https://coveralls.io/repos/canonical-hackers/cinch-convert/badge.png?branch=master)](https://coveralls.io/r/canonical-hackers/cinch-convert?branch=master)
+[![Code Climate](https://codeclimate.com/github/canonical-hackers/cinch-convert.png)](https://codeclimate.com/github/canonical-hackers/cinch-convert)
+
 Cinch Plugin to allow users to convert units.
 
 ## Installation

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec

data/cinch-convert.gemspec

@@ -16,4 +16,11 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
+
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'coveralls'
+  gem.add_development_dependency 'cinch-test'
+
+  gem.add_dependency    'cinch',      '~> 2.0.5'
 end

data/lib/cinch/plugins/convert/convert.rb

@@ -1,53 +1,49 @@
+require 'cinch'
+
 module Cinch::Plugins
   class Convert
     include Cinch::Plugin
 
     self.help = "Use .convert <thing 1> to <thing 2> to do a unit conversion. (e.g. .convert 5 feet to meters)"
 
-    match /convert (.+)/
+    match /convert (.+) to (.+)/
 
     def initialize(*args)
       super
       @units_path = config[:units_path] || '/usr/bin/units'
     end
 
-    def execute(m, conversion_string)
-      m.reply convert(conversion_string), true
+    def execute(m, from, to)
+      m.reply convert(from, to), true
     end
 
     private
 
-    def convert(conversion)
-      unless File.exist? @units_path
-        debug "Cinch can't find the unit conversion binary."
-        return "Sorry I can't convert that."
-      end
-
-      match = conversion.match(/([+\d\.-]+)\s*([\/*\s\w]+) to ([\/*\s\w]+)$/)
+    def convert(from, to)
+      return "Sorry, there's a configuration issue." unless units_binary_exists?
 
-      unless match.nil?
-        num = match[1]
-        units_from = match[2]
-        units_to = match[3]
-
-        units_output = IO.popen([@units_path, "-t", "#{num} #{units_from}", units_to])
+      unless from.nil? || to.nil?
+        units_output = IO.popen([@units_path, "-t", from, to])
 
         # we only take one line here because the first line of output is
         # either an error message or the part of the conversion output we
         # want.
-        units_line = units_output.readline
-        units_line.chomp!
+        units_line = units_output.readline.chomp!
 
-        if units_line =~ /Unknown unit/
+        if units_line.match(/Unknown unit/)
           "Sorry, #{units_line.downcase}."
-        elsif units_line =~ /conformability error/
+        elsif units_line.match(/conformability error/)
           "Sorry, there was a conformability error when making that conversion."
         else
-          "#{num} #{units_from} is #{units_line} #{units_to}."
+          "#{from} is #{units_line} #{to}."
         end
-      else
-        "Sorry, I don't understand, please use `.convert X unitname to unitname`."
       end
     end
+
+    def units_binary_exists?
+      return true if File.exist? @units_path
+      debug "Cinch can't find the unit conversion binary."
+      false
+    end
   end
 end

data/lib/cinch/plugins/convert/version.rb

@@ -1,7 +1,7 @@
 module Cinch
   module Plugins
     class Convert
-      VERSION = "0.0.1"
+      VERSION = "1.0.0"
     end
   end
 end

data/spec/cinch-convert_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe Cinch::Plugins::Convert do
+
+  include Cinch::Test
+
+  before(:each) do
+    @bot = make_bot(Cinch::Plugins::Convert)
+  end
+
+  describe 'configuration' do
+    it 'should handle the units binary\'s absence with grace' do
+      @bot = make_bot(Cinch::Plugins::Convert, { :units_path => '/usr/baddir/units' })
+      msg = make_message(@bot, '!convert 3 foo to bar')
+      get_replies(msg).last.chomp.
+        should == 'test: Sorry, there\'s a configuration issue.'
+    end
+  end
+
+  describe 'conversions' do
+    it 'should alow users to convert units' do
+      msg = make_message(@bot, '!convert 2 inches to feet')
+      get_replies(msg).last.chomp.
+        should == 'test: 2 inches is 0.16666667 feet.'
+    end
+
+    it 'should allow users to convert temps' do
+      msg = make_message(@bot, '!convert tempF(32) to tempC')
+      get_replies(msg).last.chomp.
+        should == 'test: tempF(32) is 0 tempC.'
+    end
+
+    it 'should return an error on conformability issues' do
+      msg = make_message(@bot, '!convert 15 minutes to gallons')
+      get_replies(msg).last.chomp.
+        should == 'test: Sorry, there was a conformability error when making that conversion.'
+    end
+
+    it 'should return an error on invalid units' do
+      msg = make_message(@bot, '!convert 15 foo to bar')
+      get_replies(msg).last.chomp.
+        should == 'test: Sorry, unknown unit \'foo\'.'
+    end
+
+    it 'shouldn\'t return anything on invalid conversions' do
+      msg = make_message(@bot, '!convert foo 15 foo baz bar')
+      get_replies(msg).
+        should be_empty
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'coveralls'
+Coveralls.wear!
+require 'cinch-convert'
+require 'cinch/test'
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cinch-convert
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,8 +10,88 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-07 00:00:00.000000000 Z
-dependencies: []
+date: 2013-07-01 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cinch
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.5
 description: Cinch Plugin for Coverting Units via the units binary
 email:
 - bhaberer@gmail.com
@@ -20,6 +100,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -28,6 +109,8 @@ files:
 - lib/cinch-convert.rb
 - lib/cinch/plugins/convert/convert.rb
 - lib/cinch/plugins/convert/version.rb
+- spec/cinch-convert_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/canonical-hackers/cinch-convert
 licenses: []
 post_install_message: 
@@ -52,4 +135,7 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Cinch Plugin for converting units
-test_files: []
+test_files:
+- spec/cinch-convert_spec.rb
+- spec/spec_helper.rb
+has_rdoc: