ci_reporter_cucumber 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce760faa0a83602835a97670fa175630aceb45bf
-  data.tar.gz: 9c394371da2af67f8b0039a1c41291cccdc1d3bb
+  metadata.gz: cd4c396df29bf6194a8528abbb74a8dbb2668f35
+  data.tar.gz: f91220e91ec7aff8c74108813ab6efbb381e646c
 SHA512:
-  metadata.gz: fea4800d2a3b559be342024e64c0cfcadd2ec24b56570b63c3e3a24820549729e0fefc2f169fc085e2c6c1358623d42c96d98879a18c5d4e8e84f492ca7ab575
-  data.tar.gz: 706d7ea0069db3f5225fc210123c8a5b81260301ce5880a8ff4ceea890bc98a97d04fb3cb6549ba84adf57d6a28619a4379df650ff334aa14180eae27913e605
+  metadata.gz: b11188238074ed454bb14011cc257c0723e5e66d55c0f5555cfc7947f85b87310d8b9a1147d60117f3bd4ec970a59f9be50e7e0daa51176ac753162980da3d3c
+  data.tar.gz: 4f2d47e2efd71f28501ceb9ec2ebbe86ed40043afc3fc7560dd6f8e0a6eddef569374f4d29819140dacff3e4e2b3a9fb6f77f4fb68ef332fddf64b222835c19d

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.0.2 (2015-11-30)
+
+Mark skipped test cases as skipped (#9)
+
+Add option to mark pending/undefined steps as failures (#10)
+
 ## 1.0.1 (2015-08-09)
 
 Fix malformed testcase output w/ Backgrounds (#7)

data/README.md

@@ -46,6 +46,10 @@ task :cucumber => 'ci:setup:cucumber'
 
 ### Advanced usage
 
+If you want to treat `undefined` and `pending` steps as failures
+(instead of skipping them), set the `CI_PENDING_IS_FAILURE`
+environment variable to `true`.
+
 Refer to the shared [documentation][ci] for details on setting up
 CI::Reporter.
 

data/acceptance/cucumber/cucumber_example.feature

@@ -13,6 +13,10 @@ Feature: Example Cucumber feature
     And I don't bother writing cucumber features
     Then I should be fired
 
+  Scenario: Forgetful hacker
+    Given that I am a forgetful hacker
+    And I forgot to define a cucumber step
+
   Scenario: Bad coder
     Given that I can't code for peanuts
     And I write step definitions that throw exceptions

data/acceptance/verification_spec.rb

@@ -15,8 +15,9 @@ describe "Cucumber acceptance" do
     subject(:result) { Accessor.new(load_xml_result(report_path)) }
 
     it { is_expected.to have(0).errors }
+    it { expect(result.skipped_count).to be 1 }
     it { is_expected.to have(2).failures }
-    it { is_expected.to have(3).testcases }
+    it { is_expected.to have(4).testcases }
 
     it_behaves_like "a report with consistent attribute counts"
     it_behaves_like "assertions are not tracked"
@@ -36,6 +37,12 @@ describe "Cucumber acceptance" do
       end
     end
 
+    describe "the test the forgetful hacker wrote" do
+      subject(:testcase) { result.testcase('Forgetful hacker (PENDING)') }
+
+      it { is_expected.to be_skipped }
+    end
+
     describe "the test the bad coder wrote" do
       subject(:testcase) { result.testcase('Bad coder') }
 

data/lib/ci/reporter/cucumber.rb

@@ -74,14 +74,24 @@ module CI
         @test_case.start
       end
 
+      def treat_pending_as_failure?
+        ENV['CI_PENDING_IS_FAILURE'] == 'true'
+      end
+
       def after_steps(steps)
         @test_case.finish
 
         case steps.status
         when :pending, :undefined
-          @test_case.name = "#{@test_case.name} (PENDING)"
+          if treat_pending_as_failure?
+            @test_case.failures << CucumberFailure.new(steps)
+          else
+            @test_case.name = "#{@test_case.name} (PENDING)"
+            @test_case.skipped = true
+          end
         when :skipped
           @test_case.name = "#{@test_case.name} (SKIPPED)"
+          @test_case.skipped = true
         when :failed
           @test_case.failures << CucumberFailure.new(steps)
         end

data/lib/ci/reporter/cucumber/version.rb

@@ -1,7 +1,7 @@
 module CI
   module Reporter
     class Cucumber
-      VERSION = "1.0.1"
+      VERSION = "1.0.2"
     end
   end
 end

data/spec/ci/reporter/cucumber_spec.rb

@@ -106,7 +106,10 @@ module CI::Reporter
 
       context "after steps" do
         before :each do
+          allow(cucumber).to receive(:treat_pending_as_failure?).and_return(false)
           cucumber.before_steps(step)
+          allow(test_case).to receive(:name=)
+          allow(test_case).to receive(:skipped=)
         end
 
         it "indicates that the test case has finished" do
@@ -121,22 +124,73 @@ module CI::Reporter
           expect(testcases.first).to eql test_case
         end
 
-        it "alters the name of a test case that is pending to include '(PENDING)'" do
-          allow(step).to receive(:status).and_return(:pending)
-          expect(test_case).to receive(:name=).with("Step Name (PENDING)")
-          cucumber.after_steps(step)
+        context "a pending test" do
+          before { allow(step).to receive(:status).and_return(:pending) }
+
+          it "alters the name of a test case that is pending to include '(PENDING)'" do
+            expect(test_case).to receive(:name=).with("Step Name (PENDING)")
+            cucumber.after_steps(step)
+          end
+
+          it "marks the test case as skipped" do
+            expect(test_case).to receive(:skipped=).with(true)
+            cucumber.after_steps(step)
+          end
         end
 
-        it "alters the name of a test case that is undefined to include '(PENDING)'" do
-          allow(step).to receive(:status).and_return(:undefined)
-          expect(test_case).to receive(:name=).with("Step Name (PENDING)")
-          cucumber.after_steps(step)
+        context "an undefined test" do
+          before { allow(step).to receive(:status).and_return(:undefined) }
+
+          it "alters the name of a test case that is undefined to include '(PENDING)'" do
+            expect(test_case).to receive(:name=).with("Step Name (PENDING)")
+            cucumber.after_steps(step)
+          end
+
+          it "marks the test case as skipped" do
+            expect(test_case).to receive(:skipped=).with(true)
+            cucumber.after_steps(step)
+          end
         end
 
-        it "alter the name of a test case that was skipped to include '(SKIPPED)'" do
-          allow(step).to receive(:status).and_return(:skipped)
-          expect(test_case).to receive(:name=).with("Step Name (SKIPPED)")
-          cucumber.after_steps(step)
+        context "a skipped test" do
+          before { allow(step).to receive(:status).and_return(:skipped) }
+
+          it "alters the name of a test case that was skipped to include '(SKIPPED)'" do
+            expect(test_case).to receive(:name=).with("Step Name (SKIPPED)")
+            cucumber.after_steps(step)
+          end
+
+          it "marks the test case as skipped" do
+            expect(test_case).to receive(:skipped=).with(true)
+            cucumber.after_steps(step)
+          end
+        end
+
+        context "when treating undefined/pending steps as failures" do
+          let(:failures) { [] }
+          let(:cucumber_failure) { double("cucumber_failure") }
+
+          before :each do
+            allow(cucumber).to receive(:treat_pending_as_failure?).and_return(true)
+            allow(test_case).to receive(:failures).and_return(failures)
+            allow(CI::Reporter::CucumberFailure).to receive(:new).and_return(cucumber_failure)
+          end
+
+          it "creates a new cucumber failure with a pending step" do
+            allow(step).to receive(:status).and_return(:pending)
+            expect(failures).to be_empty
+            cucumber.after_steps(step)
+            expect(failures).to_not be_empty
+            expect(failures.first).to eql cucumber_failure
+          end
+
+          it "creates a new cucumber failure with an undefined step" do
+            allow(step).to receive(:status).and_return(:undefined)
+            expect(failures).to be_empty
+            cucumber.after_steps(step)
+            expect(failures).to_not be_empty
+            expect(failures.first).to eql cucumber_failure
+          end
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ci_reporter_cucumber
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Nick Sieger
@@ -9,104 +9,104 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-06 00:00:00.000000000 Z
+date: 2015-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.3
 - !ruby/object:Gem::Dependency
   name: ci_reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: ci_reporter_test_utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -117,8 +117,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -147,17 +147,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Connects CI::Reporter to Cucumber