ci-queue 0.94.0 → 0.96.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c02125deb535c3692db00957a8684af3080464e2eb0433ce32a86d596068290
-  data.tar.gz: 609ffa08032a2603d305a2651b91a751beb25220fda483a64c5b29b4bd4b9b9e
+  metadata.gz: 8c3ced29dc916918cd28d47f312be55e014fd5836ab0c91d1e2eab17c9484951
+  data.tar.gz: 3ac890363a4a861ca2c3420c24490dff1ffd89dfb890b8d0fd71062ccf812003
 SHA512:
-  metadata.gz: e543f22d017b64b9ff0c053e1095485de56900b67f3d81d3f5ee9271c1dd2534774362f5a275bc160aa5c88e9de9f4ba80770540d08b9e0fc017dd58dbfda55f
-  data.tar.gz: 6309ef7b55e0a627ddeb7415316dae9eb761bebc7d8bf7355d5a6239ac70a91e7558b991c27affc0484a4ccc0a50bb00be7b3d6c2fba9bee52d13fd0af8d9c8e
+  metadata.gz: 27f198e8d9201f56112cc29bb3fcaa8518e7d5ddedc629d5eba13de06e0b936a8e809d47162d088f57d5ff614d3c4f92f003f786de62310ae421498e9913d8a9
+  data.tar.gz: 2c5f925d28012585afa8212cbb14afb1966cb0a2e5dbeaa9927486b2e96fb2c96d595f06ef7aa5ab6b97e5c238e5bca01e3572273a8a5fa9e8be357f54c44bf5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ci-queue (0.94.0)
+    ci-queue (0.96.0)
       logger
 
 GEM

data/lib/ci/queue/configuration.rb

@@ -172,7 +172,21 @@ module CI
       end
 
       def flaky?(test)
-        @flaky_tests.include?(test.id)
+        lazy_normalized_flaky_tests.include?(normalize_test_id(test.id))
+      end
+
+      def normalize_test_id(id)
+        id
+      end
+
+      def lazy_normalized_flaky_tests
+        @normalized_flaky_tests ||= @flaky_tests.to_set { |test_id| normalize_test_id(test_id) }
+      end
+
+      def test_id_normalizer=(normalizer)
+        normalizer = normalizer.to_proc if Method === normalizer
+        define_singleton_method(:normalize_test_id, normalizer)
+        @normalized_flaky_tests = nil
       end
 
       def seed

data/lib/ci/queue/version.rb

@@ -2,7 +2,7 @@
 
 module CI
   module Queue
-    VERSION = '0.94.0'
+    VERSION = '0.96.0'
     DEV_SCRIPTS_ROOT = ::File.expand_path('../../../../../redis', __FILE__)
     RELEASE_SCRIPTS_ROOT = ::File.expand_path('../redis', __FILE__)
   end

data/lib/minitest/queue/junit_reporter.rb

@@ -3,6 +3,7 @@
 require 'minitest/reporters'
 require 'rexml/document'
 require 'fileutils'
+require 'tempfile'
 
 module Minitest
   module Queue
@@ -40,9 +41,16 @@ module Minitest
       def report
         super
 
-        FileUtils.mkdir_p(File.dirname(@report_path))
-        File.open(@report_path, 'w+') do |file|
-          format_document(generate_document, file)
+        dir = File.dirname(@report_path)
+        FileUtils.mkdir_p(dir)
+        tmp = Tempfile.new([File.basename(@report_path), '.tmp'], dir)
+        begin
+          format_document(generate_document, tmp)
+          tmp.close
+          File.rename(tmp.path, @report_path)
+        rescue
+          tmp.close!
+          raise
         end
       end
 

data/lib/minitest/queue/runner.rb

@@ -254,7 +254,9 @@ module Minitest
           step(yellow("The failing test was the first test in the test order so there is nothing to bisect."))
           File.write('log/test_order.log', "")
           File.write('log/bisect_test_details.log', "")
-          exit! 1
+          # Bisect ran successfully; there is simply nothing to bisect against.
+          # Reserve non-zero exits for cases where the bisect could not run (see failing_test_present? above).
+          exit! 0
         end
 
         failing_order = queue.candidates
@@ -263,7 +265,10 @@ module Minitest
           step(yellow("The bisection was inconclusive, there might not be any leaky test here."))
           File.write('log/test_order.log', "")
           File.write('log/bisect_test_details.log', "")
-          exit! 1
+          # Bisect ran successfully; the failure did not reproduce on the narrowed-down order.
+          # This is the expected outcome for genuinely flaky tests (timing/async) rather than order-dependent ones.
+          # Reserve non-zero exits for cases where the bisect could not run.
+          exit! 0
         else
           step(green('The following command should reproduce the leak on your machine:'), collapsed: false)
           command = %w(bundle exec minitest-queue --queue - run)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ci-queue
 version: !ruby/object:Gem::Version
-  version: 0.94.0
+  version: 0.96.0
 platform: ruby
 authors:
 - Jean Boussier
@@ -319,7 +319,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.11
 specification_version: 4
 summary: Distribute tests over many workers using a queue
 test_files: []