ci-queue 0.101.0 → 0.102.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 612d0f2f3077fdd5b7e74b343649a162101c2961c8b4cda8329ca10fbd831e6b
-  data.tar.gz: bdd01c95971bcbfab5999b3754f8d019be35a7202e5f766d5df19191462e5563
+  metadata.gz: 24f5d0ca5b0d0391a953c6f0014635eec1b6ea541e7ac46a944ac413952777e0
+  data.tar.gz: aeec01bc647d5fb960449d57362cc6961479f5c6da78177c915c35bd9706f861
 SHA512:
-  metadata.gz: 69a03983e12372fe0ab0258ec08262b2672624d49d2d63a0c35d0a89b4c8c85b3fd89ece2ce3c71de112652cd327868ee0fa7633ae283facb3b0bf57035d5724
-  data.tar.gz: 44ead0bb47b690b19652982496f8a48d698f5bb78ea4f88c01e56b7774d4c79f6b6015b50e91cb70e241fc00a13bf842a72828792c7f716644cacf12bfb8bb2d
+  metadata.gz: 896cb4ac3e81d1235581e11ce6a0693565c6089afc441546a94d7211eab24b538279dfd6eb5abe06d7e3187e1b54bfb0f5d4127baa06d49a12baf181b345a444
+  data.tar.gz: 0be6036f02910f31672c28e2d6c6eb4cdbd41f066ffb499eed8e10990b2a7a8e6d596ecf9c3da5c57c574fc0a76ac73b430d447781c2929f615a2aa669ecbe74

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ci-queue (0.101.0)
+    ci-queue (0.102.0)
       logger
 
 GEM

data/lib/ci/queue/version.rb

@@ -2,7 +2,7 @@
 
 module CI
   module Queue
-    VERSION = '0.101.0'
+    VERSION = '0.102.0'
     DEV_SCRIPTS_ROOT = ::File.expand_path('../../../../../redis', __FILE__)
     RELEASE_SCRIPTS_ROOT = ::File.expand_path('../redis', __FILE__)
   end

data/lib/minitest/queue/runner.rb

@@ -304,7 +304,11 @@ module Minitest
         step("Waiting for workers to complete")
 
         unless supervisor.wait_for_workers { display_warnings(supervisor.build) }
-          unless supervisor.queue_initialized?
+          # A lazy-load leader only marks the queue as initialized once it has
+          # streamed every test, but workers start on the first batch, so the wait
+          # can end (e.g. on --max-test-failed) while it is still streaming.
+          # Check streaming? first: the status only moves from streaming to ready.
+          unless supervisor.streaming? || supervisor.queue_initialized?
             abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?", 40
           end
 
@@ -314,7 +318,7 @@ module Minitest
             reporter.write_failure_file(queue_config.failure_file) if queue_config.failure_file
             reporter.write_flaky_tests_file(queue_config.export_flaky_tests_file) if queue_config.export_flaky_tests_file
 
-            abort!("#{supervisor.size} tests weren't run.", exit_code)
+            abort!(unrun_tests_message(supervisor), exit_code)
           end
         end
 
@@ -447,6 +451,16 @@ module Minitest
         Minitest::Queue::WorkerProfileReporter.new(supervisor).print_summary
       end
 
+      def unrun_tests_message(supervisor)
+        # Read the status before the size: tests a streaming leader hasn't pushed
+        # yet aren't in the queue, so the size is only a lower bound.
+        if supervisor.streaming?
+          "At least #{supervisor.size} tests weren't run (the leader hadn't finished streaming tests to the queue)."
+        else
+          "#{supervisor.size} tests weren't run."
+        end
+      end
+
       def parser
         @parser ||= OptionParser.new do |opts|
           opts.banner = "Usage: minitest-queue [options] COMMAND [ARGS]"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ci-queue
 version: !ruby/object:Gem::Version
-  version: 0.101.0
+  version: 0.102.0
 platform: ruby
 authors:
 - Jean Boussier