chutney 3.0.0.beta.1 → 3.1.1

data/lib/chutney/linter/missing_feature_description.rb

@@ -6,7 +6,7 @@ module Chutney
     MESSAGE = 'Features should have a description so that its purpose is clear'
     def lint
       return unless feature
-      
+
       add_issue(I18n.t('linters.missing_feature_description'), feature) if feature.description.empty?
     end
   end

data/lib/chutney/linter/missing_feature_name.rb

@@ -2,10 +2,10 @@
 
 module Chutney
   # service class to lint for missing feature names
-  class MissingFeatureName < Linter    
+  class MissingFeatureName < Linter
     def lint
       return unless feature
-      
+
       add_issue(I18n.t('linters.missing_feature_name'), feature) if feature.name.empty?
     end
   end

data/lib/chutney/linter/missing_scenario_name.rb

@@ -2,8 +2,7 @@
 
 module Chutney
   # service class to lint for missing scenario names
-  class MissingScenarioName < Linter  
-  
+  class MissingScenarioName < Linter
     def lint
       scenarios do |feature, scenario|
         add_issue(I18n.t('linters.missing_scenario_name'), feature, scenario) if scenario.name.empty?

data/lib/chutney/linter/missing_test_action.rb

@@ -7,7 +7,7 @@ module Chutney
       filled_scenarios do |feature, scenario|
         when_steps = scenario.steps.select { |step| when_word?(step.keyword) }
         next unless when_steps.empty?
-        
+
         add_issue(I18n.t('linters.missing_test_action'), feature, scenario)
       end
     end

data/lib/chutney/linter/missing_verification.rb

@@ -9,7 +9,7 @@ module Chutney
       filled_scenarios do |feature, scenario|
         then_steps = scenario.steps.select { |step| then_word?(step.keyword) }
         next unless then_steps.empty?
-        
+
         add_issue(I18n.t('linters.missing_test_verification'), feature, scenario)
       end
     end

data/lib/chutney/linter/required_tags_starts_with.rb

@@ -3,26 +3,25 @@
 module Chutney
   # service class to lint for tags used multiple times
   class RequiredTagsStartsWith < Linter
-        
     def lint
       return unless pattern
 
       scenarios do |feature, scenario|
         next if match_pattern? tags_for(feature)
         next if match_pattern? tags_for(scenario)
-        
+
         add_issue(
-          I18n.t('linters.required_tags_starts_with', 
-                 allowed: pattern.join(', ')), 
+          I18n.t('linters.required_tags_starts_with',
+                 allowed: pattern.join(', ')),
           feature, scenario
         )
       end
     end
-    
+
     def pattern
       configuration['Matcher'] || nil
     end
-  
+
     def match_pattern?(target)
       target.each do |t|
         return true if t.start_with?(*pattern)

data/lib/chutney/linter/same_tag_different_case.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require 'chutney/linter'
+
+module Chutney
+  # service class to lint for missing verifications
+  class SameTagDifferentCase < Linter
+    def all_known_tags
+      # rubocop:disable Style/ClassVars
+      @@all_known_tags ||= []
+      # rubocop:enable Style/ClassVars
+    end
+
+    def lint
+      scenarios do |feature, scenario|
+        total_tags = tags_for(feature) + tags_for(scenario)
+
+        total_tags.each do |tag|
+          collision_with = case_collision(tag)
+          if collision_with
+            add_issue(I18n.t('linters.same_tag_different_case',
+                             existing_tag: collision_with, tag: tag),
+                      feature, scenario)
+          else
+            @@all_known_tags << tag
+          end
+        end
+      end
+    end
+
+    def case_collision(tag)
+      return nil if all_known_tags.include?(tag)
+
+      all_known_tags.select { |t| t.casecmp(tag).zero? }.first
+    end
+  end
+end

data/lib/chutney/linter/same_tag_for_all_scenarios.rb

@@ -14,13 +14,13 @@ module Chutney
       tags = scenario_tags
       return if tags.nil? || tags.empty?
       return unless feature.tests.length > 1
-            
+
       tags.each do |tag|
         next if tag == 'skip'
 
         add_issue(
-          I18n.t('linters.same_tag_for_all_scenarios.feature_level', 
-                 tag: tag), 
+          I18n.t('linters.same_tag_for_all_scenarios.feature_level',
+                 tag: tag),
           feature
         )
       end
@@ -32,12 +32,12 @@ module Chutney
         next if tags.nil? || tags.empty?
         next unless scenario.is_a? CukeModeler::Outline
         next unless scenario.examples.length > 1
-        
+
         tags.each do |tag|
           next if tag == 'skip'
 
-          add_issue(I18n.t('linters.same_tag_for_all_scenarios.example_level', 
-                           tag: tag), feature, scenario)        
+          add_issue(I18n.t('linters.same_tag_for_all_scenarios.example_level',
+                           tag: tag), feature, scenario)
         end
       end
     end
@@ -55,13 +55,13 @@ module Chutney
     def example_tags(scenario)
       result = nil
       return result unless scenario.is_a?(CukeModeler::Outline) && scenario.examples
-      
+
       scenario.examples.each do |example|
         return nil unless example.tags
-        
+
         tags = tags_for(example)
         result = tags if result.nil?
-        
+
         result &= tags
       end
       result

data/lib/chutney/linter/scenario_names_match.rb

@@ -6,14 +6,13 @@ module Chutney
   # service class to lint for tags used multiple times
   class ScenarioNamesMatch < Linter
     MESSAGE = 'Scenario Name does not match pattern'
-  
 
     def lint
       scenarios do |feature, scenario|
         next unless (scenario.name =~ /#{configuration['Matcher']}/).nil?
-        
+
         add_issue(
-          I18n.t('linters.scenario_names_match', 
+          I18n.t('linters.scenario_names_match',
                  pattern: configuration['Matcher']), feature, scenario
         )
       end

data/lib/chutney/linter/tag_used_multiple_times.rb

@@ -8,7 +8,7 @@ module Chutney
         total_tags = tags_for(feature) + tags_for(scenario)
         double_used_tags = total_tags.find_all { |a| total_tags.count(a) > 1 }.uniq!
         next if double_used_tags.nil?
-                
+
         add_issue(
           I18n.t('linters.tag_used_multiple_times', tags: double_used_tags.join(',')), feature
         )

data/lib/chutney/linter/too_clumsy.rb

@@ -9,7 +9,7 @@ module Chutney
       filled_scenarios do |feature, scenario|
         characters = scenario.steps.map { |step| step.text.length }.inject(0, :+)
         next if characters < 400
-        
+
         add_issue(
           I18n.t('linters.too_clumsy', length: characters), feature, scenario
         )

data/lib/chutney/linter/too_long_step.rb

@@ -6,14 +6,14 @@ module Chutney
     def lint
       steps do |feature, scenario, step|
         next if step.text.length <= maxlength
-        
+
         add_issue(
-          I18n.t('linters.too_long_step', length: step.text.length, max: maxlength), 
+          I18n.t('linters.too_long_step', length: step.text.length, max: maxlength),
           feature, scenario
         )
       end
     end
-    
+
     def maxlength
       configuration['MaxLength'] || '120'
     end

data/lib/chutney/linter/too_many_different_tags.rb

@@ -6,20 +6,20 @@ module Chutney
     def lint
       tags = all_tags
       return if tags.length <= maxcount
-      
+
       add_issue(
-        I18n.t('linters.too_many_different_tags', count: tags.length, max: maxcount), 
+        I18n.t('linters.too_many_different_tags', count: tags.length, max: maxcount),
         feature
       )
     end
-    
-    def maxcount 
+
+    def maxcount
       configuration['MaxCount']&.to_i || 3
     end
-    
+
     def all_tags
       return [] unless feature&.scenarios
-      
+
       tags_for(feature) + feature.scenarios.map { |scenario| tags_for(scenario) }.flatten
     end
   end

data/lib/chutney/linter/too_many_steps.rb

@@ -6,14 +6,14 @@ module Chutney
     def lint
       filled_scenarios do |feature, scenario|
         next if scenario.steps.length <= maxcount
-        
+
         add_issue(
-          I18n.t('linters.too_many_steps', count: scenario.steps.length, max: maxcount), 
+          I18n.t('linters.too_many_steps', count: scenario.steps.length, max: maxcount),
           feature
         )
       end
     end
-    
+
     def maxcount
       configuration['MaxCount']&.to_i || 10
     end

data/lib/chutney/linter/too_many_tags.rb

@@ -7,14 +7,14 @@ module Chutney
       scenarios do |feature, scenario|
         tags = tags_for(feature) + tags_for(scenario)
         next unless tags.length > maxcount
-        
+
         add_issue(
-          I18n.t('linters.too_many_tags', count: tags.length, max: maxcount), 
+          I18n.t('linters.too_many_tags', count: tags.length, max: maxcount),
           feature
         )
       end
     end
-    
+
     def maxcount
       configuration['MaxCount']&.to_i || 3
     end

data/lib/chutney/linter/unique_scenario_names.rb

@@ -14,13 +14,13 @@ module Chutney
         end
       end
     end
-    
+
     def issue(name, first_location, scenario)
       add_issue(
         I18n.t('linters.unique_scenario_names',
                name: name,
                line: first_location[:line],
-               column: first_location[:column]), 
+               column: first_location[:column]),
         feature, scenario
       )
     end

data/lib/chutney/linter/unknown_variable.rb

@@ -9,7 +9,7 @@ module Chutney
         scenario.steps.each do |step|
           step_vars(step).each do |used_var|
             next if known_vars.include? used_var
-            
+
             add_issue(
               I18n.t('linters.unknown_variable', variable: used_var), feature, scenario
             )
@@ -21,7 +21,7 @@ module Chutney
     def step_vars(step)
       vars = gather_vars step.text
       return vars unless step.block
-      
+
       vars + gather_vars_from_argument(step.block)
     end
 
@@ -39,7 +39,7 @@ module Chutney
 
     def known_variables(scenario)
       return [] unless scenario.is_a? CukeModeler::Outline
-    
+
       scenario.examples.map { |ex| ex.rows.first.cells.map(&:value) }.flatten
     end
   end

data/lib/chutney/linter/unused_variable.rb

@@ -6,9 +6,8 @@ module Chutney
     def lint
       scenarios do |feature, scenario|
         next unless scenario.is_a? CukeModeler::Outline
-      
+
         scenario.examples.each do |example|
-          
           example.rows.first.cells.map(&:value).each do |variable|
             next if used?(variable, scenario)
 
@@ -20,7 +19,7 @@ module Chutney
 
     def used?(variable, scenario)
       variable = "<#{variable}>"
-      
+
       scenario.steps.each do |step|
         return true if step.text.include? variable
         next unless step.block
@@ -36,7 +35,7 @@ module Chutney
 
     def used_in_table?(variable, step)
       return false unless step.block.is_a?(CukeModeler::Table)
-      
+
       step.block.rows.each do |row|
         row.cells.each { |cell| return true if cell.value.include?(variable) }
       end

data/lib/chutney/linter/use_background.rb

@@ -16,11 +16,11 @@ module Chutney
 
     def gather_givens
       return unless feature.children
-      
+
       has_non_given_step = false
       scenarios do |_feature, scenario|
         next unless scenario.steps
-        
+
         has_non_given_step = true unless given_word?(scenario.steps.first.keyword)
       end
       return if has_non_given_step
@@ -33,7 +33,7 @@ module Chutney
     def expanded_steps(&block)
       scenarios do |_feature, scenario|
         next unless scenario.steps
-        
+
         prototypes = [render_step(scenario.steps.first)]
         prototypes = expand_examples(scenario.examples, prototypes) if scenario.is_a? CukeModeler::Outline
         prototypes.each(&block)
@@ -52,7 +52,7 @@ module Chutney
       headers = example.rows.first.cells.map(&:value)
       example.rows.each_with_index do |row, idx|
         next if idx.zero? # skip the header
-        
+
         modified_sentence = sentence.dup
         headers.zip(row.cells.map(&:value)).map do |key, value|
           modified_sentence.gsub!("<#{key}>", value)

data/lib/chutney/linter/use_outline.rb

@@ -11,18 +11,18 @@ module Chutney
       scenarios.product(scenarios) do |lhs, rhs|
         next if lhs == rhs
         next if lhs[:reference][:line] > rhs[:reference][:line]
-        
+
         similarity = determine_similarity(lhs[:text], rhs[:text])
         next unless similarity >= 0.95
-        
+
         similarity_pct = similarity.round(3) * 100
-        
+
         add_issue(lhs, rhs, similarity_pct)
       end
     end
-    
+
     def add_issue(lhs, rhs, pct)
-      super(I18n.t('linters.use_outline', 
+      super(I18n.t('linters.use_outline',
                    pct: pct,
                    lhs_name: lhs[:name],
                    lhs_line: lhs[:reference][:line],
@@ -39,11 +39,11 @@ module Chutney
     def gather_scenarios(feature)
       scenarios = []
       return scenarios if feature.nil? || !feature.tests
-      
+
       scenarios do |_feature, scenario|
         next unless scenario.steps
         next if scenario.steps.empty?
-        
+
         scenarios.push generate_reference(feature, scenario)
       end
       scenarios

data/lib/chutney/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Chutney
-  VERSION = '3.0.0.beta.1'
+  VERSION = '3.1.1'
 end