chutney 2.2.1 → 3.1.0

data/lib/chutney/linter/use_outline.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for using outline
   class UseOutline < Linter
@@ -9,18 +11,18 @@ module Chutney
       scenarios.product(scenarios) do |lhs, rhs|
         next if lhs == rhs
         next if lhs[:reference][:line] > rhs[:reference][:line]
-        
+
         similarity = determine_similarity(lhs[:text], rhs[:text])
         next unless similarity >= 0.95
-        
+
         similarity_pct = similarity.round(3) * 100
-        
+
         add_issue(lhs, rhs, similarity_pct)
       end
     end
-    
+
     def add_issue(lhs, rhs, pct)
-      super(I18n.t('linters.use_outline', 
+      super(I18n.t('linters.use_outline',
                    pct: pct,
                    lhs_name: lhs[:name],
                    lhs_line: lhs[:reference][:line],
@@ -36,13 +38,12 @@ module Chutney
 
     def gather_scenarios(feature)
       scenarios = []
-      return scenarios if feature.nil? || !feature.include?(:children)
-      
-      feature[:children].each do |scenario|
-        next unless scenario[:type] == :Scenario
-        next unless scenario.include? :steps
-        next if scenario[:steps].empty?
-        
+      return scenarios if feature.nil? || !feature.tests
+
+      scenarios do |_feature, scenario|
+        next unless scenario.steps
+        next if scenario.steps.empty?
+
         scenarios.push generate_reference(feature, scenario)
       end
       scenarios
@@ -51,8 +52,8 @@ module Chutney
     def generate_reference(feature, scenario)
       reference = {}
       reference[:reference] = location(feature, scenario, nil)
-      reference[:name] = "#{scenario[:keyword]}: #{scenario[:name]}"
-      reference[:text] = scenario[:steps].map { |step| render_step(step) }.join ' '
+      reference[:name] = "#{scenario.keyword}: #{scenario.name}"
+      reference[:text] = scenario.steps.map { |step| render_step(step) }.join ' '
       reference
     end
   end

data/lib/chutney/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Chutney
-  VERSION = '2.2.1'.freeze
+  VERSION = '3.1.0'
 end

data/lib/config/locales/en.yml

@@ -63,6 +63,9 @@ en:
     scenario_names_match: >-
       You have a scenario name which does not match the required format.
       Allowed patterns are '%{pattern}'.
+    same_tag_different_case: >-
+      You have a tag which has already appeared as '@%{existing_tag}' which is a different case
+      to '@%{tag}'. Cucumber tags are case-sensitive: use a consistent case for your tag names.
     same_tag_for_all_scenarios:
       feature_level: >-
         You are using the same tag (%{tag}) for all scenarios.

data/spec/chutney_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'chutney'
 
 describe Chutney::ChutneyLint do
@@ -6,25 +8,25 @@ describe Chutney::ChutneyLint do
   it 'has a version number' do
     expect(Chutney::VERSION).not_to be nil
   end
-  
+
   describe '#initialize' do
     it 'creates an instance' do
       expect(subject).not_to be_nil
     end
-    
+
     it 'has an empty list of files if none are given' do
       expect(subject.files).to eq []
     end
-    
+
     it 'has a list of files given on initialization' do
       alt_subject = Chutney::ChutneyLint.new('a', 'b')
       expect(alt_subject.files).to eq %w[a b]
     end
-    
+
     it 'initializes a results hash' do
       expect(subject.results).to eq({})
     end
-    
+
     it 'sets the load path for I18n' do
       expect(I18n.load_path).not_to eq []
     end
@@ -34,25 +36,25 @@ describe Chutney::ChutneyLint do
         expect(subject.configuration).not_to be_nil
         expect(subject.configuration).to respond_to :[]
       end
-      
+
       it 'allows the configuration to be set explicitly' do
         config = { 'BackgroundDoesMoreThanSetup' => { 'Enabled' => true } }
         subject.configuration = config
         expect(subject.configuration).to be config
       end
-      
+
       it 'controls the available linters' do
         subject.configuration = {}
         expect(subject.linters).to be_empty
       end
-      
+
       it 'enables linters to be activated' do
         config = { 'BackgroundDoesMoreThanSetup' => { 'Enabled' => true } }
         subject.configuration = config
         expect(subject.linters).to eq [Chutney::BackgroundDoesMoreThanSetup]
       end
     end
-    
+
     context 'linting' do
       it 'aliases analyse and analyze' do
         expect(subject).to respond_to :analyse

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 require 'coveralls'
 # Coveralls.wear!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chutney
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Nigel Brookes-Thomas
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-25 00:00:00.000000000 Z
+date: 2021-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amatch
@@ -28,19 +28,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.4.0
 - !ruby/object:Gem::Dependency
-  name: gherkin
+  name: cuke_modeler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: '3.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -103,14 +103,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -173,14 +173,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 1.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 1.14.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -195,8 +195,10 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.8'
-description: A linter for your Cucumber features. It supports any spoken language
-  Cucumber v3 supports.
+description: A linter for your Cucumber features. Making sure you have nice, expressible
+  Gherkin is essential is making sure you have a readable test-base. Chutney is designed
+  to sniff out smells in your feature files. It supports any spoken language Cucumber
+  supports.
 email:
 - nigel@brookes-thomas.co.uk
 executables:
@@ -206,6 +208,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".coveralls.yml"
+- ".github/dependabot.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -215,7 +218,8 @@ files:
 - README.md
 - Rakefile
 - chutney.gemspec
-- config/chutney.yml
+- config/chutney_defaults.yml
+- config/cucumber.yml
 - docs/.keep
 - docs/_config.yml
 - docs/credits.md
@@ -259,6 +263,7 @@ files:
 - lib/chutney/linter/missing_test_action.rb
 - lib/chutney/linter/missing_verification.rb
 - lib/chutney/linter/required_tags_starts_with.rb
+- lib/chutney/linter/same_tag_different_case.rb
 - lib/chutney/linter/same_tag_for_all_scenarios.rb
 - lib/chutney/linter/scenario_names_match.rb
 - lib/chutney/linter/tag_used_multiple_times.rb
@@ -289,17 +294,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
-summary: A linter for English language Gherkin
+summary: A linter for multi-lingual Gherkin
 test_files: []