chutney 2.1.1 → 3.0.1

data/lib/chutney/linter/bad_scenario_name.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Chutney
-  # service class to lint for bad scenario names  
+  # service class to lint for bad scenario names
   class BadScenarioName < Linter
     def lint
       scenarios do |feature, scenario|
-        next if scenario[:name].empty?
-        
+        next if scenario.name.empty?
+
         bad = /\w*(test|verif|check)\w*/i
-        match = scenario[:name].match(bad).to_a.first
+        match = scenario.name.match(bad).to_a.first
         add_issue(I18n.t('linters.bad_scenario_name', word: match), feature, scenario) if match
       end
     end

data/lib/chutney/linter/empty_feature_file.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module Chutney
+  # service class to lint for Features that have no content
+  class EmptyFeatureFile < Linter
+    def lint
+      add_issue(I18n.t('linters.empty_feature_file')) if feature.nil?
+    end
+  end
+end

data/lib/chutney/linter/file_name_differs_feature_name.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for file name differs feature name
   class FileNameDiffersFeatureName < Linter
     def lint
-      return unless feature&.include?(:name)
-        
+      return unless feature
+
       expected_feature_name = title_case(filename)
-      return if ignore_whitespaces(feature[:name]).casecmp(ignore_whitespaces(expected_feature_name)) == 0
-        
-      add_issue(I18n.t('linters.file_name_differs_feature_name', expected: expected_feature_name), feature) 
+      return if ignore_whitespaces(feature.name).casecmp(ignore_whitespaces(expected_feature_name)) == 0
+
+      add_issue(I18n.t('linters.file_name_differs_feature_name', expected: expected_feature_name), feature)
     end
 
     def title_case(value)

data/lib/chutney/linter/givens_after_background.rb

@@ -1,15 +1,14 @@
+# frozen_string_literal: true
+
 module Chutney
-  # service class to lint for bad scenario names  
+  # service class to lint for bad scenario names
   class GivensAfterBackground < Linter
     def lint
-      return if background.nil?
-      return if background.empty?
-      
+      return unless background
+
       filled_scenarios do |feature, scenario|
-        scenario[:steps].each do |step|
-          if given_word?(step[:keyword])
-            add_issue(I18n.t('linters.givens_after_background'), feature, scenario, step)
-          end
+        scenario.steps.each do |step|
+          add_issue(I18n.t('linters.givens_after_background'), feature, scenario, step) if given_word?(step.keyword)
         end
       end
     end

data/lib/chutney/linter/invalid_file_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'chutney/linter'
 
 module Chutney
@@ -11,7 +13,7 @@ module Chutney
         end
       end
     end
-    
+
     def recommend(filename)
       File.basename(filename, '.*').gsub(/::/, '/')
           .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')

data/lib/chutney/linter/invalid_step_flow.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for invalid step flow
   class InvalidStepFlow < Linter
     def lint
       filled_scenarios do |feature, scenario|
-        steps = scenario[:steps].select { |step| !and_word?(step[:keyword]) && !but_word?(step[:keyword]) }
+        steps = scenario.steps.select { |step| !and_word?(step.keyword) && !but_word?(step.keyword) }
         next if steps.empty?
-        
+
         last_step_is_an_action(feature, scenario, steps)
         given_after_non_given(feature, scenario, steps)
         verification_before_action(feature, scenario, steps)
@@ -13,7 +15,7 @@ module Chutney
     end
 
     def last_step_is_an_action(feature, scenario, steps)
-      return unless when_word?(steps.last[:keyword])
+      return unless when_word?(steps.last.keyword)
 
       add_issue(I18n.t('linters.invalid_step_flow.action_last'), feature, scenario, steps.last)
     end
@@ -21,7 +23,7 @@ module Chutney
     def given_after_non_given(feature, scenario, steps)
       last_step = steps.first
       steps.each do |step|
-        if given_word?(step[:keyword]) && !given_word?(last_step[:keyword])
+        if given_word?(step.keyword) && !given_word?(last_step.keyword)
           add_issue(I18n.t('linters.invalid_step_flow.given_order'), feature, scenario, step)
         end
         last_step = step
@@ -30,11 +32,9 @@ module Chutney
 
     def verification_before_action(feature, scenario, steps)
       steps.each do |step|
-        break if when_word?(step[:keyword])
-        
-        if then_word?(step[:keyword])
-          add_issue(I18n.t('linters.invalid_step_flow.missing_action'), feature, scenario)
-        end
+        break if when_word?(step.keyword)
+
+        add_issue(I18n.t('linters.invalid_step_flow.missing_action'), feature, scenario) if then_word?(step.keyword)
       end
     end
   end

data/lib/chutney/linter/missing_example_name.rb

@@ -1,25 +1,25 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for missing example names
   class MissingExampleName < Linter
-  
     def lint
       scenarios do |_feature, scenario|
-        next unless scenario[:examples]
+        next unless scenario.is_a? CukeModeler::Outline
 
-        scenario[:examples].each do |example|
-          example_count = scenario[:examples]&.length || 0
+        scenario.examples.each do |example|
+          example_count = scenario.examples&.length || 0
           next unless example_count > 1
-          
+
           check_example(scenario, example)
         end
       end
-    end               
+    end
 
     def check_example(scenario, example)
-      name = example.key?(:name) ? example[:name].strip : ''
-      duplicate_name_count = scenario[:examples].filter { |e| e[:name] == name }.count
+      name = example.name.strip
+      duplicate_name_count = scenario.examples.filter { |e| e.name == name }.count
       add_issue(I18n.t('linters.missing_example_name'), feature, scenario, example) if duplicate_name_count >= 2
     end
-    
   end
 end

data/lib/chutney/linter/missing_feature_description.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for missing feature descriptions
   class MissingFeatureDescription < Linter
-    MESSAGE = 'Features should have a description so that its purpose is clear'.freeze
+    MESSAGE = 'Features should have a description so that its purpose is clear'
     def lint
       return unless feature
-      
-      name = feature.key?(:description) ? feature[:description].strip : ''
-      add_issue(I18n.t('linters.missing_feature_description'), feature) if name.empty?
+
+      add_issue(I18n.t('linters.missing_feature_description'), feature) if feature.description.empty?
     end
   end
 end

data/lib/chutney/linter/missing_feature_name.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for missing feature names
-  class MissingFeatureName < Linter    
+  class MissingFeatureName < Linter
     def lint
       return unless feature
-      
-      name = feature.key?(:name) ? feature[:name].strip : ''
-      add_issue(I18n.t('linters.missing_feature_name'), feature) if name.empty?
+
+      add_issue(I18n.t('linters.missing_feature_name'), feature) if feature.name.empty?
     end
   end
 end

data/lib/chutney/linter/missing_scenario_name.rb

@@ -1,13 +1,11 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for missing scenario names
-  class MissingScenarioName < Linter  
-  
+  class MissingScenarioName < Linter
     def lint
       scenarios do |feature, scenario|
-        name = scenario.key?(:name) ? scenario[:name].strip : ''
-        next unless name.empty?
-        
-        add_issue(I18n.t('linters.missing_scenario_name'), feature, scenario) if name.empty?
+        add_issue(I18n.t('linters.missing_scenario_name'), feature, scenario) if scenario.name.empty?
       end
     end
   end

data/lib/chutney/linter/missing_test_action.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for missing test actions
   class MissingTestAction < Linter
     def lint
       filled_scenarios do |feature, scenario|
-        when_steps = scenario[:steps].select { |step| when_word?(step[:keyword]) }
+        when_steps = scenario.steps.select { |step| when_word?(step.keyword) }
         next unless when_steps.empty?
-        
+
         add_issue(I18n.t('linters.missing_test_action'), feature, scenario)
       end
     end

data/lib/chutney/linter/missing_verification.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'chutney/linter'
 
 module Chutney
@@ -5,9 +7,9 @@ module Chutney
   class MissingVerification < Linter
     def lint
       filled_scenarios do |feature, scenario|
-        then_steps = scenario[:steps].select { |step| then_word?(step[:keyword]) }
+        then_steps = scenario.steps.select { |step| then_word?(step.keyword) }
         next unless then_steps.empty?
-        
+
         add_issue(I18n.t('linters.missing_test_verification'), feature, scenario)
       end
     end

data/lib/chutney/linter/required_tags_starts_with.rb

@@ -1,26 +1,27 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for tags used multiple times
   class RequiredTagsStartsWith < Linter
-        
     def lint
       return unless pattern
 
       scenarios do |feature, scenario|
         next if match_pattern? tags_for(feature)
         next if match_pattern? tags_for(scenario)
-        
+
         add_issue(
-          I18n.t('linters.required_tags_starts_with', 
-                 allowed: pattern.join(', ')), 
+          I18n.t('linters.required_tags_starts_with',
+                 allowed: pattern.join(', ')),
           feature, scenario
         )
       end
     end
-    
+
     def pattern
       configuration['Matcher'] || nil
     end
-  
+
     def match_pattern?(target)
       target.each do |t|
         return true if t.start_with?(*pattern)

data/lib/chutney/linter/same_tag_for_all_scenarios.rb

@@ -1,40 +1,43 @@
+# frozen_string_literal: true
+
 require 'chutney/linter'
 
 module Chutney
   # service class to lint for using same tag on all scenarios
   class SameTagForAllScenarios < Linter
     def lint
-      lint_scenarios if feature&.include?(:children)
-      lint_examples  if feature&.include?(:children)
+      lint_scenarios if feature&.scenarios
+      lint_examples  if feature&.scenarios
     end
 
     def lint_scenarios
       tags = scenario_tags
       return if tags.nil? || tags.empty?
-      return unless feature[:children].length > 1
-            
+      return unless feature.tests.length > 1
+
       tags.each do |tag|
         next if tag == 'skip'
 
         add_issue(
-          I18n.t('linters.same_tag_for_all_scenarios.feature_level', 
-                 tag: tag), 
+          I18n.t('linters.same_tag_for_all_scenarios.feature_level',
+                 tag: tag),
           feature
         )
       end
     end
 
     def lint_examples
-      feature[:children].each do |scenario|
+      scenarios do |_feature, scenario|
         tags = example_tags(scenario)
         next if tags.nil? || tags.empty?
-        next unless scenario[:examples].length > 1
-        
+        next unless scenario.is_a? CukeModeler::Outline
+        next unless scenario.examples.length > 1
+
         tags.each do |tag|
           next if tag == 'skip'
 
-          add_issue(I18n.t('linters.same_tag_for_all_scenarios.example_level', 
-                           tag: tag), feature, scenario)        
+          add_issue(I18n.t('linters.same_tag_for_all_scenarios.example_level',
+                           tag: tag), feature, scenario)
         end
       end
     end
@@ -42,8 +45,6 @@ module Chutney
     def scenario_tags
       result = nil
       scenarios do |_feature, scenario|
-        next if scenario[:type] == :Background
-
         tags = tags_for(scenario)
         result ||= tags
         result &= tags
@@ -53,14 +54,14 @@ module Chutney
 
     def example_tags(scenario)
       result = nil
-      return result unless scenario.include? :examples
-      
-      scenario[:examples].each do |example|
-        return nil unless example.include? :tags
-        
+      return result unless scenario.is_a?(CukeModeler::Outline) && scenario.examples
+
+      scenario.examples.each do |example|
+        return nil unless example.tags
+
         tags = tags_for(example)
         result = tags if result.nil?
-        
+
         result &= tags
       end
       result

data/lib/chutney/linter/scenario_names_match.rb

@@ -1,18 +1,18 @@
+# frozen_string_literal: true
+
 require 'chutney/linter'
 
 module Chutney
   # service class to lint for tags used multiple times
   class ScenarioNamesMatch < Linter
-    MESSAGE = 'Scenario Name does not match pattern'.freeze
-  
+    MESSAGE = 'Scenario Name does not match pattern'
 
     def lint
       scenarios do |feature, scenario|
-        name = scenario.key?(:name) ? scenario[:name].strip : ''
-        next unless (name =~ /#{configuration['Matcher']}/).nil?
-        
+        next unless (scenario.name =~ /#{configuration['Matcher']}/).nil?
+
         add_issue(
-          I18n.t('linters.scenario_names_match', 
+          I18n.t('linters.scenario_names_match',
                  pattern: configuration['Matcher']), feature, scenario
         )
       end

data/lib/chutney/linter/tag_used_multiple_times.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for tags used multiple times
   class TagUsedMultipleTimes < Linter
@@ -6,7 +8,7 @@ module Chutney
         total_tags = tags_for(feature) + tags_for(scenario)
         double_used_tags = total_tags.find_all { |a| total_tags.count(a) > 1 }.uniq!
         next if double_used_tags.nil?
-                
+
         add_issue(
           I18n.t('linters.tag_used_multiple_times', tags: double_used_tags.join(',')), feature
         )

data/lib/chutney/linter/too_clumsy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'chutney/linter'
 
 module Chutney
@@ -5,9 +7,9 @@ module Chutney
   class TooClumsy < Linter
     def lint
       filled_scenarios do |feature, scenario|
-        characters = scenario[:steps].map { |step| step[:text].length }.inject(0, :+)
+        characters = scenario.steps.map { |step| step.text.length }.inject(0, :+)
         next if characters < 400
-        
+
         add_issue(
           I18n.t('linters.too_clumsy', length: characters), feature, scenario
         )

data/lib/chutney/linter/too_long_step.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 module Chutney
   # service class to lint for too long steps
   class TooLongStep < Linter
     def lint
       steps do |feature, scenario, step|
-        next if step[:text].length <= maxlength
-        
+        next if step.text.length <= maxlength
+
         add_issue(
-          I18n.t('linters.too_long_step', length: step[:text].length, max: maxlength), 
+          I18n.t('linters.too_long_step', length: step.text.length, max: maxlength),
           feature, scenario
         )
       end
     end
-    
+
     def maxlength
       configuration['MaxLength'] || '120'
     end