chupa-text 1.1.3 → 1.1.4

data/lib/chupa-text/extractor.rb

@@ -99,9 +99,15 @@ module ChupaText
     end
 
     def find_decomposer(data)
-      @decomposers.find do |decomposer|
-        decomposer.target?(data)
+      candidates = []
+      @decomposers.each do |decomposer|
+        score = decomposer.target_score(data)
+        next if score.nil?
+        candidates << [score, decomposer]
       end
+      return nil if candidates.empty?
+      candidate = candidates.sort_by {|score, _| score}.first
+      candidate[1]
     end
 
     def log_tag

data/lib/chupa-text/formatters/mime.rb

@@ -22,9 +22,10 @@ require "chupa-text/formatters/hash"
 module ChupaText
   module Formatters
     class MIME < Hash
-      def initialize(output)
+      def initialize(output, options={})
         super()
         @output = output
+        @boundary = options[:boundary]
       end
 
       def format_finish(data)
@@ -33,7 +34,7 @@ module ChupaText
         @output << "MIME-Version: 1.0\r\n"
         format_hash(formatted, ["texts"])
         texts = formatted["texts"]
-        boundary = Digest::SHA1.hexdigest(data.uri.to_s)
+        boundary = @boundary || Digest::SHA1.hexdigest(data.uri.to_s)
         @output << "Content-Type: multipart/mixed; boundary=#{boundary}\r\n"
         texts.each do |text|
           @output << "\r\n--#{boundary}\r\n"

data/lib/chupa-text/version.rb

@@ -15,5 +15,5 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
 module ChupaText
-  VERSION = "1.1.3"
+  VERSION = "1.1.4"
 end

data/test/decomposers/test-office-open-xml-document.rb

@@ -0,0 +1,144 @@
+# Copyright (C) 2019  Kouhei Sutou <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+class TestDecomposersOfficeOpenXMLDocument < Test::Unit::TestCase
+  include Helper
+
+  def setup
+    @decomposer = ChupaText::Decomposers::OfficeOpenXMLDocument.new({})
+  end
+
+  def decompose(path)
+    data = ChupaText::InputData.new(path)
+    decomposed = []
+    @decomposer.decompose(data) do |decomposed_data|
+      decomposed << decomposed_data
+    end
+    decomposed
+  end
+
+  sub_test_case("#target_score") do
+    def test_extension
+      data = ChupaText::Data.new
+      data.body = ""
+      data.uri = "document.docx"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+
+    def test_mime_type
+      data = ChupaText::Data.new
+      data.mime_type = "application/vnd.openxmlformats-officedocument.wordprocessingml.document"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+  end
+
+  sub_test_case("#decompose") do
+    sub_test_case("attributes") do
+      def decompose(attribute_name)
+        super(fixture_path("docx", "attributes.docx")).collect do |data|
+          data[attribute_name]
+        end
+      end
+
+      def test_title
+        assert_equal(["Title"], decompose("title"))
+      end
+
+      def test_author
+        assert_equal([nil], decompose("author"))
+      end
+
+      def test_subject
+        assert_equal(["Subject"], decompose("subject"))
+      end
+
+      def test_keywords
+        assert_equal(["Keyword1 Keyword2"], decompose("keywords"))
+      end
+
+      def test_created_time
+        assert_equal([Time],
+                     decompose("created_time").collect(&:class))
+      end
+
+      def test_modified_time
+        assert_equal([Time],
+                     decompose("modified_time").collect(&:class))
+      end
+
+      def test_application
+        assert_equal(["LibreOffice"],
+                     normalize_applications(decompose("application")))
+      end
+
+      def normalize_applications(applications)
+        applications.collect do |application|
+          normalize_application(application)
+        end
+      end
+
+      def normalize_application(application)
+        if application.start_with?("LibreOffice")
+          "LibreOffice"
+        else
+          application
+        end
+      end
+
+      def test_creation_date
+        assert_equal([nil], decompose("creation_date"))
+      end
+    end
+
+    sub_test_case("one page") do
+      def decompose
+        super(fixture_path("docx", "one-page.docx"))
+      end
+
+      def test_body
+        assert_equal(["Page1\n"], decompose.collect(&:body))
+      end
+    end
+
+    sub_test_case("multi pages") do
+      def decompose
+        super(fixture_path("docx", "multi-pages.docx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Page1
+Page2
+        BODY
+      end
+    end
+
+    sub_test_case("special characters") do
+      def decompose
+        super(fixture_path("docx", "special-characters.docx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Ampersand: &
+Reference: &amp;
+HTML: <a href="">
+Single quote: ''
+        BODY
+      end
+    end
+  end
+end

data/test/decomposers/test-office-open-xml-presentation.rb

@@ -0,0 +1,133 @@
+# Copyright (C) 2019  Kouhei Sutou <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+class TestDecomposersOfficeOpenXMLPresentation < Test::Unit::TestCase
+  include Helper
+
+  def setup
+    @decomposer = ChupaText::Decomposers::OfficeOpenXMLPresentation.new({})
+  end
+
+  def decompose(path)
+    data = ChupaText::InputData.new(path)
+    decomposed = []
+    @decomposer.decompose(data) do |decomposed_data|
+      decomposed << decomposed_data
+    end
+    decomposed
+  end
+
+  sub_test_case("#target_score") do
+    def test_extension
+      data = ChupaText::Data.new
+      data.body = ""
+      data.uri = "presentation.pptx"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+
+    def test_mime_type
+      data = ChupaText::Data.new
+      data.mime_type = "application/vnd.openxmlformats-officedocument.presentationml.presentation"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+  end
+
+  sub_test_case("#decompose") do
+    sub_test_case("attributes") do
+      def decompose(attribute_name)
+        super(fixture_path("pptx", "attributes.pptx")).collect do |data|
+          data[attribute_name]
+        end
+      end
+
+      def test_title
+        assert_equal(["Title"], decompose("title"))
+      end
+
+      def test_author
+        assert_equal([nil], decompose("author"))
+      end
+
+      def test_subject
+        assert_equal(["Subject"], decompose("subject"))
+      end
+
+      def test_keywords
+        assert_equal(["Keyword1 Keyword2"], decompose("keywords"))
+      end
+
+      def test_modified_time
+        assert_equal([Time],
+                     decompose("modified_time").collect(&:class))
+      end
+
+      def test_application
+        assert_equal(["LibreOffice"],
+                     normalize_applications(decompose("application")))
+      end
+
+      def normalize_applications(applications)
+        applications.collect do |application|
+          normalize_application(application)
+        end
+      end
+
+      def normalize_application(application)
+        if application.start_with?("LibreOffice")
+          "LibreOffice"
+        else
+          application
+        end
+      end
+
+      def test_creation_date
+        assert_equal([nil], decompose("creation_date"))
+      end
+    end
+
+    sub_test_case("one slide") do
+      def decompose
+        super(fixture_path("pptx", "one-slide.pptx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Slide1 title
+Slide1 content
+        BODY
+      end
+    end
+
+    sub_test_case("multi slides") do
+      def decompose
+        super(fixture_path("pptx", "multi-slides.pptx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Slide1 title
+Slide1 content
+
+Slide2 title
+Slide2 content
+
+Slide3 title
+Slide3 content
+        BODY
+      end
+    end
+  end
+end

data/test/decomposers/test-office-open-xml-workbook.rb

@@ -0,0 +1,138 @@
+# Copyright (C) 2019  Kouhei Sutou <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+class TestDecomposersOfficeOpenXMLWorkbook < Test::Unit::TestCase
+  include Helper
+
+  def setup
+    @decomposer = ChupaText::Decomposers::OfficeOpenXMLWorkbook.new({})
+  end
+
+  def decompose(path)
+    data = ChupaText::InputData.new(path)
+    decomposed = []
+    @decomposer.decompose(data) do |decomposed_data|
+      decomposed << decomposed_data
+    end
+    decomposed
+  end
+
+  sub_test_case("#target_score") do
+    def test_extension
+      data = ChupaText::Data.new
+      data.body = ""
+      data.uri = "workbook.xlsx"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+
+    def test_mime_type
+      data = ChupaText::Data.new
+      data.mime_type = "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet"
+      assert_equal(-1, @decomposer.target_score(data))
+    end
+  end
+
+  sub_test_case("#decompose") do
+    sub_test_case("attributes") do
+      def decompose(attribute_name)
+        super(fixture_path("xlsx", "attributes.xlsx")).collect do |data|
+          data[attribute_name]
+        end
+      end
+
+      def test_title
+        assert_equal(["Title"], decompose("title"))
+      end
+
+      def test_author
+        assert_equal([nil], decompose("author"))
+      end
+
+      def test_subject
+        assert_equal(["Subject"], decompose("subject"))
+      end
+
+      def test_keywords
+        assert_equal(["Keyword1 Keyword2"], decompose("keywords"))
+      end
+
+      def test_created_time
+        assert_equal([Time],
+                     decompose("created_time").collect(&:class))
+      end
+
+      def test_modified_time
+        assert_equal([Time],
+                     decompose("modified_time").collect(&:class))
+      end
+
+      def test_application
+        assert_equal(["LibreOffice"],
+                     normalize_applications(decompose("application")))
+      end
+
+      def normalize_applications(applications)
+        applications.collect do |application|
+          normalize_application(application)
+        end
+      end
+
+      def normalize_application(application)
+        if application.start_with?("LibreOffice")
+          "LibreOffice"
+        else
+          application
+        end
+      end
+
+      def test_creation_date
+        assert_equal([nil], decompose("creation_date"))
+      end
+    end
+
+    sub_test_case("one sheet") do
+      def decompose
+        super(fixture_path("xlsx", "one-sheet.xlsx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Sheet1 - A1\tSheet1 - B1
+Sheet1 - A2\tSheet1 - B2
+        BODY
+      end
+    end
+
+    sub_test_case("multi sheets") do
+      def decompose
+        super(fixture_path("xlsx", "multi-sheets.xlsx"))
+      end
+
+      def test_body
+        assert_equal([<<-BODY], decompose.collect(&:body))
+Sheet1 - A1\tSheet1 - B1
+Sheet1 - A2\tSheet1 - B2
+
+Sheet2 - A1\tSheet2 - B1
+Sheet2 - A2\tSheet2 - B2
+
+Sheet3 - A1\tSheet3 - B1
+Sheet3 - A2\tSheet3 - B2
+        BODY
+      end
+    end
+  end
+end