chrono_model 0.13.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3f1a4af62a1e1fc9dd641e0ce9a4b10492678114
-  data.tar.gz: f5d6842907e806c741118b414f2072fa6ca480c7
+SHA256:
+  metadata.gz: 2697fea79973f57287cdb45ffa3bc3e5ecac4b3ad0c9b98b30ac77412a39727e
+  data.tar.gz: 2d683ca63fccf590d3f90e0196e8c3392e1033d726181a772ea80fba9acb8515
 SHA512:
-  metadata.gz: ecc295d770d70dab6b4be67e7473039adf621c5017cd71c9c51b906d797bf58f4683a6631abaac8b5651eb663e37364797f0f30928497ef292a76e04c0f0dd8d
-  data.tar.gz: 4663026045406c0aeabfe0bc4e0ab4976d461b42359476e5bd3967e9c905f6804532c090524c704655ec707385eb9ec3f0fbafd09aade63ee8203649c71898e6
+  metadata.gz: fbe2f67c78f27a89c007007dcf2b29e40ddafee336191be41fa05e40cea2f0cc5bbf0c509c46facc756ff03f212b203b4f7824ce8ec7e7d376610f1b03797204
+  data.tar.gz: 89f588e6b34b4b841e2a6f1b5bda6d7c9ee55a497134d738be53e9c08db6f3bef87a061421860524ada85f370e1c1e492ef0b54488cfda5bacdfe7eb84277de6

data/.travis.yml

@@ -1,17 +1,17 @@
 rvm:
-  - 2.2.7
   - 2.3
   - 2.4
+  - 2.5
 
 gemfile:
-  - gemfiles/rails_4.2.gemfile
   - gemfiles/rails_5.0.gemfile
   - gemfiles/rails_5.1.gemfile
+  - gemfiles/rails_5.2.gemfile
 
-matrix:
-  exclude:
-    - rvm: 2.4
-      gemfile: gemfiles/rails_4.2.gemfile
+#matrix:
+#  exclude:
+#    - rvm: 2.4
+#      gemfile: gemfiles/rails_4.2.gemfile
 
 sudo: false
 
@@ -19,9 +19,9 @@ language: ruby
 cache: bundler
 
 addons:
-  postgresql: "9.4"
+  postgresql: "9.6"
   apt:
-    packages: postgresql-plpython-9.4
+    packages: postgresql-plpython-9.6
   code_climate:
     repo_token: dedfb7472ee410eec459bff3681d9a8fd8dd237e9bd7e8675a7c8eb7e253bba9
 

data/README.md

@@ -65,8 +65,8 @@ All timestamps are _forcibly_ stored in as UTC, bypassing the
 
 ## Requirements
 
-* Ruby >= 2.2 (1.9 to 2.1 could still work, but aren't supported).
-* Active Record 4.2, 5.0 or 5.1. NOTE: AR 4.2 is not compatible with Ruby 2.4. [Detailed matrix](https://travis-ci.org/ifad/chronomodel)
+* Ruby >= 2.3
+* Active Record >= 5.0. See the [detailed supported versions matrix on travis](https://travis-ci.org/ifad/chronomodel)
 * PostgreSQL >= 9.3
 * The `btree_gist` PostgreSQL extension
 * The `plpython` PostgreSQL extension if you have *JSON* (*not* JSONB) columns

data/chrono_model.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = ChronoModel::VERSION
 
-  gem.add_dependency 'activerecord', '>= 4.2.0', '< 5.2.0'
+  gem.add_dependency 'activerecord', '>= 5.0.0'
   gem.add_dependency "pg"
   gem.add_dependency "multi_json"
 

data/gemfiles/rails_5.0.gemfile

@@ -2,6 +2,5 @@ source "https://rubygems.org"
 
 gem "activerecord", "~> 5.0.0"
 gem "rails", "~> 5.0.0"
-gem "pg", "~> 0.18"
 
 gemspec :path => "../"

data/gemfiles/rails_5.1.gemfile

@@ -2,6 +2,5 @@ source "https://rubygems.org"
 
 gem "activerecord", "~> 5.1.0"
 gem "rails", "~> 5.1.0"
-gem "pg", "~> 0.18"
 
 gemspec :path => "../"

data/gemfiles/rails_5.2.gemfile

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+gem "activerecord", "~> 5.2.0"
+gem "rails", "~> 5.2.0"
+
+gemspec :path => "../"

data/lib/active_record/connection_adapters/chronomodel_adapter.rb

@@ -17,11 +17,7 @@ module ActiveRecord
       conn_params[:dbname] = conn_params.delete(:database) if conn_params[:database]
 
       # Forward only valid config params to PG::Connection.connect.
-      valid_conn_param_keys = if ActiveRecord::VERSION::MAJOR == 4
-                                VALID_CONN_PARAMS
-                              else
-                                PG::Connection.conndefaults_hash.keys + [:requiressl]
-                              end
+      valid_conn_param_keys = PG::Connection.conndefaults_hash.keys + [:requiressl]
       conn_params.slice!(*valid_conn_param_keys)
 
       # The postgres drivers don't allow the creation of an unconnected PG::Connection object,

data/lib/chrono_model/adapter.rb

@@ -35,8 +35,8 @@ module ChronoModel
       return super unless options[:temporal]
 
       if options[:id] == false
-        logger.warn "WARNING - Temporal Temporal tables require a primary key."
-        logger.warn "WARNING - Creating a \"__chrono_id\" primary key to fulfill the requirement"
+        logger.warn "ChronoModel: Temporal Temporal tables require a primary key."
+        logger.warn "ChronoModel: Adding a `__chrono_id' primary key to #{table_name} definition."
 
         options[:id] = '__chrono_id'
       end
@@ -511,7 +511,7 @@ module ChronoModel
       end
     end
 
-    def initialize_type_map(type_map)
+    def initialize_type_map(m = type_map)
       super.tap do
         ar_type = type_map.fetch(TSRange::OID)
         cm_type = TSRange.new(ar_type.subtype, ar_type.type)
@@ -601,7 +601,7 @@ module ChronoModel
               upgrade_from_legacy(table_name)
               logger.info "ChronoModel: legacy #{table_name} upgrade complete"
             else
-              logger.info "ChronoModel: upgrading #{table_name} from #{desc[:version]} to #{VERSION}"
+              logger.info "ChronoModel: upgrading #{table_name} from #{version} to #{VERSION}"
               chrono_create_view_for(table_name)
               logger.info "ChronoModel: #{table_name} upgrade complete"
             end

data/lib/chrono_model/patches.rb

@@ -6,8 +6,6 @@ module ChronoModel
     module AsOfTimeHolder
       # Sets the virtual 'as_of_time' attribute to the given time, converting to UTC.
       #
-      # See ChronoModel::Patches::AsOfTimeHolder
-      #
       def as_of_time!(time)
         @_as_of_time = time.utc
 
@@ -16,14 +14,12 @@ module ChronoModel
 
       # Reads the virtual 'as_of_time' attribute
       #
-      # See ChronoModel::Patches::AsOfTimeHolder
-      #
       def as_of_time
         @_as_of_time
       end
     end
 
-    # This class supports the AR 4.2 code that expects to receive an
+    # This class supports the AR 5.0 code that expects to receive an
     # Arel::Table as the left join node. We need to replace the node
     # with a virtual table that fetches from the history at a given
     # point in time, we replace the join node with a SqlLiteral node
@@ -65,7 +61,7 @@ module ChronoModel
         super.as_of_time!(@_as_of_time)
       end
 
-      def build_arel
+      def build_arel(*)
         return super unless @_as_of_time
 
         super.tap do |arel|
@@ -85,11 +81,27 @@ module ChronoModel
         end
       end
 
-      # Build a preloader at the +as_of_time+ of this relation
+      # Build a preloader at the +as_of_time+ of this relation.
+      # Pass the current model to define Relation
       #
       def build_preloader
-        options = as_of_time ? {as_of_time: as_of_time} : {}
-        ActiveRecord::Associations::Preloader.new(options)
+        ActiveRecord::Associations::Preloader.new(
+          model: self.model, as_of_time: as_of_time
+        )
+      end
+    end
+
+    # This class is a dummy relation whose scope is only to pass around the
+    # as_of_time parameters across ActiveRecord call chains.
+    #
+    # With AR 5.2 a simple relation can be used, as the only required argument
+    # is the model. 5.0 and 5.1 require more arguments, that are passed here.
+    #
+    class AsOfTimeRelation < ActiveRecord::Relation
+      if ActiveRecord::VERSION::STRING.to_f < 5.2
+        def initialize(klass, table: klass.arel_table, predicate_builder: klass.predicate_builder, values: {})
+          super(klass, table, predicate_builder, values)
+        end
       end
     end
 
@@ -107,13 +119,6 @@ module ChronoModel
         @options = options.freeze
       end
 
-      # See +ActiveRecord::Associations::Preloader::NULL_RELATION+
-      NULL_RELATION = ActiveRecord::Associations::Preloader::NULL_RELATION
-
-      # Extend +NULL_RELATION+ by adding the +as_of_time!+ method.
-      # See +preload+ and +AsOfTimeHolder+.
-      NULL_RELATION.class.instance_eval { include AsOfTimeHolder }
-
       # Patches the AR Preloader (lib/active_record/associations/preloader.rb)
       # in order to carry around the +as_of_time+ of the original invocation.
       #
@@ -128,22 +133,18 @@ module ChronoModel
       # around the +as_of_time+ of the original query invocation, so that
       # preloaded records are preloaded honoring the +as_of_time+.
       #
-      # The +preload_scope+ is not nil only for through associations, but the
+      # The +preload_scope+ is present only in through associations, but the
       # preloader interfaces expect it to be always defined, for consistency.
       #
-      # So, AR defines a +NULL_RELATION+ constant to pass around for the
-      # association types that do not have a preload_scope. It quacks like a
-      # Relation, and it contains only the methods that are used by the other
-      # preloader methods. We use this +NULL_RELATION+ to which we have added
-      # the `as_of_time!` holder method.
-      #
       # For `:through` associations, the +given_preload_scope+ is already a
       # +Relation+, that already has the +as_of_time+ getters and setters,
       # so we use it directly.
       #
       def preload(records, associations, given_preload_scope = nil)
-        if options.key?(:as_of_time)
-          preload_scope = given_preload_scope || NULL_RELATION.dup
+        if options[:as_of_time]
+          preload_scope = given_preload_scope ||
+            AsOfTimeRelation.new(options[:model])
+
           preload_scope.as_of_time!(options[:as_of_time])
         end
 
@@ -152,13 +153,13 @@ module ChronoModel
 
       module Association
         # Builds the preloader scope taking into account a potential
-        # +as_of_time+ set above in +Preloader#preload+ and coming from the
-        # user's query invocation.
+        # +as_of_time+ passed down the call chain starting at the
+        # end user invocation.
         #
         def build_scope
           scope = super
 
-          if preload_scope.respond_to?(:as_of_time) && preload_scope.as_of_time
+          if preload_scope.try(:as_of_time)
             scope = scope.as_of(preload_scope.as_of_time)
           end
 
@@ -176,7 +177,7 @@ module ChronoModel
     # on the join model's (:through association) one.
     #
     module Association
-      def skip_statement_cache?
+      def skip_statement_cache?(*)
         super || _chrono_target?
       end
 

data/lib/chrono_model/time_machine.rb

@@ -9,8 +9,8 @@ module ChronoModel
 
     included do
       if table_exists? && !chrono?
-        puts "WARNING: #{table_name} is not a temporal table. " \
-          "Please use change_table :#{table_name}, :temporal => true"
+        puts  "ChronoModel: #{table_name} is not a temporal table. " \
+          "Please use `change_table :#{table_name}, temporal: true` in a migration."
       end
 
       history = TimeMachine.define_history_model_for(self)
@@ -54,7 +54,7 @@ module ChronoModel
 
         extend TimeMachine::HistoryMethods
 
-        scope :chronological, -> { order('lower(validity)') }
+        scope :chronological, -> { order(Arel.sql('lower(validity) ASC')) }
 
         # The history id is `hid`, but this cannot set as primary key
         # or temporal assocations will break. Solutions are welcome.
@@ -85,30 +85,16 @@ module ChronoModel
           with_hid_pkey { super }
         end
 
-        if RUBY_VERSION.to_f < 2.0
-          # PLEASE UPDATE YOUR RUBY <3
-          #
-          def save_with_pkey(*)
-            self.class.with_hid_pkey { save_without_pkey }
-          end
-
-          def save_with_pkey!(*)
-            self.class.with_hid_pkey { save_without_pkey! }
-          end
-
-          alias_method_chain :save, :pkey
-        else
-          def save(*)
-            self.class.with_hid_pkey { super }
-          end
+        def save(*)
+          self.class.with_hid_pkey { super }
+        end
 
-          def save!(*)
-            self.class.with_hid_pkey { super }
-          end
+        def save!(*)
+          self.class.with_hid_pkey { super }
+        end
 
-          def update_columns(*)
-            self.class.with_hid_pkey { super }
-          end
+        def update_columns(*)
+          self.class.with_hid_pkey { super }
         end
 
         # Returns the previous history entry, or nil if this
@@ -271,10 +257,13 @@ module ChronoModel
     #
     def pred(options = {})
       if self.class.timeline_associations.empty?
-        history.order('upper(validity) DESC').offset(1).first
+        history.order(Arel.sql('upper(validity) DESC')).offset(1).first
       else
         return nil unless (ts = pred_timestamp(options))
-        self.class.as_of(ts).order(%[ LOWER(#{options[:table] || self.class.quoted_table_name}."validity") DESC ]).find(options[:id] || id)
+
+        order_clause = Arel.sql %[ LOWER(#{options[:table] || self.class.quoted_table_name}."validity") DESC ]
+
+        self.class.as_of(ts).order(order_clause).find(options[:id] || id)
       end
     end
 
@@ -284,9 +273,9 @@ module ChronoModel
     def pred_timestamp(options = {})
       if historical?
         options[:before] ||= as_of_time
-        timeline(options.merge(:limit => 1, :reverse => true)).first
+        timeline(options.merge(limit: 1, reverse: true)).first
       else
-        timeline(options.merge(:limit => 2, :reverse => true)).second
+        timeline(options.merge(limit: 2, reverse: true)).second
       end
     end
 
@@ -295,7 +284,10 @@ module ChronoModel
     def succ(options = {})
       unless self.class.timeline_associations.empty?
         return nil unless (ts = succ_timestamp(options))
-        self.class.as_of(ts).order(%[ LOWER(#{options[:table] || self.class.quoted_table_name}."validity"_ DESC ]).find(options[:id] || id)
+
+        order_clause = Arel.sql %[ LOWER(#{options[:table] || self.class.quoted_table_name}."validity"_ DESC ]
+
+        self.class.as_of(ts).order(order_clause).find(options[:id] || id)
       end
     end
 
@@ -306,7 +298,7 @@ module ChronoModel
       return nil unless historical?
 
       options[:after] ||= as_of_time
-      timeline(options.merge(:limit => 1, :reverse => false)).first
+      timeline(options.merge(limit: 1, reverse: false)).first
     end
 
     # Returns the current history version
@@ -444,9 +436,9 @@ module ChronoModel
 
         def build_time_query(time, range, op = '&&')
           if time.kind_of?(Array)
-            %[ #{range.type}(#{time.first}, #{time.last}) #{op} #{table_name}.#{range.name} ]
+            Arel.sql %[ #{range.type}(#{time.first}, #{time.last}) #{op} #{table_name}.#{range.name} ]
           else
-            %[ #{time} <@ #{table_name}.#{range.name} ]
+            Arel.sql %[ #{time} <@ #{table_name}.#{range.name} ]
           end
         end
     end
@@ -513,7 +505,7 @@ module ChronoModel
       # Returns the history sorted by recorded_at
       #
       def sorted
-        all.order(%[ #{quoted_table_name}."recorded_at", #{quoted_table_name}."hid" ])
+        all.order(Arel.sql(%[ #{quoted_table_name}."recorded_at" ASC, #{quoted_table_name}."hid" ASC ]))
       end
 
       # Fetches the given +object+ history, sorted by history record time

data/lib/chrono_model/version.rb

@@ -1,3 +1,3 @@
 module ChronoModel
-  VERSION = "0.13.2"
+  VERSION = "1.0.0"
 end

data/spec/aruba/migrations_spec.rb

@@ -5,10 +5,10 @@ describe 'database migrations', type: :aruba do
     before { write_file('config/database.yml',
       File.read(File.expand_path('fixtures/database_without_username_and_password.yml', __dir__))) }
 
-    before { run_simple('bundle exec rails g migration CreateModels name:string') }
+    before { run_command_and_stop('bundle exec rails g migration CreateModels name:string') }
 
     describe 'bundle exec rake db:migrate' do
-      let(:action) { run('bundle exec rake db:migrate') }
+      let(:action) { run_command('bundle exec rake db:migrate') }
       let(:last_command) { action && last_command_started }
 
       specify { expect(last_command).to be_successfully_executed }
@@ -30,21 +30,7 @@ describe 'database migrations', type: :aruba do
       )
     end
 
-    before do
-      # Alter migrations and remove the version specifier for Rails < 5.0
-      #
-      if gem_version('rails') < Gem::Version.new('5.0')
-        Dir['spec/aruba/fixtures/migrations/56/*rb'].each do |migration|
-          migration = File.basename(migration)
-
-          file_mangle! "db/migrate/#{migration}" do |contents|
-            contents.sub(/::Migration\[\d\.\d\]/, '::Migration')
-          end
-        end
-      end
-    end
-
-    let(:action) { run(command) }
+    let(:action) { run_command(command) }
     let(:regex) { /-- change_table\(:impressions, {:temporal=>true, :copy_data=>true}\)/ }
 
     describe 'once' do
@@ -54,7 +40,7 @@ describe 'database migrations', type: :aruba do
     end
 
     describe 'twice' do
-      let(:last_command) { run_simple(command) && action && last_command_started }
+      let(:last_command) { run_command_and_stop(command) && action && last_command_started }
       specify { expect(last_command).to be_successfully_executed }
       specify { expect(last_command).to have_output(regex) }
     end

data/spec/aruba/rake_task_spec.rb

@@ -5,14 +5,14 @@ require 'spec_helper'
 #
 describe 'rake tasks', type: :aruba do
   describe 'bundle exec rake -T' do
-    before { run_simple('bundle exec rake -T') }
+    before { run_command_and_stop('bundle exec rake -T') }
     subject { last_command_started }
 
     it { is_expected.to have_output(/db:structure:load/) }
   end
 
   describe 'db:structure:load' do
-    let(:action) { run('bundle exec rake db:structure:load') }
+    let(:action) { run_command('bundle exec rake db:structure:load') }
     let(:last_command) { action && last_command_started }
 
     context 'given a file db/structure.sql' do
@@ -51,7 +51,7 @@ describe 'rake tasks', type: :aruba do
     let(:database_yml) { 'fixtures/database_without_username_and_password.yml' }
     before { write_file('config/database.yml', File.read(File.expand_path(database_yml, __dir__))) }
 
-    before { run_simple('bundle exec rake db:data:dump DUMP=db/test.sql') }
+    before { run_command_and_stop('bundle exec rake db:data:dump DUMP=db/test.sql') }
 
     it { expect(last_command_started).to be_successfully_executed }
     it { expect('db/test.sql').to be_an_existing_file }
@@ -64,7 +64,7 @@ describe 'rake tasks', type: :aruba do
     let(:structure_sql) { 'fixtures/empty_structure.sql' }
     before { write_file('db/test.sql', File.read(File.expand_path(structure_sql, __dir__))) }
 
-    before { run_simple('bundle exec rake db:data:load DUMP=db/test.sql') }
+    before { run_command_and_stop('bundle exec rake db:data:load DUMP=db/test.sql') }
 
     it { expect(last_command_started).to be_successfully_executed }
   end

data/spec/json_ops_spec.rb

@@ -14,11 +14,11 @@ describe 'JSON equality operator' do
     ChronoModel::Json.drop
   end
 
-  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a":1}'::json ])).to eq AR_TRUE }
-  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a" : 1}'::json ])).to eq AR_TRUE }
-  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a":2}'::json ])).to eq AR_FALSE }
-  it { expect(adapter.select_value(%[ SELECT '{"a":1,"b":2}'::json = '{"b":2,"a":1}'::json ])).to eq AR_TRUE }
-  it { expect(adapter.select_value(%[ SELECT '{"a":1,"b":2,"x":{"c":4,"d":5}}'::json = '{"b":2, "x": { "d": 5, "c": 4}, "a":1}'::json ])).to eq AR_TRUE }
+  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a":1}'::json ])).to eq true }
+  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a" : 1}'::json ])).to eq true }
+  it { expect(adapter.select_value(%[ SELECT '{"a":1}'::json = '{"a":2}'::json ])).to eq false }
+  it { expect(adapter.select_value(%[ SELECT '{"a":1,"b":2}'::json = '{"b":2,"a":1}'::json ])).to eq true }
+  it { expect(adapter.select_value(%[ SELECT '{"a":1,"b":2,"x":{"c":4,"d":5}}'::json = '{"b":2, "x": { "d": 5, "c": 4}, "a":1}'::json ])).to eq true }
 
   context 'on a temporal table' do
     before :all do

data/spec/spec_helper.rb

@@ -17,9 +17,6 @@ require 'support/aruba'
 
 puts "Testing against Active Record #{ActiveRecord::VERSION::STRING} with Arel #{Arel::VERSION}"
 
-# Rails 5 returns a True/FalseClass
-AR_TRUE, AR_FALSE  = ActiveRecord::VERSION::MAJOR == 4 ? ['t', 'f'] : [true, false]
-
 RSpec.configure do |config|
   config.include(ChronoTest::Matchers::Schema)
   config.include(ChronoTest::Matchers::Table)

data/spec/support/aruba.rb

@@ -40,10 +40,5 @@ module ChronoTest
       # Write
       write_file file, file_contents
     end
-
-    def gem_version(name)
-      spec = Bundler.locked_gems.specs.find {|s| s.name == name }
-      return spec.version if spec
-    end
   end
 end

data/spec/support/matchers/function.rb

@@ -31,7 +31,7 @@ module ChronoTest::Matchers
 
       protected
         def has_function?(name)
-          select_value(<<-SQL, [name], 'Check function') == AR_TRUE
+          select_value(<<-SQL, [name], 'Check function') == true
             SELECT EXISTS(
               SELECT 1
               FROM pg_catalog.pg_proc p, pg_catalog.pg_namespace n

data/spec/support/matchers/table.rb

@@ -12,7 +12,7 @@ module ChronoTest::Matchers
           schema = options[:in]
           kind   = options[:kind] == :view ? 'v' : 'r'
 
-          select_value(<<-SQL, [ table, schema ], 'Check table exists') == AR_TRUE
+          select_value(<<-SQL, [ table, schema ], 'Check table exists') == true
             SELECT EXISTS (
               SELECT 1
                 FROM pg_class c
@@ -129,7 +129,7 @@ module ChronoTest::Matchers
         def inherits_from_temporal?
           binds = ["#{history_schema}.#{table}", "#{temporal_schema}.#{table}"]
 
-          @inheritance = select_value(<<-SQL, binds, 'Check inheritance') == AR_TRUE
+          @inheritance = select_value(<<-SQL, binds, 'Check inheritance') == true
             SELECT EXISTS (
               SELECT 1 FROM pg_catalog.pg_inherits
                WHERE inhrelid  = ?::regclass::oid
@@ -172,7 +172,7 @@ module ChronoTest::Matchers
             attname:      connection.primary_key(table)
           }
 
-          @constraint = select_value(<<-SQL, binds, 'Check Consistency Constraint') == AR_TRUE
+          @constraint = select_value(<<-SQL, binds, 'Check Consistency Constraint') == true
             SELECT EXISTS (
               SELECT 1 FROM pg_catalog.pg_constraint
               WHERE conname = :conname

data/spec/time_machine_spec.rb

@@ -304,7 +304,7 @@ describe ChronoModel::TimeMachine do
 
     context '.sorted' do
       describe 'orders by recorded_at, hid' do
-        it { expect(foo.history.sorted.to_sql).to match(/order by .+"recorded_at", .+"hid"/i) }
+        it { expect(foo.history.sorted.to_sql).to match(/order by .+"recorded_at" ASC, .+"hid" ASC/i) }
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chrono_model
 version: !ruby/object:Gem::Version
-  version: 0.13.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Marcello Barnaba
@@ -17,20 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -217,9 +211,9 @@ files:
 - README.sql
 - Rakefile
 - chrono_model.gemspec
-- gemfiles/rails_4.2.gemfile
 - gemfiles/rails_5.0.gemfile
 - gemfiles/rails_5.1.gemfile
+- gemfiles/rails_5.2.gemfile
 - lib/active_record/connection_adapters/chronomodel_adapter.rb
 - lib/active_record/tasks/chronomodel_database_tasks.rb
 - lib/chrono_model.rb
@@ -278,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Temporal extensions (SCD Type II) for Active Record

data/gemfiles/rails_4.2.gemfile

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gem "activerecord", "~> 4.2.0"
-gem "rails", "~> 4.2.0"
-gem "pg", "~> 0.18"
-
-gemspec :path => "../"