chrono_model 0.12.2 → 0.12.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69a13f407cf20b6ffbf08382a831c49085158b7d
-  data.tar.gz: 9461316b8a2b3b0498e8d1fc8dc45b15e5492905
+  metadata.gz: 867208c8ba66191c8cf3bdebbc9eb4d811d59625
+  data.tar.gz: 4651e58743b71d6cb54bba59929fec7c10ae80ac
 SHA512:
-  metadata.gz: 81ef0ab38b9d33cd457bd33c869128e480d2493120e66fe50624aae94a8a6899df462285ec8003f5f9413f5ccf6d362b53699f20cc5be3b83d9d92ccbdcb65bb
-  data.tar.gz: e3673608283f66ecb82808f9b4ee64e7da9c7c76a44e297e826284755607e38194ebf2a8aad12bbd92bbb5ac7cd91c5d11fb91b72dabd2431671cc22307914b4
+  metadata.gz: 5dd88e44a1fedb1bb33199f2483c7d008fda05c753510d74b0fdb1fd9a2966138a0838b68d08d8e088d8e6bd36c50588f76357d327a966f6af68abc520ccbc6e
+  data.tar.gz: 297be09d1673a4235bc3168fdfdf087612740790d33ca99b0eff033f24738536854ff7044f024a1b86df9da84c5fdb1e43cd9e90da2e212c2e02c5ce39bc475d

data/README.md

@@ -66,7 +66,7 @@ All timestamps are _forcibly_ stored in as UTC, bypassing the
 ## Requirements
 
 * Ruby >= 2.2 (1.9 to 2.1 could still work, but aren't supported).
-* Active Record 4.2 or 5.0 (4.2 doesn't work with Ruby 2.4, though)
+* Active Record 4.2, 5.0 or 5.1. NOTE: AR 4.2 is not compatible with Ruby 2.4. [Detailed matrix](https://travis-ci.org/ifad/chronomodel)
 * PostgreSQL >= 9.3
 * The `btree_gist` PostgreSQL extension
 * The `plpython` PostgreSQL extension if you have *JSON* (*not* JSONB) columns

data/lib/chrono_model/adapter.rb

@@ -106,9 +106,7 @@ module ChronoModel
 
         # Drop functions
         #
-        %w( insert update delete ).each do |func|
-          execute "DROP FUNCTION chronomodel_#{name}_#{func}()"
-        end
+        chrono_drop_trigger_functions_for(name)
 
         # Create view and functions
         #
@@ -168,11 +166,7 @@ module ChronoModel
             #
             execute "DROP VIEW #{table_name}"
 
-            _on_temporal_schema do
-              %w( insert update delete ).each do |func|
-                execute "DROP FUNCTION IF EXISTS #{table_name}_#{func}() CASCADE"
-              end
-            end
+            chrono_drop_trigger_functions_for(table_name)
 
             _on_history_schema { execute "DROP TABLE #{table_name}" }
 
@@ -198,6 +192,8 @@ module ChronoModel
       return super unless is_chrono?(table_name)
 
       _on_temporal_schema { execute "DROP TABLE #{table_name} CASCADE" }
+
+      chrono_drop_trigger_functions_for(table_name)
     end
 
     # If adding an index to a temporal table, add it to the one in the
@@ -852,6 +848,12 @@ module ChronoModel
         SQL
       end
 
+      def chrono_drop_trigger_functions_for(table_name)
+        %w( insert update delete ).each do |func|
+          execute "DROP FUNCTION IF EXISTS chronomodel_#{table_name}_#{func}()"
+        end
+      end
+
       # In destructive changes, such as removing columns or changing column
       # types, the view must be dropped and recreated, while the change has
       # to be applied to the table in the temporal schema.

data/lib/chrono_model/version.rb

@@ -1,3 +1,3 @@
 module ChronoModel
-  VERSION = "0.12.2"
+  VERSION = "0.12.3"
 end

data/spec/adapter_spec.rb

@@ -9,6 +9,7 @@ shared_examples_for 'temporal table' do
   it { is_expected.to have_temporal_backing }
   it { is_expected.to have_history_backing }
   it { is_expected.to have_history_extra_columns }
+  it { is_expected.to have_history_functions }
   it { is_expected.to have_public_interface }
 
   it { is_expected.to have_columns(columns) }
@@ -23,6 +24,7 @@ shared_examples_for 'plain table' do
 
   it { is_expected.to_not have_temporal_backing }
   it { is_expected.to_not have_history_backing }
+  it { is_expected.to_not have_history_functions }
   it { is_expected.to_not have_public_interface }
 
   it { is_expected.to have_columns(columns) }
@@ -168,6 +170,7 @@ describe ChronoModel::Adapter do
     it { is_expected.to_not have_public_backing }
     it { is_expected.to_not have_temporal_backing }
     it { is_expected.to_not have_history_backing }
+    it { is_expected.to_not have_history_functions }
     it { is_expected.to_not have_public_interface }
   end
 

data/spec/spec_helper.rb

@@ -10,6 +10,7 @@ require 'support/matchers/schema'
 require 'support/matchers/table'
 require 'support/matchers/column'
 require 'support/matchers/index'
+require 'support/matchers/function'
 require 'support/aruba'
 
 # Rails 5 returns a True/FalseClass

data/spec/support/matchers/function.rb

@@ -0,0 +1,79 @@
+module ChronoTest::Matchers
+
+  module Column
+    class HaveFunctions < ChronoTest::Matchers::Base
+      def initialize(functions, schema = 'public')
+        @functions = functions
+        @schema    = schema
+      end
+
+      def description
+        'have functions'
+      end
+
+      def matches?(table)
+        super(table)
+
+        @matches = @functions.inject({}) do |h, name|
+          h.update(name => has_function?(name))
+        end
+
+        @matches.values.all?
+      end
+
+      def failure_message
+        message_matches("expected #{@schema}.#{table} to have")
+      end
+
+      def failure_message_when_negated
+        message_matches("expected #{@schema}.#{table} to not have")
+      end
+
+      protected
+        def has_function?(name)
+          select_value(<<-SQL, [name], 'Check function') == AR_TRUE
+            SELECT EXISTS(
+              SELECT 1
+              FROM pg_catalog.pg_proc p, pg_catalog.pg_namespace n
+              WHERE p.pronamespace = n.oid
+                AND n.nspname = 'public'
+                AND p.proname = ?
+            )
+          SQL
+        end
+
+      private
+        def message_matches(message)
+          (message << ' ').tap do |message|
+            message << @matches.map do |name, match|
+              "a #{name} function"
+            end.compact.to_sentence
+          end
+        end
+    end
+
+    def have_functions(*args)
+      HaveFunctions.new(*args)
+    end
+
+    class HaveHistoryFunctions < HaveFunctions
+      def initialize
+        @function_templates = [
+          'chronomodel_%s_insert',
+          'chronomodel_%s_update',
+          'chronomodel_%s_delete',
+        ]
+      end
+
+      def matches?(table)
+        @functions = @function_templates.map {|t| t % [table] }
+
+        super(table)
+      end
+    end
+
+    def have_history_functions
+      HaveHistoryFunctions.new
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chrono_model
 version: !ruby/object:Gem::Version
-  version: 0.12.2
+  version: 0.12.3
 platform: ruby
 authors:
 - Marcello Barnaba
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-21 00:00:00.000000000 Z
+date: 2018-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -250,6 +250,7 @@ files:
 - spec/support/helpers.rb
 - spec/support/matchers/base.rb
 - spec/support/matchers/column.rb
+- spec/support/matchers/function.rb
 - spec/support/matchers/index.rb
 - spec/support/matchers/schema.rb
 - spec/support/matchers/table.rb
@@ -302,6 +303,7 @@ test_files:
 - spec/support/helpers.rb
 - spec/support/matchers/base.rb
 - spec/support/matchers/column.rb
+- spec/support/matchers/function.rb
 - spec/support/matchers/index.rb
 - spec/support/matchers/schema.rb
 - spec/support/matchers/table.rb