chrono_model 0.12.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 514bcdaa49d7f8ca35bb422ea3fb47b5f11bfbd4
-  data.tar.gz: af83cb212905b691d0c0ab43e9bf38306a089819
+  metadata.gz: 7bf80e2ead7e4bd268485039492504007f1bef1d
+  data.tar.gz: ec80e086d0723533e8f7bb06e78ec58e1a9edd39
 SHA512:
-  metadata.gz: 96b7a8b00ca96174c66499824b801f9ec50f4644ee0a65adc37fc8a3e0fc57188172cb0e72563800c94b0e82c860af6d1137eb24948f169ce99191f476f5257b
-  data.tar.gz: 1078c39fdab5c0af049df0eddbe7832055e72b872cec07d87d43d205ac1ccca44a3c8c8cb5cf5f9876f9a025a20109060b36541ef5354ed0410961c583ba586e
+  metadata.gz: eea3f10b7f18fd38718716ef4c90fc3a65ac4e789a6ae6a888080d655a1b2fae6761830242cf03bb911e9e7f090706c66ddf71bab20b76fb2f76ff3a68caf25e
+  data.tar.gz: fa5936bc34ca7820eefceb3064af13c12d5e323f0f8bede5e01062936b5ae7003bbe104b162a61469e95825a2b74b1580e05a21e5591dd537185842bb75d50d8

data/.gitignore

@@ -5,6 +5,7 @@
 .yardoc
 .byebug_history
 Gemfile.lock
+gemfiles/*.lock
 InstalledFiles
 _yardoc
 coverage

data/lib/chrono_model/adapter.rb

@@ -46,8 +46,6 @@ module ChronoModel
         _on_history_schema { chrono_create_history_for(table_name) }
 
         chrono_create_view_for(table_name, options)
-
-        TableCache.add! table_name
       end
     end
 
@@ -115,9 +113,6 @@ module ChronoModel
         # Create view and functions
         #
         chrono_create_view_for(new_name)
-
-        TableCache.del! name
-        TableCache.add! new_name
       end
     end
 
@@ -148,8 +143,6 @@ module ChronoModel
             chrono_create_view_for(table_name, options)
             copy_indexes_to_history_for(table_name)
 
-            TableCache.add! table_name
-
             # Optionally copy the plain table data, setting up history
             # retroactively.
             #
@@ -191,8 +184,6 @@ module ChronoModel
 
               execute "ALTER TABLE #{table_name} SET SCHEMA #{default_schema}"
             end
-
-            TableCache.del! table_name
           end
 
           super table_name, options, &block
@@ -207,8 +198,6 @@ module ChronoModel
       return super unless is_chrono?(table_name)
 
       _on_temporal_schema { execute "DROP TABLE #{table_name} CASCADE" }
-
-      TableCache.del! table_name
     end
 
     # If adding an index to a temporal table, add it to the one in the
@@ -452,20 +441,11 @@ module ChronoModel
       @_on_schema_nesting -= 1
     end
 
-    TableCache = (Class.new(Hash) do
-      def all         ; keys;                      ; end
-      def add!  table ; self[table.to_s] = true    ; end
-      def del!  table ; self[table.to_s] = nil     ; end
-      def fetch table ; self[table.to_s] ||= yield ; end
-    end).new
-
     # Returns true if the given name references a temporal table.
     #
     def is_chrono?(table)
-      TableCache.fetch(table) do
-        _on_temporal_schema { chrono_data_source_exists?(table) } &&
+      _on_temporal_schema { chrono_data_source_exists?(table) } &&
         _on_history_schema { chrono_data_source_exists?(table) }
-      end
 
     rescue ActiveRecord::StatementInvalid => e
       # means that we could not change the search path to check for

data/lib/chrono_model/version.rb

@@ -1,3 +1,3 @@
 module ChronoModel
-  VERSION = "0.12.0"
+  VERSION = "0.12.1"
 end

data/spec/aruba/fixtures/migrations/56/20160812190335_create_impressions.rb

@@ -0,0 +1,10 @@
+class CreateImpressions < ActiveRecord::Migration[5.0]
+  def change
+    create_table :impressions do |t|
+      t.integer :response
+      t.decimal :amount
+
+      t.timestamps
+    end
+  end
+end

data/spec/aruba/fixtures/migrations/56/20171115195229_add_temporal_extension_to_impressions.rb

@@ -0,0 +1,10 @@
+class AddTemporalExtensionToImpressions < ActiveRecord::Migration[5.0]
+  def self.up
+    enable_extension 'btree_gist' unless extension_enabled?('btree_gist')
+    change_table :impressions, temporal: true, copy_data: true
+  end
+
+  def self.down
+    change_table :impressions, temporal: false
+  end
+end

data/spec/aruba/fixtures/railsapp/config/environments/development.rb

@@ -12,25 +12,9 @@ Rails.application.configure do
   # Show full error reports.
   config.consider_all_requests_local = true
 
-  # Enable/disable caching. By default caching is disabled.
-  if Rails.root.join('tmp/caching-dev.txt').exist?
-    config.action_controller.perform_caching = true
-
-    config.cache_store = :memory_store
-    config.public_file_server.headers = {
-      'Cache-Control' => "public, max-age=#{2.days.seconds.to_i}"
-    }
-  else
-    config.action_controller.perform_caching = false
-
-    config.cache_store = :null_store
-  end
-
   # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
-  config.action_mailer.perform_caching = false
-
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 

data/spec/aruba/migrations_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
-describe 'database migrations' do
+describe 'database migrations', type: :aruba do
   context 'after a migration was generated' do
     before { write_file('config/database.yml',
       File.read(File.expand_path('fixtures/database_without_username_and_password.yml', __dir__))) }
 
     before { run_simple('bundle exec rails g migration CreateModels name:string') }
 
-    describe 'bundle exec rake db:migrate', type: :aruba do
+    describe 'bundle exec rake db:migrate' do
       let(:action) { run('bundle exec rake db:migrate') }
       let(:last_command) { action && last_command_started }
 
@@ -15,4 +15,48 @@ describe 'database migrations' do
       specify { expect(last_command).to have_output(/CreateModels: migrated/) }
     end
   end
+
+
+  describe 'rerun bundle exec rake db:drop db:create db:migrate', issue: 56 do
+    let(:command) { 'bundle exec rake db:drop db:create db:migrate' }
+    before do
+      copy(
+        '../../spec/aruba/fixtures/database_without_username_and_password.yml',
+        'config/database.yml'
+      )
+      copy(
+        '../../spec/aruba/fixtures/migrations/56/',
+        'db/migrate'
+      )
+    end
+
+    before do
+      # Alter migrations and remove the version specifier for Rails < 5.0
+      #
+      if gem_version('rails') < Gem::Version.new('5.0')
+        Dir['spec/aruba/fixtures/migrations/56/*rb'].each do |migration|
+          migration = File.basename(migration)
+
+          file_mangle! "db/migrate/#{migration}" do |contents|
+            contents.sub(/::Migration\[\d\.\d\]/, '::Migration')
+          end
+        end
+      end
+    end
+
+    let(:action) { run(command) }
+    let(:regex) { /-- change_table\(:impressions, {:temporal=>true, :copy_data=>true}\)/ }
+
+    describe 'once' do
+      let(:last_command) { action && last_command_started }
+      specify { expect(last_command).to be_successfully_executed }
+      specify { expect(last_command).to have_output(regex) }
+    end
+
+    describe 'twice' do
+      let(:last_command) { run_simple(command) && action && last_command_started }
+      specify { expect(last_command).to be_successfully_executed }
+      specify { expect(last_command).to have_output(regex) }
+    end
+  end
 end

data/spec/aruba/rake_task_spec.rb

@@ -30,10 +30,9 @@ describe 'rake tasks', type: :aruba do
         #
         before do
           if which 'brew'
-            database_config = read('config/database.yml').join("\n").
-              sub('username: postgres', "username: #{Etc.getlogin}")
-
-            write_file 'config/database.yml', database_config
+            file_mangle!('config/database.yml') do |contents|
+              contents.sub('username: postgres', "username: #{Etc.getlogin}")
+            end
           end
         end
 

data/spec/support/aruba.rb

@@ -29,5 +29,21 @@ module ChronoTest
       connection.drop_database   database
       connection.create_database database
     end
+
+    def file_mangle!(file, &block)
+      # Read
+      file_contents = read(file).join("\n")
+
+      # Mangle
+      file_contents = block.call(file_contents)
+
+      # Write
+      write_file file, file_contents
+    end
+
+    def gem_version(name)
+      spec = Bundler.locked_gems.specs.find {|s| s.name == name }
+      return spec.version if spec
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chrono_model
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.1
 platform: ruby
 authors:
 - Marcello Barnaba
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-16 00:00:00.000000000 Z
+date: 2017-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -234,6 +234,8 @@ files:
 - spec/aruba/fixtures/database_with_default_username_and_password.yml
 - spec/aruba/fixtures/database_without_username_and_password.yml
 - spec/aruba/fixtures/empty_structure.sql
+- spec/aruba/fixtures/migrations/56/20160812190335_create_impressions.rb
+- spec/aruba/fixtures/migrations/56/20171115195229_add_temporal_extension_to_impressions.rb
 - spec/aruba/fixtures/railsapp/config/application.rb
 - spec/aruba/fixtures/railsapp/config/boot.rb
 - spec/aruba/fixtures/railsapp/config/environments/development.rb
@@ -284,6 +286,8 @@ test_files:
 - spec/aruba/fixtures/database_with_default_username_and_password.yml
 - spec/aruba/fixtures/database_without_username_and_password.yml
 - spec/aruba/fixtures/empty_structure.sql
+- spec/aruba/fixtures/migrations/56/20160812190335_create_impressions.rb
+- spec/aruba/fixtures/migrations/56/20171115195229_add_temporal_extension_to_impressions.rb
 - spec/aruba/fixtures/railsapp/config/application.rb
 - spec/aruba/fixtures/railsapp/config/boot.rb
 - spec/aruba/fixtures/railsapp/config/environments/development.rb