chrono 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82628fe0ca33aeac8bd5b8f6d72d570a250e5636
-  data.tar.gz: 093720914965710dccca4dca1054616bc676e783
+  metadata.gz: 0d252cd6e02cae1bbb12c6a310402e15de067158
+  data.tar.gz: a8f41a68a6e85e74a05edc049cab7593f51e89e0
 SHA512:
-  metadata.gz: 2bdc77b1029f70e80ccde05ac6c5a3f4fe84d8e39d34c1484cf1b56a84580b0234e0e01b9b1604937d705c4241940f953565f5ff436a193cfb26f930b7339751
-  data.tar.gz: ff6f91a205265f49e78e208ada8f87f1c61d881d52c0bd9b6786eab1732944d8f72ce3fe1825327eacfa10f62507ca36a2cb92c11fbe709b6867bd1c41d95830
+  metadata.gz: 6e7cf6afc4ad77ade83fde6f5fea043dcfaa91167905cd2165e872840264f57395e93dbe22e11003568537b9998e90f42d0f066741b036b6dfac0fe57ce17f04
+  data.tar.gz: 29f662fa1ea7aa28d9e613e1bc73c80b6869662e003e52f92f5250e4c3da5c574b59d0829c4d16f478054db219f44723dcf405083d8c51435c31f811d6cec050

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0
+
+- Raise ArgumentError on inifinite loop detected (thx @nurse)
+
 ## 0.3.0
 - Fix bug on day and wday specs
 

data/lib/chrono/next_time.rb

@@ -21,7 +21,10 @@ module Chrono
     end
 
     def to_time
-      loop do
+      # the longest cycle is 4 years (leap year)
+      # Note that the combination of day-month and wday is OR
+      max_time = time + (365 * 3 + 366).days
+      while @time < max_time
         case
         when !scheduled_in_this_month?
           carry_month
@@ -32,9 +35,10 @@ module Chrono
         when !scheduled_in_this_minute?
           carry_minute
         else
-          break time
+          return @time
         end
       end
+      raise ArgumentError, "invalid cron string '#{@source}'"
     end
 
     private

data/lib/chrono/version.rb

@@ -1,3 +1,3 @@
 module Chrono
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/spec/chrono/iterator_spec.rb

@@ -24,27 +24,32 @@ describe Chrono::Iterator do
       "2000-01-01 00:20:00", "2000-01-01 01:01:00", "1-20/3 * * * *",
       "2000-01-01 00:00:00", "2000-01-03 00:00:00", "0 0 1,15 * 1",
       "2000-01-01 00:00:00", "2000-01-05 00:00:00", "0 0 5,15,25 * 5",
+      "2000-02-29 00:00:01", "2004-02-29 00:00:00", "0 0 29 2 *",
     ].each_slice(3) do |from, to, source|
       it "ticks #{from} to #{to} by #{source}" do
         now = Time.parse(from)
         expect(described_class.new(source, now: now).next).to eq(Time.parse(to))
       end
+    end
 
-      it 'raises error when empty range is given' do
-        expect { described_class.new('5-0 * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
-      end
+    it 'raises error when empty range is given' do
+      expect { described_class.new('5-0 * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
+    end
 
-      it 'raises error when too large upper is given' do
-        expect { described_class.new('5-60 * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
-      end
+    it 'raises error when too large upper is given' do
+      expect { described_class.new('5-60 * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
+    end
 
-      it 'raises error when too low lower is given' do
-        expect { described_class.new('* * 0 * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
-      end
+    it 'raises error when too low lower is given' do
+      expect { described_class.new('* * 0 * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
+    end
 
-      it 'raises error when unparsable field is given' do
-        expect { described_class.new('a-z * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
-      end
+    it 'raises error when unparsable field is given' do
+      expect { described_class.new('a-z * * * *').next }.to raise_error(Chrono::Fields::Base::InvalidField)
+    end
+
+    it 'raises error when unparsable field is given' do
+      expect { described_class.new('* * 31 11 *').next }.to raise_error(ArgumentError)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chrono
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-09 00:00:00.000000000 Z
+date: 2017-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -145,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Provides a chain of logics about chronology.
@@ -154,4 +154,3 @@ test_files:
 - spec/chrono/schedule_spec.rb
 - spec/chrono/trigger_spec.rb
 - spec/spec_helper.rb
-has_rdoc: