chromium-pdf 1.0.4 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00ca3cc4b98adc752f0fc922ef246c613acfb35f915edc90ffb551803ba17d8c
-  data.tar.gz: 6ac4d6928c6ef664e70b6429fa7b401a0b832a38cbdea17d94feaee3cefe7076
+  metadata.gz: afa7368ea8f9d35e2b64a1e8b19746e0197c5a78788693c6c8c193cf7a6b6095
+  data.tar.gz: bde5ed7f8ad0f0ef810466f9f3ff687e4087a6424acb9c01dff092e985a105ec
 SHA512:
-  metadata.gz: 547f1f46062417cdfa4d80da94ce0aa4b1134ebc1a619372380680ecd859861055d3f8aafcd9409bff129de212c8f37096bc07346bde7e21c5a221ae0d1c6528
-  data.tar.gz: dfc587b51a40b3ec10d122ddb3c5c2dda8c9fb4f4be346ae895211901fd0e69861b738f047319ebf77a85d08e68cf326b5b2dfe0a02da3b57693a5f9a806d9d3
+  metadata.gz: 6531912997d2a24850bb7d707d7464e71f26705a875e4ded22548e13310d55bf641c30d3cf28c73a00e2c87952e06dab1e9e6d8a17ed2c9eb9ca02bbc329e5a9
+  data.tar.gz: b3f8184f00a4a9f101a64d050a87708378227692614f806f26643d896d50ef10f3cad32d8c755499c9c2ff41415a67bae637443edca6b62735af783089b23eab

data/lib/chromium/pdf/version.rb

@@ -2,6 +2,6 @@
 
 module Chromium
   module Pdf
-    VERSION = '1.0.4'
+    VERSION = '1.0.6'
   end
 end

data/lib/chromium/pdf.rb

@@ -29,20 +29,26 @@ module Chromium
 
       Dir.mktmpdir do |path|
         filepath = "#{path}/#{filename}"
-        chrome_print(print_url, filename, filepath, arguments, &block)
+        chrome_print!(print_url, filepath, arguments)
+
+        File.open(filepath) do |file|
+          block&.call(file, filename)
+        end
       end
     end
 
     protected
 
-    def chrome_print(print_url, filename, filepath, arguments, &block)
+    def chrome_print!(print_url, pdf_path, arguments)
       chrome_path = ENV.fetch('GOOGLE_CHROME_BIN', 'chrome')
-      Kernel.system("LD_PRELOAD='' #{chrome_path} --print-to-pdf='#{filepath}' #{arguments.join(' ')} #{print_url}")
-      sleep 0.1 until file_created?(filepath)
-
-      File.open(filepath) do |file|
-        block&.call(file, filename)
-      end
+      Kernel.system(
+        { 'LD_PRELOAD' => '' },
+        chrome_path,
+        *arguments,
+        "--print-to-pdf=#{pdf_path}",
+        print_url,
+        exception: true
+      )
     end
 
     def file_created?(filepath)

data/lib/generators/chromium/pdf/install/templates/app/jobs/generate_pdf_job.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 class GeneratePdfJob < ApplicationJob
-  JobTimeoutError = Class.new(StandardError)
+  class JobTimeoutError < StandardError
+  end
   include GoodJob::ActiveJobExtensions::Concurrency
   include Chromium::Pdf
 
@@ -16,9 +17,7 @@ class GeneratePdfJob < ApplicationJob
   )
 
   around_perform do |_job, block|
-    Timeout.timeout(180.seconds, JobTimeoutError) do
-      block.call
-    end
+    Timeout.timeout(180.seconds, JobTimeoutError, &block)
   end
 
   def perform(model)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chromium-pdf
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.6
 platform: ruby
 authors:
 - RoleModel Software