chromedriver-helper 2.0.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 523493a4eb5cc7c2a490ac9ff43b2daccd069cc9307687b8ef1df1ee814b9b0c
-  data.tar.gz: caddb00bafb5979ba43d5915ecd17ef117f9f72304b8a715d6811cfe597372f7
+  metadata.gz: 00d7bfc33c3feb7a50b220782801f8b1bb619a368ee5d6dd5a901621341c5d0d
+  data.tar.gz: e5e3f2d16b4f1a778cfc0afc9b4f2448ec1157ff67bf7dfdfce90a355c473341
 SHA512:
-  metadata.gz: 91380ff21ff39b55d0efa3869fcf267346bfca777a3a93076d748df1015f212f730a7ed18454500cae85f0138acac090153efeeb8a51adda2998510db42e6827
-  data.tar.gz: e72ef928b757d173c5448f8d4c4b12c5df09dcafa4fc5c2217064b8c9db89a9d434fd53bb5b1183131a17354ff207e9a18ca51c110bfb6034e0615a28d80b863
+  metadata.gz: d8cd6b73b42605d7a0ddd66d8b5230b34a8dc38ae7c532477620c7595e2821aebb040c4d5dc267bf8e16f58de24781505715f83239b84b2d68b38d253876038d
+  data.tar.gz: '09805d4ffa96dd170d1ebfceadf3ba4e917504c7f614bff69cb334a4cd90c31b6cdf7a271d240ae33c5ae509bf21d8db1d939eca3cf5160ab41cb2d2fb9e53ff'

data/CHANGELOG.md

@@ -1,12 +1,24 @@
 chromedriver-helper changelog
 ==========
 
+2.1.0 - 2018-09-18
+----------
+
+Enhancement:
+
+* Use the `LATEST_RELEASE` file to determine the newest version, to avoid downloading the experimental versions the Chrome team is posting recently. [#62](https://github.com/flavorjones/chromedriver-helper/issues/62) (Thanks, @ibrahima!)
+
+Bug fix:
+
+* `lib/chromedriver-helper.rb` explicitly requires `chromedriver/helper` to avoid "uninitialized constant Chromedriver" exception when calling `Chromedriver.set_version` in a default-configured Rails app. [#65](https://github.com/flavorjones/chromedriver-helper/issues/65)
+
+
 2.0.1 - 2019-09-17
 ----------
 
 Bug fix:
 
-* Explicitly require 'selenium-webdriver' for projects who don't have the default Rails ordering in their Gemfile. [#60](https://github.com/flavorjones/chromedriver-helper/issues/60)
+* Explicitly require 'selenium-webdriver' for projects who don't have the default Rails ordering in their Gemfile. [#60](https://github.com/flavorjones/chromedriver-helper/issues/60) (Thanks, @mattbrictson!)
 
 
 2.0.0 - 2019-09-15

data/README.md

@@ -16,16 +16,63 @@ Individual projects can even select which version of `chromedriver` they want to
 
 # Usage
 
-If you're using Bundler and Capybara, it's as easy as:
+## In a Rails project
+
+If you're using Bundler and Capybara in a Rails project, it's as easy as:
+
+``` ruby
+# Gemfile
+gem "selenium-webdriver"
+gem "chromedriver-helper"
+```
+
+then, in your spec setup:
+
+``` ruby
+Capybara.register_driver :selenium do |app|
+  Capybara::Selenium::Driver.new(app, :browser => :chrome)
+end
+```
+
+
+## Standalone
+
+If you're using it standlone just to manage chromedriver binaries,
 
     # Gemfile
     gem "chromedriver-helper"
 
-then, in your specs:
+Then just run the executable script:
+
+    chromedriver-helper
 
-    Capybara.register_driver :selenium do |app|
-      Capybara::Selenium::Driver.new(app, :browser => :chrome)
-    end
+which will download `chromedriver` if necessary and exec it.
+
+
+# Configuration
+
+There are some commandline options that can be sent to `chromedriver` as options to `Capybara::Selenium::Driver.new`. The supported options can be discovered by looking at the Selenium source code here:
+
+    https://github.com/SeleniumHQ/selenium/blob/master/rb/lib/selenium/webdriver/chrome/service.rb
+
+As of this writing, the supported options are:
+
+* `log_path`
+* `url_base`
+* `port_server`
+* `whitelisted_ips`
+* `verbose`
+* `silent`
+
+An example usage would be:
+
+``` ruby
+Capybara::Selenium::Driver.new(app, browser: :chrome,
+  driver_opts: {
+    log_path: '/tmp/chrome.log',
+    verbose: true
+  })
+```
 
 
 # Updating to latest `chromedriver`

data/lib/chromedriver-helper.rb

@@ -1,2 +1,4 @@
+require 'chromedriver/helper'
 require 'selenium-webdriver'
+
 Selenium::WebDriver::Chrome.driver_path=Gem.bin_path("chromedriver-helper","chromedriver-helper")

data/lib/chromedriver/helper/google_code_parser.rb

@@ -1,16 +1,18 @@
 require 'nokogiri'
 require 'open-uri'
+require 'uri'
 
 module Chromedriver
   class Helper
     class GoogleCodeParser
       BUCKET_URL = 'https://chromedriver.storage.googleapis.com'
 
-      attr_reader :source, :platform
+      attr_reader :source, :platform, :newest_download_version
 
       def initialize(platform, open_uri_provider=OpenURI)
         @platform = platform
         @source = open_uri_provider.open_uri(BUCKET_URL)
+        @newest_download_version = Gem::Version.new(open_uri_provider.open_uri(URI.join(BUCKET_URL, "LATEST_RELEASE")).read)
       end
 
       def downloads
@@ -22,10 +24,6 @@ module Chromedriver
         end
       end
 
-      def newest_download_version
-        @newest_download_version ||= downloads.map { |download| version_of(download) }.max
-      end
-
       def version_download_url(version)
         gem_version = Gem::Version.new(version)
         downloads.find { |download_url| version_of(download_url) == gem_version }

data/lib/chromedriver/helper/version.rb

@@ -1,5 +1,5 @@
 module Chromedriver
   class Helper
-    VERSION = "2.0.1"
+    VERSION = "2.1.0"
   end
 end

data/spec/google_code_parser_spec.rb

@@ -3,7 +3,14 @@ require "spec_helper"
 describe Chromedriver::Helper::GoogleCodeParser do
   let!(:open_uri_provider) do
     double("open_uri_provider").tap do |oup|
-      allow(oup).to receive(:open_uri) { File.read(File.join(File.dirname(__FILE__), "assets/google-code-bucket.xml")) }
+      allow(oup).to receive(:open_uri) do |uri|
+        case uri.to_s
+        when "https://chromedriver.storage.googleapis.com/LATEST_RELEASE"
+          StringIO.new("2.42")
+        when "https://chromedriver.storage.googleapis.com"
+          StringIO.new(File.read(File.join(File.dirname(__FILE__), "assets/google-code-bucket.xml")))
+        end
+      end
     end
   end
   let!(:parser) { Chromedriver::Helper::GoogleCodeParser.new('mac', open_uri_provider) }
@@ -21,22 +28,7 @@ describe Chromedriver::Helper::GoogleCodeParser do
 
   describe "#newest_download_version" do
     it "returns the last URL for the platform" do
-      expect(parser.newest_download_version).to eq Gem::Version.new("2.4")
-    end
-
-    context "out-of-order versions" do
-      before do
-        allow(parser).to receive(:downloads).and_return([
-          "https://chromedriver.storage.googleapis.com/2.3/chromedriver_mac32.zip",
-          "https://chromedriver.storage.googleapis.com/2.4/chromedriver_mac32.zip",
-          "https://chromedriver.storage.googleapis.com/2.14/chromedriver_mac32.zip",
-          "https://chromedriver.storage.googleapis.com/2.2/chromedriver_mac32.zip",
-        ])
-      end
-
-      it "returns the newest version" do
-        expect(parser.newest_download_version).to eq(Gem::Version.new("2.14"))
-      end
+      expect(parser.newest_download_version).to eq Gem::Version.new("2.42")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chromedriver-helper
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Mike Dalessio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-17 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec