chore-core 1.8.2 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1a706f2f8f8eefe36f16cfaea8636f6fe13df8d
-  data.tar.gz: d4c0b0f97c85916e509ec609bd9a9e38cac6aac0
+  metadata.gz: 9c18dd2782818f483d141ed7fff2daac3b9dacab
+  data.tar.gz: 78b658a9ad9b2e79126f194a56090e8e9da16d8f
 SHA512:
-  metadata.gz: c92dcbc42098e17b5e1d3ac05860ca1b74022725a2839964f6480bc8c3f080555e950757997ad9d3d4cdbd4b122e02e467614bb481a4108dfe65c5a74b797c6c
-  data.tar.gz: 95baf93fe723268b499447c24464443e3e7e19ed62d5718394c7dae66bcafb44a33f47133b3973827efd5856acc4fee2aab795adc33515c18068807f9e5039aa
+  metadata.gz: 24ef03d8f8a42f2632073c2bfa4df9e466aa9fea90350f8df496dc117cae946aff83fcc1f4d458c00f1b8149067c85d3f990ebddac7b85d8d443901cf94062e9
+  data.tar.gz: 0925bbf1e586472db8a894116b2b9b6f4fe13c54941e250ae1006f400baf6fe35261314c63934c40d2f1b683dea2dd33c684d134f2edb07fecf7c1ae88001c48

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2014, Tapjoy, Inc.
+Copyright (c) 2020, Tapjoy, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

data/README.md

@@ -1,89 +1,90 @@
-# Chore: Job processing... for the future!
+# Chore: Async Job Processing Framework For Ruby
+
+[![Build Status](https://travis-ci.org/Tapjoy/chore.svg?branch=master)](https://travis-ci.org/Tapjoy/chore)
 
 ## About
 
-Chore is a pluggable, multi-backend job processor. It was built from the ground up to be extremely flexible. We hope that you
-will find integrating and using Chore to be as pleasant as we do.
+Chore is a pluggable, multi-backend job processing framework. It was built from the ground up to be extremely flexible.
+We hope that you find integrating and using Chore to be as pleasant as we do.
 
-The full docs for Chore can always be found at http://tapjoy.github.io/chore.
+The full docs for Chore can always be found at https://tapjoy.github.io/chore.
 
 ## Configuration
 
 Chore can be integrated with any Ruby-based project by following these instructions:
 
-    gem 'chore-core', '~> 1.6.0'
+1. Add `chore-core` to the Gemfile
+
+    ```ruby
+    gem 'chore-core', '~> 4.0.0'
+    ```
 
-If you also plan on using SQS, you must also bring in dalli to use for memcached:
+    When using SQS, also add `dalli` to use for `memcached`-based deduplication:
 
+    ```ruby
     gem 'dalli'
+    ```
 
-Create a `Chorefile` file in the root of your project directory. While you can configure Chore itself from this file, it's primarly used to direct the Chore binary toward the root of your application, so that it can locate all of the depdendencies and required code.
+1. Create a `Chorefile` file in the root of the project directory. While Chore itself can be configured from this file,
+it's primarily used to direct the Chore binstub toward the root of the application so that it can locate all of the
+dependencies and required code.
 
+    ```
     --require=./<FILE_TO_LOAD>
+    ```
 
-Make sure that `--require` points to the main entry point for your app. If integrating with a Rails app, just point it to the directory of your application and it will handle loading the correct files on its own.
-
-Other options include:
-
-    --concurrency 16 # number of concurrent worker processes, if using forked worker strategy
-    --worker-strategy Chore::Strategy::ForkedWorkerStrategy # which worker strategy class to use
-    --consumer Chore::Queues::SQS::Consumer # which consumer class to use Options are SQS::Consumer and Filesystem::Consumer. Filesystem is recommended for local and testing purposes only.
-    --consumer-strategy Chore::Queues::Strategies::Consumer::ThreadedConsumerStrategy # which consuming strategy to use. Options are SingleConsumerStrategy and ThreadedConsumerStrategy. Threaded is recommended for better tuning your consuming profile
-    --consumer-sleep-interval 1.0 # The amount of time in seconds to sleep when a consumer doesn't receive any messages. Sub-second values are accepted. The default varies by consumer implementation. This is a weak form of backoff for when there is no work to do.
-    --threads-per-queue 4 # number of threads per queue for consuming from a given queue.
-    --dedupe-servers # if using SQS or similiar queue with at-least once delivery and your memcache is running on something other than localhost
-    --batch-size 50 # how many messages are batched together before handing them to a worker
-    --queue_prefix prefixy # A prefix to prepend to queue names, mainly for development and qa testing purposes
-    --max-attempts 100 # The maximum number of times a job can be attempted
-    --dupe-on-cache-failure # Determines the deduping behavior when a cache connection error occurs. When set to `false`, the message is assumed not to be a duplicate. Defaults to `false`.
-    --queue-polling-size 10 # If your particular queueing system supports responding with messages in batches of a certain size, you can control that with this flag. SQS has a built in upper-limit of 10, but other systems will vary.
-
-If you're using SQS, you'll want to add AWS keys so that Chore can authenticate with AWS.
+    Make sure that `--require` points to the main entry point for the application. If integrating with a Rails app,
+    point it to the application directory and Chore will handle loading the correct files on its own.
 
-    --aws-access-key=<AWS KEY>
-    --aws-secret-key=<AWS SECRET>
+1. When using SQS, ensure that AWS credentials exist in the environment (e.g. but not limited to `AWS_ACCESS_KEY_ID` &
+`AWS_SECRET_ACCESS_KEY` environment variables) and an AWS region is set (e.g. `AWS_REGION` environment variable) so that
+Chore can authenticate with AWS.
 
-By default, Chore will run over all queues it detects among the required files. If you wish to change this behavior, you can use:
+    By default, Chore will run over all queues it detects among the required files. If different behavior is desired,
+    use one of the following flags:
 
+    ```
+    # Note that only one of these options may be used, not both. Chore will quit
+    # if both options are specified.
     --queues QUEUE1,QUEUE2... # a list of queues to process
     --except-queues QUEUE1,QUEUE2... # a list of queues _not_ to process
+    ```
 
-Note that you can use one or the other but not both. Chore will quit and make fun of you if both options are specified.
+1. Chore has many more options, which can be viewed by executing `bundle exec chore --help`
 
-### Tips for configuring Chore
+### Tips For Configuring Chore
 
-For Rails, it can be necessary to add the directory you store your jobs in to the eager loading path,
-found in application.rb. You likely need a similar approach for most apps using jobs, unless you places
-them into a directory that is already eager loaded by default. One example of this might be:
+For Rails, it can be necessary to add the jobs directory to the eager loading path, found in `application.rb`. A similar
+approach for most apps using jobs is likely needed, unless the jobs are placed into a directory that is already eager
+loaded by the application. One example of this might be:
 
 ```ruby
 config.eager_load_paths += File.join(config.root, "app", "jobs")
 ```
 
-However, due to the way eager_load_paths works in Rails, this may only solve the issue
-in your production environment. You might also find it useful for other environments
-to throw soemthing like this in an config/initializers/chore.rb file, although you
-can choose to load the job files in any way you like:
+However, due to the way `eager_load_paths` works in Rails, this may only solve the issue in the production environment.
+It can also be useful useful for other environments to have something like this in an `config/initializers/chore.rb`
+file, although the job files can be loaded in just about any way.
 
 ```ruby
-Dir["#{Rails.root}/app/jobs/**/*"].each do |file|
-  require file unless File.directory?(file)
-end unless Rails.env.production?
+if !Rails.env.production?
+  Dir["#{Rails.root}/app/jobs/**/*"].each do |file|
+    require file unless File.directory?(file)
+  end
+end
 ```
 
-### Producing and Consuming Jobs
-
-When it comes to configuring Chore, you have 2 main use cases - as a producer of messages, or as a consumer of messages (the consumer is also able to produce messages if need be, but is running as it's own isolated instance of your application).
+### Producing & Consuming Jobs
 
-For producers, you must do all of your Chore configuration in an intializer.
+When it comes to configuring Chore, there are 2 main use configurations - as a producer of messages, or as a consumer of
+messages. The consuming context may also messages if necessary, as it is running as its own isolated instance of the
+application.
 
-For consumers, you need to either use a Chorefile or Chorefile + an initializer.
+For producers, all of the Chore configuration must be in an initializer.
 
-Because you are likely to use the same app as the basis for both producing and consuming messages, you'll already have a considerable amount of configuration in your Producer - it makes sense to use Chorefile to simply provide the `require` option, and stick to the initializer for the rest of the configuration to keep things DRY.
+For consumers, a Chorefile must be used. A Chorefile _plus_ an initializer is also a good pattern.
 
-However, like many aspects of Chore, it is ultimately up to the developer to decide which use case fits their needs best. Chore is happy to let you configure it in almost any way you want.
-
-An example of how to configure chore via an initializer:
+Here's example of how to configure chore via an initializer:
 
 ```ruby
 Chore.configure do |c|
@@ -92,30 +93,46 @@ Chore.configure do |c|
   c.max_attempts = 100
   ...
   c.batch_size = 50
+  c.batch_timeout = 20
 end
 ```
 
+Because it is like that the same application serves as the basis for both producing and consuming messages, and there
+will already be a considerable amount of configuration in the Producer, it makes sense to use Chorefile to simply
+provide the `require` option and stick to the initializer for the rest of the configuration to keep things DRY.
+
+However, like many aspects of Chore, it is ultimately up to the developer to decide which use case fits their needs
+best. Chore is happy to be configured in almost any way a developer desires.
+
 ## Integration
 
-Add an appropriate line to your `Procfile`:
+This section assumes `foreman` is being used to execute (or export the run commands of) the application, but it is not
+ strictly necessary.
+
+1. Add an appropriate line to the `Procfile`:
 
+    ```
     jobs: bundle exec chore -c config/chore.config
+    ```
 
-If your queues do not exist, you must create them before you run the application:
+1. If the queues do not exist, they must be created before the application can produce/consume Chore jobs:
 
-```ruby
-require 'aws-sdk'
-sqs = AWS::SQS.new
-sqs.queues.create("test_queue")
-```
+    ```ruby
+    require 'aws-sdk-sqs'
+    sqs = Aws::SQS::Client.new
+    sqs.create_queue(queue_name: "test_queue")
+    ```
 
-Finally, start foreman as usual
+1. Finally, start the application as usual
 
+    ```
     bundle exec foreman start
+    ```
 
-## Chore::Job
+## `Chore::Job`
 
-A Chore::Job is any class that includes `Chore::Job` and implements `perform(*args)` Here is an example job class:
+A `Chore::Job` is any class with `include Chore::Job` and implements a `perform(*args)` instance method. Here is an
+example job class:
 
 ```ruby
 class TestJob
@@ -125,30 +142,36 @@ class TestJob
   def perform(args={})
     Chore.logger.debug "My first async job"
   end
-
 end
 ```
 
-This job declares that the name of the queue it uses is `test_queue`, set in the queue_options method.
+This job declares that the name of the queue it uses is `test_queue`, set in the `queue_options` method.
 
-### Chore::Job and perform signatures
+### `Chore::Job` & `perform` Signatures
 
-The perform method signature can have explicit argument names, but in practice this makes changing the signature more difficult later on. Once a Job is in production and is being used at a constant rate, it becomes problematic to begin mixing versions of jobs which have non-matching signatures.
+The perform method signature can have explicit argument names, but in practice this makes changing the signature more
+difficult later on. Once a `Chore::Job` is in production and being used at a constant rate, it becomes problematic to
+begin mixing versions of the job with non-matching signatures.
 
-While this is able to be overcome with a number of techniques, such as versioning your jobs/queues, it increases the complexity of making changes.
+While this is able to be overcome with a number of techniques, such as versioning jobs/queues, it increases the
+complexity of making changes.
 
-The simplest way to structure job signatures is to treat the arguments as a hash. This will allow you to maintain forwards and backwards compatibility between signature changes with the same job class.
+The simplest way to structure job signatures is to treat the arguments as a hash. This enables maintaining forwards and
+backwards compatibility between signature changes with the same job class.
 
-However, Chore is ultimately agnostic to your particular needs in this regard, and will let you use explicit arguments in your signatures as easily as you can use a simple hash - the choice is left to you, the developer.
+However, Chore is ultimately agnostic in this regard and will allow explicit arguments in signatures as easily as using
+a simple hash; the choice is left to the developer.
 
-### Chore::Job and publishing Jobs
+### `Chore::Job` & Publishing Jobs
+
+Now that there's a test job, publishing an instance of the job is as simple as:
 
-Now that you've got a test job, if you wanted to publish to that job it's as simple as:
 ```ruby
 TestJob.perform_async({"message"=>"YES, DO THAT THING."})
 ```
 
-It's advisable to specify the Publisher chore uses to send messages globally, so that you can change it easily for local and test environments. To do this, you can add a configuration block to an initializer like so:
+It's advisable to specify the Publisher Chore uses to send messages globally, so that it can easily be modified based on
+the environment. To do this, add a configuration block to an initializer:
 
 ```ruby
 Chore.configure do |c|
@@ -156,14 +179,15 @@ Chore.configure do |c|
 end
 ```
 
-It is worth noting that any option that can be set via config file or command-line args can also be set in a configure block.
+It is worth noting that any option that can be set via config file or command-line args can also be set in a configure
+block.
 
 If a global publisher is set, it can be overridden on a per-job basis by specifying the publisher in `queue_options`.
 
 ## Retry Backoff Strategy
 
-Chore has basic support for delaying retries  of a failed job using a step function. Currently the only queue that
-supports this functionality is SQS, all others will simply ignore the delay setting.
+Chore has basic support for delaying retries of a failed job using a step function. Currently the only queue that
+supports this functionality is SQS; all others will simply ignore the delay setting.
 
 ### Setup
 
@@ -175,49 +199,52 @@ queue_options :name => 'nameOfQueue',
   :backoff => lambda { |work| work.current_attempt ** 2 } # Exponential backoff
 ```
 
-### Using the Backoff
+### Using The Backoff
 
 If there is a `:backoff` option supplied, any failures will delay the next attempt by the result of that lambda.
 
-### Notes on SQS and Delays
+### Notes On SQS & Delays
 
-Read more details about SQS and Delays [here](docs/Delayed Jobs.md)
+Read more details about SQS and Delays [here](docs/Delayed%20Jobs.md)
 
 ## Hooks
 
-A number of hooks, both global and per-job, exist in Chore for your convenience.
-
-Global Hooks:
+A number of hooks, both global and per-job, exist in Chore for flexibility and convencience. Hooks should be named
+`hook_name_identifier` where `identifier` is a descriptive string of chosen by the developer.
 
-* before_first_fork
-* before_fork
-* after_fork
-* around_fork
-* within_fork
+### Global Hooks
 
-("within_fork" behaves similarly to around_fork, except that it is called after the worker process has been forked. In contrast, around_fork is called by the parent process.)
+* `before_start`
+* `before_first_fork`
+* `before_fork`
+* `after_fork`
+* `around_fork`
+* `within_fork`
+  * behaves similarly to `around_fork`, except that it is called _after_ the worker process has been forked.
+    In contrast, `around_fork` is called by the parent process ( chore-master`)
+* `before_shutdown`
 
-Filesystem Consumer/Publisher
+## Filesystem Consumer/Publisher Hooks
 
-* on_fetch(job_file, job_json)
+* `on_fetch(job_file, job_json)`
 
-SQS Consumer
+#### SQS Consumer Hooks
 
-* on_fetch(handle, body)
+* `on_fetch(handle, body)`
 
-Per Job:
+### Per Job
 
-* before_publish
-* after_publish
-* before_perform(message)
-* after_perform(message)
-* on_rejected(message)
-* on_failure(message, error)
-* on_permanent_failure(queue_name, message, error)
+* `before_publish`
+* `after_publish`
+* `before_perform(message)`
+* `after_perform(message)`
+* `on_rejected(message)`
+* `on_failure(message, error)`
+* `on_permanent_failure(queue_name, message, error)`
 
 All per-job hooks can also be global hooks.
 
-Hooks can be added to a job class as so:
+Hooks can be added to a job class like so:
 
 ```ruby
 class TestJob
@@ -233,56 +260,52 @@ class TestJob
   end
 end
 ```
+
 Global hooks can also be registered like so:
 
 ```ruby
 Chore.add_hook :after_publish do
-  # your special handler here
+  # Add handler code here
 end
 ```
 
 ## Signals
 
-Signal handling can get complicated when you have multiple threads, process
-forks, and both signal handlers and application code making use of mutexes.
+Signal handling can get complicated when there are multiple threads, process forks, and both signal handlers and
+application code making use of mutexes.
 
-To simplify the complexities around this, Chore introduces some additional
-behaviors on top of Ruby's default Signal.trap implementation.  This
-functionality is primarily inspired by sidekiq's signal handling @
+To simplify the complexities around this, Chore introduces some additional behaviors on top of Ruby's default
+`Signal.trap` implementation.  This functionality is primarily inspired by `sidekiq`'s signal handling @
 https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/cli.rb.
 
-In particular, Chore handles signals in a separate thread and does so
-sequentially instead of interrupt-driven.  See Chore::Signal for more details
-on the differences between Ruby's `Signal.trap` and Chore's `Chore::Signal.trap`.
+In particular Chore handles signals in a separate thread, and does so sequentially instead of being interrupt-driven.
+See `Chore::Signal` for more details on the differences between Ruby's `Signal.trap` and Chore's `Chore::Signal.trap`.
 
-Chore will respond to the following Signals:
+Chore will respond to the following signals:
 
-* INT , TERM, QUIT - Chore will begin shutting down, taking steps to safely terminate workers and not interrupt jobs in progress unless it believes they may be hung
-* USR1 - Re-opens logfiles, useful for handling log rotations
+* `INT` , `TERM`, `QUIT` - Chore will begin shutting down, taking steps to safely terminate workers and not interrupt
+  jobs in progress unless it believes they may be hung
+* `USR1` - Re-opens logfiles, useful for handling log rotations
 
 ## Timeouts
 
-When using the forked worker strategy for processing jobs, inevitably there are
-cases in which child processes become stuck.  This could result from deadlocks,
-hung network calls, tight loops, etc.  When these jobs hang, they consume
+When using the forked worker strategy for processing jobs, inevitably there are cases in which child processes become
+stuck.  This could result from deadlocks, hung network calls, tight loops, etc.  When these jobs hang, they consume
 resources and can affect throughput.
 
-To mitigate this, Chore has built-in monitoring of forked child processes.
-When a fork is created to process a batch of work, that fork is assigned an
-expiration time -- if it doesn't complete by that time, the process is sent
-a KILL signal.
+To mitigate this, Chore has built-in monitoring of forked child processes. When a fork is created to process a batch of
+work, that fork is assigned an expiration time -- if it doesn't complete by that time, the process is sent a `KILL`
+signal.
 
 Fork expiration times are determined from one of two places:
-1. The timeout associated with the queue.  For SQS, this is the visibility
-   timeout.
-2. The default queue timeout configured for Chore.  For Filesystem queues,
-   this is the value used.
 
-For example, if a worker is processing a batch of 5 jobs and each job's queue
-has a timeout of 60s, then the expiration time will be 5 minutes for the worker.
+1. The timeout associated with the queue.  For SQS queues, this is the visibility timeout.
+1. The default queue timeout configured for Chore. For filesystem queues, this is the value used.
 
-To change the default queue timeout (when one can't be inferred), you can do
-the following:
+For example, if a worker is processing a batch of 5 jobs and each job's queue has a timeout of 60s, then the expiration
+time will be 5 minutes for the worker.
+
+To change the default queue timeout (when one can't be inferred), do the following:
 
 ```ruby
 Chore.configure do |c|
@@ -290,62 +313,62 @@ Chore.configure do |c|
 end
 ```
 
-A reasonable timeout would be based on the maximum amount of time you expect any
-job in your system to run.  Keep in mind that the process running the job may
-get killed if the job is running for too long.
+A reasonable timeout would be based on the maximum amount of time any job in the system is expected to run.  Keep in
+mind that the process running the job may get killed if the job is running for too long.
 
 ## Plugins
 
-Chore has several plugin gems available, which extend it's core functionality
+Chore has several plugin gems available, which extend its core functionality
 
 [New Relic](https://github.com/Tapjoy/chore-new_relic) - Integrating Chore with New Relic
 
 [Airbrake](https://github.com/Tapjoy/chore-airbrake) - Integrating Chore with Airbrake
 
-## Managing Chore processes
+## Managing Chore Processes
 
 ### Sample Upstart
 
-There are lots of ways to create upstart scripts, so it's difficult to give a prescriptive
-example of the "right" way to do it. However, here are some ideas from how we run it in production
-at Tapjoy:
+There are lots of ways to create upstart scripts, so it's difficult to give a prescriptive example of the "right" way to
+do it. However, here are some ideas from how we run it in production at Tapjoy:
 
-You should have a specific user that the process runs under, for security reasons. Swap to
-this user at the beginning of your exec line
+For security reasons, a specific user should be specified that the process runs as. Switch to this user at the beginning
+of the exec line
 
 ```bash
 su - $USER --command '...'
 ```
 
-For the command to run Chore itself keeping all of the necessary environment variables in an env
-file that your upstart can source on it's exec line, to prevent having to mix changing environment
-variables with having to change the upstart script itself
+For the command to run Chore itself keeping all of the necessary environment variables in an env file that Upstart can
+source on it's exec line, to prevent having to mix changing environment variables with having to change the upstart
+script itself
 
 ```bash
 source $PATHTOENVVARS ;
 ```
 
-After that, you'll want to make sure you're running Chore under the right ruby version. Additionally,
-we like to redirect STDOUT and STDERR to logger, with an app name. This makes it easy to find
-information in syslog later on. Putting that all together looks like:
+After that, ensure Chore is running under the right ruby version. Additionally, `STDOUT` and `STDERR` can be redirected
+to `logger` with an app name. This makes it easy to find information in syslog later on. Putting that all together looks
+like:
 
 ```bash
 rvm use $RUBYVERSION do  bundle exec chore -c Chorefile  2>&1 | logger -t $APPNAME
 ```
 
-There are many other ways you could manage the Upstart file, but these are a few of the ways we
-prefer to do it. Putting it all together, it looks something like:
+There are many other ways to manage the Upstart file, but these are a few of the ways we prefer to do it. Putting it all
+together, it looks something like:
 
 ```bash
-exec su - special_user --command 'source /the/path/to/env ; rvm use ruby-1.9.3-p484 do bundle exec chore -c Chorefile 2>&1 | logger chore-app'
+exec su - special_user --command '\
+  source /the/path/to/env ;\
+  rvm use 2.4.1 do bundle exec chore -c Chorefile 2>&1 | logger chore-app ;'
 ```
 
 ### Locating Processes
 
-As Chore does not keep a PIDfile, and has both a master and a potential number of workers,
-you may find it difficult to isolate the exact PID for the master process.
+As Chore does not keep a PID file, and has both a master and a potential number of workers, it may be difficult to
+isolate the exact PID for the master process.
 
-To find Chore master processes via ```ps```, you can run the following:
+To find Chore master processes via `ps`, run the following:
 
 ```bash
 ps aux | grep bin/chore
@@ -360,15 +383,15 @@ pgrep -f bin/chore
 To find a list of only Chore worker processes:
 
 ```bash
-ps aux | grep chore-
+ps aux | grep chore-worker
 ```
 
 or
 
 ```bash
-pgrep -f chore-
+pgrep -f chore-worker
 ```
+
 ## Copyright
 
-Copyright (c) 2013 - 2015 Tapjoy. See LICENSE.txt for
-further details.
+Copyright (c) 2013 - 2020 Tapjoy. See [LICENSE.txt](LICENSE.txt) for further details.