chord 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d87fc026e550a99125b7aac97b1069d943ccc8b6c23f4bface9ae5136d2fd48d
-  data.tar.gz: ca017e9919b6323d25f0dbac900598be630c843120bef07f1db29787e94b675d
+  metadata.gz: 6da5791c0fe9f32d72d827bc87ae15186cadbff18bfceecee81b98f17c3111a0
+  data.tar.gz: 037ad832506b87180563ce7ab0d8fbf591bcef211e1a72abe1110292329052dc
 SHA512:
-  metadata.gz: e027f417299124bbcf66d573ddd4ddb36f9a3c3d193385df49b2499ed9658543b58375064ba4cd583777a66be63ef685c036ba3616f7813bd34ebd857753d34a
-  data.tar.gz: fc10bf3c2ff5b9fd59048024ff07f3288b9593aea3da6a90fc35b11697d992bdcc48b00d873bbc07685b63440e9a228dc27330409568d98073f1e9adc51c0416
+  metadata.gz: afd04a08a2150ee30708c5ded7ec9a795839cfe606e17e9633691a76e2820346a7127995374639a8bbda0a20b39d529380b1b60810fee7993ad68983ae904fc5
+  data.tar.gz: d9c99564446ead46f5155f6efa8ae6efed6caa28d6ac64241f4be70fb6f4f674f3f9b228610ebf8a1d41dd8cf7d81b279942d5bcb25368ba877dd90d88506dbf

data/CHANGELOG.md

@@ -2,9 +2,14 @@
 
 Major changes for each release. Please see the Git log for complete list of changes.
 
+## 0.0.5
+
+* Add expand! method.
+* Fix Order object IDs.
+
 ## 0.0.4
 
-* Load attribute if missing.
+* Load subscription_in_cart attribute if missing when it's needed.
 
 ## 0.0.3
 

data/README.md

@@ -20,9 +20,10 @@ These classes provide simple read and write access to the Chord OMS API. Get sta
 
 Objects are constructed in a way that minimizes API calls but occasionally yields objects that seem incomplete. For example:
 
-    u = Chord::User.find(44)
-    s = u.subscriptions.first
-    s.user
+    orders = Chord::Order.all
+    o = orders.first
 
-will return a Chord::User object with only two attributes (ID and email) because the API only returns two attributes with a Subscription object.
+will return a Chord::Order object with around 40 attributes, not the full set of 55 (it's missing line items, for example), because the `/orders` endpoint returns abbreviated objects. To load the full set of data for these objects, use the `expand!` method:
+
+    o.expand!
 

data/lib/chord/version.rb

@@ -1,3 +1,3 @@
 module Chord
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/chord.rb

@@ -28,20 +28,28 @@ module Chord
 
     class << self
       attr_writer :per_page
-      def per_page; @per_page || 99999; end
+      def per_page; 99999; end
 
       def all
-        @all ||= fetch_all_data[base_path].map{ |i| new(i['id'], i) }
+        @all ||= fetch_all_data[base_path].map{ |i| new(i[id_attribute], i) }
       end
 
       def where(query_options = {})
-        fetch_all_data(query_options)[base_path].map{ |i| new(i['id'], i) }
+        fetch_all_data(query_options)[base_path].map{ |i| new(i[id_attribute], i) }
       end
 
       def find(id)
         return nil if id.nil? or id == ''
-        attrs = get(base_url + "#{base_path}/#{id}", http_options).parsed_response
-        attrs.include?('error') ? nil : new(id, attrs)
+        attrs = fetch_attributes(id)
+        attrs.include?('error') ? nil : new(attrs[id_attribute], attrs)
+      end
+
+      def fetch_attributes(id)
+        get(base_url + "#{base_path}/#{id}", http_options).parsed_response
+      end
+
+      def id_attribute
+        'id'
       end
 
       def fetch_all_data(query_options = {})
@@ -109,6 +117,13 @@ module Chord
       self.class.delete(base_url + "#{base_path}/#{id}", http_options).parsed_response
     end
 
+    # fetch all attributes, but don't overwrite existing ones,
+    # in case changes have been made
+    def expand!
+      all_attributes = self.class.fetch_attributes(id)
+      @attributes = all_attributes.merge(@attributes)
+    end
+
     def method_missing(method, *args, &block)
       if attributes.include?(method.to_s)
         attributes[method.to_s]
@@ -175,8 +190,12 @@ module Chord
       'orders'
     end
 
+    def self.id_attribute
+      'number'
+    end
+
     def user
-      Chord::User.find(attributes['user_id'])
+      @user ||= Chord::User.find(attributes['user_id'])
     end
 
     def payments
@@ -198,9 +217,7 @@ module Chord
     end
 
     def subscription_start?
-      unless attributes.include?('subscription_in_cart')
-        attributes['subscription_in_cart'] = Chord::Order.find(number).subscription_in_cart
-      end
+      expand! unless attributes.include?('subscription_in_cart')
       subscription_in_cart
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chord
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Alex Reisner