chobble-forms 0.7.0 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 114cd63966175b3b8f30be99441ff3da688526f9e46bc0b08c9add531c93d8eb
-  data.tar.gz: 225988209e98465f4c92d14729ad9650878519d1563cea5486f90b3342d8a28e
+  metadata.gz: 6541e97cfb901cd5437021bc314615f055125057456dfad79475be9497c55092
+  data.tar.gz: 21a7944f64c0974e144cfbc0b39fcb4d0f7dcff980358b08454c899ef181d8a3
 SHA512:
-  metadata.gz: 934333541f43b3fd5f8f0c24468f15a1d755b5567c0c341a856c6fedb67932f2a606d93452741ca26531a107d30cbd21363f1ec27f4acc7059a001edc3ca42ac
-  data.tar.gz: 535ab94d5f12ca207fd4c34d198e3938161465112819c0df18ea8cfa7c8f33ab29d8f44e9112aab6a011bf1889e49cf99e527223dadcdcb920f41830dbea7065
+  metadata.gz: 47ddc8c257e2e6b228205fbe2f6ac215b5d43d51e1df0f4348f912b94f1d153f2b0d810db04ef6531c71c30b0f69ad12b29a4d9ab74b4a5be7af60bf56237f2a
+  data.tar.gz: f30b8deb1d9ad611671be7a3fc92d41e37e36613b6a6d294cef1c28e46ef402bd495820b5a7b1bd0e989e987729defb196292c17dc20a258a3b88b3c437e2a92

data/lib/chobble_forms/helpers.rb

@@ -7,11 +7,11 @@ module ChobbleForms
   module Helpers
     extend T::Sig
 
-    SelectOption = T.type_alias {
+    SelectOption = T.type_alias do
       [String, T.any(String, Integer)]
-    }
+    end
 
-    LocalAssignValue = T.type_alias {
+    LocalAssignValue = T.type_alias do
       T.any(
         String,
         Symbol,
@@ -21,9 +21,9 @@ module ChobbleForms
         T::Array[SelectOption],
         T::Hash[Symbol, T.untyped]
       )
-    }
+    end
 
-    FieldSetupResult = T.type_alias {
+    FieldSetupResult = T.type_alias do
       {
         form_object: T.untyped,
         i18n_base: String,
@@ -33,7 +33,7 @@ module ChobbleForms
         field_hint: T.nilable(String),
         field_placeholder: T.nilable(String)
       }
-    }
+    end
 
     sig { params(field: Symbol, local_assigns: T::Hash[Symbol, LocalAssignValue]).returns(FieldSetupResult) }
     def form_field_setup(field, local_assigns)
@@ -91,7 +91,10 @@ module ChobbleForms
       }
     end
 
-    sig { params(prefilled: T::Boolean, checked_value: T.untyped, expected_value: T.untyped).returns(T::Hash[Symbol, T::Boolean]) }
+    sig do
+      params(prefilled: T::Boolean, checked_value: T.untyped,
+        expected_value: T.untyped).returns(T::Hash[Symbol, T::Boolean])
+    end
     def radio_button_options(prefilled, checked_value, expected_value)
       (prefilled && checked_value == expected_value) ? {checked: true} : {}
     end
@@ -135,8 +138,13 @@ module ChobbleForms
     def build_field_translations(field)
       i18n_base = T.unsafe(instance_variable_get(:@_current_i18n_base))
 
-      field_without_suffix = FieldUtils.strip_field_suffix(field)
-      fields_key = "#{i18n_base}.fields.#{field_without_suffix}"
+      # Only strip _pass suffix for pass/fail fields, not _comment fields
+      lookup_field = if field.to_s.end_with?("_pass")
+        FieldUtils.strip_field_suffix(field)
+      else
+        field
+      end
+      fields_key = "#{i18n_base}.fields.#{lookup_field}"
       field_label = t(fields_key, raise: true)
 
       base_parts = i18n_base.split(".")
@@ -151,7 +159,10 @@ module ChobbleForms
       }
     end
 
-    sig { params(field_translations: T::Hash[Symbol, T.nilable(String)], value: T.untyped, prefilled: T::Boolean).returns(FieldSetupResult) }
+    sig do
+      params(field_translations: T::Hash[Symbol, T.nilable(String)], value: T.untyped,
+        prefilled: T::Boolean).returns(FieldSetupResult)
+    end
     def build_field_setup_result(field_translations, value, prefilled)
       form_obj = T.unsafe(instance_variable_get(:@_current_form))
       i18n_base = T.unsafe(instance_variable_get(:@_current_i18n_base))
@@ -167,13 +178,28 @@ module ChobbleForms
       )
     end
 
+    sig { params(model: T.untyped, field: Symbol, raise_if_missing: T::Boolean).returns(T.untyped) }
+    def get_field_value_from_model(model, field, raise_if_missing: false)
+      return nil unless model
+
+      # Check for base field first (for fields like step_ramp_size that have a base value)
+      # Only check for _pass suffix if base field doesn't exist (for pass_fail_comment partials)
+      if model.respond_to?(field)
+        model.send(field)
+      elsif model.respond_to?("#{field}_pass")
+        model.send("#{field}_pass")
+      elsif raise_if_missing
+        available = model.attributes.keys.sort.join(", ")
+        raise "Field '#{field}' or '#{field}_pass' not found on " \
+              "#{model.class.name}. Available fields: #{available}"
+      end
+    end
+
     sig { params(model: T.untyped, field: Symbol).returns({value: T.untyped, prefilled: T::Boolean}) }
     def resolve_field_value(model, field)
-      field_str = field.to_s
+      return {value: nil, prefilled: false} if field.to_s.include?("password")
 
-      return {value: nil, prefilled: false} if field_str.include?("password")
-
-      current_value = model.send(field) if model.respond_to?(field)
+      current_value = get_field_value_from_model(model, field, raise_if_missing: true)
 
       # Check if this field should not be prefilled based on excluded fields list
       excluded_fields = T.unsafe(instance_variable_get(:@_excluded_prefill_fields))
@@ -189,11 +215,7 @@ module ChobbleForms
         }
       end
 
-      if field_str.end_with?("_id") && field_str != "id"
-        resolve_association_value(model, field_str)
-      else
-        {value: current_value, prefilled: false}
-      end
+      {value: current_value, prefilled: false}
     end
 
     sig { params(previous_inspection: T.untyped, current_model: T.untyped, field: Symbol).returns(T.untyped) }
@@ -203,7 +225,7 @@ module ChobbleForms
       elsif current_model.class.name.include?("Assessment")
         assessment_type = current_model.class.name.demodulize.underscore
         previous_model = previous_inspection.send(assessment_type)
-        previous_model&.send(field)
+        get_field_value_from_model(previous_model, field, raise_if_missing: false)
       else
         previous_inspection.send(field)
       end

data/lib/chobble_forms/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module ChobbleForms
-  VERSION = "0.7.0"
+  VERSION = "0.7.2"
 end

data/views/chobble_forms/_pass_fail_comment.html.erb

@@ -1,13 +1,14 @@
 <%
   # Composite partial for pass/fail + comment fields with grid layout
   # Required parameters:
-  #   field: Base field name (e.g., 'seam_integrity_pass')
+  #   field: Base field name (e.g., 'seam_integrity')
   #
   # This will render:
-  #   - Pass/fail field: field (e.g., 'seam_integrity_pass')
+  #   - Pass/fail field: base field + '_pass' (e.g., 'seam_integrity_pass')
   #   - Comment field: base field + '_comment' (e.g., 'seam_integrity_comment')
 
   base_field = field.to_s.gsub(/_pass$/, "")
+  pass_field = "#{base_field}_pass".to_sym
   comment_field = "#{base_field}_comment".to_sym
 
   form = @_current_form
@@ -30,7 +31,7 @@
   </label>
 
   <%= render 'chobble_forms/radio_pass_fail',
-    field: field,
+    field: pass_field,
     prefilled: field_data[:prefilled],
     checked_value: checked_value %>
 

data/views/chobble_forms/_pass_fail_na_comment.html.erb

@@ -1,15 +1,16 @@
 <%
   # Composite partial for pass/fail + N/A + comment fields with grid layout
   # Required parameters:
-  #   field: Base field name (e.g., 'seam_integrity_pass')
+  #   field: Base field name (e.g., 'seam_integrity')
   #
   # This will render:
-  #   - Pass/fail/N/A field: field (e.g., 'seam_integrity_pass')
+  #   - Pass/fail/N/A field: base field + '_pass' (e.g., 'seam_integrity_pass')
   #     - Enum fields: Pass = "pass", Fail = "fail", N/A = "na" (rendered as radio buttons)
   #     - Boolean fields: Pass = true, Fail = false (rendered as radio buttons)
   #   - Comment field: base field + '_comment' (e.g., 'seam_integrity_comment')
 
   base_field = field.to_s.gsub(/_pass$/, "")
+  pass_field = "#{base_field}_pass".to_sym
   comment_field = "#{base_field}_comment".to_sym
 
   form = @_current_form
@@ -31,7 +32,7 @@
   </label>
 
   <%= render 'chobble_forms/radio_pass_fail',
-    field: field,
+    field: pass_field,
     prefilled: field_data[:prefilled],
     checked_value: checked_value %>
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chobble-forms
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.2
 platform: ruby
 authors:
 - Chobble.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-16 00:00:00.000000000 Z
+date: 2025-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails