chobble-forms 0.5.6 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38897550927a4c901cada28fbe5f63e8447bf108e6eb3bedf5d045807e45c245
-  data.tar.gz: ede19464d42338a4834967dda6a1df1048d2bef39599ddd89e079256c796ec15
+  metadata.gz: 32610a1903913985762082f5865bd24bfcae7327bf887cafa70c09db7efe9e88
+  data.tar.gz: 4d0e15de04ab8ceee7fac1fea871d83582caf5bc96e4cc39760ef7e1297c8915
 SHA512:
-  metadata.gz: c24eca1ed04bf5d7cbbe7d483451368ef3b636d3d0d42018e967a5f22ddbee88e4c7c8d2c5a7f6f104828af570610d395342bb05fad838c5366f4b84edd186db
-  data.tar.gz: b486d795a2b856e0895b4736901f52fede072e35319acb7511aaef5b007919e8af5ea644365c34ef30839f0f36301a247fe0b791a5a12c98318ebdd078c11649
+  metadata.gz: c70cbe6796e0edba08b2c41c5e476401d4579cc86de865710a772c0f4ef570abacd76f4ec08033d1d405ef887cdf44b52aa5f4e82c07085270c28186f5fb7532
+  data.tar.gz: d9b8cc2aff3b86e9de10b189a44f2d2a9f651a236b87da01dd0095bc27fb81b8ea034f14d72655ae580fa4cd26a777674c3a2db78225769eca42af134e176208

data/README.md

@@ -18,36 +18,20 @@ bundle install
 
 ## Type Safety with Sorbet
 
-ChobbleForms uses Sorbet for static type checking, providing improved type safety and better IDE support. All library files use `typed: strict` with comprehensive type signatures.
+ChobbleForms is fully typed with Sorbet (`typed: strict`) providing compile-time type safety and runtime validation. All field parameters must be symbols for a clean, consistent API.
 
 ### Type Checking
 
-Run type checking with:
-
 ```bash
 bundle exec srb tc
 ```
 
-Or use the provided Rake task:
-
-```bash
-bundle exec rake typecheck
-```
-
 ### Development Setup
 
-For contributors working on this gem:
-
 1. Install dependencies: `bundle install`
 2. Generate RBI files: `bundle exec rake sorbet_rbi`
 3. Run type checking: `bundle exec rake typecheck`
 
-All methods have full type signatures, providing:
-- Static type checking at development time
-- Runtime type validation
-- Better IDE autocomplete and documentation
-- Early detection of type mismatches
-
 ## CSS Styles
 
 ChobbleForms includes CSS for styling the form components. To use the included styles, add this to your application.css:

data/lib/chobble_forms/field_utils.rb

@@ -1,13 +1,20 @@
-# typed: false
+# typed: strict
+# frozen_string_literal: true
+
+require "sorbet-runtime"
 
 module ChobbleForms
   module FieldUtils
+    extend T::Sig
+
+    sig { params(field: Symbol).returns(String) }
     def self.strip_field_suffix(field)
       field.to_s.gsub(/_pass$|_comment$/, "")
     end
 
+    sig { params(field: Symbol, partial: Symbol).returns(T::Array[String]) }
     def self.get_composite_fields(field, partial)
-      fields = []
+      fields = T.let([], T::Array[String])
       partial_str = partial.to_s
 
       if partial_str.include?("pass_fail") && !field.to_s.end_with?("_pass")
@@ -22,22 +29,27 @@ module ChobbleForms
       fields
     end
 
+    sig { params(field: Symbol).returns(T::Boolean) }
     def self.is_pass_field?(field)
       field.to_s.end_with?("_pass")
     end
 
+    sig { params(field: Symbol).returns(T::Boolean) }
     def self.is_comment_field?(field)
       field.to_s.end_with?("_comment")
     end
 
+    sig { params(field: Symbol).returns(T::Boolean) }
     def self.is_composite_field?(field)
       is_pass_field?(field) || is_comment_field?(field)
     end
 
+    sig { params(field: Symbol).returns(String) }
     def self.base_field_name(field)
       strip_field_suffix(field)
     end
 
+    sig { params(form: Symbol, field: Symbol).returns(String) }
     def self.form_field_label(form, field)
       I18n.t("forms.#{form}.fields.#{field}")
     end

data/lib/chobble_forms/helpers.rb

@@ -7,7 +7,7 @@ module ChobbleForms
   module Helpers
     extend T::Sig
 
-    sig { params(field: T.any(Symbol, String), local_assigns: T::Hash[Symbol, T.untyped]).returns(T::Hash[Symbol, T.untyped]) }
+    sig { params(field: Symbol, local_assigns: T::Hash[Symbol, T.untyped]).returns(T::Hash[Symbol, T.untyped]) }
     def form_field_setup(field, local_assigns)
       validate_local_assigns(local_assigns)
       validate_form_context
@@ -19,7 +19,7 @@ module ChobbleForms
       build_field_setup_result(field_translations, value, prefilled)
     end
 
-    sig { params(form_object: T.untyped, field: T.any(Symbol, String)).returns([T.untyped, T::Boolean]) }
+    sig { params(form_object: T.untyped, field: Symbol).returns([T.untyped, T::Boolean]) }
     def get_field_value_and_prefilled_status(form_object, field)
       return [nil, false] unless form_object&.object
       model = form_object.object
@@ -27,7 +27,7 @@ module ChobbleForms
       [resolved[:value], resolved[:prefilled]]
     end
 
-    sig { params(form: T.untyped, comment_field: T.any(Symbol, String), base_field_label: String).returns(T::Hash[Symbol, T.untyped]) }
+    sig { params(form: T.untyped, comment_field: Symbol, base_field_label: String).returns(T::Hash[Symbol, T.untyped]) }
     def comment_field_options(form, comment_field, base_field_label)
       raise ArgumentError, "form_object required" unless form
       model = form.object
@@ -106,7 +106,7 @@ module ChobbleForms
       raise ArgumentError, "missing form_object" unless form_obj
     end
 
-    sig { params(field: T.any(Symbol, String)).returns(T::Hash[Symbol, T.nilable(String)]) }
+    sig { params(field: Symbol).returns(T::Hash[Symbol, T.nilable(String)]) }
     def build_field_translations(field)
       i18n_base = T.unsafe(instance_variable_get(:@_current_i18n_base))
       fields_key = "#{i18n_base}.fields.#{field}"
@@ -137,29 +137,24 @@ module ChobbleForms
       }.merge(field_translations)
     end
 
-    sig { params(model: T.untyped, field: T.any(Symbol, String)).returns(T::Hash[Symbol, T.untyped]) }
+    sig { params(model: T.untyped, field: Symbol).returns(T::Hash[Symbol, T.untyped]) }
     def resolve_field_value(model, field)
       field_str = field.to_s
 
-      # Never return values for password fields
       if field_str.include?("password")
         return {value: nil, prefilled: false}
       end
 
-      # Check current model value
       current_value = model.send(field) if model.respond_to?(field)
 
-      # Check if this field should be excluded from prefilling
       if defined?(InspectionsController::NOT_COPIED_FIELDS) &&
           InspectionsController::NOT_COPIED_FIELDS.include?(field_str)
         return {value: current_value, prefilled: false}
       end
 
-      # Extract previous value if available
       prev_inspection = T.unsafe(instance_variable_get(:@previous_inspection))
       previous_value = extract_previous_value(prev_inspection, model, field)
 
-      # Return previous value if current is nil and previous exists
       if current_value.nil? && !previous_value.nil?
         return {
           value: format_numeric_value(previous_value),
@@ -170,12 +165,11 @@ module ChobbleForms
       if field_str.end_with?("_id") && field_str != "id"
         resolve_association_value(model, field_str)
       else
-        # Always return current value, even if nil
         {value: current_value, prefilled: false}
       end
     end
 
-    sig { params(previous_inspection: T.untyped, current_model: T.untyped, field: T.any(Symbol, String)).returns(T.untyped) }
+    sig { params(previous_inspection: T.untyped, current_model: T.untyped, field: Symbol).returns(T.untyped) }
     def extract_previous_value(previous_inspection, current_model, field)
       if !previous_inspection
         nil

data/lib/chobble_forms/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module ChobbleForms
-  VERSION = "0.5.6"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chobble-forms
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.6.0
 platform: ruby
 authors:
 - Chobble.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-12 00:00:00.000000000 Z
+date: 2025-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails