chili_pdf 0.4.3 → 0.4.4

data/History.txt

@@ -1,3 +1,17 @@
+=== 0.4.4 / 2011-06-27
+
+* Minor enhancements:
+
+  * Removed #-based link -> absolute URLs conversions, as it
+    was not necessary (wkhtmltopdf handles those links correctly as link
+    to another location in the generated PDF).
+  * Added hook listener so a "PDF" link is added to the bottom of project
+    wiki pages. Requires a 1-line patch outlined/proposed
+    "here":https://www.chiliproject.org/issues/488 to work. You can apply
+    it yourself manually if you like until the patch is (hopefully)
+    accepted.
+  * Added some base styles for HTML tables
+
 === 0.4.3 / 2011-06-20
 
 * Bugfix:

data/Manifest.txt

@@ -32,6 +32,7 @@ lib/tasks/chili_pdf_tasks.rb
 lib/tasks/contributor_tasks.rb
 lib/tasks/test_lib_dir.rake
 lib/user_patch.rb
+lib/wiki_format_hook_listener.rb
 rails/init.rb
 test/chili_pdf/config_test.rb
 test/chili_pdf/formatter_test.rb

data/README.md

@@ -15,12 +15,18 @@ ChiliProject (/Redmine) plugin which implements/enhances PDF-export functionalit
    server. Technically this is a dependency of the library being used to
    generate the PDFs ([wicked_pdf](https://github.com/mileszs/wicked_pdf)),
    but, it's something you should be aware of.
-1. Requires a patch to the Redmine/ChiliProject core application in order to
-   prevent a 'Double render' error on the WikiController. A pull request
-   [has been submitted](https://github.com/chiliproject/chiliproject/pull/62)
-   to the ChiliProject core team. Until then, you can manually apply the (small)
-   patch to your app if you like. The changeset can be found
-   [here](https://github.com/tomkersten/chiliproject/commit/b4e345dca9d72d8af9e8326c7cd8642e550be379).
+1. Two patches to consider adding to your Redmine/ChiliProject core application:
+   1. (REQUIRED) In order to prevent a 'Double render' error on the
+      WikiController. A pull request [has been submitted](http://bit.ly/jMrtYb)
+      to the ChiliProject core team. Until then, you can manually apply the
+      (small) patch to your app if you like. The changeset can be found
+      [here](http://bit.ly/jAPnuy).
+   1. (Optional) To get a "PDF" link on the bottom of your project wiki pages,
+      you need to apply a (one-line) diff to your ChiliProject codebase. You can
+      find the diff [here](http://bit.ly/wiki_view_format_link_hooks). There is
+      a "Feature request" issue set up with a patch/pull request for the
+      implementation so it may be in the core soon. You can follow along with
+      the issue status [here](https://www.chiliproject.org/issues/488).
 
 ## FEATURES:
 
@@ -32,6 +38,8 @@ ChiliProject (/Redmine) plugin which implements/enhances PDF-export functionalit
    own CSS and/or JavaScript on the plugin configuration page.
 1. Custom logo support. You can specify the URL of an image to place in the
    top-right corner of the first page of all exported PDFs.
+1. Adds a "PDF" link to the "Also available in" list of links at the bottom of
+   all wiki pages ([merged, but not released yet](http://bit.ly/jdcko9)).
 
 ## SCREENSHOTS:
 

data/assets/stylesheets/pdf.css

@@ -54,3 +54,17 @@ pre {
   padding:10px; background:#DDD;
   margin:5px 0;
 }
+
+table {
+  border:1px solid #999;
+  border-collapse:collapse;
+}
+table th,
+table td {
+  padding:5px;
+  vertical-align:top;
+  border:1px solid #999;
+}
+table th {
+  font-weight:bold;
+}

data/init.rb

@@ -20,4 +20,6 @@ Dispatcher.to_prepare :chili_pdf do
   require_dependency 'principal'
   require_dependency 'user'
   User.send(:include, UserPatch) unless User.included_modules.include? UserPatch
+
+  require_dependency 'wiki_format_hook_listener'
 end

data/lib/chili_pdf.rb

@@ -5,5 +5,5 @@ require 'chili_pdf/string_token'
 require 'chili_pdf/tag_mangler'
 
 module ChiliPDF
-  VERSION = '0.4.3'
+  VERSION = '0.4.4'
 end

data/lib/chili_pdf/tag_mangler.rb

@@ -9,13 +9,7 @@ class TagMangler
   end
 
   def to_absolute_url
-     if relative_url?
-       "#{base_url}#{relative_url}"
-     elsif anchor_tag
-       "#{@request_like.url}#{anchor_tag}"
-     else
-       @src_attribute
-     end
+    relative_url? ? "#{base_url}#{relative_url}" : @src_attribute
   end
 
   private
@@ -31,14 +25,6 @@ class TagMangler
       end
     end
 
-    def anchor_tag
-      @src_attribute[%r!^(#.*)!]
-    end
-
-    def anchor_tag?
-      !anchor_tag.blank
-    end
-
     def relative_url
       @src_attribute.match(%r!^/(.*)!) && $1
     end

data/lib/wiki_format_hook_listener.rb

@@ -0,0 +1,5 @@
+class WikiFormatHookListener < Redmine::Hook::ViewListener
+  def view_wiki_show_other_formats(options = {})
+    options[:link_builder].link_to "PDF", :url => options[:url_params].merge({:format => 'pdf'})
+  end
+end

data/test/chili_pdf/tag_mangler_test.rb

@@ -142,24 +142,5 @@ class TokenManagerTest < Test::Unit::TestCase
         assert_equal @absolute_url, @mangler.to_absolute_url
       end
     end
-
-    context "when the content passed in has an anchor to another location in the current page" do
-      setup do
-        @base_url = "http://example.com"
-        @current_page = "/current_page"
-        @absolute_url = "#{@base_url}#{@current_page}"
-
-        mock_request = 'Mocked Request'
-        mock_request.stubs(:request_uri).returns(@current_page)
-        mock_request.stubs(:url).returns(@absolute_url)
-
-        @requested_asset = "#HeadingOnPage"
-        @mangler = make_mangler_with(@requested_asset, mock_request)
-      end
-
-      should "should return an absolute URL to the original page" do
-        assert_equal "#{@absolute_url}#{@requested_asset}", @mangler.to_absolute_url
-      end
-    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: chili_pdf
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: 
   segments: 
   - 0
   - 4
-  - 3
-  version: 0.4.3
+  - 4
+  version: 0.4.4
 platform: ruby
 authors: 
 - Tom Kersten
@@ -36,7 +36,7 @@ cert_chain:
   NVADJA==
   -----END CERTIFICATE-----
 
-date: 2011-06-20 00:00:00 -05:00
+date: 2011-06-27 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -132,6 +132,7 @@ files:
 - lib/tasks/contributor_tasks.rb
 - lib/tasks/test_lib_dir.rake
 - lib/user_patch.rb
+- lib/wiki_format_hook_listener.rb
 - rails/init.rb
 - test/chili_pdf/config_test.rb
 - test/chili_pdf/formatter_test.rb