childprocess 3.0.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3927c01811510b0458e140f2b6f0fc6974f15ef733af515fa1d1b30976af4f4
-  data.tar.gz: 82883fa302f9e1698cff900a88cf5662e4561b5ca6fb5c6a794eccb65fc89d96
+  metadata.gz: b4e76f415dff2879680f9ca7c48442132fde2099dbdcd956aaf44b429269067b
+  data.tar.gz: b02b05e8ec6ad8a63c31cbaae6067cf5dae11e80b79850ebf9cf630e6fe69ddf
 SHA512:
-  metadata.gz: 98d6faa166068b1f9186cbf817ac5623e22212a7cd434b5a9213be80bf2e13df8d517513a772a5e5abf3a81c3dfe930c75bfd3f822423bf9e9259230dd4a26bd
-  data.tar.gz: 92082f9fb2ca7ec07bcaefcb1c0cd2619305204bbc7872090b485e694e36879e4de4d6abc460867a2715ea0214b0aeef16d67016fa0f36280028aa391b27ca94
+  metadata.gz: ea2985d14f2b941e48dfa544c4531440560e6e4fc7c8edb1bdf68200099f9002cba20e033c0267a5f87bed8f886ae655dd3476c023f1133ce0729d7428610d8f
+  data.tar.gz: d962183e2e67e3612be72a7120a2a083bae78f738662cd8f0af7e50513b9936406814a25136e8a5cb7ae2c3166eb4d3ead38f85be834478b6fd26106c000dd56

data/.travis.yml

@@ -4,7 +4,6 @@ os:
 
 rvm:
   - rbx-3
-  - 2.3
   - 2.4
   - 2.5
   - 2.6
@@ -16,9 +15,7 @@ cache: bundler
 
 before_install:
   - "echo 'gem: --no-document' > ~/.gemrc"
-  # RubyGems update is supported for Ruby 2.3 and later
-  - ruby -e "system('gem update --system') if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.3')"
-  - gem install bundler --version '~> 1.17'
+  - gem install bundler
 
 before_script:
   - 'export JAVA_OPTS="${JAVA_OPTS_FOR_SPECS}"'

data/CHANGELOG.md

@@ -1,6 +1,10 @@
+### Version 4.0.0 / 2020-06-18
+
+* [#167](https://github.com/enkessler/childprocess/pull/167): Fix detach behavior on Windows
+
 ### Version 3.0.0 / 2019-09-20
 
-* [#156](https://github.com/enkessler/childprocess/pull/156)Remove unused `rubyforge_project` from gemspec
+* [#156](https://github.com/enkessler/childprocess/pull/156): Remove unused `rubyforge_project` from gemspec
 * [#160](https://github.com/enkessler/childprocess/pull/160): Remove extension to conditionally install `ffi` gem on Windows platforms
 * [#160](https://github.com/enkessler/childprocess/pull/160): Remove runtime dependency on `rake` gem
 

data/README.md

@@ -14,7 +14,7 @@ a standalone library.
 
 # Requirements
 
-* Ruby 2.3+, JRuby 9+
+* Ruby 2.4+, JRuby 9+
 
 Windows users **must** ensure the `ffi` gem (`>= 1.0.11`) is installed in order to use ChildProcess.
 
@@ -69,21 +69,33 @@ end
 ```ruby
 r, w = IO.pipe
 
-proc = ChildProcess.build("echo", "foo")
-proc.io.stdout = proc.io.stderr = w
-proc.start
-
-Thread.new {
-  begin
-    loop do
-      print r.readpartial(8192)
+begin
+  process = ChildProcess.build("sh" , "-c",
+                               "for i in {1..3}; do echo $i; sleep 1; done")
+  process.io.stdout = w
+  process.start # This results in a fork, inheriting the write end of the pipe.
+
+  # Close parent's copy of the write end of the pipe so when the (forked) child
+  # process closes its write end of the pipe the parent receives EOF when
+  # attempting to read from it. If the parent leaves its write end open, it
+  # will not detect EOF.
+  w.close
+
+  thread = Thread.new do
+    begin
+      loop do
+        print r.readpartial(16384)
+      end
+    rescue EOFError
+      # Child has closed the write end of the pipe
     end
-  rescue EOFError
   end
-}
 
-proc.wait
-w.close
+  process.wait
+  thread.join
+ensure
+  r.close
+end
 ```
 
 Note that if you just want to get the output of a command, the backtick method on Kernel may be a better fit.

data/appveyor.yml

@@ -2,12 +2,6 @@ version: '1.0.{build}'
 
 environment:
   matrix:
-    - CHILDPROCESS_POSIX_SPAWN: true
-      CHILDPROCESS_UNSET: should-be-unset
-      RUBY_VERSION: 23-x64
-    - CHILDPROCESS_POSIX_SPAWN: false
-      CHILDPROCESS_UNSET: should-be-unset
-      RUBY_VERSION: 23-x64
     - CHILDPROCESS_POSIX_SPAWN: true
       CHILDPROCESS_UNSET: should-be-unset
       RUBY_VERSION: 24-x64

data/childprocess.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- spec/*`.split("\n")
   s.require_paths = ["lib"]
 
-  s.required_ruby_version = '>= 2.3.0'
+  s.required_ruby_version = '>= 2.4.0'
 
   s.add_development_dependency "rspec", "~> 3.0"
   s.add_development_dependency "yard", "~> 0.0"

data/lib/childprocess/version.rb

@@ -1,3 +1,3 @@
 module ChildProcess
-  VERSION = '3.0.0'
+  VERSION = '4.0.0'
 end

data/lib/childprocess/windows/process.rb

@@ -71,7 +71,7 @@ module ChildProcess
         @handle = Handle.open @pid
 
         if leader?
-          @job = Job.new
+          @job = Job.new(detach?, true)
           @job << @handle
         end
 
@@ -93,7 +93,7 @@ module ChildProcess
 
 
       class Job
-        def initialize
+        def initialize(detach, leader)
           @pointer = Lib.create_job_object(nil, nil)
 
           if @pointer.nil? || @pointer.null?
@@ -101,7 +101,8 @@ module ChildProcess
           end
 
           basic = JobObjectBasicLimitInformation.new
-          basic[:LimitFlags] = JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE | JOB_OBJECT_LIMIT_BREAKAWAY_OK
+          basic[:LimitFlags] |= JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE if !detach
+          basic[:LimitFlags] |= JOB_OBJECT_LIMIT_BREAKAWAY_OK if leader
 
           extended = JobObjectExtendedLimitInformation.new
           extended[:BasicLimitInformation] = basic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: childprocess
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Jari Bakken
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-20 00:00:00.000000000 Z
+date: 2020-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -123,14 +123,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.1
 signing_key: 
 specification_version: 4
 summary: A simple and reliable solution for controlling external programs running