childprocess 0.1.9 → 0.2.0

data/{README.rdoc → README.md}

@@ -1,4 +1,5 @@
-= childprocess
+childprocess
+============
 
 This gem aims at being a simple and reliable solution for controlling
 external programs running in the background on any Ruby / OS combination.
@@ -6,26 +7,29 @@ external programs running in the background on any Ruby / OS combination.
 The code originated in the selenium-webdriver gem, but should prove useful as
 a standalone library.
 
-== Usage
+Usage
+-----
+```ruby
+process = ChildProcess.build("ruby", "-e", "sleep")
 
-   process = ChildProcess.build("ruby", "-e", "sleep")
+# inherit stdout/stderr from parent
+process.io.inherit!
 
-   # inherit stdout/stderr from parent
-   process.io.inherit!
+# or pass an IO
+process.io.stdout = Tempfile.new("child-output")
 
-   # or pass an IO
-   process.io.stdout = Tempfile.new("child-output")
+process.start
 
-   process.start
+process.alive?    #=> true
+process.exited?   #=> false
 
-   process.alive?    #=> true
-   process.exited?   #=> false
-
-   process.stop
+process.stop
+```
 
 The object returned from ChildProcess.build will implement ChildProcess::AbstractProcess.
 
-== Implementation
+Implementation
+--------------
 
 How the process is launched and killed depends on the platform:
 
@@ -34,8 +38,8 @@ How the process is launched and killed depends on the platform:
 * JRuby    : java.lang.{Process,ProcessBuilder}
 * IronRuby : System.Diagnostics.Process
 
-
-== Note on Patches/Pull Requests
+Note on Patches/Pull Requests
+-----------------------------
 
 * Fork the project.
 * Make your feature addition or bug fix.
@@ -45,6 +49,7 @@ How the process is launched and killed depends on the platform:
   (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
 * Send me a pull request. Bonus points for topic branches.
 
-== Copyright
+Copyright
+---------
 
 Copyright (c) 2010-2011 Jari Bakken. See LICENSE for details.

data/childprocess.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rspec", [">= 2.0.0"]
   s.add_development_dependency "yard", [">= 0"]
+  s.add_development_dependency "rake", ["~> 0.8.7"]
   s.add_runtime_dependency "ffi", ["~> 1.0.6"]
 end
 

data/lib/childprocess/version.rb

@@ -1,3 +1,3 @@
 module ChildProcess
-  VERSION = "0.1.9"
+  VERSION = "0.2.0"
 end

data/lib/childprocess/windows/process.rb

@@ -52,10 +52,7 @@ module ChildProcess
           opts[:stderr] = @io.stderr
         end
 
-        # TODO: escape/quote arguments properly
-        command = @args.join ' '
-
-        @pid = Lib.create_proc(command, opts)
+        @pid = Lib.create_proc(command_string, opts)
         @handle = Handle.open(@pid)
 
         if duplex?
@@ -65,6 +62,23 @@ module ChildProcess
         self
       end
 
+      def command_string
+        @command_string ||= (
+          @args.map { |arg| quote_if_necessary(arg.to_s) }.join ' '
+        )
+      end
+
+      def quote_if_necessary(str)
+        quote = str.start_with?('"') ? "'" : '"'
+
+        case str
+        when /[\s\\'"]/
+          %{#{quote}#{str}#{quote}}
+        else
+          str
+        end
+      end
+
     end # Process
   end # Windows
 end # ChildProcess

data/spec/childprocess_spec.rb

@@ -165,4 +165,17 @@ describe ChildProcess do
       Dir.rmdir(path) if File.exist?(path)
     end
   end
+
+  it "can handle whitespace, special characters and quotes in arguments" do
+    args = ["foo bar", 'foo\bar', "'i-am-quoted'", '"i am double quoted"']
+
+    Tempfile.open("argv-spec") do |file|
+      process = write_argv(file.path, *args).start
+      process.poll_for_exit(EXIT_TIMEOUT)
+
+      file.rewind
+      file.read.should == args.inspect
+    end
+  end
+
 end

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: childprocess
 version: !ruby/object:Gem::Version 
-  hash: 9
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 9
-  version: 0.1.9
+  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors: 
 - Jari Bakken
@@ -15,8 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-13 00:00:00 +02:00
-default_executable: 
+date: 2011-07-20 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -26,11 +20,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 0
-        - 0
         version: 2.0.0
   type: :development
   version_requirements: *id001
@@ -42,28 +31,31 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: ffi
+  name: rake
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 27
-        segments: 
-        - 1
-        - 0
-        - 6
+        version: 0.8.7
+  type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: ffi
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
         version: 1.0.6
   type: :runtime
-  version_requirements: *id003
+  version_requirements: *id004
 description: This gem aims at being a simple and reliable solution for controlling external programs running in the background on any Ruby / OS combination.
 email: 
 - jari.bakken@gmail.com
@@ -79,7 +71,7 @@ files:
 - .rspec
 - Gemfile
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - childprocess.gemspec
 - lib/childprocess.rb
@@ -111,7 +103,6 @@ files:
 - spec/spec_helper.rb
 - spec/unix_spec.rb
 - spec/windows_spec.rb
-has_rdoc: true
 homepage: http://github.com/jarib/childprocess
 licenses: []
 
@@ -125,23 +116,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: childprocess
-rubygems_version: 1.3.7
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: This gem aims at being a simple and reliable solution for controlling external programs running in the background on any Ruby / OS combination.