childprocess 0.1.2 → 0.1.3

data/VERSION

@@ -1 +1 @@
-0.1.2
+0.1.3

data/childprocess.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{childprocess}
-  s.version = "0.1.2"
+  s.version = "0.1.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jari Bakken"]
@@ -45,11 +45,13 @@ Gem::Specification.new do |s|
      "lib/childprocess/windows/io.rb",
      "lib/childprocess/windows/process.rb",
      "lib/childprocess/windows/structs.rb",
+     "spec/abstract_io_spec.rb",
      "spec/childprocess_spec.rb",
      "spec/jruby_spec.rb",
      "spec/spec.opts",
      "spec/spec_helper.rb",
-     "spec/unix_spec.rb"
+     "spec/unix_spec.rb",
+     "spec/windows_spec.rb"
   ]
   s.homepage = %q{http://github.com/jarib/childprocess}
   s.rdoc_options = ["--charset=UTF-8"]
@@ -61,7 +63,8 @@ Gem::Specification.new do |s|
      "spec/childprocess_spec.rb",
      "spec/jruby_spec.rb",
      "spec/spec_helper.rb",
-     "spec/unix_spec.rb"
+     "spec/unix_spec.rb",
+     "spec/windows_spec.rb"
   ]
 
   if s.respond_to? :specification_version then

data/lib/childprocess.rb

@@ -44,6 +44,10 @@ module ChildProcess
       platform == :jruby
     end
 
+    def windows?
+      !jruby? && os == :windows
+    end
+
     def os
       @os ||= (
         require "rbconfig"

data/lib/childprocess/windows/io.rb

@@ -14,7 +14,7 @@ module ChildProcess
         io.respond_to?(:fileno) && io.fileno
       end
 
-      def has_to_io?
+      def has_to_io?(io)
         io.respond_to?(:to_io) && io.to_io.kind_of?(::IO)
       end
 

data/lib/childprocess/windows/process.rb

@@ -47,7 +47,8 @@ module ChildProcess
           opts[:stderr] = @io.stderr
         end
 
-        command = @args.map { |e| e.inspect }.join(' ')
+       # TODO: escape/quote arguments properly
+       command = @args.join ' '
 
         @pid = Lib.create_proc(command, opts)
         @handle = Handle.open(@pid)

data/spec/abstract_io_spec.rb

@@ -2,10 +2,10 @@ require File.expand_path('../spec_helper', __FILE__)
 
 describe ChildProcess::AbstractIO do
   let(:io) { ChildProcess::AbstractIO.new }
-  
+
   it "inherits the parent's IO streams" do
     io.inherit!
-    
+
     io.stdout.should == STDOUT
     io.stderr.should == STDERR
   end

data/spec/unix_spec.rb

@@ -38,7 +38,7 @@ if ChildProcess.unix?
       lambda { io.stdout = nil }.should raise_error(ArgumentError, /to respond to :to_io/)
     end
 
-    it "raises an ArgumentError if the IO's fileno is nil" do
+    it "raises a TypeError if #to_io does not return an IO" do
       fake_io = Object.new
       def fake_io.to_io() StringIO.new end
 

data/spec/windows_spec.rb

@@ -0,0 +1,18 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+if ChildProcess.windows?
+  describe ChildProcess::Windows::IO do
+    let(:io) { ChildProcess::Windows::IO.new }
+
+    it "raises an ArgumentError if given IO does not respond to :fileno" do
+      lambda { io.stdout = nil }.should raise_error(ArgumentError, /must have :fileno or :to_io/)
+    end
+
+    it "raises an ArgumentError if the #to_io does not return an IO " do
+      fake_io = Object.new
+      def fake_io.to_io() StringIO.new end
+
+      lambda { io.stdout = fake_io }.should raise_error(ArgumentError, /must have :fileno or :to_io/)
+    end
+  end
+end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 2
-  version: 0.1.2
+  - 3
+  version: 0.1.3
 platform: ruby
 authors: 
 - Jari Bakken
@@ -98,12 +98,13 @@ files:
 - lib/childprocess/windows/io.rb
 - lib/childprocess/windows/process.rb
 - lib/childprocess/windows/structs.rb
+- spec/abstract_io_spec.rb
 - spec/childprocess_spec.rb
 - spec/jruby_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 - spec/unix_spec.rb
-- spec/abstract_io_spec.rb
+- spec/windows_spec.rb
 has_rdoc: true
 homepage: http://github.com/jarib/childprocess
 licenses: []
@@ -142,3 +143,4 @@ test_files:
 - spec/jruby_spec.rb
 - spec/spec_helper.rb
 - spec/unix_spec.rb
+- spec/windows_spec.rb