chh_moretext 0.1.1 → 0.1.2

data/README.md

@@ -47,6 +47,12 @@ ChhMoretext::Moretext.paragraphs(5)
 # 也可以指定要有幾個段落
 ```
 
+## Issues
+
+目前已知的問題……
+
+* limit 如果設一個字，例如給出 /sentences.json?n=3&limit=1 這個 URL 請求，Moretext 伺服器就會死機好一陣子；
+
 ## TODO
 
 * 目前每呼叫一個方法就是一個 request，造成產生假文的速度非常緩慢，打算弄個「快取層」先把資料抓來，呼叫方法時從快取裡面去拿；

data/lib/chh_moretext.rb

@@ -7,23 +7,20 @@ module ChhMoretext
     class << self
       def fetch_moretext(number, limit)
         number = "n=#{number}"
-
-        if limit.is_a?(Range)
-          limit = "limit=#{limit.min},#{limit.max}"
-        elsif limit.is_a?(Integer)
-          limit = "limit=#{limit}"
-        else
-          limit = nil
-        end
-
-        if limit.nil?
-          condition = "?#{number}"
-        else
-          condition = "?#{number}&#{limit}"
-        end
+        limit  = parse(limit)
+        condition = limit.nil? ? "?#{number}" : "?#{number}&#{limit}"
         return JSON(open("http://more.handlino.com/sentences.json#{condition}").read)["sentences"]
       end
     end
+
+    private
+      def self.parse(type)
+        case type
+        when Range   then "limit=#{type.min},#{type.max}"
+        when Integer then "limit=#{type}"
+        else nil
+        end
+      end
   end
 end
 

data/lib/chh_moretext/version.rb

@@ -1,3 +1,3 @@
 module ChhMoretext
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chh_moretext
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors: