chewy 5.2.0 → 6.0.0

data/spec/chewy/multi_search_spec.rb

@@ -0,0 +1,85 @@
+require 'spec_helper'
+require 'chewy/multi_search'
+
+describe Chewy::MultiSearch do
+  before { Chewy.massacre }
+
+  before do
+    stub_model(:city)
+    stub_model(:country)
+
+    stub_index(:cities) do
+      def self.aggregate_by_country
+        aggs(country: {terms: {field: :country_id}})
+      end
+
+      define_type City do
+        field :name, type: 'keyword'
+        field :country_id, type: 'keyword'
+      end
+    end
+  end
+
+  let(:places_query) { CitiesIndex.all }
+
+  describe '#queries' do
+    specify 'returns the queries that are a part of the multi search' do
+      multi_search = described_class.new([places_query])
+      expect(multi_search.queries).to contain_exactly(places_query)
+    end
+  end
+
+  describe '#add_query' do
+    specify 'adds a query to the multi search' do
+      multi_search = described_class.new([])
+      expect do
+        multi_search.add_query(places_query)
+      end.to change {
+        multi_search.queries
+      }.from([]).to([places_query])
+    end
+  end
+
+  context 'when given two queries' do
+    let(:queries) { [aggregates, results] }
+    let(:aggregates) { CitiesIndex.aggregate_by_country.limit(0) }
+    let(:results) { CitiesIndex.limit(10) }
+    let(:multi_search) { described_class.new(queries) }
+    let(:cities) { Array.new(3) { |i| City.create! name: "Name#{i + 2}", country_id: i + 1 } }
+    before { CitiesIndex.import! city: cities }
+
+    describe '#perform' do
+      specify 'performs each query' do
+        expect { multi_search.perform }
+          .to change(aggregates, :performed?).from(false).to(true)
+          .and change(results, :performed?).from(false).to(true)
+      end
+
+      specify 'issues a single request using the msearch endpoint', :aggregate_failures do
+        expect(Chewy.client).to receive(:msearch).once.and_return('responses' => [])
+        expect(Chewy.client).to_not receive(:search)
+        multi_search.perform
+      end
+    end
+
+    describe '#responses' do
+      subject(:responses) { multi_search.responses }
+
+      context 'on a previously performed multi search' do
+        before { multi_search.perform }
+
+        it 'does not perform the query again' do
+          expect(Chewy.client).to_not receive(:msearch)
+          multi_search.responses
+        end
+      end
+
+      specify 'returns the results of each query', :aggregate_failures do
+        is_expected.to have(2).responses
+        expect(responses[0]).to be_a(Chewy::Search::Response)
+        expect(responses[1]).to be_a(Chewy::Search::Response)
+        expect(responses[1].wrappers).to all(be_a CitiesIndex::City)
+      end
+    end
+  end
+end

data/spec/chewy/rake_helper_spec.rb

@@ -7,16 +7,18 @@ describe Chewy::RakeHelper, :orm do
     stub_model(:city)
     stub_model(:country)
 
-    stub_index(:places) do
+    stub_index(:cities) do
       define_type City do
         field :name
         field :updated_at, type: 'date'
       end
+    end
+    stub_index(:countries) do
       define_type Country
     end
     stub_index(:users)
 
-    allow(described_class).to receive(:all_indexes) { [PlacesIndex, UsersIndex] }
+    allow(described_class).to receive(:all_indexes) { [CitiesIndex, CountriesIndex, UsersIndex] }
   end
 
   let!(:cities) { Array.new(3) { |i| City.create!(name: "Name#{i + 1}") } }
@@ -24,7 +26,7 @@ describe Chewy::RakeHelper, :orm do
   let(:journal) do
     Chewy::Stash::Journal.import([
       {
-        index_name: 'places',
+        index_name: 'cities',
         type_name: 'city',
         action: 'index',
         references: cities.first(2).map(&:id).map(&:to_s)
@@ -32,7 +34,7 @@ describe Chewy::RakeHelper, :orm do
         created_at: 2.minutes.since
       },
       {
-        index_name: 'places',
+        index_name: 'countries',
         type_name: 'country',
         action: 'index',
         references: [Base64.encode64(countries.first.id.to_s.to_json)],
@@ -47,14 +49,17 @@ describe Chewy::RakeHelper, :orm do
     specify do
       output = StringIO.new
       expect { described_class.reset(output: output) }
-        .to update_index(PlacesIndex::City)
+        .to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AResetting PlacesIndex
-  Imported PlacesIndex::City in \\d+s, stats: index 3
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
-  Applying journal to \\[PlacesIndex::City, PlacesIndex::Country\\], 3 entries, stage 1
-  Imported PlacesIndex::City in \\d+s, stats: index 2
-  Imported PlacesIndex::Country in \\d+s, stats: index 1
+\\AResetting CitiesIndex
+  Imported CitiesIndex::City in \\d+s, stats: index 3
+  Applying journal to \\[CitiesIndex::City\\], 2 entries, stage 1
+  Imported CitiesIndex::City in \\d+s, stats: index 2
+  Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
+Resetting CountriesIndex
+  Imported CountriesIndex::Country in \\d+s, stats: index 2
+  Applying journal to \\[CountriesIndex::Country\\], 1 entries, stage 1
+  Imported CountriesIndex::Country in \\d+s, stats: index 1
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
 Resetting UsersIndex
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
@@ -64,15 +69,13 @@ Total: \\d+s\\Z
 
     specify do
       output = StringIO.new
-      expect { described_class.reset(only: 'places', output: output) }
-        .to update_index(PlacesIndex::City)
+      expect { described_class.reset(only: 'cities', output: output) }
+        .to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AResetting PlacesIndex
-  Imported PlacesIndex::City in \\d+s, stats: index 3
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
-  Applying journal to \\[PlacesIndex::City, PlacesIndex::Country\\], 3 entries, stage 1
-  Imported PlacesIndex::City in \\d+s, stats: index 2
-  Imported PlacesIndex::Country in \\d+s, stats: index 1
+\\AResetting CitiesIndex
+  Imported CitiesIndex::City in \\d+s, stats: index 3
+  Applying journal to \\[CitiesIndex::City\\], 2 entries, stage 1
+  Imported CitiesIndex::City in \\d+s, stats: index 2
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
 Total: \\d+s\\Z
       OUTPUT
@@ -80,8 +83,8 @@ Total: \\d+s\\Z
 
     specify do
       output = StringIO.new
-      expect { described_class.reset(except: PlacesIndex, output: output) }
-        .not_to update_index(PlacesIndex::City)
+      expect { described_class.reset(except: [CitiesIndex, CountriesIndex], output: output) }
+        .not_to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AResetting UsersIndex
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
@@ -94,11 +97,13 @@ Total: \\d+s\\Z
     specify do
       output = StringIO.new
       expect { described_class.upgrade(output: output) }
-        .to update_index(PlacesIndex::City)
+        .to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AResetting PlacesIndex
-  Imported PlacesIndex::City in \\d+s, stats: index 3
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
+\\AResetting CitiesIndex
+  Imported CitiesIndex::City in \\d+s, stats: index 3
+  Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
+Resetting CountriesIndex
+  Imported CountriesIndex::Country in \\d+s, stats: index 2
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
 Resetting UsersIndex
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
@@ -107,14 +112,18 @@ Total: \\d+s\\Z
     end
 
     context do
-      before { PlacesIndex.reset! }
+      before do
+        CitiesIndex.reset!
+        CountriesIndex.reset!
+      end
 
       specify do
         output = StringIO.new
         expect { described_class.upgrade(output: output) }
-          .not_to update_index(PlacesIndex::City)
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASkipping PlacesIndex, the specification didn't change
+\\ASkipping CitiesIndex, the specification didn't change
+Skipping CountriesIndex, the specification didn't change
 Resetting UsersIndex
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
 Total: \\d+s\\Z
@@ -123,8 +132,8 @@ Total: \\d+s\\Z
 
       specify do
         output = StringIO.new
-        expect { described_class.upgrade(except: PlacesIndex, output: output) }
-          .not_to update_index(PlacesIndex::City)
+        expect { described_class.upgrade(except: [CitiesIndex, CountriesIndex], output: output) }
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AResetting UsersIndex
   Imported Chewy::Stash::Specification::Specification in \\d+s, stats: index 1
@@ -137,8 +146,8 @@ Total: \\d+s\\Z
 
         specify do
           output = StringIO.new
-          expect { described_class.upgrade(except: ['places'], output: output) }
-            .not_to update_index(PlacesIndex::City)
+          expect { described_class.upgrade(except: %w[cities countries], output: output) }
+            .not_to update_index(CitiesIndex)
           expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\ANo index specification was changed
 Total: \\d+s\\Z
@@ -152,45 +161,51 @@ Total: \\d+s\\Z
     specify do
       output = StringIO.new
       expect { described_class.update(output: output) }
-        .not_to update_index(PlacesIndex::City)
+        .not_to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASkipping PlacesIndex, it does not exists \\(use rake chewy:reset\\[places\\] to create and update it\\)
+\\ASkipping CitiesIndex, it does not exists \\(use rake chewy:reset\\[cities\\] to create and update it\\)
+Skipping CountriesIndex, it does not exists \\(use rake chewy:reset\\[countries\\] to create and update it\\)
+Total: \\d+s\\Z
       OUTPUT
     end
 
     context do
-      before { PlacesIndex.reset! }
+      before do
+        CitiesIndex.reset!
+        CountriesIndex.reset!
+      end
 
       specify do
         output = StringIO.new
         expect { described_class.update(output: output) }
-          .to update_index(PlacesIndex::City)
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AUpdating PlacesIndex
-  Imported PlacesIndex::City in \\d+s, stats: index 3
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
+\\AUpdating CitiesIndex
+  Imported CitiesIndex::City in \\d+s, stats: index 3
+Updating CountriesIndex
+  Imported CountriesIndex::Country in \\d+s, stats: index 2
 Total: \\d+s\\Z
         OUTPUT
       end
 
       specify do
         output = StringIO.new
-        expect { described_class.update(only: 'places#country', output: output) }
-          .not_to update_index(PlacesIndex::City)
+        expect { described_class.update(only: 'countries', output: output) }
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AUpdating PlacesIndex
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
+\\AUpdating CountriesIndex
+  Imported CountriesIndex::Country in \\d+s, stats: index 2
 Total: \\d+s\\Z
         OUTPUT
       end
 
       specify do
         output = StringIO.new
-        expect { described_class.update(except: PlacesIndex::Country, output: output) }
-          .to update_index(PlacesIndex::City)
+        expect { described_class.update(except: CountriesIndex, output: output) }
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\AUpdating PlacesIndex
-  Imported PlacesIndex::City in \\d+s, stats: index 3
+\\AUpdating CitiesIndex
+  Imported CitiesIndex::City in \\d+s, stats: index 3
 Total: \\d+s\\Z
         OUTPUT
       end
@@ -201,15 +216,15 @@ Total: \\d+s\\Z
     specify do
       output = StringIO.new
       expect { described_class.sync(output: output) }
-        .to update_index(PlacesIndex::City)
+        .to update_index(CitiesIndex)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASynchronizing PlacesIndex::City
-  Imported PlacesIndex::City in \\d+s, stats: index 3
+\\ASynchronizing CitiesIndex::City
+  Imported CitiesIndex::City in \\d+s, stats: index 3
   Missing documents: \\[[^\\]]+\\]
   Took \\d+s
-Synchronizing PlacesIndex::Country
-  PlacesIndex::Country doesn't support outdated synchronization
-  Imported PlacesIndex::Country in \\d+s, stats: index 2
+Synchronizing CountriesIndex::Country
+  CountriesIndex::Country doesn't support outdated synchronization
+  Imported CountriesIndex::Country in \\d+s, stats: index 2
   Missing documents: \\[[^\\]]+\\]
   Took \\d+s
 Total: \\d+s\\Z
@@ -218,8 +233,8 @@ Total: \\d+s\\Z
 
     context do
       before do
-        PlacesIndex::City.import(cities.first(2))
-        PlacesIndex::Country.import
+        CitiesIndex.import(cities.first(2))
+        CountriesIndex.import
 
         sleep(1) if ActiveSupport::VERSION::STRING < '4.1.0'
         cities.first.update(name: 'Name5')
@@ -228,16 +243,16 @@ Total: \\d+s\\Z
       specify do
         output = StringIO.new
         expect { described_class.sync(output: output) }
-          .to update_index(PlacesIndex::City)
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASynchronizing PlacesIndex::City
-  Imported PlacesIndex::City in \\d+s, stats: index 2
+\\ASynchronizing CitiesIndex::City
+  Imported CitiesIndex::City in \\d+s, stats: index 2
   Missing documents: \\["#{cities.last.id}"\\]
   Outdated documents: \\["#{cities.first.id}"\\]
   Took \\d+s
-Synchronizing PlacesIndex::Country
-  PlacesIndex::Country doesn't support outdated synchronization
-  Skipping PlacesIndex::Country, up to date
+Synchronizing CountriesIndex::Country
+  CountriesIndex::Country doesn't support outdated synchronization
+  Skipping CountriesIndex::Country, up to date
   Took \\d+s
 Total: \\d+s\\Z
         OUTPUT
@@ -245,11 +260,11 @@ Total: \\d+s\\Z
 
       specify do
         output = StringIO.new
-        expect { described_class.sync(only: PlacesIndex::City, output: output) }
-          .to update_index(PlacesIndex::City)
+        expect { described_class.sync(only: CitiesIndex, output: output) }
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASynchronizing PlacesIndex::City
-  Imported PlacesIndex::City in \\d+s, stats: index 2
+\\ASynchronizing CitiesIndex::City
+  Imported CitiesIndex::City in \\d+s, stats: index 2
   Missing documents: \\["#{cities.last.id}"\\]
   Outdated documents: \\["#{cities.first.id}"\\]
   Took \\d+s
@@ -259,12 +274,12 @@ Total: \\d+s\\Z
 
       specify do
         output = StringIO.new
-        expect { described_class.sync(except: ['places#city'], output: output) }
-          .not_to update_index(PlacesIndex::City)
+        expect { described_class.sync(except: ['cities'], output: output) }
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
-\\ASynchronizing PlacesIndex::Country
-  PlacesIndex::Country doesn't support outdated synchronization
-  Skipping PlacesIndex::Country, up to date
+\\ASynchronizing CountriesIndex::Country
+  CountriesIndex::Country doesn't support outdated synchronization
+  Skipping CountriesIndex::Country, up to date
   Took \\d+s
 Total: \\d+s\\Z
         OUTPUT
@@ -290,12 +305,12 @@ Total: \\d+s\\Z
       specify do
         output = StringIO.new
         expect { described_class.journal_apply(time: Time.now, output: output) }
-          .to update_index(PlacesIndex::City)
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AApplying journal entries created after [+-:\\d\\s]+
-  Applying journal to \\[PlacesIndex::City, PlacesIndex::Country\\], 3 entries, stage 1
-  Imported PlacesIndex::City in \\d+s, stats: index 2
-  Imported PlacesIndex::Country in \\d+s, stats: index 1
+  Applying journal to \\[CitiesIndex::City, CountriesIndex::Country\\], 3 entries, stage 1
+  Imported CitiesIndex::City in \\d+s, stats: index 2
+  Imported CountriesIndex::Country in \\d+s, stats: index 1
 Total: \\d+s\\Z
         OUTPUT
       end
@@ -303,35 +318,35 @@ Total: \\d+s\\Z
       specify do
         output = StringIO.new
         expect { described_class.journal_apply(time: 3.minutes.since, output: output) }
-          .not_to update_index(PlacesIndex::City)
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AApplying journal entries created after [+-:\\d\\s]+
-  Applying journal to \\[PlacesIndex::Country\\], 1 entries, stage 1
-  Imported PlacesIndex::Country in \\d+s, stats: index 1
+  Applying journal to \\[CountriesIndex::Country\\], 1 entries, stage 1
+  Imported CountriesIndex::Country in \\d+s, stats: index 1
 Total: \\d+s\\Z
         OUTPUT
       end
 
       specify do
         output = StringIO.new
-        expect { described_class.journal_apply(time: Time.now, only: PlacesIndex::City, output: output) }
-          .to update_index(PlacesIndex::City)
+        expect { described_class.journal_apply(time: Time.now, only: CitiesIndex, output: output) }
+          .to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AApplying journal entries created after [+-:\\d\\s]+
-  Applying journal to \\[PlacesIndex::City\\], 2 entries, stage 1
-  Imported PlacesIndex::City in \\d+s, stats: index 2
+  Applying journal to \\[CitiesIndex::City\\], 2 entries, stage 1
+  Imported CitiesIndex::City in \\d+s, stats: index 2
 Total: \\d+s\\Z
         OUTPUT
       end
 
       specify do
         output = StringIO.new
-        expect { described_class.journal_apply(time: Time.now, except: PlacesIndex::City, output: output) }
-          .not_to update_index(PlacesIndex::City)
+        expect { described_class.journal_apply(time: Time.now, except: CitiesIndex, output: output) }
+          .not_to update_index(CitiesIndex)
         expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\AApplying journal entries created after [+-:\\d\\s]+
-  Applying journal to \\[PlacesIndex::Country\\], 1 entries, stage 1
-  Imported PlacesIndex::Country in \\d+s, stats: index 1
+  Applying journal to \\[CountriesIndex::Country\\], 1 entries, stage 1
+  Imported CountriesIndex::Country in \\d+s, stats: index 1
 Total: \\d+s\\Z
         OUTPUT
       end
@@ -362,7 +377,7 @@ Total: \\d+s\\Z
 
     specify do
       output = StringIO.new
-      described_class.journal_clean(only: PlacesIndex::City, output: output)
+      described_class.journal_clean(only: CitiesIndex, output: output)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\ACleaned up 1 journal entries
 Total: \\d+s\\Z
@@ -371,7 +386,7 @@ Total: \\d+s\\Z
 
     specify do
       output = StringIO.new
-      described_class.journal_clean(except: PlacesIndex::City, output: output)
+      described_class.journal_clean(except: CitiesIndex, output: output)
       expect(output.string).to match(Regexp.new(<<-OUTPUT, Regexp::MULTILINE))
 \\ACleaned up 1 journal entries
 Total: \\d+s\\Z