chewy 5.1.0 → 7.2.7

data/spec/chewy/{type → index}/syncer_spec.rb

@@ -1,36 +1,34 @@
 require 'spec_helper'
 
-describe Chewy::Type::Syncer, :orm do
+describe Chewy::Index::Syncer, :orm do
   before { Chewy.massacre }
   before do
     stub_model(:city)
     stub_index(:cities) do
-      define_type City do
-        field :name
-        field :updated_at, type: 'date'
-      end
+      index_scope City
+      field :name
+      field :updated_at, type: 'date'
     end
   end
 
   shared_examples 'sync' do |options = {}|
     let!(:cities) { Array.new(3) { |i| City.create!(name: "Name#{i + 1}") } }
-    subject { described_class.new(CitiesIndex::City, **options) }
+    subject { described_class.new(CitiesIndex, **options) }
 
     describe '#perform' do
-      before { CitiesIndex::City.import!(cities) }
+      before { CitiesIndex.import!(cities) }
       specify { expect(subject.perform).to eq(0) }
 
       context do
         before do
           cities.first.destroy
-          sleep(1) if ActiveSupport::VERSION::STRING < '4.1.0'
           cities.last.update(name: 'Name5')
         end
         let!(:additional_city) { City.create!(name: 'Name4') }
 
         specify { expect(subject.perform).to eq(3) }
         specify do
-          expect { subject.perform }.to update_index(CitiesIndex::City)
+          expect { subject.perform }.to update_index(CitiesIndex)
             .and_reindex(additional_city, cities.last)
             .and_delete(cities.first).only
         end
@@ -39,9 +37,8 @@ describe Chewy::Type::Syncer, :orm do
       context 'does not support outdated sync' do
         before do
           stub_index(:cities) do
-            define_type City do
-              field :name
-            end
+            index_scope City
+            field :name
           end
         end
 
@@ -56,7 +53,7 @@ describe Chewy::Type::Syncer, :orm do
 
           specify { expect(subject.perform).to eq(2) }
           specify do
-            expect { subject.perform }.to update_index(CitiesIndex::City)
+            expect { subject.perform }.to update_index(CitiesIndex)
               .and_reindex(additional_city)
               .and_delete(cities.first).only
           end
@@ -68,7 +65,7 @@ describe Chewy::Type::Syncer, :orm do
       specify { expect(subject.missing_ids).to match_array(cities.map(&:id).map(&:to_s)) }
 
       context do
-        before { CitiesIndex::City.import!(cities) }
+        before { CitiesIndex.import!(cities) }
         specify { expect(subject.missing_ids).to eq([]) }
 
         context do
@@ -83,12 +80,11 @@ describe Chewy::Type::Syncer, :orm do
       specify { expect(subject.outdated_ids).to eq([]) }
 
       context do
-        before { CitiesIndex::City.import!(cities) }
+        before { CitiesIndex.import!(cities) }
         specify { expect(subject.outdated_ids).to eq([]) }
 
         context do
           before do
-            sleep(1) if ActiveSupport::VERSION::STRING < '4.1.0'
             cities.first.update(name: 'Name4')
             cities.last.update(name: 'Name5')
           end
@@ -99,9 +95,8 @@ describe Chewy::Type::Syncer, :orm do
       context 'does not support outdated sync' do
         before do
           stub_index(:cities) do
-            define_type City do
-              field :name
-            end
+            index_scope City
+            field :name
           end
         end
 

data/spec/chewy/{type → index}/witchcraft_spec.rb

@@ -1,25 +1,23 @@
 require 'spec_helper'
 
-describe Chewy::Type::Witchcraft do
+describe Chewy::Index::Witchcraft do
   def self.mapping(&block)
     before do
       stub_index(:products) do
-        define_type :product do
-          witchcraft!
+        witchcraft!
 
-          instance_exec(&block)
-        end
+        instance_exec(&block)
       end
     end
   end
 
   describe '#cauldron' do
-    let(:type) { ProductsIndex::Product }
+    let(:index) { ProductsIndex }
     let(:object) {}
 
     context 'empty mapping' do
       mapping {}
-      specify { expect(type.cauldron.brew(object)).to eq({}) }
+      specify { expect(index.cauldron.brew(object)).to eq({}) }
     end
 
     context do
@@ -32,18 +30,18 @@ describe Chewy::Type::Witchcraft do
 
       context do
         let(:object) { double(attributes) }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq(attributes.as_json) }
       end
 
       context do
         let(:object) { attributes }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq(attributes.as_json) }
       end
 
       context do
         let(:object) { double(attributes) }
         specify do
-          expect(type.cauldron(fields: %i[name tags]).brew(object))
+          expect(index.cauldron(fields: %i[name tags]).brew(object))
             .to eq('name' => 'Name', 'tags' => %w[Ruby RoR])
         end
       end
@@ -51,7 +49,7 @@ describe Chewy::Type::Witchcraft do
       context do
         let(:object) { attributes }
         specify do
-          expect(type.cauldron(fields: %i[name tags]).brew(object))
+          expect(index.cauldron(fields: %i[name tags]).brew(object))
             .to eq('name' => 'Name', 'tags' => %w[Ruby RoR])
         end
       end
@@ -69,7 +67,7 @@ describe Chewy::Type::Witchcraft do
 
       context do
         let(:object) { double(attributes) }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.merge(tags: %i[Ruby RoR]).as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq(attributes.merge(tags: %i[Ruby RoR]).as_json) }
       end
     end
 
@@ -82,7 +80,7 @@ describe Chewy::Type::Witchcraft do
       context do
         let(:object) { double(attributes) }
         let(:crutches) { double(names: ['Other']) }
-        specify { expect(type.cauldron.brew(object, crutches)).to eq({name: 'Other'}.as_json) }
+        specify { expect(index.cauldron.brew(object, crutches)).to eq({name: 'Other'}.as_json) }
       end
     end
 
@@ -102,7 +100,7 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({queries: [
+          expect(index.cauldron.brew(object)).to eq({queries: [
             {title: 'Title1', body: 'This Body1'},
             {title: 'Title2', body: 'This Body2'}
           ]}.as_json)
@@ -124,7 +122,7 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({queries: [
+          expect(index.cauldron.brew(object)).to eq({queries: [
             {title: 'Title1', body: 'This Body1'},
             {title: 'Title2', body: 'This Body2'}
           ]}.as_json)
@@ -146,7 +144,7 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({queries: [
+          expect(index.cauldron.brew(object)).to eq({queries: [
             {title: 'Title1', body: 'This Body1'},
             {title: 'Title2', body: 'This Body2'}
           ]}.as_json)
@@ -172,7 +170,7 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object, double(second: 'Crutch'))).to eq({queries: [
+          expect(index.cauldron.brew(object, double(second: 'Crutch'))).to eq({queries: [
             {fields: [
               {first: 'First1', second: 'Value1Second1'},
               {first: 'First2', second: 'Value1Crutch'}
@@ -181,6 +179,21 @@ describe Chewy::Type::Witchcraft do
           ]}.as_json)
         end
       end
+
+      context do
+        mapping do
+          field :not_present do
+            field :nothing
+          end
+        end
+
+        let(:object) do
+          double(not_present: nil)
+        end
+        specify do
+          expect(index.cauldron.brew(object)).to eq({not_present: nil}.as_json)
+        end
+      end
     end
 
     context 'dynamic fields' do
@@ -193,7 +206,7 @@ describe Chewy::Type::Witchcraft do
 
       context do
         let(:object) { double(attributes) }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq(attributes.as_json) }
       end
     end
 
@@ -209,7 +222,7 @@ describe Chewy::Type::Witchcraft do
 
       context do
         let(:object) { double(attributes) }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq(attributes.as_json) }
       end
     end
 
@@ -220,12 +233,12 @@ describe Chewy::Type::Witchcraft do
 
       context do
         let(:object) { double(last_name: 'Name') }
-        specify { expect(type.cauldron.brew(object)).to eq({name: 'Name'}.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq({name: 'Name'}.as_json) }
       end
 
       context do
         let(:object) { {'last_name' => 'Name'} }
-        specify { expect(type.cauldron.brew(object)).to eq({name: 'Name'}.as_json) }
+        specify { expect(index.cauldron.brew(object)).to eq({name: 'Name'}.as_json) }
       end
     end
   end

data/spec/chewy/index/wrapper_spec.rb

@@ -0,0 +1,100 @@
+require 'spec_helper'
+
+describe Chewy::Index::Wrapper do
+  before do
+    stub_class(:city)
+    stub_index(:cities) do
+      index_scope City
+    end
+  end
+
+  let(:cities_index) { CitiesIndex }
+
+  describe '.build' do
+    specify do
+      expect(cities_index.build({}).attributes)
+        .to eq('id' => nil, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(cities_index.build('_source' => {name: 'Martin'}).attributes)
+        .to eq('id' => nil, '_score' => nil, '_explanation' => nil, 'name' => 'Martin')
+    end
+    specify do
+      expect(cities_index.build('_id' => 42).attributes)
+        .to eq('id' => 42, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(cities_index.build('_id' => 42, '_source' => {'id' => 43}).attributes)
+        .to eq('id' => 43, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(cities_index.build('_score' => 42, '_explanation' => {foo: 'bar'}).attributes)
+        .to eq('id' => nil, '_score' => 42, '_explanation' => {foo: 'bar'})
+    end
+    specify do
+      expect(cities_index.build('_score' => 42, 'borogoves' => {foo: 'bar'})._data)
+        .to eq('_score' => 42, 'borogoves' => {foo: 'bar'})
+    end
+  end
+
+  describe '#initialize' do
+    subject(:city) { cities_index.new(name: 'Martin', age: 42) }
+
+    it do
+      is_expected.to respond_to(:name)
+        .and respond_to(:age)
+        .and have_attributes(
+          name: 'Martin',
+          age: 42
+        )
+    end
+
+    it { expect { city.population }.to raise_error(NoMethodError) }
+
+    context 'highlight' do
+      subject(:city) do
+        cities_index.new(name: 'Martin', age: 42)
+          .tap do |city|
+            city._data = {
+              'highlight' => {'name' => ['<b>Mar</b>tin']}
+            }
+          end
+      end
+
+      it do
+        is_expected.to respond_to(:name_highlight)
+          .and respond_to(:name_highlights)
+          .and have_attributes(
+            name: 'Martin',
+            name_highlight: '<b>Mar</b>tin',
+            name_highlights: ['<b>Mar</b>tin']
+          )
+      end
+    end
+  end
+
+  describe '#==' do
+    specify { expect(cities_index.new(id: 42)).to eq(cities_index.new(id: 42)) }
+    specify { expect(cities_index.new(id: 42, age: 55)).to eq(cities_index.new(id: 42, age: 54)) }
+    specify { expect(cities_index.new(id: 42)).not_to eq(cities_index.new(id: 43)) }
+    specify { expect(cities_index.new(id: 42, age: 55)).not_to eq(cities_index.new(id: 43, age: 55)) }
+    specify { expect(cities_index.new(age: 55)).to eq(cities_index.new(age: 55)) }
+    specify { expect(cities_index.new(age: 55)).not_to eq(cities_index.new(age: 54)) }
+
+    specify { expect(cities_index.new(id: '42')).to eq(City.new.tap { |m| allow(m).to receive_messages(id: 42) }) }
+    specify { expect(cities_index.new(id: 42)).not_to eq(City.new.tap { |m| allow(m).to receive_messages(id: 43) }) }
+    specify { expect(cities_index.new(id: 42)).not_to eq(Class.new) }
+
+    context 'models', :orm do
+      before do
+        stub_model(:city)
+        stub_index(:cities) do
+          index_scope City
+        end
+      end
+      specify { expect(cities_index.new(id: '42')).to eq(City.new.tap { |m| allow(m).to receive_messages(id: 42) }) }
+      specify { expect(cities_index.new(id: 42)).not_to eq(City.new.tap { |m| allow(m).to receive_messages(id: 43) }) }
+      specify { expect(cities_index.new(id: 42)).not_to eq(Class.new) }
+    end
+  end
+end