chewy 0.9.0 → 0.10.0

data/spec/chewy/type/mapping_spec.rb

@@ -16,7 +16,7 @@ describe Chewy::Type::Mapping do
             field :subfield2
           end
           agg :named_agg do
-            { avg: { field: 'title.subfield1' } }
+            {avg: {field: 'title.subfield1'}}
           end
         end
       end
@@ -27,19 +27,47 @@ describe Chewy::Type::Mapping do
           field :rating, type: 'long'
         end
         agg :named_agg do
-          { avg: { field: 'comments.rating' } }
+          {avg: {field: 'comments.rating'}}
         end
       end
     end
   end
 
+  context 'no root element call' do
+    before do
+      stub_index(:products) do
+        define_type :product do
+          field :title, type: 'string' do
+            field :subfield1
+          end
+        end
+      end
+    end
+
+    specify { expect(product.root_object.children.map(&:name)).to eq([:title]) }
+    specify { expect(product.root_object.children.map(&:parent)).to eq([product.root_object]) }
+    specify { expect(product.root_object.children[0].children.map(&:name)).to eq([:subfield1]) }
+    specify { expect(product.root_object.children[0].children.map(&:parent)).to eq([product.root_object.children[0]]) }
+
+    context 'default root options are set' do
+      around do |example|
+        previous_options = Chewy.default_root_options
+        Chewy.default_root_options = {_all: {enabled: false}}
+        example.run
+        Chewy.default_root_options = previous_options
+      end
+
+      specify { expect(product.mappings_hash[:product]).to include(_all: {enabled: false}) }
+    end
+  end
+
   describe '.agg' do
-    specify { expect(product._agg_defs[:named_agg].call).to eq(avg: { field: 'title.subfield1' }) }
-    specify { expect(review._agg_defs[:named_agg].call).to eq(avg: { field: 'comments.rating' }) }
+    specify { expect(product._agg_defs[:named_agg].call).to eq(avg: {field: 'title.subfield1'}) }
+    specify { expect(review._agg_defs[:named_agg].call).to eq(avg: {field: 'comments.rating'}) }
   end
 
   describe '.field' do
-    specify { expect(product.root_object.children.map(&:name)).to eq([:name, :surname, :title, :price]) }
+    specify { expect(product.root_object.children.map(&:name)).to eq(%i[name surname title price]) }
     specify { expect(product.root_object.children.map(&:parent)).to eq([product.root_object] * 4) }
 
     specify { expect(product.root_object.children[0].children.map(&:name)).to eq([]) }
@@ -75,7 +103,7 @@ describe Chewy::Type::Mapping do
         before do
           stub_index(:products) do
             define_type :product do
-              root parent: { 'type' => 'project' }, parent_id: -> { project_id } do
+              root parent: {'type' => 'project'}, parent_id: -> { project_id } do
                 field :name, 'surname'
               end
             end
@@ -87,20 +115,28 @@ describe Chewy::Type::Mapping do
     end
   end
 
-  context 'no root element call' do
-    before do
-      stub_index(:products) do
-        define_type :product do
-          field :title, type: 'string' do
-            field :subfield1
-          end
-        end
+  describe '.supports_outdated_sync?' do
+    def type(&block)
+      stub_index(:cities) do
+        define_type :city, &block
       end
+      CitiesIndex::City
     end
 
-    specify { expect(product.root_object.children.map(&:name)).to eq([:title]) }
-    specify { expect(product.root_object.children.map(&:parent)).to eq([product.root_object]) }
-    specify { expect(product.root_object.children[0].children.map(&:name)).to eq([:subfield1]) }
-    specify { expect(product.root_object.children[0].children.map(&:parent)).to eq([product.root_object.children[0]]) }
+    specify { expect(type.supports_outdated_sync?).to eq(false) }
+    specify { expect(type { field :updated_at }.supports_outdated_sync?).to eq(true) }
+    specify { expect(type { field :updated_at, value: -> {} }.supports_outdated_sync?).to eq(false) }
+    specify do
+      expect(type do
+        self.outdated_sync_field = :version
+        field :updated_at
+      end.supports_outdated_sync?).to eq(false)
+    end
+    specify do
+      expect(type do
+        self.outdated_sync_field = :version
+        field :version
+      end.supports_outdated_sync?).to eq(true)
+    end
   end
 end

data/spec/chewy/type/observe_spec.rb

@@ -50,7 +50,11 @@ describe Chewy::Type::Observe do
         Country.one_to_many :cities
         City.plugin :dirty
       else
-        City.belongs_to :country
+        if adapter == :mongoid && Mongoid::VERSION.start_with?('6')
+          City.belongs_to :country, optional: true
+        else
+          City.belongs_to :country
+        end
         Country.has_many :cities
       end
 

data/spec/chewy/type/syncer_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+describe Chewy::Type::Syncer, :orm do
+  before { Chewy.massacre }
+  before do
+    stub_model(:city)
+    stub_index(:cities) do
+      define_type City do
+        field :name
+        field :updated_at, type: 'date'
+      end
+    end
+  end
+
+  shared_examples 'sync' do |options = {}|
+    let!(:cities) { Array.new(3) { |i| City.create!(name: "Name#{i + 1}") } }
+    subject { described_class.new(CitiesIndex::City, **options) }
+
+    describe '#perform' do
+      before { CitiesIndex::City.import!(cities) }
+      specify { expect(subject.perform).to eq(0) }
+
+      context do
+        before do
+          cities.first.destroy
+          sleep(1) if ActiveSupport::VERSION::STRING < '4.1.0'
+          cities.last.update(name: 'Name5')
+        end
+        let!(:additional_city) { City.create!(name: 'Name4') }
+
+        specify { expect(subject.perform).to eq(3) }
+        specify do
+          expect { subject.perform }.to update_index(CitiesIndex::City)
+            .and_reindex(additional_city, cities.last)
+            .and_delete(cities.first).only
+        end
+      end
+
+      context 'does not support outdated sync' do
+        before do
+          stub_index(:cities) do
+            define_type City do
+              field :name
+            end
+          end
+        end
+
+        specify { expect(subject.perform).to eq(0) }
+
+        context do
+          before do
+            cities.first.destroy
+            cities.last.update(name: 'Name5')
+          end
+          let!(:additional_city) { City.create!(name: 'Name4') }
+
+          specify { expect(subject.perform).to eq(2) }
+          specify do
+            expect { subject.perform }.to update_index(CitiesIndex::City)
+              .and_reindex(additional_city)
+              .and_delete(cities.first).only
+          end
+        end
+      end
+    end
+
+    describe '#missing_ids' do
+      specify { expect(subject.missing_ids).to match_array(cities.map(&:id).map(&:to_s)) }
+
+      context do
+        before { CitiesIndex::City.import!(cities) }
+        specify { expect(subject.missing_ids).to eq([]) }
+
+        context do
+          let!(:additional_city) { City.create!(name: 'Name4') }
+          before { cities.first.destroy }
+          specify { expect(subject.missing_ids).to contain_exactly(cities.first.id.to_s, additional_city.id.to_s) }
+        end
+      end
+    end
+
+    describe '#outdated_ids' do
+      specify { expect(subject.outdated_ids).to eq([]) }
+
+      context do
+        before { CitiesIndex::City.import!(cities) }
+        specify { expect(subject.outdated_ids).to eq([]) }
+
+        context do
+          before do
+            sleep(1) if ActiveSupport::VERSION::STRING < '4.1.0'
+            cities.first.update(name: 'Name4')
+            cities.last.update(name: 'Name5')
+          end
+          specify { expect(subject.outdated_ids).to contain_exactly(cities.first.id.to_s, cities.last.id.to_s) }
+        end
+      end
+
+      context 'does not support outdated sync' do
+        before do
+          stub_index(:cities) do
+            define_type City do
+              field :name
+            end
+          end
+        end
+
+        specify { expect(subject.outdated_ids).to eq([]) }
+
+        context do
+          before do
+            cities.first.update(name: 'Name4')
+            cities.last.update(name: 'Name5')
+          end
+          specify { expect(subject.outdated_ids).to eq([]) }
+        end
+      end
+    end
+  end
+
+  include_examples 'sync'
+  include_examples 'sync', parallel: 0
+end

data/spec/chewy/type/witchcraft_spec.rb

@@ -28,7 +28,7 @@ describe Chewy::Type::Witchcraft do
         field :age
         field :tags
       end
-      let(:attributes) { { name: 'Name', age: 13, tags: %w(Ruby RoR) } }
+      let(:attributes) { {name: 'Name', age: 13, tags: %w[Ruby RoR]} }
 
       context do
         let(:object) { double(attributes) }
@@ -39,6 +39,22 @@ describe Chewy::Type::Witchcraft do
         let(:object) { attributes }
         specify { expect(type.cauldron.brew(object)).to eq(attributes.as_json) }
       end
+
+      context do
+        let(:object) { double(attributes) }
+        specify do
+          expect(type.cauldron(fields: %i[name tags]).brew(object))
+            .to eq('name' => 'Name', 'tags' => %w[Ruby RoR])
+        end
+      end
+
+      context do
+        let(:object) { attributes }
+        specify do
+          expect(type.cauldron(fields: %i[name tags]).brew(object))
+            .to eq('name' => 'Name', 'tags' => %w[Ruby RoR])
+        end
+      end
     end
 
     context 'simple lambdas' do
@@ -49,11 +65,11 @@ describe Chewy::Type::Witchcraft do
         }
         field :tags, value: -> { tags.map(&:to_sym) }
       end
-      let(:attributes) { { name: 'Name', age: 13, tags: %w(Ruby RoR) } }
+      let(:attributes) { {name: 'Name', age: 13, tags: %w[Ruby RoR]} }
 
       context do
         let(:object) { double(attributes) }
-        specify { expect(type.cauldron.brew(object)).to eq(attributes.merge(tags: [:Ruby, :RoR]).as_json) }
+        specify { expect(type.cauldron.brew(object)).to eq(attributes.merge(tags: %i[Ruby RoR]).as_json) }
       end
     end
 
@@ -61,12 +77,12 @@ describe Chewy::Type::Witchcraft do
       mapping do
         field :name, value: ->(_o, c) { c.names[0] }
       end
-      let(:attributes) { { name: 'Name' } }
+      let(:attributes) { {name: 'Name'} }
 
       context do
         let(:object) { double(attributes) }
         let(:crutches) { double(names: ['Other']) }
-        specify { expect(type.cauldron.brew(object, crutches)).to eq({ name: 'Other' }.as_json) }
+        specify { expect(type.cauldron.brew(object, crutches)).to eq({name: 'Other'}.as_json) }
       end
     end
 
@@ -81,15 +97,15 @@ describe Chewy::Type::Witchcraft do
 
         let(:object) do
           double(queries: [
-            { title: 'Title1', body: 'Body1' },
-            { title: 'Title2', body: 'Body2' }
+            {title: 'Title1', body: 'Body1'},
+            {title: 'Title2', body: 'Body2'}
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({ queries: [
-            { title: 'Title1', body: 'This Body1' },
-            { title: 'Title2', body: 'This Body2' }
-          ] }.as_json)
+          expect(type.cauldron.brew(object)).to eq({queries: [
+            {title: 'Title1', body: 'This Body1'},
+            {title: 'Title2', body: 'This Body2'}
+          ]}.as_json)
         end
       end
 
@@ -108,10 +124,10 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({ queries: [
-            { title: 'Title1', body: 'This Body1' },
-            { title: 'Title2', body: 'This Body2' }
-          ] }.as_json)
+          expect(type.cauldron.brew(object)).to eq({queries: [
+            {title: 'Title1', body: 'This Body1'},
+            {title: 'Title2', body: 'This Body2'}
+          ]}.as_json)
         end
       end
 
@@ -130,10 +146,10 @@ describe Chewy::Type::Witchcraft do
           ])
         end
         specify do
-          expect(type.cauldron.brew(object)).to eq({ queries: [
-            { title: 'Title1', body: 'This Body1' },
-            { title: 'Title2', body: 'This Body2' }
-          ] }.as_json)
+          expect(type.cauldron.brew(object)).to eq({queries: [
+            {title: 'Title1', body: 'This Body1'},
+            {title: 'Title2', body: 'This Body2'}
+          ]}.as_json)
         end
       end
 
@@ -151,18 +167,18 @@ describe Chewy::Type::Witchcraft do
 
         let(:object) do
           double(queries: [
-            double(value: 'Value1', fields: [double(first: 'First1', second: 'Second1'), { first: 'First2' }]),
+            double(value: 'Value1', fields: [double(first: 'First1', second: 'Second1'), {first: 'First2'}]),
             double(value: 'Value2', fields: double(first: 'First3', second: 'Second2', third: 'Third'))
           ])
         end
         specify do
-          expect(type.cauldron.brew(object, double(second: 'Crutch'))).to eq({ queries: [
-            { fields: [
-              { first: 'First1', second: 'Value1Second1' },
-              { first: 'First2', second: 'Value1Crutch' }
-            ] },
-            { fields: { first: 'First3', second: 'Value2Second2' } }
-          ] }.as_json)
+          expect(type.cauldron.brew(object, double(second: 'Crutch'))).to eq({queries: [
+            {fields: [
+              {first: 'First1', second: 'Value1Second1'},
+              {first: 'First2', second: 'Value1Crutch'}
+            ]},
+            {fields: {first: 'First3', second: 'Value2Second2'}}
+          ]}.as_json)
         end
       end
     end
@@ -173,7 +189,7 @@ describe Chewy::Type::Witchcraft do
           field param.first, value: ->(o) { o.send(param[0]) if param[0] }
         end
       end
-      let(:attributes) { { name: 'Name', age: 13 } }
+      let(:attributes) { {name: 'Name', age: 13} }
 
       context do
         let(:object) { double(attributes) }
@@ -189,7 +205,7 @@ describe Chewy::Type::Witchcraft do
 
         field :name, value: custom_value(:name)
       end
-      let(:attributes) { { name: 'Name' } }
+      let(:attributes) { {name: 'Name'} }
 
       context do
         let(:object) { double(attributes) }

data/spec/chewy/type/wrapper_spec.rb

@@ -10,36 +10,65 @@ describe Chewy::Type::Wrapper do
 
   let(:city_type) { CitiesIndex::City }
 
-  subject(:city) { city_type.new(name: 'Martin', age: 42) }
-
-  it do
-    is_expected.to respond_to(:name)
-      .and respond_to(:age)
-      .and have_attributes(
-        name: 'Martin',
-        age: 42
-      )
+  describe '.build' do
+    specify do
+      expect(city_type.build({}).attributes)
+        .to eq('id' => nil, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(city_type.build('_source' => {name: 'Martin'}).attributes)
+        .to eq('id' => nil, '_score' => nil, '_explanation' => nil, 'name' => 'Martin')
+    end
+    specify do
+      expect(city_type.build('_id' => 42).attributes)
+        .to eq('id' => 42, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(city_type.build('_id' => 42, '_source' => {'id' => 43}).attributes)
+        .to eq('id' => 43, '_score' => nil, '_explanation' => nil)
+    end
+    specify do
+      expect(city_type.build('_score' => 42, '_explanation' => {foo: 'bar'}).attributes)
+        .to eq('id' => nil, '_score' => 42, '_explanation' => {foo: 'bar'})
+    end
+    specify do
+      expect(city_type.build('_score' => 42, 'borogoves' => {foo: 'bar'})._data)
+        .to eq('_score' => 42, 'borogoves' => {foo: 'bar'})
+    end
   end
 
-  it { expect { city.population }.to raise_error(NoMethodError) }
-
-  context 'highlight' do
-    subject(:city) do
-      city_type.new(name: 'Martin', age: 42)
-        .tap do |city|
-          city._data = {
-            'highlight' => { 'name' => ['<b>Mar</b>tin'] }
-          }
-        end
-    end
+  describe '#initialize' do
+    subject(:city) { city_type.new(name: 'Martin', age: 42) }
 
     it do
-      is_expected.to respond_to(:name_highlight)
+      is_expected.to respond_to(:name)
+        .and respond_to(:age)
         .and have_attributes(
           name: 'Martin',
-          name_highlight: '<b>Mar</b>tin'
+          age: 42
         )
     end
+
+    it { expect { city.population }.to raise_error(NoMethodError) }
+
+    context 'highlight' do
+      subject(:city) do
+        city_type.new(name: 'Martin', age: 42)
+          .tap do |city|
+            city._data = {
+              'highlight' => {'name' => ['<b>Mar</b>tin']}
+            }
+          end
+      end
+
+      it do
+        is_expected.to respond_to(:name_highlight)
+          .and have_attributes(
+            name: 'Martin',
+            name_highlight: '<b>Mar</b>tin'
+          )
+      end
+    end
   end
 
   describe '#==' do
@@ -52,7 +81,18 @@ describe Chewy::Type::Wrapper do
 
     specify { expect(city_type.new(id: '42')).to eq(City.new.tap { |m| allow(m).to receive_messages(id: 42) }) }
     specify { expect(city_type.new(id: 42)).not_to eq(City.new.tap { |m| allow(m).to receive_messages(id: 43) }) }
-
     specify { expect(city_type.new(id: 42)).not_to eq(Class.new) }
+
+    context 'models', :orm do
+      before do
+        stub_model(:city)
+        stub_index(:cities) do
+          define_type City
+        end
+      end
+      specify { expect(city_type.new(id: '42')).to eq(City.new.tap { |m| allow(m).to receive_messages(id: 42) }) }
+      specify { expect(city_type.new(id: 42)).not_to eq(City.new.tap { |m| allow(m).to receive_messages(id: 43) }) }
+      specify { expect(city_type.new(id: 42)).not_to eq(Class.new) }
+    end
   end
 end