chewy 0.8.4 → 5.1.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (303) hide show
  1. checksums.yaml +5 -5
  2. data/.gitignore +1 -0
  3. data/.rubocop.yml +56 -0
  4. data/.rubocop_todo.yml +44 -0
  5. data/.travis.yml +36 -67
  6. data/.yardopts +5 -0
  7. data/Appraisals +63 -58
  8. data/CHANGELOG.md +168 -11
  9. data/Gemfile +16 -9
  10. data/Guardfile +5 -5
  11. data/LEGACY_DSL.md +497 -0
  12. data/README.md +403 -470
  13. data/Rakefile +11 -1
  14. data/chewy.gemspec +12 -15
  15. data/gemfiles/rails.4.0.activerecord.gemfile +9 -9
  16. data/gemfiles/rails.4.1.activerecord.gemfile +9 -9
  17. data/gemfiles/rails.4.2.activerecord.gemfile +8 -8
  18. data/gemfiles/rails.4.2.mongoid.5.2.gemfile +16 -0
  19. data/gemfiles/rails.5.0.activerecord.gemfile +16 -0
  20. data/gemfiles/rails.5.0.mongoid.6.1.gemfile +16 -0
  21. data/gemfiles/rails.5.1.activerecord.gemfile +16 -0
  22. data/gemfiles/rails.5.1.mongoid.6.3.gemfile +16 -0
  23. data/gemfiles/rails.5.2.activerecord.gemfile +16 -0
  24. data/gemfiles/sequel.4.45.gemfile +11 -0
  25. data/lib/chewy/backports/deep_dup.rb +1 -1
  26. data/lib/chewy/backports/duplicable.rb +1 -0
  27. data/lib/chewy/config.rb +53 -21
  28. data/lib/chewy/errors.rb +6 -6
  29. data/lib/chewy/fields/base.rb +59 -29
  30. data/lib/chewy/fields/root.rb +49 -14
  31. data/lib/chewy/index/actions.rb +95 -36
  32. data/lib/chewy/index/aliases.rb +2 -1
  33. data/lib/chewy/index/settings.rb +10 -5
  34. data/lib/chewy/index/specification.rb +60 -0
  35. data/lib/chewy/index.rb +239 -138
  36. data/lib/chewy/journal.rb +55 -0
  37. data/lib/chewy/log_subscriber.rb +8 -8
  38. data/lib/chewy/minitest/helpers.rb +77 -0
  39. data/lib/chewy/minitest/search_index_receiver.rb +80 -0
  40. data/lib/chewy/minitest.rb +1 -0
  41. data/lib/chewy/query/compose.rb +18 -19
  42. data/lib/chewy/query/criteria.rb +34 -24
  43. data/lib/chewy/query/filters.rb +28 -11
  44. data/lib/chewy/query/loading.rb +3 -4
  45. data/lib/chewy/query/nodes/and.rb +1 -1
  46. data/lib/chewy/query/nodes/base.rb +1 -1
  47. data/lib/chewy/query/nodes/bool.rb +6 -4
  48. data/lib/chewy/query/nodes/equal.rb +4 -4
  49. data/lib/chewy/query/nodes/exists.rb +1 -1
  50. data/lib/chewy/query/nodes/expr.rb +2 -2
  51. data/lib/chewy/query/nodes/field.rb +35 -31
  52. data/lib/chewy/query/nodes/has_child.rb +1 -0
  53. data/lib/chewy/query/nodes/has_parent.rb +1 -0
  54. data/lib/chewy/query/nodes/has_relation.rb +10 -12
  55. data/lib/chewy/query/nodes/missing.rb +1 -1
  56. data/lib/chewy/query/nodes/not.rb +1 -1
  57. data/lib/chewy/query/nodes/or.rb +1 -1
  58. data/lib/chewy/query/nodes/prefix.rb +3 -2
  59. data/lib/chewy/query/nodes/query.rb +1 -1
  60. data/lib/chewy/query/nodes/range.rb +9 -9
  61. data/lib/chewy/query/nodes/raw.rb +1 -1
  62. data/lib/chewy/query/nodes/regexp.rb +13 -9
  63. data/lib/chewy/query/nodes/script.rb +4 -4
  64. data/lib/chewy/query/pagination.rb +10 -1
  65. data/lib/chewy/query.rb +286 -170
  66. data/lib/chewy/railtie.rb +7 -6
  67. data/lib/chewy/rake_helper.rb +275 -37
  68. data/lib/chewy/repository.rb +2 -2
  69. data/lib/chewy/rspec/update_index.rb +70 -65
  70. data/lib/chewy/rspec.rb +1 -1
  71. data/lib/chewy/runtime/version.rb +4 -4
  72. data/lib/chewy/search/loader.rb +83 -0
  73. data/lib/chewy/{query → search}/pagination/kaminari.rb +13 -5
  74. data/lib/chewy/search/pagination/will_paginate.rb +43 -0
  75. data/lib/chewy/search/parameters/aggs.rb +16 -0
  76. data/lib/chewy/search/parameters/allow_partial_search_results.rb +27 -0
  77. data/lib/chewy/search/parameters/concerns/bool_storage.rb +24 -0
  78. data/lib/chewy/search/parameters/concerns/hash_storage.rb +23 -0
  79. data/lib/chewy/search/parameters/concerns/integer_storage.rb +14 -0
  80. data/lib/chewy/search/parameters/concerns/query_storage.rb +238 -0
  81. data/lib/chewy/search/parameters/concerns/string_array_storage.rb +23 -0
  82. data/lib/chewy/search/parameters/concerns/string_storage.rb +14 -0
  83. data/lib/chewy/search/parameters/docvalue_fields.rb +12 -0
  84. data/lib/chewy/search/parameters/explain.rb +16 -0
  85. data/lib/chewy/search/parameters/filter.rb +47 -0
  86. data/lib/chewy/search/parameters/highlight.rb +16 -0
  87. data/lib/chewy/search/parameters/indices.rb +123 -0
  88. data/lib/chewy/search/parameters/indices_boost.rb +52 -0
  89. data/lib/chewy/search/parameters/limit.rb +17 -0
  90. data/lib/chewy/search/parameters/load.rb +32 -0
  91. data/lib/chewy/search/parameters/min_score.rb +16 -0
  92. data/lib/chewy/search/parameters/none.rb +27 -0
  93. data/lib/chewy/search/parameters/offset.rb +17 -0
  94. data/lib/chewy/search/parameters/order.rb +64 -0
  95. data/lib/chewy/search/parameters/post_filter.rb +19 -0
  96. data/lib/chewy/search/parameters/preference.rb +16 -0
  97. data/lib/chewy/search/parameters/profile.rb +16 -0
  98. data/lib/chewy/search/parameters/query.rb +19 -0
  99. data/lib/chewy/search/parameters/request_cache.rb +27 -0
  100. data/lib/chewy/search/parameters/rescore.rb +29 -0
  101. data/lib/chewy/search/parameters/script_fields.rb +16 -0
  102. data/lib/chewy/search/parameters/search_after.rb +20 -0
  103. data/lib/chewy/search/parameters/search_type.rb +16 -0
  104. data/lib/chewy/search/parameters/source.rb +73 -0
  105. data/lib/chewy/search/parameters/storage.rb +95 -0
  106. data/lib/chewy/search/parameters/stored_fields.rb +63 -0
  107. data/lib/chewy/search/parameters/suggest.rb +16 -0
  108. data/lib/chewy/search/parameters/terminate_after.rb +16 -0
  109. data/lib/chewy/search/parameters/timeout.rb +16 -0
  110. data/lib/chewy/search/parameters/track_scores.rb +16 -0
  111. data/lib/chewy/search/parameters/types.rb +20 -0
  112. data/lib/chewy/search/parameters/version.rb +16 -0
  113. data/lib/chewy/search/parameters.rb +167 -0
  114. data/lib/chewy/search/query_proxy.rb +257 -0
  115. data/lib/chewy/search/request.rb +1045 -0
  116. data/lib/chewy/search/response.rb +119 -0
  117. data/lib/chewy/search/scoping.rb +50 -0
  118. data/lib/chewy/search/scrolling.rb +134 -0
  119. data/lib/chewy/search.rb +81 -26
  120. data/lib/chewy/stash.rb +79 -0
  121. data/lib/chewy/strategy/active_job.rb +1 -0
  122. data/lib/chewy/strategy/atomic.rb +2 -4
  123. data/lib/chewy/strategy/base.rb +4 -4
  124. data/lib/chewy/strategy/bypass.rb +1 -2
  125. data/lib/chewy/strategy/resque.rb +1 -0
  126. data/lib/chewy/strategy/shoryuken.rb +40 -0
  127. data/lib/chewy/strategy/sidekiq.rb +13 -1
  128. data/lib/chewy/strategy/urgent.rb +1 -1
  129. data/lib/chewy/strategy.rb +19 -10
  130. data/lib/chewy/type/actions.rb +26 -2
  131. data/lib/chewy/type/adapter/active_record.rb +50 -24
  132. data/lib/chewy/type/adapter/base.rb +29 -9
  133. data/lib/chewy/type/adapter/mongoid.rb +19 -10
  134. data/lib/chewy/type/adapter/object.rb +195 -31
  135. data/lib/chewy/type/adapter/orm.rb +69 -33
  136. data/lib/chewy/type/adapter/sequel.rb +37 -19
  137. data/lib/chewy/type/crutch.rb +5 -4
  138. data/lib/chewy/type/import/bulk_builder.rb +122 -0
  139. data/lib/chewy/type/import/bulk_request.rb +78 -0
  140. data/lib/chewy/type/import/journal_builder.rb +45 -0
  141. data/lib/chewy/type/import/routine.rb +138 -0
  142. data/lib/chewy/type/import.rb +150 -176
  143. data/lib/chewy/type/mapping.rb +58 -42
  144. data/lib/chewy/type/observe.rb +21 -15
  145. data/lib/chewy/type/syncer.rb +222 -0
  146. data/lib/chewy/type/witchcraft.rb +89 -34
  147. data/lib/chewy/type/wrapper.rb +48 -16
  148. data/lib/chewy/type.rb +77 -49
  149. data/lib/chewy/version.rb +1 -1
  150. data/lib/chewy.rb +95 -52
  151. data/lib/generators/chewy/install_generator.rb +3 -3
  152. data/lib/sequel/plugins/chewy_observe.rb +4 -19
  153. data/lib/tasks/chewy.rake +91 -28
  154. data/spec/chewy/config_spec.rb +130 -12
  155. data/spec/chewy/fields/base_spec.rb +194 -172
  156. data/spec/chewy/fields/root_spec.rb +123 -17
  157. data/spec/chewy/fields/time_fields_spec.rb +10 -9
  158. data/spec/chewy/index/actions_spec.rb +228 -43
  159. data/spec/chewy/index/aliases_spec.rb +2 -2
  160. data/spec/chewy/index/settings_spec.rb +100 -49
  161. data/spec/chewy/index/specification_spec.rb +169 -0
  162. data/spec/chewy/index_spec.rb +159 -63
  163. data/spec/chewy/journal_spec.rb +268 -0
  164. data/spec/chewy/minitest/helpers_spec.rb +90 -0
  165. data/spec/chewy/minitest/search_index_receiver_spec.rb +120 -0
  166. data/spec/chewy/query/criteria_spec.rb +503 -236
  167. data/spec/chewy/query/filters_spec.rb +96 -68
  168. data/spec/chewy/query/loading_spec.rb +80 -42
  169. data/spec/chewy/query/nodes/and_spec.rb +3 -7
  170. data/spec/chewy/query/nodes/bool_spec.rb +5 -13
  171. data/spec/chewy/query/nodes/equal_spec.rb +20 -20
  172. data/spec/chewy/query/nodes/exists_spec.rb +7 -7
  173. data/spec/chewy/query/nodes/has_child_spec.rb +42 -23
  174. data/spec/chewy/query/nodes/has_parent_spec.rb +42 -23
  175. data/spec/chewy/query/nodes/match_all_spec.rb +2 -2
  176. data/spec/chewy/query/nodes/missing_spec.rb +6 -5
  177. data/spec/chewy/query/nodes/not_spec.rb +5 -7
  178. data/spec/chewy/query/nodes/or_spec.rb +3 -7
  179. data/spec/chewy/query/nodes/prefix_spec.rb +6 -6
  180. data/spec/chewy/query/nodes/query_spec.rb +3 -3
  181. data/spec/chewy/query/nodes/range_spec.rb +19 -19
  182. data/spec/chewy/query/nodes/raw_spec.rb +2 -2
  183. data/spec/chewy/query/nodes/regexp_spec.rb +31 -19
  184. data/spec/chewy/query/nodes/script_spec.rb +5 -5
  185. data/spec/chewy/query/pagination/kaminari_spec.rb +3 -55
  186. data/spec/chewy/query/pagination/will_paginate_spec.rb +5 -0
  187. data/spec/chewy/query/pagination_spec.rb +25 -22
  188. data/spec/chewy/query_spec.rb +510 -505
  189. data/spec/chewy/rake_helper_spec.rb +381 -0
  190. data/spec/chewy/repository_spec.rb +8 -8
  191. data/spec/chewy/rspec/update_index_spec.rb +215 -113
  192. data/spec/chewy/runtime_spec.rb +2 -2
  193. data/spec/chewy/search/loader_spec.rb +117 -0
  194. data/spec/chewy/search/pagination/kaminari_examples.rb +71 -0
  195. data/spec/chewy/search/pagination/kaminari_spec.rb +21 -0
  196. data/spec/chewy/search/pagination/will_paginate_examples.rb +63 -0
  197. data/spec/chewy/search/pagination/will_paginate_spec.rb +23 -0
  198. data/spec/chewy/search/parameters/aggs_spec.rb +5 -0
  199. data/spec/chewy/search/parameters/bool_storage_examples.rb +53 -0
  200. data/spec/chewy/search/parameters/docvalue_fields_spec.rb +5 -0
  201. data/spec/chewy/search/parameters/explain_spec.rb +5 -0
  202. data/spec/chewy/search/parameters/filter_spec.rb +5 -0
  203. data/spec/chewy/search/parameters/hash_storage_examples.rb +59 -0
  204. data/spec/chewy/search/parameters/highlight_spec.rb +5 -0
  205. data/spec/chewy/search/parameters/indices_spec.rb +191 -0
  206. data/spec/chewy/search/parameters/integer_storage_examples.rb +32 -0
  207. data/spec/chewy/search/parameters/limit_spec.rb +5 -0
  208. data/spec/chewy/search/parameters/load_spec.rb +60 -0
  209. data/spec/chewy/search/parameters/min_score_spec.rb +32 -0
  210. data/spec/chewy/search/parameters/none_spec.rb +5 -0
  211. data/spec/chewy/search/parameters/offset_spec.rb +5 -0
  212. data/spec/chewy/search/parameters/order_spec.rb +65 -0
  213. data/spec/chewy/search/parameters/post_filter_spec.rb +5 -0
  214. data/spec/chewy/search/parameters/preference_spec.rb +5 -0
  215. data/spec/chewy/search/parameters/profile_spec.rb +5 -0
  216. data/spec/chewy/search/parameters/query_spec.rb +5 -0
  217. data/spec/chewy/search/parameters/query_storage_examples.rb +388 -0
  218. data/spec/chewy/search/parameters/request_cache_spec.rb +67 -0
  219. data/spec/chewy/search/parameters/rescore_spec.rb +62 -0
  220. data/spec/chewy/search/parameters/script_fields_spec.rb +5 -0
  221. data/spec/chewy/search/parameters/search_after_spec.rb +32 -0
  222. data/spec/chewy/search/parameters/search_type_spec.rb +5 -0
  223. data/spec/chewy/search/parameters/source_spec.rb +156 -0
  224. data/spec/chewy/search/parameters/storage_spec.rb +60 -0
  225. data/spec/chewy/search/parameters/stored_fields_spec.rb +126 -0
  226. data/spec/chewy/search/parameters/string_array_storage_examples.rb +63 -0
  227. data/spec/chewy/search/parameters/string_storage_examples.rb +32 -0
  228. data/spec/chewy/search/parameters/suggest_spec.rb +5 -0
  229. data/spec/chewy/search/parameters/terminate_after_spec.rb +5 -0
  230. data/spec/chewy/search/parameters/timeout_spec.rb +5 -0
  231. data/spec/chewy/search/parameters/track_scores_spec.rb +5 -0
  232. data/spec/chewy/search/parameters/types_spec.rb +5 -0
  233. data/spec/chewy/search/parameters/version_spec.rb +5 -0
  234. data/spec/chewy/search/parameters_spec.rb +145 -0
  235. data/spec/chewy/search/query_proxy_spec.rb +68 -0
  236. data/spec/chewy/search/request_spec.rb +685 -0
  237. data/spec/chewy/search/response_spec.rb +192 -0
  238. data/spec/chewy/search/scrolling_spec.rb +169 -0
  239. data/spec/chewy/search_spec.rb +37 -20
  240. data/spec/chewy/stash_spec.rb +95 -0
  241. data/spec/chewy/strategy/active_job_spec.rb +8 -2
  242. data/spec/chewy/strategy/atomic_spec.rb +4 -1
  243. data/spec/chewy/strategy/resque_spec.rb +8 -2
  244. data/spec/chewy/strategy/shoryuken_spec.rb +66 -0
  245. data/spec/chewy/strategy/sidekiq_spec.rb +10 -2
  246. data/spec/chewy/strategy_spec.rb +6 -6
  247. data/spec/chewy/type/actions_spec.rb +29 -10
  248. data/spec/chewy/type/adapter/active_record_spec.rb +357 -139
  249. data/spec/chewy/type/adapter/mongoid_spec.rb +220 -101
  250. data/spec/chewy/type/adapter/object_spec.rb +129 -40
  251. data/spec/chewy/type/adapter/sequel_spec.rb +304 -152
  252. data/spec/chewy/type/import/bulk_builder_spec.rb +279 -0
  253. data/spec/chewy/type/import/bulk_request_spec.rb +102 -0
  254. data/spec/chewy/type/import/journal_builder_spec.rb +95 -0
  255. data/spec/chewy/type/import/routine_spec.rb +110 -0
  256. data/spec/chewy/type/import_spec.rb +360 -244
  257. data/spec/chewy/type/mapping_spec.rb +96 -29
  258. data/spec/chewy/type/observe_spec.rb +25 -15
  259. data/spec/chewy/type/syncer_spec.rb +123 -0
  260. data/spec/chewy/type/witchcraft_spec.rb +122 -44
  261. data/spec/chewy/type/wrapper_spec.rb +63 -23
  262. data/spec/chewy/type_spec.rb +32 -10
  263. data/spec/chewy_spec.rb +82 -12
  264. data/spec/spec_helper.rb +16 -2
  265. data/spec/support/active_record.rb +6 -2
  266. data/spec/support/class_helpers.rb +4 -19
  267. data/spec/support/mongoid.rb +17 -5
  268. data/spec/support/sequel.rb +6 -1
  269. metadata +250 -57
  270. data/gemfiles/rails.3.2.activerecord.gemfile +0 -15
  271. data/gemfiles/rails.3.2.activerecord.kaminari.gemfile +0 -14
  272. data/gemfiles/rails.3.2.activerecord.will_paginate.gemfile +0 -14
  273. data/gemfiles/rails.4.0.activerecord.kaminari.gemfile +0 -14
  274. data/gemfiles/rails.4.0.activerecord.will_paginate.gemfile +0 -14
  275. data/gemfiles/rails.4.0.mongoid.4.0.0.gemfile +0 -15
  276. data/gemfiles/rails.4.0.mongoid.4.0.0.kaminari.gemfile +0 -14
  277. data/gemfiles/rails.4.0.mongoid.4.0.0.will_paginate.gemfile +0 -14
  278. data/gemfiles/rails.4.0.mongoid.5.1.0.gemfile +0 -15
  279. data/gemfiles/rails.4.0.mongoid.5.1.0.kaminari.gemfile +0 -14
  280. data/gemfiles/rails.4.0.mongoid.5.1.0.will_paginate.gemfile +0 -14
  281. data/gemfiles/rails.4.1.activerecord.kaminari.gemfile +0 -14
  282. data/gemfiles/rails.4.1.activerecord.will_paginate.gemfile +0 -14
  283. data/gemfiles/rails.4.1.mongoid.4.0.0.gemfile +0 -15
  284. data/gemfiles/rails.4.1.mongoid.4.0.0.kaminari.gemfile +0 -14
  285. data/gemfiles/rails.4.1.mongoid.4.0.0.will_paginate.gemfile +0 -14
  286. data/gemfiles/rails.4.1.mongoid.5.1.0.gemfile +0 -15
  287. data/gemfiles/rails.4.1.mongoid.5.1.0.kaminari.gemfile +0 -14
  288. data/gemfiles/rails.4.1.mongoid.5.1.0.will_paginate.gemfile +0 -14
  289. data/gemfiles/rails.4.2.activerecord.kaminari.gemfile +0 -15
  290. data/gemfiles/rails.4.2.activerecord.will_paginate.gemfile +0 -15
  291. data/gemfiles/rails.4.2.mongoid.4.0.0.gemfile +0 -15
  292. data/gemfiles/rails.4.2.mongoid.4.0.0.kaminari.gemfile +0 -14
  293. data/gemfiles/rails.4.2.mongoid.4.0.0.will_paginate.gemfile +0 -14
  294. data/gemfiles/rails.4.2.mongoid.5.1.0.gemfile +0 -15
  295. data/gemfiles/rails.4.2.mongoid.5.1.0.kaminari.gemfile +0 -14
  296. data/gemfiles/rails.4.2.mongoid.5.1.0.will_paginate.gemfile +0 -14
  297. data/gemfiles/rails.5.0.0.beta3.activerecord.gemfile +0 -16
  298. data/gemfiles/rails.5.0.0.beta3.activerecord.kaminari.gemfile +0 -16
  299. data/gemfiles/rails.5.0.0.beta3.activerecord.will_paginate.gemfile +0 -15
  300. data/gemfiles/sequel.4.31.gemfile +0 -13
  301. data/lib/chewy/query/pagination/will_paginate.rb +0 -27
  302. data/lib/chewy/query/scoping.rb +0 -20
  303. data/spec/chewy/query/pagination/will_paginage_spec.rb +0 -60
@@ -28,7 +28,7 @@ describe Chewy::Query::Criteria do
28
28
  its(:fields?) { should eq(false) }
29
29
  its(:types?) { should eq(false) }
30
30
 
31
- its(:none?){ should eq(false) }
31
+ its(:none?) { should eq(false) }
32
32
 
33
33
  describe '#update_options' do
34
34
  specify { expect { subject.update_options(field: 'hello') }.to change { subject.options }.to(hash_including(field: 'hello')) }
@@ -46,9 +46,11 @@ describe Chewy::Query::Criteria do
46
46
  describe '#update_scores' do
47
47
  specify { expect { subject.update_scores(:score) }.to change { subject.scores? }.to(true) }
48
48
  specify { expect { subject.update_scores(:score) }.to change { subject.scores }.to([:score]) }
49
- specify { expect { subject.update_scores([:score, :score2]) }.to change { subject.scores }.to([:score, :score2]) }
50
- specify { expect { subject.tap { |s| s.update_scores(:score1) }.update_scores([:score2, :score3]) }
51
- .to change { subject.scores }.to([:score1, :score2, :score3]) }
49
+ specify { expect { subject.update_scores(%i[score score2]) }.to change { subject.scores }.to(%i[score score2]) }
50
+ specify do
51
+ expect { subject.tap { |s| s.update_scores(:score1) }.update_scores(%i[score2 score3]) }
52
+ .to change { subject.scores }.to(%i[score1 score2 score3])
53
+ end
52
54
  end
53
55
 
54
56
  describe '#update_aggregations' do
@@ -57,74 +59,154 @@ describe Chewy::Query::Criteria do
57
59
  end
58
60
 
59
61
  describe '#update_script_fields' do
60
- specify { expect { subject.update_script_fields(distance: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }.to change { subject.script_fields? }.to(true) }
61
- specify { expect { subject.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }.to change { subject.script_fields }.to(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }
62
+ specify do
63
+ expect { subject.update_script_fields(distance: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }
64
+ .to change { subject.script_fields? }.to(true)
65
+ end
66
+ specify do
67
+ expect { subject.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }
68
+ .to change { subject.script_fields }.to(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"})
69
+ end
62
70
  end
63
71
 
64
72
  describe '#update_queries' do
65
- specify { expect { subject.update_queries(field: 'hello') }.to change { subject.queries? }.to(true) }
66
- specify { expect { subject.update_queries(field: 'hello') }.to change { subject.queries }.to([field: 'hello']) }
67
- specify { expect { subject.update_queries(field: 'hello'); subject.update_queries(field: 'world') }
68
- .to change { subject.queries }.to([{field: 'hello'}, {field: 'world'}]) }
69
- specify { expect { subject.update_queries([{field: 'hello'}, {field: 'world'}, nil]) }
70
- .to change { subject.queries }.to([{field: 'hello'}, {field: 'world'}]) }
73
+ specify do
74
+ expect { subject.update_queries(field: 'hello') }
75
+ .to change { subject.queries? }.to(true)
76
+ end
77
+ specify do
78
+ expect { subject.update_queries(field: 'hello') }
79
+ .to change { subject.queries }.to([field: 'hello'])
80
+ end
81
+ specify do
82
+ expect do
83
+ subject.update_queries(field: 'hello')
84
+ subject.update_queries(field: 'world')
85
+ end
86
+ .to change { subject.queries }.to([{field: 'hello'}, {field: 'world'}])
87
+ end
88
+ specify do
89
+ expect { subject.update_queries([{field: 'hello'}, {field: 'world'}, nil]) }
90
+ .to change { subject.queries }.to([{field: 'hello'}, {field: 'world'}])
91
+ end
71
92
  end
72
93
 
73
94
  describe '#update_filters' do
74
95
  specify { expect { subject.update_filters(field: 'hello') }.to change { subject.filters? }.to(true) }
75
96
  specify { expect { subject.update_filters(field: 'hello') }.to change { subject.filters }.to([{field: 'hello'}]) }
76
- specify { expect { subject.update_filters(field: 'hello'); subject.update_filters(field: 'world') }
77
- .to change { subject.filters }.to([{field: 'hello'}, {field: 'world'}]) }
78
- specify { expect { subject.update_filters([{field: 'hello'}, {field: 'world'}, nil]) }
79
- .to change { subject.filters }.to([{field: 'hello'}, {field: 'world'}]) }
97
+ specify do
98
+ expect do
99
+ subject.update_filters(field: 'hello')
100
+ subject.update_filters(field: 'world')
101
+ end
102
+ .to change { subject.filters }.to([{field: 'hello'}, {field: 'world'}])
103
+ end
104
+ specify do
105
+ expect { subject.update_filters([{field: 'hello'}, {field: 'world'}, nil]) }
106
+ .to change { subject.filters }.to([{field: 'hello'}, {field: 'world'}])
107
+ end
80
108
  end
81
109
 
82
110
  describe '#update_post_filters' do
83
111
  specify { expect { subject.update_post_filters(field: 'hello') }.to change { subject.post_filters? }.to(true) }
84
112
  specify { expect { subject.update_post_filters(field: 'hello') }.to change { subject.post_filters }.to([{field: 'hello'}]) }
85
- specify { expect { subject.update_post_filters(field: 'hello'); subject.update_post_filters(field: 'world') }
86
- .to change { subject.post_filters }.to([{field: 'hello'}, {field: 'world'}]) }
87
- specify { expect { subject.update_post_filters([{field: 'hello'}, {field: 'world'}, nil]) }
88
- .to change { subject.post_filters }.to([{field: 'hello'}, {field: 'world'}]) }
113
+ specify do
114
+ expect do
115
+ subject.update_post_filters(field: 'hello')
116
+ subject.update_post_filters(field: 'world')
117
+ end
118
+ .to change { subject.post_filters }.to([{field: 'hello'}, {field: 'world'}])
119
+ end
120
+ specify do
121
+ expect { subject.update_post_filters([{field: 'hello'}, {field: 'world'}, nil]) }
122
+ .to change { subject.post_filters }.to([{field: 'hello'}, {field: 'world'}])
123
+ end
89
124
  end
90
125
 
91
126
  describe '#update_sort' do
92
- specify { expect { subject.update_sort(:field) }.to change { subject.sort? }.to(true) }
93
-
94
- specify { expect { subject.update_sort([:field]) }.to change { subject.sort }.to([:field]) }
95
- specify { expect { subject.update_sort([:field1, :field2]) }.to change { subject.sort }.to([:field1, :field2]) }
96
- specify { expect { subject.update_sort([{field: :asc}]) }.to change { subject.sort }.to([{field: :asc}]) }
97
- specify { expect { subject.update_sort([:field1, field2: {order: :asc}]) }.to change { subject.sort }.to([:field1, {field2: {order: :asc}}]) }
98
- specify { expect { subject.update_sort([{field1: {order: :asc}}, :field2]) }.to change { subject.sort }.to([{field1: {order: :asc}}, :field2]) }
99
- specify { expect { subject.update_sort([field1: :asc, field2: {order: :asc}]) }.to change { subject.sort }.to([{field1: :asc}, {field2: {order: :asc}}]) }
100
- specify { expect { subject.update_sort([{field1: {order: :asc}}, :field2, :field3]) }.to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3]) }
101
- specify { expect { subject.update_sort([{field1: {order: :asc}}, [:field2, :field3]]) }.to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3]) }
102
- specify { expect { subject.update_sort([{field1: {order: :asc}}, [:field2], :field3]) }.to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3]) }
103
- specify { expect { subject.update_sort([{field1: {order: :asc}, field2: :desc}, [:field3], :field4]) }.to change { subject.sort }.to([{field1: {order: :asc}}, {field2: :desc}, :field3, :field4]) }
104
- specify { expect { subject.tap { |s| s.update_sort([field1: {order: :asc}, field2: :desc]) }.update_sort([[:field3], :field4]) }.to change { subject.sort }.to([{field1: {order: :asc}}, {field2: :desc}, :field3, :field4]) }
105
- specify { expect { subject.tap { |s| s.update_sort([field1: {order: :asc}, field2: :desc]) }.update_sort([[:field3], :field4], purge: true) }.to change { subject.sort }.to([:field3, :field4]) }
127
+ specify do
128
+ expect { subject.update_sort(:field) }
129
+ .to change { subject.sort? }.to(true)
130
+ end
131
+
132
+ specify do
133
+ expect { subject.update_sort([:field]) }
134
+ .to change { subject.sort }.to([:field])
135
+ end
136
+ specify do
137
+ expect { subject.update_sort(%i[field1 field2]) }
138
+ .to change { subject.sort }.to(%i[field1 field2])
139
+ end
140
+ specify do
141
+ expect { subject.update_sort([{field: :asc}]) }
142
+ .to change { subject.sort }.to([{field: :asc}])
143
+ end
144
+ specify do
145
+ expect { subject.update_sort([:field1, field2: {order: :asc}]) }
146
+ .to change { subject.sort }.to([:field1, {field2: {order: :asc}}])
147
+ end
148
+ specify do
149
+ expect { subject.update_sort([{field1: {order: :asc}}, :field2]) }
150
+ .to change { subject.sort }.to([{field1: {order: :asc}}, :field2])
151
+ end
152
+ specify do
153
+ expect { subject.update_sort([field1: :asc, field2: {order: :asc}]) }
154
+ .to change { subject.sort }.to([{field1: :asc}, {field2: {order: :asc}}])
155
+ end
156
+ specify do
157
+ expect { subject.update_sort([{field1: {order: :asc}}, :field2, :field3]) }
158
+ .to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3])
159
+ end
160
+ specify do
161
+ expect { subject.update_sort([{field1: {order: :asc}}, %i[field2 field3]]) }
162
+ .to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3])
163
+ end
164
+ specify do
165
+ expect { subject.update_sort([{field1: {order: :asc}}, [:field2], :field3]) }
166
+ .to change { subject.sort }.to([{field1: {order: :asc}}, :field2, :field3])
167
+ end
168
+ specify do
169
+ expect { subject.update_sort([{field1: {order: :asc}, field2: :desc}, [:field3], :field4]) }
170
+ .to change { subject.sort }.to([{field1: {order: :asc}}, {field2: :desc}, :field3, :field4])
171
+ end
172
+ specify do
173
+ expect { subject.tap { |s| s.update_sort([field1: {order: :asc}, field2: :desc]) }.update_sort([[:field3], :field4]) }
174
+ .to change { subject.sort }.to([{field1: {order: :asc}}, {field2: :desc}, :field3, :field4])
175
+ end
176
+ specify do
177
+ expect { subject.tap { |s| s.update_sort([field1: {order: :asc}, field2: :desc]) }.update_sort([[:field3], :field4], purge: true) }
178
+ .to change { subject.sort }.to(%i[field3 field4])
179
+ end
106
180
  end
107
181
 
108
182
  describe '#update_fields' do
109
183
  specify { expect { subject.update_fields(:field) }.to change { subject.fields? }.to(true) }
110
184
  specify { expect { subject.update_fields(:field) }.to change { subject.fields }.to(['field']) }
111
- specify { expect { subject.update_fields([:field, :field]) }.to change { subject.fields }.to(['field']) }
112
- specify { expect { subject.update_fields([:field1, :field2]) }.to change { subject.fields }.to(['field1', 'field2']) }
113
- specify { expect { subject.tap { |s| s.update_fields(:field1) }.update_fields([:field2, :field3]) }
114
- .to change { subject.fields }.to(['field1', 'field2', 'field3']) }
115
- specify { expect { subject.tap { |s| s.update_fields(:field1) }.update_fields([:field2, :field3], purge: true) }
116
- .to change { subject.fields }.to(['field2', 'field3']) }
185
+ specify { expect { subject.update_fields(%i[field field]) }.to change { subject.fields }.to(['field']) }
186
+ specify { expect { subject.update_fields(%i[field1 field2]) }.to change { subject.fields }.to(%w[field1 field2]) }
187
+ specify do
188
+ expect { subject.tap { |s| s.update_fields(:field1) }.update_fields(%i[field2 field3]) }
189
+ .to change { subject.fields }.to(%w[field1 field2 field3])
190
+ end
191
+ specify do
192
+ expect { subject.tap { |s| s.update_fields(:field1) }.update_fields(%i[field2 field3], purge: true) }
193
+ .to change { subject.fields }.to(%w[field2 field3])
194
+ end
117
195
  end
118
196
 
119
197
  describe '#update_types' do
120
198
  specify { expect { subject.update_types(:type) }.to change { subject.types? }.to(true) }
121
199
  specify { expect { subject.update_types(:type) }.to change { subject.types }.to(['type']) }
122
- specify { expect { subject.update_types([:type, :type]) }.to change { subject.types }.to(['type']) }
123
- specify { expect { subject.update_types([:type1, :type2]) }.to change { subject.types }.to(['type1', 'type2']) }
124
- specify { expect { subject.tap { |s| s.update_types(:type1) }.update_types([:type2, :type3]) }
125
- .to change { subject.types }.to(['type1', 'type2', 'type3']) }
126
- specify { expect { subject.tap { |s| s.update_types(:type1) }.update_types([:type2, :type3], purge: true) }
127
- .to change { subject.types }.to(['type2', 'type3']) }
200
+ specify { expect { subject.update_types(%i[type type]) }.to change { subject.types }.to(['type']) }
201
+ specify { expect { subject.update_types(%i[type1 type2]) }.to change { subject.types }.to(%w[type1 type2]) }
202
+ specify do
203
+ expect { subject.tap { |s| s.update_types(:type1) }.update_types(%i[type2 type3]) }
204
+ .to change { subject.types }.to(%w[type1 type2 type3])
205
+ end
206
+ specify do
207
+ expect { subject.tap { |s| s.update_types(:type1) }.update_types(%i[type2 type3], purge: true) }
208
+ .to change { subject.types }.to(%w[type2 type3])
209
+ end
128
210
  end
129
211
 
130
212
  describe '#merge' do
@@ -133,30 +215,63 @@ describe Chewy::Query::Criteria do
133
215
  specify { expect(subject.merge(criteria)).not_to be_equal subject }
134
216
  specify { expect(subject.merge(criteria)).not_to be_equal criteria }
135
217
 
136
- specify { expect(subject.tap { |c| c.update_options(opt1: 'hello') }
137
- .merge(criteria.tap { |c| c.update_options(opt2: 'hello') }).options).to include(opt1: 'hello', opt2: 'hello') }
138
- specify { expect(subject.tap { |c| c.update_request_options(opt1: 'hello') }
139
- .merge(criteria.tap { |c| c.update_request_options(opt2: 'hello') }).request_options).to include(opt1: 'hello', opt2: 'hello') }
140
- specify { expect(subject.tap { |c| c.update_facets(field1: 'hello') }
141
- .merge(criteria.tap { |c| c.update_facets(field1: 'hello') }).facets).to eq({field1: 'hello'}) }
142
- specify { expect(subject.tap { |c| c.update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }
143
- .merge(criteria.tap { |c| c.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }).script_fields).to eq({distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}, distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}}) }
144
- specify { expect(subject.tap { |c| c.update_scores(script: 'hello') }
145
- .merge(criteria.tap { |c| c.update_scores(script: 'foobar') }).scores).to eq([{script: 'hello'}, { script: 'foobar' } ]) }
146
- specify { expect(subject.tap { |c| c.update_aggregations(field1: 'hello') }
147
- .merge(criteria.tap { |c| c.update_aggregations(field1: 'hello') }).aggregations).to eq({field1: 'hello'}) }
148
- specify { expect(subject.tap { |c| c.update_queries(field1: 'hello') }
149
- .merge(criteria.tap { |c| c.update_queries(field2: 'hello') }).queries).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
150
- specify { expect(subject.tap { |c| c.update_filters(field1: 'hello') }
151
- .merge(criteria.tap { |c| c.update_filters(field2: 'hello') }).filters).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
152
- specify { expect(subject.tap { |c| c.update_post_filters(field1: 'hello') }
153
- .merge(criteria.tap { |c| c.update_post_filters(field2: 'hello') }).post_filters).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
154
- specify { expect(subject.tap { |c| c.update_sort(:field1) }
155
- .merge(criteria.tap { |c| c.update_sort(:field2) }).sort).to eq([:field1, :field2]) }
156
- specify { expect(subject.tap { |c| c.update_fields(:field1) }
157
- .merge(criteria.tap { |c| c.update_fields(:field2) }).fields).to eq(['field1', 'field2']) }
158
- specify { expect(subject.tap { |c| c.update_types(:type1) }
159
- .merge(criteria.tap { |c| c.update_types(:type2) }).types).to eq(['type1', 'type2']) }
218
+ specify do
219
+ expect(subject.tap { |c| c.update_options(opt1: 'hello') }
220
+ .merge(criteria.tap { |c| c.update_options(opt2: 'hello') }).options)
221
+ .to include(opt1: 'hello', opt2: 'hello')
222
+ end
223
+ specify do
224
+ expect(subject.tap { |c| c.update_request_options(opt1: 'hello') }
225
+ .merge(criteria.tap { |c| c.update_request_options(opt2: 'hello') }).request_options)
226
+ .to include(opt1: 'hello', opt2: 'hello')
227
+ end
228
+ specify do
229
+ expect(subject.tap { |c| c.update_facets(field1: 'hello') }
230
+ .merge(criteria.tap { |c| c.update_facets(field1: 'hello') }).facets)
231
+ .to eq(field1: 'hello')
232
+ end
233
+ specify do
234
+ expect(subject.tap { |c| c.update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }
235
+ .merge(criteria.tap { |c| c.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }).script_fields)
236
+ .to eq(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}, distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"})
237
+ end
238
+ specify do
239
+ expect(subject.tap { |c| c.update_scores(script: 'hello') }
240
+ .merge(criteria.tap { |c| c.update_scores(script: 'foobar') }).scores)
241
+ .to eq([{script: 'hello'}, {script: 'foobar'}])
242
+ end
243
+ specify do
244
+ expect(subject.tap { |c| c.update_aggregations(field1: 'hello') }
245
+ .merge(criteria.tap { |c| c.update_aggregations(field1: 'hello') }).aggregations)
246
+ .to eq(field1: 'hello')
247
+ end
248
+ specify do
249
+ expect(subject.tap { |c| c.update_queries(field1: 'hello') }
250
+ .merge(criteria.tap { |c| c.update_queries(field2: 'hello') }).queries)
251
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
252
+ end
253
+ specify do
254
+ expect(subject.tap { |c| c.update_filters(field1: 'hello') }
255
+ .merge(criteria.tap { |c| c.update_filters(field2: 'hello') }).filters)
256
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
257
+ end
258
+ specify do
259
+ expect(subject.tap { |c| c.update_post_filters(field1: 'hello') }
260
+ .merge(criteria.tap { |c| c.update_post_filters(field2: 'hello') }).post_filters)
261
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
262
+ end
263
+ specify do
264
+ expect(subject.tap { |c| c.update_sort(:field1) }
265
+ .merge(criteria.tap { |c| c.update_sort(:field2) }).sort).to eq(%i[field1 field2])
266
+ end
267
+ specify do
268
+ expect(subject.tap { |c| c.update_fields(:field1) }
269
+ .merge(criteria.tap { |c| c.update_fields(:field2) }).fields).to eq(%w[field1 field2])
270
+ end
271
+ specify do
272
+ expect(subject.tap { |c| c.update_types(:type1) }
273
+ .merge(criteria.tap { |c| c.update_types(:type2) }).types).to eq(%w[type1 type2])
274
+ end
160
275
  end
161
276
 
162
277
  describe '#merge!' do
@@ -165,210 +280,362 @@ describe Chewy::Query::Criteria do
165
280
  specify { expect(subject.merge!(criteria)).to be_equal subject }
166
281
  specify { expect(subject.merge!(criteria)).not_to be_equal criteria }
167
282
 
168
- specify { expect(subject.tap { |c| c.update_options(opt1: 'hello') }
169
- .merge!(criteria.tap { |c| c.update_options(opt2: 'hello') }).options).to include(opt1: 'hello', opt2: 'hello') }
170
- specify { expect(subject.tap { |c| c.update_request_options(opt1: 'hello') }
171
- .merge!(criteria.tap { |c| c.update_request_options(opt2: 'hello') }).request_options).to include(opt1: 'hello', opt2: 'hello') }
172
- specify { expect(subject.tap { |c| c.update_facets(field1: 'hello') }
173
- .merge!(criteria.tap { |c| c.update_facets(field1: 'hello') }).facets).to eq({field1: 'hello'}) }
174
- specify { expect(subject.tap { |c| c.update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }
175
- .merge(criteria.tap { |c| c.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }).script_fields).to eq({distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}, distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}}) }
176
- specify { expect(subject.tap { |c| c.update_aggregations(field1: 'hello') }
177
- .merge!(criteria.tap { |c| c.update_aggregations(field1: 'hello') }).aggregations).to eq({field1: 'hello'}) }
178
- specify { expect(subject.tap { |c| c.update_queries(field1: 'hello') }
179
- .merge!(criteria.tap { |c| c.update_queries(field2: 'hello') }).queries).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
180
- specify { expect(subject.tap { |c| c.update_filters(field1: 'hello') }
181
- .merge!(criteria.tap { |c| c.update_filters(field2: 'hello') }).filters).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
182
- specify { expect(subject.tap { |c| c.update_post_filters(field1: 'hello') }
183
- .merge!(criteria.tap { |c| c.update_post_filters(field2: 'hello') }).post_filters).to eq([{field1: 'hello'}, {field2: 'hello'}]) }
184
- specify { expect(subject.tap { |c| c.update_sort(:field1) }
185
- .merge!(criteria.tap { |c| c.update_sort(:field2) }).sort).to eq([:field1, :field2]) }
186
- specify { expect(subject.tap { |c| c.update_fields(:field1) }
187
- .merge!(criteria.tap { |c| c.update_fields(:field2) }).fields).to eq(['field1', 'field2']) }
188
- specify { expect(subject.tap { |c| c.update_types(:type1) }
189
- .merge!(criteria.tap { |c| c.update_types(:type2) }).types).to eq(['type1', 'type2']) }
283
+ specify do
284
+ expect(subject.tap { |c| c.update_options(opt1: 'hello') }
285
+ .merge!(criteria.tap { |c| c.update_options(opt2: 'hello') }).options)
286
+ .to include(opt1: 'hello', opt2: 'hello')
287
+ end
288
+ specify do
289
+ expect(subject.tap { |c| c.update_request_options(opt1: 'hello') }
290
+ .merge!(criteria.tap { |c| c.update_request_options(opt2: 'hello') }).request_options)
291
+ .to include(opt1: 'hello', opt2: 'hello')
292
+ end
293
+ specify do
294
+ expect(subject.tap { |c| c.update_facets(field1: 'hello') }
295
+ .merge!(criteria.tap { |c| c.update_facets(field1: 'hello') }).facets)
296
+ .to eq(field1: 'hello')
297
+ end
298
+ specify do
299
+ expect(subject.tap { |c| c.update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}) }
300
+ .merge(criteria.tap { |c| c.update_script_fields(distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"}) }).script_fields)
301
+ .to eq(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}, distance_km: {script: "doc['coordinates'].distanceInKm(lat, lon)"})
302
+ end
303
+ specify do
304
+ expect(subject.tap { |c| c.update_aggregations(field1: 'hello') }
305
+ .merge!(criteria.tap { |c| c.update_aggregations(field1: 'hello') }).aggregations)
306
+ .to eq(field1: 'hello')
307
+ end
308
+ specify do
309
+ expect(subject.tap { |c| c.update_queries(field1: 'hello') }
310
+ .merge!(criteria.tap { |c| c.update_queries(field2: 'hello') }).queries)
311
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
312
+ end
313
+ specify do
314
+ expect(subject.tap { |c| c.update_filters(field1: 'hello') }
315
+ .merge!(criteria.tap { |c| c.update_filters(field2: 'hello') }).filters)
316
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
317
+ end
318
+ specify do
319
+ expect(subject.tap { |c| c.update_post_filters(field1: 'hello') }
320
+ .merge!(criteria.tap { |c| c.update_post_filters(field2: 'hello') }).post_filters)
321
+ .to eq([{field1: 'hello'}, {field2: 'hello'}])
322
+ end
323
+ specify do
324
+ expect(subject.tap { |c| c.update_sort(:field1) }
325
+ .merge!(criteria.tap { |c| c.update_sort(:field2) }).sort)
326
+ .to eq(%i[field1 field2])
327
+ end
328
+ specify do
329
+ expect(subject.tap { |c| c.update_fields(:field1) }
330
+ .merge!(criteria.tap { |c| c.update_fields(:field2) }).fields)
331
+ .to eq(%w[field1 field2])
332
+ end
333
+ specify do
334
+ expect(subject.tap { |c| c.update_types(:type1) }
335
+ .merge!(criteria.tap { |c| c.update_types(:type2) }).types)
336
+ .to eq(%w[type1 type2])
337
+ end
190
338
  end
191
339
 
192
340
  describe '#request_body' do
193
- def request_body &block
341
+ def request_body(&block)
194
342
  subject.instance_exec(&block) if block
195
343
  subject.request_body
196
344
  end
197
345
 
198
- specify { expect(request_body).to eq({body: {}}) }
199
- specify { expect(request_body { update_request_options(size: 10) }).to eq({body: {size: 10}}) }
200
- specify { expect(request_body { update_request_options(from: 10) }).to eq({body: {from: 10}}) }
201
- specify { expect(request_body { update_request_options(explain: true) }).to eq({body: {explain: true}}) }
202
- specify { expect(request_body { update_queries(:query) }).to eq({body: {query: :query}}) }
203
- specify { expect(request_body {
204
- update_scores(script_score: { script: '_score'})
205
- }).to eq({body: {query: { function_score: { functions: [{ script_score: {script: '_score' }}] }}}}) }
206
- specify { expect(request_body {
207
- update_scores(script_score: { script: "boost_me" })
208
- update_queries(:query)
209
- update_options(boost_mode: :add)
210
- update_options(score_mode: :avg)
211
- }).to eq({body: {query: {
212
- function_score: {
213
- functions: [{
214
- script_score: {script: 'boost_me' }
215
- }],
216
- query: :query,
217
- boost_mode: :add,
218
- score_mode: :avg
219
- }}}})
220
- }
221
- specify { expect(request_body {
222
- update_request_options(from: 10); update_sort(:field); update_fields(:field); update_queries(:query)
223
- }).to eq({body: {query: :query, from: 10, sort: [:field], _source: ['field']}}) }
224
-
225
- specify { expect(request_body {
226
- update_queries(:query); update_filters(:filters);
227
- }).to eq({body: {query: {filtered: {query: :query, filter: :filters}}}}) }
228
- specify { expect(request_body {
229
- update_queries(:query); update_post_filters(:post_filter);
230
- }).to eq({body: {query: :query, post_filter: :post_filter}}) }
231
- specify { expect(request_body {
232
- update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"})
233
- }).to eq({:body=>{:script_fields=>{:distance_m=>{:script=>"doc['coordinates'].distanceInMiles(lat, lon)"}}}}) }
346
+ specify { expect(request_body).to eq(body: {}) }
347
+ specify { expect(request_body { update_request_options(size: 10) }).to eq(body: {size: 10}) }
348
+ specify { expect(request_body { update_request_options(from: 10) }).to eq(body: {from: 10}) }
349
+ specify { expect(request_body { update_request_options(explain: true) }).to eq(body: {explain: true}) }
350
+ specify { expect(request_body { update_queries(:query) }).to eq(body: {query: :query}) }
351
+ specify do
352
+ expect(request_body do
353
+ update_scores(script_score: {script: '_score'})
354
+ end).to eq(body: {query: {function_score: {functions: [{script_score: {script: '_score'}}]}}}) end
355
+ specify do
356
+ expect(request_body do
357
+ update_scores(script_score: {script: 'boost_me'})
358
+ update_queries(:query)
359
+ update_options(boost_mode: :add)
360
+ update_options(score_mode: :avg)
361
+ end).to eq(body: {query: {
362
+ function_score: {
363
+ functions: [{
364
+ script_score: {script: 'boost_me'}
365
+ }],
366
+ query: :query,
367
+ boost_mode: :add,
368
+ score_mode: :avg
369
+ }
370
+ }})
371
+ end
372
+ specify do
373
+ expect(request_body do
374
+ update_request_options(from: 10)
375
+ update_sort(:field)
376
+ update_fields(:field)
377
+ update_queries(:query)
378
+ end).to eq(body: {query: :query, from: 10, sort: [:field], _source: ['field']}) end
379
+
380
+ specify do
381
+ expect(request_body do
382
+ update_queries(:query)
383
+ update_filters(:filters)
384
+ end).to eq(body: {query: {filtered: {query: :query, filter: :filters}}}) end
385
+ specify do
386
+ expect(request_body do
387
+ update_queries(:query)
388
+ update_post_filters(:post_filter)
389
+ end).to eq(body: {query: :query, post_filter: :post_filter}) end
390
+ specify do
391
+ expect(request_body do
392
+ update_script_fields(distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"})
393
+ end).to eq(body: {script_fields: {distance_m: {script: "doc['coordinates'].distanceInMiles(lat, lon)"}}}) end
234
394
  end
235
395
 
236
396
  describe '#_filtered_query' do
237
- def _filtered_query options = {}, &block
397
+ def _filtered_query(options = {}, &block)
238
398
  subject.instance_exec(&block) if block
239
399
  subject.send(:_filtered_query, subject.send(:_request_query), subject.send(:_request_filter), options)
240
400
  end
241
401
 
242
402
  specify { expect(_filtered_query).to eq({}) }
243
- specify { expect(_filtered_query { update_queries(:query) }).to eq({query: :query}) }
244
- specify { expect(_filtered_query(strategy: 'query_first') { update_queries(:query) }).to eq({query: :query}) }
245
- specify { expect(_filtered_query { update_queries([:query1, :query2]) })
246
- .to eq({query: {bool: {must: [:query1, :query2]}}}) }
247
- specify { expect(_filtered_query { update_options(query_mode: :should); update_queries([:query1, :query2]) })
248
- .to eq({query: {bool: {should: [:query1, :query2]}}}) }
249
- specify { expect(_filtered_query { update_options(query_mode: :dis_max); update_queries([:query1, :query2]) })
250
- .to eq({query: {dis_max: {queries: [:query1, :query2]}}}) }
251
-
252
- specify { expect(_filtered_query(strategy: 'query_first') { update_filters([:filter1, :filter2]) })
253
- .to eq({query: {filtered: {query: {match_all: {}}, filter: {and: [:filter1, :filter2]}, strategy: 'query_first'}}}) }
254
- specify { expect(_filtered_query { update_filters([:filter1, :filter2]) })
255
- .to eq({query: {filtered: {query: {match_all: {}}, filter: {and: [:filter1, :filter2]}}}}) }
256
-
257
- specify { expect(_filtered_query { update_filters([:filter1, :filter2]); update_queries([:query1, :query2]) })
258
- .to eq({query: {filtered: {
259
- query: {bool: {must: [:query1, :query2]}},
260
- filter: {and: [:filter1, :filter2]}
261
- }}})
262
- }
263
- specify { expect(_filtered_query(strategy: 'query_first') { update_filters([:filter1, :filter2]); update_queries([:query1, :query2]) })
264
- .to eq({query: {filtered: {
265
- query: {bool: {must: [:query1, :query2]}},
266
- filter: {and: [:filter1, :filter2]},
267
- strategy: 'query_first'
268
- }}})
269
- }
270
- specify { expect(_filtered_query {
271
- update_options(query_mode: :should); update_options(filter_mode: :or);
272
- update_filters([:filter1, :filter2]); update_queries([:query1, :query2])
273
- }).to eq({query: {filtered: {
274
- query: {bool: {should: [:query1, :query2]}},
275
- filter: {or: [:filter1, :filter2]}
276
- }}})
277
- }
403
+ specify { expect(_filtered_query { update_queries(:query) }).to eq(query: :query) }
404
+ specify { expect(_filtered_query(strategy: 'query_first') { update_queries(:query) }).to eq(query: :query) }
405
+ specify do
406
+ expect(_filtered_query { update_queries(%i[query1 query2]) })
407
+ .to eq(query: {bool: {must: %i[query1 query2]}})
408
+ end
409
+ specify do
410
+ expect(_filtered_query do
411
+ update_options(query_mode: :should)
412
+ update_queries(%i[query1 query2])
413
+ end)
414
+ .to eq(query: {bool: {should: %i[query1 query2]}})
415
+ end
416
+ specify do
417
+ expect(_filtered_query do
418
+ update_options(query_mode: :dis_max)
419
+ update_queries(%i[query1 query2])
420
+ end)
421
+ .to eq(query: {dis_max: {queries: %i[query1 query2]}})
422
+ end
423
+
424
+ specify do
425
+ expect(_filtered_query(strategy: 'query_first') { update_filters(%i[filter1 filter2]) })
426
+ .to eq(query: {filtered: {query: {match_all: {}}, filter: {and: %i[filter1 filter2]}, strategy: 'query_first'}})
427
+ end
428
+ specify do
429
+ expect(_filtered_query { update_filters(%i[filter1 filter2]) })
430
+ .to eq(query: {filtered: {query: {match_all: {}}, filter: {and: %i[filter1 filter2]}}})
431
+ end
432
+
433
+ specify do
434
+ expect(_filtered_query do
435
+ update_filters(%i[filter1 filter2])
436
+ update_queries(%i[query1 query2])
437
+ end)
438
+ .to eq(query: {filtered: {
439
+ query: {bool: {must: %i[query1 query2]}},
440
+ filter: {and: %i[filter1 filter2]}
441
+ }})
442
+ end
443
+ specify do
444
+ expect(_filtered_query(strategy: 'query_first') do
445
+ update_filters(%i[filter1 filter2])
446
+ update_queries(%i[query1 query2])
447
+ end)
448
+ .to eq(query: {filtered: {
449
+ query: {bool: {must: %i[query1 query2]}},
450
+ filter: {and: %i[filter1 filter2]},
451
+ strategy: 'query_first'
452
+ }})
453
+ end
454
+ specify do
455
+ expect(_filtered_query do
456
+ update_options(query_mode: :should)
457
+ update_options(filter_mode: :or)
458
+ update_filters(%i[filter1 filter2])
459
+ update_queries(%i[query1 query2])
460
+ end).to eq(query: {filtered: {
461
+ query: {bool: {should: %i[query1 query2]}},
462
+ filter: {or: %i[filter1 filter2]}
463
+ }})
464
+ end
278
465
  end
279
466
 
280
- describe "#_boost_query" do
281
- specify { expect(subject.send(:_boost_query, query: :query)).to eq(query: :query) }
282
- specify {
283
- subject.update_scores({ boost_factor: 5 })
284
- expect(subject.send(:_boost_query, query: :query)).to eq(query: { function_score: { functions: [{ boost_factor: 5 }], query: :query } })
285
- }
286
- specify {
287
- subject.update_scores({ boost_factor: 5 })
467
+ describe '#_boost_query' do
468
+ specify do
469
+ expect(subject.send(:_boost_query, query: :query))
470
+ .to eq(query: :query)
471
+ end
472
+ specify do
473
+ subject.update_scores(boost_factor: 5)
474
+ expect(subject.send(:_boost_query, query: :query))
475
+ .to eq(query: {function_score: {functions: [{boost_factor: 5}], query: :query}})
476
+ end
477
+ specify do
478
+ subject.update_scores(boost_factor: 5)
288
479
  subject.update_options(boost_mode: :multiply)
289
480
  subject.update_options(score_mode: :add)
290
- expect(subject.send(:_boost_query, query: :query)).to eq(query: { function_score: { functions: [{ boost_factor: 5 }], query: :query, boost_mode: :multiply, score_mode: :add } })
291
- }
292
- specify {
293
- subject.update_scores({ boost_factor: 5 })
294
- expect(subject.send(:_boost_query, query: :query, filter: :filter)).to eq(query: { function_score: { functions: [{ boost_factor: 5 }], query: { filtered: { query: :query, filter: :filter } } } })
295
- }
481
+ expect(subject.send(:_boost_query, query: :query))
482
+ .to eq(query: {function_score: {functions: [{boost_factor: 5}], query: :query, boost_mode: :multiply, score_mode: :add}})
483
+ end
484
+ specify do
485
+ subject.update_scores(boost_factor: 5)
486
+ expect(subject.send(:_boost_query, query: :query, filter: :filter))
487
+ .to eq(query: {function_score: {functions: [{boost_factor: 5}], query: {filtered: {query: :query, filter: :filter}}}})
488
+ end
296
489
  end
297
490
 
298
491
  describe '#_request_filter' do
299
- def _request_filter &block
492
+ def _request_filter(&block)
300
493
  subject.instance_exec(&block) if block
301
494
  subject.send(:_request_filter)
302
495
  end
303
496
 
304
497
  specify { expect(_request_filter).to be_nil }
305
498
 
306
- specify { expect(_request_filter { update_types(:type) }).to eq({type: {value: 'type'}}) }
307
- specify { expect(_request_filter { update_types([:type1, :type2]) })
308
- .to eq({or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}) }
309
-
310
- specify { expect(_request_filter { update_filters([:filter1, :filter2]) })
311
- .to eq({and: [:filter1, :filter2]}) }
312
- specify { expect(_request_filter { update_options(filter_mode: :or); update_filters([:filter1, :filter2]) })
313
- .to eq({or: [:filter1, :filter2]}) }
314
- specify { expect(_request_filter { update_options(filter_mode: :must); update_filters([:filter1, :filter2]) })
315
- .to eq({bool: {must: [:filter1, :filter2]}}) }
316
- specify { expect(_request_filter { update_options(filter_mode: :should); update_filters([:filter1, :filter2]) })
317
- .to eq({bool: {should: [:filter1, :filter2]}}) }
318
- specify { expect(_request_filter { update_options(filter_mode: :must_not); update_filters([:filter1, :filter2]) })
319
- .to eq({bool: {must_not: [:filter1, :filter2]}}) }
320
-
321
- specify { expect(_request_filter { update_types([:type1, :type2]); update_filters([:filter1, :filter2]) })
322
- .to eq({and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, :filter1, :filter2]}) }
323
- specify { expect(_request_filter { update_options(filter_mode: :or); update_types([:type1, :type2]); update_filters([:filter1, :filter2]) })
324
- .to eq({and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {or: [:filter1, :filter2]}]}) }
325
- specify { expect(_request_filter { update_options(filter_mode: :must); update_types([:type1, :type2]); update_filters([:filter1, :filter2]) })
326
- .to eq({and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {must: [:filter1, :filter2]}}]}) }
327
- specify { expect(_request_filter { update_options(filter_mode: :should); update_types([:type1, :type2]); update_filters([:filter1, :filter2]) })
328
- .to eq({and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {should: [:filter1, :filter2]}}]}) }
329
- specify { expect(_request_filter { update_options(filter_mode: :must_not); update_types([:type1, :type2]); update_filters([:filter1, :filter2]) })
330
- .to eq({and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {must_not: [:filter1, :filter2]}}]}) }
499
+ specify { expect(_request_filter { update_types(:type) }).to eq(type: {value: 'type'}) }
500
+ specify do
501
+ expect(_request_filter { update_types(%i[type1 type2]) })
502
+ .to eq(or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}])
503
+ end
504
+
505
+ specify do
506
+ expect(_request_filter { update_filters(%i[filter1 filter2]) })
507
+ .to eq(and: %i[filter1 filter2])
508
+ end
509
+ specify do
510
+ expect(_request_filter do
511
+ update_options(filter_mode: :or)
512
+ update_filters(%i[filter1 filter2])
513
+ end)
514
+ .to eq(or: %i[filter1 filter2])
515
+ end
516
+ specify do
517
+ expect(_request_filter do
518
+ update_options(filter_mode: :must)
519
+ update_filters(%i[filter1 filter2])
520
+ end)
521
+ .to eq(bool: {must: %i[filter1 filter2]})
522
+ end
523
+ specify do
524
+ expect(_request_filter do
525
+ update_options(filter_mode: :should)
526
+ update_filters(%i[filter1 filter2])
527
+ end)
528
+ .to eq(bool: {should: %i[filter1 filter2]})
529
+ end
530
+ specify do
531
+ expect(_request_filter do
532
+ update_options(filter_mode: :must_not)
533
+ update_filters(%i[filter1 filter2])
534
+ end)
535
+ .to eq(bool: {must_not: %i[filter1 filter2]})
536
+ end
537
+
538
+ specify do
539
+ expect(_request_filter do
540
+ update_types(%i[type1 type2])
541
+ update_filters(%i[filter1 filter2])
542
+ end)
543
+ .to eq(and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, :filter1, :filter2])
544
+ end
545
+ specify do
546
+ expect(_request_filter do
547
+ update_options(filter_mode: :or)
548
+ update_types(%i[type1 type2])
549
+ update_filters(%i[filter1 filter2])
550
+ end)
551
+ .to eq(and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {or: %i[filter1 filter2]}])
552
+ end
553
+ specify do
554
+ expect(_request_filter do
555
+ update_options(filter_mode: :must)
556
+ update_types(%i[type1 type2])
557
+ update_filters(%i[filter1 filter2])
558
+ end)
559
+ .to eq(and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {must: %i[filter1 filter2]}}])
560
+ end
561
+ specify do
562
+ expect(_request_filter do
563
+ update_options(filter_mode: :should)
564
+ update_types(%i[type1 type2])
565
+ update_filters(%i[filter1 filter2])
566
+ end)
567
+ .to eq(and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {should: %i[filter1 filter2]}}])
568
+ end
569
+ specify do
570
+ expect(_request_filter do
571
+ update_options(filter_mode: :must_not)
572
+ update_types(%i[type1 type2])
573
+ update_filters(%i[filter1 filter2])
574
+ end)
575
+ .to eq(and: [{or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}, {bool: {must_not: %i[filter1 filter2]}}])
576
+ end
331
577
  end
332
578
 
333
579
  describe '#_request_post_filter' do
334
- def _request_post_filter &block
580
+ def _request_post_filter(&block)
335
581
  subject.instance_exec(&block) if block
336
582
  subject.send(:_request_post_filter)
337
583
  end
338
584
 
339
585
  specify { expect(_request_post_filter).to be_nil }
340
586
 
341
- specify { expect(_request_post_filter { update_post_filters([:post_filter1, :post_filter2]) })
342
- .to eq({and: [:post_filter1, :post_filter2]}) }
343
- specify { expect(_request_post_filter { update_options(post_filter_mode: :or); update_post_filters([:post_filter1, :post_filter2]) })
344
- .to eq({or: [:post_filter1, :post_filter2]}) }
345
- specify { expect(_request_post_filter { update_options(post_filter_mode: :must); update_post_filters([:post_filter1, :post_filter2]) })
346
- .to eq({bool: {must: [:post_filter1, :post_filter2]}}) }
347
- specify { expect(_request_post_filter { update_options(post_filter_mode: :should); update_post_filters([:post_filter1, :post_filter2]) })
348
- .to eq({bool: {should: [:post_filter1, :post_filter2]}}) }
587
+ specify do
588
+ expect(_request_post_filter { update_post_filters(%i[post_filter1 post_filter2]) })
589
+ .to eq(and: %i[post_filter1 post_filter2])
590
+ end
591
+ specify do
592
+ expect(_request_post_filter do
593
+ update_options(post_filter_mode: :or)
594
+ update_post_filters(%i[post_filter1 post_filter2])
595
+ end)
596
+ .to eq(or: %i[post_filter1 post_filter2])
597
+ end
598
+ specify do
599
+ expect(_request_post_filter do
600
+ update_options(post_filter_mode: :must)
601
+ update_post_filters(%i[post_filter1 post_filter2])
602
+ end)
603
+ .to eq(bool: {must: %i[post_filter1 post_filter2]})
604
+ end
605
+ specify do
606
+ expect(_request_post_filter do
607
+ update_options(post_filter_mode: :should)
608
+ update_post_filters(%i[post_filter1 post_filter2])
609
+ end)
610
+ .to eq(bool: {should: %i[post_filter1 post_filter2]})
611
+ end
349
612
 
350
613
  context do
351
614
  before { allow(Chewy).to receive_messages(filter_mode: :or) }
352
615
 
353
- specify { expect(_request_post_filter { update_post_filters([:post_filter1, :post_filter2]) })
354
- .to eq({or: [:post_filter1, :post_filter2]}) }
616
+ specify do
617
+ expect(_request_post_filter { update_post_filters(%i[post_filter1 post_filter2]) })
618
+ .to eq(or: %i[post_filter1 post_filter2])
619
+ end
355
620
  end
356
621
  end
357
622
 
358
623
  describe '#_request_types' do
359
- def _request_types &block
624
+ def _request_types(&block)
360
625
  subject.instance_exec(&block) if block
361
626
  subject.send(:_request_types)
362
627
  end
363
628
 
364
629
  specify { expect(_request_types).to be_nil }
365
- specify { expect(_request_types { update_types(:type1) }).to eq({type: {value: 'type1'}}) }
366
- specify { expect(_request_types { update_types([:type1, :type2]) })
367
- .to eq({or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}]}) }
630
+ specify { expect(_request_types { update_types(:type1) }).to eq(type: {value: 'type1'}) }
631
+ specify do
632
+ expect(_request_types { update_types(%i[type1 type2]) })
633
+ .to eq(or: [{type: {value: 'type1'}}, {type: {value: 'type2'}}])
634
+ end
368
635
  end
369
636
 
370
637
  describe '#_queries_join' do
371
- def _queries_join *args
638
+ def _queries_join(*args)
372
639
  subject.send(:_queries_join, *args)
373
640
  end
374
641
 
@@ -376,31 +643,31 @@ describe Chewy::Query::Criteria do
376
643
 
377
644
  specify { expect(_queries_join([], :dis_max)).to be_nil }
378
645
  specify { expect(_queries_join([query], :dis_max)).to eq(query) }
379
- specify { expect(_queries_join([query, query], :dis_max)).to eq({dis_max: {queries: [query, query]}}) }
646
+ specify { expect(_queries_join([query, query], :dis_max)).to eq(dis_max: {queries: [query, query]}) }
380
647
 
381
648
  specify { expect(_queries_join([], 0.7)).to be_nil }
382
649
  specify { expect(_queries_join([query], 0.7)).to eq(query) }
383
- specify { expect(_queries_join([query, query], 0.7)).to eq({dis_max: {queries: [query, query], tie_breaker: 0.7}}) }
650
+ specify { expect(_queries_join([query, query], 0.7)).to eq(dis_max: {queries: [query, query], tie_breaker: 0.7}) }
384
651
 
385
652
  specify { expect(_queries_join([], :must)).to be_nil }
386
653
  specify { expect(_queries_join([query], :must)).to eq(query) }
387
- specify { expect(_queries_join([query, query], :must)).to eq({bool: {must: [query, query]}}) }
654
+ specify { expect(_queries_join([query, query], :must)).to eq(bool: {must: [query, query]}) }
388
655
 
389
656
  specify { expect(_queries_join([], :should)).to be_nil }
390
657
  specify { expect(_queries_join([query], :should)).to eq(query) }
391
- specify { expect(_queries_join([query, query], :should)).to eq({bool: {should: [query, query]}}) }
658
+ specify { expect(_queries_join([query, query], :should)).to eq(bool: {should: [query, query]}) }
392
659
 
393
660
  specify { expect(_queries_join([], :must_not)).to be_nil }
394
- specify { expect(_queries_join([query], :must_not)).to eq({bool: {must_not: [query]}}) }
395
- specify { expect(_queries_join([query, query], :must_not)).to eq({bool: {must_not: [query, query]}}) }
661
+ specify { expect(_queries_join([query], :must_not)).to eq(bool: {must_not: [query]}) }
662
+ specify { expect(_queries_join([query, query], :must_not)).to eq(bool: {must_not: [query, query]}) }
396
663
 
397
664
  specify { expect(_queries_join([], '25%')).to be_nil }
398
665
  specify { expect(_queries_join([query], '25%')).to eq(query) }
399
- specify { expect(_queries_join([query, query], '25%')).to eq({bool: {should: [query, query], minimum_should_match: '25%'}}) }
666
+ specify { expect(_queries_join([query, query], '25%')).to eq(bool: {should: [query, query], minimum_should_match: '25%'}) }
400
667
  end
401
668
 
402
669
  describe '#_filters_join' do
403
- def _filters_join *args
670
+ def _filters_join(*args)
404
671
  subject.send(:_filters_join, *args)
405
672
  end
406
673
 
@@ -408,26 +675,26 @@ describe Chewy::Query::Criteria do
408
675
 
409
676
  specify { expect(_filters_join([], :and)).to be_nil }
410
677
  specify { expect(_filters_join([filter], :and)).to eq(filter) }
411
- specify { expect(_filters_join([filter, filter], :and)).to eq({and: [filter, filter]}) }
678
+ specify { expect(_filters_join([filter, filter], :and)).to eq(and: [filter, filter]) }
412
679
 
413
680
  specify { expect(_filters_join([], :or)).to be_nil }
414
681
  specify { expect(_filters_join([filter], :or)).to eq(filter) }
415
- specify { expect(_filters_join([filter, filter], :or)).to eq({or: [filter, filter]}) }
682
+ specify { expect(_filters_join([filter, filter], :or)).to eq(or: [filter, filter]) }
416
683
 
417
684
  specify { expect(_filters_join([], :must)).to be_nil }
418
685
  specify { expect(_filters_join([filter], :must)).to eq(filter) }
419
- specify { expect(_filters_join([filter, filter], :must)).to eq({bool: {must: [filter, filter]}}) }
686
+ specify { expect(_filters_join([filter, filter], :must)).to eq(bool: {must: [filter, filter]}) }
420
687
 
421
688
  specify { expect(_filters_join([], :should)).to be_nil }
422
689
  specify { expect(_filters_join([filter], :should)).to eq(filter) }
423
- specify { expect(_filters_join([filter, filter], :should)).to eq({bool: {should: [filter, filter]}}) }
690
+ specify { expect(_filters_join([filter, filter], :should)).to eq(bool: {should: [filter, filter]}) }
424
691
 
425
692
  specify { expect(_filters_join([], :must_not)).to be_nil }
426
- specify { expect(_filters_join([filter], :must_not)).to eq({bool: {must_not: [filter]}}) }
427
- specify { expect(_filters_join([filter, filter], :must_not)).to eq({bool: {must_not: [filter, filter]}}) }
693
+ specify { expect(_filters_join([filter], :must_not)).to eq(bool: {must_not: [filter]}) }
694
+ specify { expect(_filters_join([filter, filter], :must_not)).to eq(bool: {must_not: [filter, filter]}) }
428
695
 
429
696
  specify { expect(_filters_join([], '25%')).to be_nil }
430
697
  specify { expect(_filters_join([filter], '25%')).to eq(filter) }
431
- specify { expect(_filters_join([filter, filter], '25%')).to eq({bool: {should: [filter, filter], minimum_should_match: '25%'}}) }
698
+ specify { expect(_filters_join([filter, filter], '25%')).to eq(bool: {should: [filter, filter], minimum_should_match: '25%'}) }
432
699
  end
433
700
  end