chess 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 713285e67727bcfff37a5f5ca1f5d0df7df0bd6c
-  data.tar.gz: 37d1a5a1d261dc7f09d50c82bec412a2608fa121
+SHA256:
+  metadata.gz: 4cc1db854c4be0ade586baddccf252d377a4429e4ec9663ca893c02678c97113
+  data.tar.gz: '0494c3fea2208b2d4c47c705678b6595d11578b5da6296ef8136af79b4ae95fe'
 SHA512:
-  metadata.gz: 7a4bf8496ec140aa5718ef32451ce9875c9a5c456cec8aa05b49a0589ed22ce0194155352fb10436a569ff1599180cbebe05c9a23753fd5863cec6bd19249afa
-  data.tar.gz: 40f7d06171a88dead660f28ffa33394c196ab17a4ddd1a4d9f01d7780c720efc193cedfa2d12c4bd56bf3316c38792665a2a1977a59c8dad96b14844c8e0c9e8
+  metadata.gz: a7e2971e83ee9aa24caccbd23825df3bfc959c47ab8d68db5ae48af24fcc78044854a1339091c7c54a9f536707fe16ca512adb886c835f5ec32a9891a286623b
+  data.tar.gz: 8008eb2294ec8b9860dd03e02fd7207cfd37b4292f6d16b5ba1a24e047bdb42e62b5a05e6ac21f126899a8a4299c45bf42310c1e2001277dcf76d86a6a2547ea

data/.rubocop.yml

@@ -0,0 +1,186 @@
+require: rubocop-performance
+
+AllCops:
+  Exclude:
+    - bin/*
+    - db/migrate/*
+    - db/schema.rb
+    - db/seeds.rb
+    - lib/*/Gemfile
+    - lib/*/Rakefile
+    - lib/*/bin/*
+    - lib/*/*.gemspec
+    - node_modules/**/*
+    - spec/**/*
+    - tmp/**/*
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Layout/AlignHash:
+  Enabled: false
+
+Layout/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/EmptyLinesAroundBlockBody:
+  EnforcedStyle: no_empty_lines
+
+Layout/EmptyLinesAroundClassBody:
+  EnforcedStyle: no_empty_lines
+
+Layout/IndentationConsistency:
+  EnforcedStyle: rails
+
+Layout/IndentFirstArrayElement:
+  EnforcedStyle: consistent
+
+Layout/IndentFirstHashElement:
+  EnforcedStyle: consistent
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Max: 100
+
+Metrics/BlockNesting:
+  Max: 4
+
+Metrics/ClassLength:
+  Max: 1000
+
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+Metrics/LineLength:
+  Enabled: false
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 100
+
+Metrics/ModuleLength:
+  Max: 1000
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Max: 20
+
+Performance/Casecmp:
+  Enabled: false
+
+Rails:
+  Enabled: true
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+Rails/InverseOf:
+  Enabled: false
+
+Rails/OutputSafety:
+  Enabled: false
+
+Rails/SafeNavigation:
+  ConvertTry: true
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+Rails/UnknownEnv:
+  Environments:
+    - development
+    - test
+    - simulation
+    - staging
+    - production
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/ClassVars:
+  Enabled: false
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+Style/FormatStringToken:
+  EnforcedStyle: template
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/GlobalVars:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/Lambda:
+  EnforcedStyle: literal
+
+Style/MethodDefParentheses:
+  Enabled: false
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/RaiseArgs:
+  EnforcedStyle: compact
+
+Style/RedundantReturn:
+  Enabled: false
+
+Style/RedundantSelf:
+  Enabled: false
+
+Style/RegexpLiteral:
+  AllowInnerSlashes: true
+
+Style/RescueModifier:
+  Enabled: false
+
+Style/SafeNavigation:
+  Enabled: true
+
+Style/SingleLineMethods:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
 
 # Specify your gem's dependencies in chess.gemspec
 gemspec

data/README.md

@@ -6,7 +6,7 @@ generator is written in C as a Ruby extension.
 
 ## Requirements
 
-*   Ruby 1.9 or higher
+- Ruby 2.0 or higher
 
 ## Installation
 

data/Rakefile

@@ -2,10 +2,10 @@ require 'bundler/gem_tasks'
 
 require 'yard'
 YARD::Rake::YardocTask.new do |t|
- t.files = ['lib/**/*.rb', 'ext/*.c']
- t.options << '-rREADME.md'
- t.options << '--title=Chess'
- t.options << '-mmarkdown'
+  t.files = ['lib/**/*.rb', 'ext/*.c']
+  t.options << '-rREADME.md'
+  t.options << '--title=Chess'
+  t.options << '-mmarkdown'
 end
 
 require 'rake/testtask'

data/chess.gemspec

@@ -1,5 +1,4 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path('../lib', __FILE__)
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 require 'chess/version'
 
 Gem::Specification.new do |s|
@@ -8,21 +7,23 @@ Gem::Specification.new do |s|
   s.authors     = ['Enrico Pilotto']
   s.email       = ['epilotto@gmx.com']
   s.homepage    = 'https://github.com/pioz/chess'
-  s.summary     = %q{A fast chess library to play chess with Ruby.}
-  s.description = %q{A fast chess library that use bitboards to play chess with Ruby.}
+  s.summary     = 'A fast chess library to play chess with Ruby.'
+  s.description = 'A fast chess library that use bitboards to play chess with Ruby.'
   s.license     = 'LGPLv3'
 
   s.rubyforge_project = 'chess'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.extensions    = ['ext/extconf.rb']
   s.require_paths = ['lib']
 
   s.required_ruby_version = '>= 1.9'
-  s.add_development_dependency 'bundler', '~> 1.14'
-  s.add_development_dependency 'rake', '~> 12.0'
-  s.add_development_dependency 'minitest', '~> 5.10'
+  s.add_development_dependency 'bundler', '~> 2'
+  s.add_development_dependency 'minitest', '~> 5'
+  s.add_development_dependency 'rake', '~> 12'
+  s.add_development_dependency 'rubocop', '~> 0.71'
+  s.add_development_dependency 'rubocop-performance', '~> 1'
   s.add_development_dependency 'yard', '~> 0.9'
 end

data/ext/extconf.rb

@@ -10,8 +10,8 @@ INCLUDE_DIRS = [
   # Then search /usr/local for people that installed from source
   '/usr/local/include',
   # Finally fall back to /usr
-  '/usr/include',
-]
+  '/usr/include'
+].freeze
 
 LIB_DIRS = [
   # Check the ruby install locations
@@ -21,10 +21,10 @@ LIB_DIRS = [
   # Then search /usr/local for people that installed from source
   '/usr/local/lib',
   # Finally fall back to /usr
-  '/usr/lib',
-]
+  '/usr/lib'
+].freeze
 
-#dir_config('chess', INCLUDE_DIRS, LIB_DIRS)
-$CFLAGS << " -std=c99"
+# dir_config('chess', INCLUDE_DIRS, LIB_DIRS)
+$CFLAGS << ' -std=c99'
 
 create_makefile('chess/chess')

data/lib/chess/exceptions.rb

@@ -1,5 +1,4 @@
 module Chess
-
   # This exception will be raised when an invalid short algebraic chess notation
   # string is passed to the {Game#move} function.
   class BadNotationError < StandardError
@@ -11,9 +10,8 @@ module Chess
 
   # This exception will be raised when a malformed PGN file is loaded.
   class InvalidPgnFormatError < StandardError
-    # @param [String] filename The PGN filename
-    def initialize(filename)
-      super("Invalid PGN file '#{filename}'")
+    def initialize
+      super('Invalid PGN format')
     end
   end
 
@@ -24,5 +22,4 @@ module Chess
       super("Invalid FEN string '#{fen_string}'")
     end
   end
-
 end

data/lib/chess/game.rb

@@ -1,10 +1,8 @@
 require File.join(File.dirname(__FILE__), '../../ext/chess')
 
 module Chess
-
   # This class rappresents a chess game.
   class Game < CGame
-
     # @param [Array<String>] moves If an array of moves is provided, the moves will be performed.
     # @raise [IllegalMoveError]
     # @raise [BadNotationError]
@@ -41,7 +39,7 @@ module Chess
     # @raise [InvalidFenFormatError]
     # @note This game do not have history before the FEN placement.
     def self.load_fen(fen)
-      if fen =~ /^((?:[PRNBQKprnbqk1-8]{1,8}\/){7}[RNBQKPrnbqkp1-8]{1,8})\s(w|b)\s(K?Q?k?q?|-)\s([a-h][1-8]|-)\s(\d+)\s(\d+)$/
+      if /^((?:[PRNBQKprnbqk1-8]{1,8}\/){7}[RNBQKPrnbqkp1-8]{1,8})\s(w|b)\s(K?Q?k?q?|-)\s([a-h][1-8]|-)\s(\d+)\s(\d+)$/.match?(fen)
         game = Chess::Game.new
         game.set_fen!(fen)
         return game
@@ -52,8 +50,8 @@ module Chess
 
     # Make a move.
     # @note This add a new {Board} in the {Game}.
-    # @param [String] m Represents the short algebraic chess notation string of
-    #   the move. `m` can be also _from_square_ plus _to_square_ _('e2e4', ...,
+    # @param [String] notation Represents the short algebraic chess notation string of
+    #   the move. `notation` can be also _from_square_ plus _to_square_ _('e2e4', ...,
     #   'b1c3')_ (coordinate chess notation).
     # @return [String] Returns a string that represents the short algebraic
     #   chess notation of the move.
@@ -61,24 +59,22 @@ module Chess
     # @raise {IllegalMoveError} if the move is illegal.
     # @raise {BadNotationError} if the short algebraic chess notation is
     #   malformed.
-    def move(m)
-      begin
-        expand = expand_move(m)
-        if expand[:from]
-          move2(expand[:from], expand[:to], expand[:promotion])
-        else
-          super(expand[:name], expand[:dis], expand[:to], expand[:promotion])
-        end
-      rescue IllegalMoveError
-        if ENV['DEBUG']
-          raise IllegalMoveError.new("Illegal move '#{m}'\nStatus: #{self.status}\nPlayer turn #{self.active_player}\n#{self.to_s}")
-        else
-          raise IllegalMoveError.new("Illegal move '#{m}'")
-        end
+    def move(notation)
+      expand = expand_move(notation)
+      if expand[:from]
+        move2(expand[:from], expand[:to], expand[:promotion])
+      else
+        super(expand[:name], expand[:dis], expand[:to], expand[:promotion])
+      end
+    rescue IllegalMoveError
+      if ENV['DEBUG']
+        raise IllegalMoveError.new("Illegal move '#{notation}'\nStatus: #{self.status}\nPlayer turn #{self.active_player}\n#{self}")
+      else
+        raise IllegalMoveError.new("Illegal move '#{notation}'")
       end
     end
-    alias :move= :move
-    alias :<< :move
+    alias move= move
+    alias << move
 
     # Make the array of moves.
     # @param [Array<String>] moves The array of moves to performe.
@@ -160,41 +156,37 @@ module Chess
 
     private
 
-    # Expand the short algebraic chess notation string `m` in a hash like this:
-    #
-    #     Ngxe2 ==> { name: 'N', dis: 'g', from: nil, to: 'e2', promotion: nil }
-    def expand_move(m)
-      if match = m.match(Chess::MOVE_REGEXP)
-        expand = {
-          name: match[1] || 'P',    # Piece name [RNBQK]
-          dis: match[2],            # Disambiguating move
-          to: match[3],             # Move to
-          promotion: match[4],      # Promote with
-        }
-        expand[:from] = match[2] if match[2] && match[2].size == 2
-        return expand
-      elsif m =~ SHORT_CASTLING_REGEXP
-        if self.board.active_color # black king short castling
-          return { name: 'K', dis: nil, from: 'e8', to: 'g8', promotion: nil }
-        else # white king short castling
-          return { name: 'K', dis: nil, from: 'e1', to: 'g1', promotion: nil }
-        end
-      elsif m =~ LONG_CASTLING_REGEXP
-        if self.board.active_color # black king long castling
-          return { name: 'K', dis: nil, from: 'e8', to: 'c8', promotion: nil }
-        else # white king long castling
-          return { name: 'K', dis: nil, from: 'e1', to: 'c1', promotion: nil }
+      # Expand the short algebraic chess notation string `notation` in a hash like this:
+      #
+      #     Ngxe2 ==> { name: 'N', dis: 'g', from: nil, to: 'e2', promotion: nil }
+      def expand_move(notation)
+        if (match = notation.match(Chess::MOVE_REGEXP))
+          expand = {
+            name: match[1] || 'P',    # Piece name [RNBQK]
+            dis: match[2],            # Disambiguating move
+            to: match[3],             # Move to
+            promotion: match[4]      # Promote with
+          }
+          expand[:from] = match[2] if match[2] && match[2].size == 2
+          return expand
+        elsif SHORT_CASTLING_REGEXP.match?(notation)
+          if self.board.active_color # black king short castling
+            return { name: 'K', dis: nil, from: 'e8', to: 'g8', promotion: nil }
+          else # white king short castling
+            return { name: 'K', dis: nil, from: 'e1', to: 'g1', promotion: nil }
+          end
+        elsif LONG_CASTLING_REGEXP.match?(notation)
+          if self.board.active_color # black king long castling
+            return { name: 'K', dis: nil, from: 'e8', to: 'c8', promotion: nil }
+          else # white king long castling
+            return { name: 'K', dis: nil, from: 'e1', to: 'c1', promotion: nil }
+          end
         end
+        raise BadNotationError.new(notation)
       end
-      raise BadNotationError.new(m)
-    end
-
   end
 
-  private
-
-  MOVE_REGEXP = /^([RNBQK])?([a-h]|[1-8]|[a-h][1-8])?(?:x)?([a-h][1-8])(?:=?([RrNnBbQq]))?(?:ep)?(?:\+|\#)?$/
-  SHORT_CASTLING_REGEXP = /^([0O])-([0O])([\+#])?$/
-  LONG_CASTLING_REGEXP = /^([0O])-([0O])-([0O])([\+#])?$/
-
+  MOVE_REGEXP = /^([RNBQK])?([a-h]|[1-8]|[a-h][1-8])?(?:x)?([a-h][1-8])(?:=?([RrNnBbQq]))?(?:ep)?(?:\+|\#)?$/.freeze
+  SHORT_CASTLING_REGEXP = /^([0O])-([0O])([\+#])?$/.freeze
+  LONG_CASTLING_REGEXP = /^([0O])-([0O])-([0O])([\+#])?$/.freeze
 end

data/lib/chess/gnuchess.rb

@@ -1,7 +1,6 @@
 require 'mkmf'
 
 module Chess
-
   # Use Gnuchess to I.A. _(Only a draft)_.
   #
   # To use this module, extend a game object with {Chess::Gnuchess}.
@@ -12,7 +11,6 @@ module Chess
   #   g.gnuchess_move!
   #   puts g
   module Gnuchess
-
     # Returns the next move calculated by Gnuchess.
     # @return [String] Returns the short algebraic chess notation of the move.
     def gnuchess_move
@@ -24,8 +22,9 @@ module Chess
           pipe.puts(m)
         end
         pipe.puts('go')
-        while line = pipe.gets
+        while (line = pipe.gets)
           raise IllegalMoveError if line.include?('Invalid move')
+
           match = line.match(/My move is : ([a-h][1-8][a-h][1-8][rkbq]?)/)
           return match[1] if match
         end
@@ -44,70 +43,72 @@ module Chess
       self.move(next_move) if next_move
     end
 
-    private
+    class << self
+      private
 
-    def self.included(mod)
-      raise_if_gnuchess_is_not_installed
-    end
+        def included(_mod)
+          raise_if_gnuchess_is_not_installed
+        end
 
-    def self.extended(mod)
-      raise_if_gnuchess_is_not_installed
-    end
+        def extended(_mod)
+          raise_if_gnuchess_is_not_installed
+        end
 
-    def gen_pgn(file_to_save, moves = [])
-      done = false
-      pipe = IO.popen('gnuchess', 'r+')
-      begin
-        pipe.write("depth 1\n")
-        pipe.write("force\n")
-        pipe.write("name chess.rb\n")
-        moves.each do |move|
-          pipe.write("#{move}\n")
+        # Raise an exception if Gnuchess is not installed
+        def raise_if_gnuchess_is_not_installed
+          unless find_executable0('gnuchess')
+            raise 'You must install Gnuchess to use the module Chess::Gnuchess!'
+          end
         end
-        while(!done)
-          pipe.write("go\n")
-          while line = pipe.gets
-            if line =~ /My move is : /
-              break
-            elsif line =~ / : resign/
-              break
-            elsif line =~ / : 1-0 {White mates}/
-              done = :white_won
-              break
-            elsif line =~ / : 0-1 {Black mates}/
-              done = :black_won
-              break
-            elsif m = line.match(/1\/2-1\/2 {(.*?)}/)
-              case m[1]
-              when 'Stalemate'
-                done = :stalemate
-              when 'Draw by repetition'
-                done = :repetition
-              when 'Draw by fifty-move rule'
-                done = :fifty_move_rule
-              when 'Draw by insufficient material'
-                done = :insufficient_material
+    end
+
+    private
+
+      def gen_pgn(file_to_save, moves = [])
+        done = false
+        pipe = IO.popen('gnuchess', 'r+')
+        begin
+          pipe.write("depth 1\n")
+          pipe.write("force\n")
+          pipe.write("name chess.rb\n")
+          moves.each do |move|
+            pipe.write("#{move}\n")
+          end
+          until done
+            pipe.write("go\n")
+            while (line = pipe.gets)
+              if /My move is : /.match?(line)
+                break
+              elsif / : resign/.match?(line)
+                break
+              elsif / : 1-0 {White mates}/.match?(line)
+                done = :white_won
+                break
+              elsif / : 0-1 {Black mates}/.match?(line)
+                done = :black_won
+                break
+              elsif (m = line.match(/1\/2-1\/2 {(.*?)}/))
+                case m[1]
+                when 'Stalemate'
+                  done = :stalemate
+                when 'Draw by repetition'
+                  done = :repetition
+                when 'Draw by fifty-move rule'
+                  done = :fifty_move_rule
+                when 'Draw by insufficient material'
+                  done = :insufficient_material
+                end
+                break
               end
-              break
             end
           end
+          dir = File.dirname(file_to_save)
+          name = File.basename(file_to_save)
+          pipe.write("pgnsave #{File.join(dir, done.to_s, name)}\n")
+        ensure
+          pipe.write("quit\n")
+          pipe.close
         end
-        dir = File.dirname(file_to_save)
-        name = File.basename(file_to_save)
-        pipe.write("pgnsave #{File.join(dir, done.to_s, name)}\n")
-      ensure
-        pipe.write("quit\n")
-        pipe.close
       end
-    end
-
-    # Raise an exception if Gnuchess is not installed
-    def self.raise_if_gnuchess_is_not_installed
-      unless find_executable0('gnuchess')
-        raise 'You must install Gnuchess to use the module Chess::Gnuchess!'
-      end
-    end
-
   end
-
 end

data/lib/chess/pgn.rb

@@ -1,10 +1,8 @@
 module Chess
-
   # Rappresents a game in PGN (Portable Game Notation) format.
   class Pgn
-
     # Array that include PGN standard tags.
-    TAGS = %w(event site date round white black result)
+    TAGS = %w[event site date round white black result].freeze
 
     # The name of the tournament or match event.
     # @return [String]
@@ -16,7 +14,7 @@ module Chess
     attr_accessor :site
     # The starting date of the game, in YYYY.MM.DD form. ?? is used for unknown values.
     # @return [String]
-    attr_accessor :date
+    attr_reader :date
     # The playing round ordinal of the game within the event.
     # @return [String]
     attr_accessor :round
@@ -52,20 +50,31 @@ module Chess
     # @raise [InvalidPgnFormatError]
     # @raise [IllegalMoveError]
     def load(filename, check_moves: false)
-      data = File.open(filename, 'r').read
-      data.gsub!(/\{.*?\}/, '') # remove comments
+      str = File.open(filename, 'r').read
+      load_from_string(str, check_moves: check_moves)
+    end
+
+    # Load a PGN from string.
+    # @param [String] str The PGN string to load.
+    # @param [Boolean] check_moves If true check if the moves are legal.
+    # @return [Pgn] Returns `self`.
+    # @raise [InvalidPgnFormatError]
+    # @raise [IllegalMoveError]
+    def load_from_string(str, check_moves: false)
+      str.gsub!(/\{.*?\}/, '') # remove comments
       TAGS.each do |t|
-        instance_variable_set("@#{t}", data.match(/^\[#{t.capitalize} ".*"\]\s?$/).to_s.strip[t.size+3..-3])
+        instance_variable_set("@#{t}", str.match(/^\[#{t.capitalize} ".*"\]\s?$/).to_s.strip[t.size + 3..-3])
       end
       @result = '1/2-1/2' if @result == '1/2'
-      game_index = data.index(/^1\./)
-      raise Chess::InvalidPgnFormatError.new(filename) if game_index.nil?
-      game = data[game_index..-1].strip
-      @moves = game.gsub("\n", ' ').split(/\d+\./).collect{|t| t.strip}[1..-1].collect{|t| t.split(' ')}.flatten
-      @moves.delete_at(@moves.size-1) if @moves.last =~ /(0-1)|(1-0)|(1\/2)|(1\/2-1\/2)|(\*)/
+      game_index = str.index(/^1\./)
+      raise Chess::InvalidPgnFormatError.new if game_index.nil?
+
+      game = str[game_index..-1].strip
+      @moves = game.tr("\n", ' ').split(/\d+\./).collect(&:strip)[1..-1].collect { |t| t.split(' ') }.flatten
+      @moves.delete_at(@moves.size - 1) if @moves.last =~ /(0-1)|(1-0)|(1\/2)|(1\/2-1\/2)|(\*)/
       @moves.each do |m|
         if m !~ MOVE_REGEXP && m !~ SHORT_CASTLING_REGEXP && m !~ LONG_CASTLING_REGEXP
-          raise Chess::InvalidPgnFormatError.new(filename)
+          raise Chess::InvalidPgnFormatError.new
         end
       end
       Chess::Game.new(@moves) if check_moves
@@ -82,7 +91,7 @@ module Chess
       s << "\n"
       m = ''
       @moves.each_with_index do |move, i|
-        m << "#{i/2+1}. " if i % 2 == 0
+        m << "#{i / 2 + 1}. " if i.even?
         m << "#{move} "
       end
       m << @result unless @result.nil?
@@ -95,8 +104,8 @@ module Chess
       File.open(filename, 'w') { |f| f.write(self.to_s) }
     end
 
-    # @!visibility private
-    alias :old_date= :date=
+    # # @!visibility private
+    # alias old_date= date=
 
     # Set the date tag.
     def date=(value)
@@ -106,6 +115,5 @@ module Chess
         @date = value
       end
     end
-
   end
 end

data/lib/chess/utf8_notation.rb

@@ -1,5 +1,4 @@
 module Chess
-
   # With this module is possible call the method {#to_utf8} on a string. This
   # method convert the chess piece identifier character into UTF8 chess
   # character.
@@ -12,7 +11,6 @@ module Chess
   # @note To use this utility explicit require is needed: <tt>require
   #   'chess/utf8_notation'</tt>
   module UTF8Notation
-
     # Map a piece identifier character with the corresponding UTF8 chess
     # character
     UTF8_MAP = {
@@ -28,14 +26,13 @@ module Chess
       'b' => '♝',
       'q' => '♛',
       'k' => '♚'
-    }
+    }.freeze
 
     # Replace the piece identifier characters with UTF8 chess characters.
     # @return [String]
     def to_utf8
       self.gsub(/[PRNBQKprnbqk]/, UTF8_MAP)
     end
-
   end
 end
 

data/lib/chess/version.rb

@@ -1,5 +1,5 @@
 # The Chess library module.
 module Chess
   # The library version.
-  VERSION = '0.2.2'
+  VERSION = '0.3.0'.freeze
 end

data/test/test_big_pgn_collection.rb

@@ -1,13 +1,13 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   if ENV['BIG_PGN_COLLECTION'] && File.exist?(TestHelper::BIG_PGN_COLLECTION)
     puts 'Loading tests for a big PGN collection...'
     300_000.times do |i|
-      filename = sprintf("%06d.pgn", i+1)
+      filename = format('%06d.pgn', i + 1)
       path = File.join(TestHelper::BIG_PGN_COLLECTION, filename)
       break unless File.exist?(path)
+
       define_method "test_big_pgn_#{filename}" do
         pgn = Chess::Pgn.new(path)
         game = Chess::Game.new(pgn.moves)
@@ -15,5 +15,4 @@ class ChessTest < Minitest::Test
       end
     end
   end
-
 end

data/test/test_checkmate.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   TestHelper.pgns('checkmate').each do |file|
     name = File.basename(file, '.pgn')
     win = file.include?('white') ? 'white' : 'black'
@@ -18,5 +17,4 @@ class ChessTest < Minitest::Test
       end
     end
   end
-
 end

data/test/test_fifty_rule_move.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   TestHelper.pgns('fifty_move_rule').each do |file|
     name = File.basename(file, '.pgn')
     define_method "test_fifty_rule_move_#{name}" do
@@ -10,5 +9,4 @@ class ChessTest < Minitest::Test
       assert(game.board.fifty_rule_move?)
     end
   end
-
 end

data/test/test_helper.rb

@@ -2,12 +2,10 @@ require 'chess'
 require 'minitest/autorun'
 
 module TestHelper
-
-  PGN_COLLECTION = 'test/pgn_collection'
-  BIG_PGN_COLLECTION = '/Users/pioz/Code/prog/misc/pgn_collection/pgn'
+  PGN_COLLECTION = 'test/pgn_collection'.freeze
+  BIG_PGN_COLLECTION = '/Users/pioz/Code/prog/misc/pgn_collection/pgn'.freeze
 
   def self.pgns(path, prefix = PGN_COLLECTION)
     Dir[File.join(prefix, path, '**/*.pgn')]
   end
-
 end

data/test/test_illegal_moves.rb

@@ -1,14 +1,12 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   def test_illegal_moves
     game = Chess::Game.new
-    %w(Qf6 Rd4 Nc3=Q).each do |move|
+    %w[Qf6 Rd4 Nc3=Q].each do |move|
       assert_raises(Chess::IllegalMoveError) do
         game << move
       end
     end
   end
-
 end

data/test/test_insufficient_material.rb

@@ -7,12 +7,12 @@ class ChessTest < Minitest::Test
     '8/2k5/8/3b4/B7/8/2K5/8 w - - 0 1',
     '8/2k5/8/8/4B3/8/2K5/8 w - - 0 1',
     '8/2k5/8/5b2/8/8/2K5/8 w - - 0 1'
-  ]
+  ].freeze
 
   ONLY_KINGS_FENS = [
     '8/2k5/8/8/8/8/2K5/8 w - - 0 1',
     '8/4k3/8/8/1K6/8/8/8 w - - 0 1'
-  ]
+  ].freeze
 
   FENS.each_with_index do |fen, i|
     define_method("test_insufficient_material_by_fen_#{i}") do
@@ -37,5 +37,4 @@ class ChessTest < Minitest::Test
       assert(game.board.insufficient_material?)
     end
   end
-
 end

data/test/test_load_fen.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   def test_fen_in_progress
     g = Chess::Game.load_fen('rnbqkbnr/pp1ppppp/8/2p5/4P3/5N2/PPPP1PPP/RNBQKB1R b KQkq - 1 2')
     assert_equal 'P', g.board['e4']
@@ -49,5 +48,4 @@ class ChessTest < Minitest::Test
     g.move('Qh8')
     assert_equal '2b1kbnQ/rpq1pp1p/2n3p1/8/8/2P5/PP3PPP/RN2KBNR b KQ - 0 9', g.board.to_fen
   end
-
 end

data/test/test_move_generator.rb

@@ -1,20 +1,19 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   GENS = {
-    'r2qk3/8/2n5/8/8/8/p2B4/4K2R w K - 0 1' => {'e1' => ['Kd1', 'Ke2', 'Kf2', 'Kf1', 'O-O']},
-    'r2qk3/8/2n5/8/8/8/p2B4/4K2R w - - 0 1' => {'e1' => ['Kd1', 'Ke2', 'Kf2', 'Kf1']},
-    'r2qk3/8/2n5/2b5/8/8/p2B4/4K2R w K - 0 1' => {'e1' => ['Kd1', 'Ke2', 'Kf1']},
-    'r2qk3/8/2n5/2b5/8/8/p2B4/4K2R b K - 0 1' => {'a2' => ['a1=Q']},
-    'r2qk3/8/2n1n3/2b5/8/8/p2B4/4K2R b K - 0 1' => {'e6' => ['Nf8', 'Ng7', 'Ng5', 'Nf4', 'Ned4', 'Nc7']},
-    'r2qk3/8/2n5/2b2pP1/8/8/3B4/4K2R w K f6 0 1' => {'g5' => ['gxf6ep', 'g6']},
-    '1B1k4/r3q3/2n1n3/2b2pP1/8/1n6/3B4/4K2R b K - 0 1' => {'c6' => ['Nxb8', 'Ne5', 'Ncd4', 'Nb4', 'Nca5']},
-    '1B1k4/r3q3/2n1n3/2b2pP1/8/8/2nB4/3K3R b - - 0 1' => {'c6' => ['Nxb8', 'Ne5', 'Nc6d4', 'N6b4', 'Na5']},
-    '1B1k4/r3q3/2n1n2P/2b5/5p2/3p1RP1/3B4/3K4 w - - 0 1' => {'f3' => ['Rxd3', 'Re3', 'Rxf4', 'Rf2', 'Rf1']},
-    'k7/1Q6/2P5/8/8/8/8/3K4 b - - 0 1' => {'a8' => []},
-    'k7/6P1/8/8/8/3r4/3Q4/3K4 w - - 0 1' => {'d2' => ['Qxd3']}
-  }
+    'r2qk3/8/2n5/8/8/8/p2B4/4K2R w K - 0 1' => { 'e1' => ['Kd1', 'Ke2', 'Kf2', 'Kf1', 'O-O'] },
+    'r2qk3/8/2n5/8/8/8/p2B4/4K2R w - - 0 1' => { 'e1' => %w[Kd1 Ke2 Kf2 Kf1] },
+    'r2qk3/8/2n5/2b5/8/8/p2B4/4K2R w K - 0 1' => { 'e1' => %w[Kd1 Ke2 Kf1] },
+    'r2qk3/8/2n5/2b5/8/8/p2B4/4K2R b K - 0 1' => { 'a2' => ['a1=Q'] },
+    'r2qk3/8/2n1n3/2b5/8/8/p2B4/4K2R b K - 0 1' => { 'e6' => %w[Nf8 Ng7 Ng5 Nf4 Ned4 Nc7] },
+    'r2qk3/8/2n5/2b2pP1/8/8/3B4/4K2R w K f6 0 1' => { 'g5' => %w[gxf6ep g6] },
+    '1B1k4/r3q3/2n1n3/2b2pP1/8/1n6/3B4/4K2R b K - 0 1' => { 'c6' => %w[Nxb8 Ne5 Ncd4 Nb4 Nca5] },
+    '1B1k4/r3q3/2n1n3/2b2pP1/8/8/2nB4/3K3R b - - 0 1' => { 'c6' => %w[Nxb8 Ne5 Nc6d4 N6b4 Na5] },
+    '1B1k4/r3q3/2n1n2P/2b5/5p2/3p1RP1/3B4/3K4 w - - 0 1' => { 'f3' => %w[Rxd3 Re3 Rxf4 Rf2 Rf1] },
+    'k7/1Q6/2P5/8/8/8/8/3K4 b - - 0 1' => { 'a8' => [] },
+    'k7/6P1/8/8/8/3r4/3Q4/3K4 w - - 0 1' => { 'd2' => ['Qxd3'] }
+  }.freeze
 
   GENS.each do |fen, generators|
     define_method("test_move_generator_#{fen}") do
@@ -25,5 +24,4 @@ class ChessTest < Minitest::Test
       end
     end
   end
-
 end

data/test/test_particular_situations.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   def test_cant_castling
     game = Chess::Game.load_fen('2r1k2r/pR2p2p/2pn2Nb/P2p1p2/8/1P2P3/2PP4/2BQK3 b k - 1 3')
     assert_raises(Chess::IllegalMoveError) do
@@ -10,5 +9,4 @@ class ChessTest < Minitest::Test
     game = Chess::Game.load_fen('2r1k2r/pR2p2p/2pn3b/P2p1p2/8/1P2P3/2PP4/2BQK3 b k - 1 3')
     game << 'O-O'
   end
-
 end

data/test/test_pgn.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   TestHelper.pgns('invalid').each do |file|
     name = File.basename(file, '.pgn')
     define_method "test_invalid_pgn_#{name}" do
@@ -21,4 +20,51 @@ class ChessTest < Minitest::Test
     end
   end
 
+  def test_load_from_string
+    pgn_string = <<~PGN
+      [Event "70th ch-ITA"]
+      [Site "Siena ITA"]
+      [Round "10"]
+      [Date "2010.12.3"]
+      [White "Caruana, Fabiano"]
+      [Black "Godena, Michele"]
+      [Result "1-0"]
+      1.d4 d5 2.c4 dxc4 3.e4 e5 4.Nf3 Bb4+ 5.Nc3 exd4 6.Nxd4 Ne7 7.Bf4 Bxc3+ 8.bxc3 Ng6 9.Bg3 Qe7 10.Bxc4 Qxe4+ 11.Qe2 Qxe2+ 12.Bxe2 Na6 13.Rb1 O-O 14.O-O Re8 15.Rfe1 Nc5 16.Bxc7 Bd7 17.Bf3 Rxe1+ 18.Rxe1 Rc8 19.Bg3 b6 20.h4 Ne6 21.h5 Ne7 22.Be5 Nc6 23.Nxc6 Bxc6 24.Bg4 Re8 25.Bg3 g6 26.h6 f5 27.Bd1 f4 28.Bh4 Kf8 29.Re5 g5 30.Bh5 Rc8 31.Bxg5 Nxg5 32.Rxg5 Bd7 33.Rg7 Rc5 34.Bf3 Bf5 35.Rxa7 Rxc3 36.Bd5 Bg6 37.Ra4 Rc1+ 38.Kh2 Rc5 39.Rxf4+ Ke7 40.Bf3 Ra5 41.Rb4 b5 42.Bd5 Kf6 43.f4 Bf5 44.Bc6 Bd3 45.Rd4 Ra3 46.Bd5 Bb1 47.Rd1 Bd3 48.Bb3 Bc4 49.Bc2 Ke7 50.Bf5 Rxa2 51.Rd7+ Kf8 52.Rxh7 Bd5 53.Rd7 1-0
+    PGN
+    pgn = Chess::Pgn.new
+    pgn.load_from_string(pgn_string, check_moves: true)
+    assert_equal '70th ch-ITA', pgn.event
+    assert_equal 'Siena ITA', pgn.site
+    assert_equal '10', pgn.round
+    assert_equal '2010.12.3', pgn.date
+    assert_equal 'Caruana, Fabiano', pgn.white
+    assert_equal 'Godena, Michele', pgn.black
+    assert_equal 'Godena, Michele', pgn.black
+    assert_equal '1-0', pgn.result
+    assert_equal 'Rd7', pgn.moves.last
+  end
+
+  def test_load_from_string_without_tags
+    pgn_string = <<~PGN
+      1. e4 e5 2. Nf3 Nc6 3. Bb5 a6 {This opening is called the Ruy Lopez.}
+      4. Ba4 Nf6 5. O-O Be7 6. Re1 b5 7. Bb3 d6 8. c3 O-O 9. h3 Nb8 10. d4 Nbd7
+      11. c4 c6 12. cxb5 axb5 13. Nc3 Bb7 14. Bg5 b4 15. Nb1 h6 16. Bh4 c5 17. dxe5
+      Nxe4 18. Bxe7 Qxe7 19. exd6 Qf6 20. Nbd2 Nxd6 21. Nc4 Nxc4 22. Bxc4 Nb6
+      23. Ne5 Rae8 24. Bxf7+ Rxf7 25. Nxf7 Rxe1+ 26. Qxe1 Kxf7 27. Qe3 Qg5 28. Qxg5
+      hxg5 29. b3 Ke6 30. a3 Kd6 31. axb4 cxb4 32. Ra5 Nd5 33. f3 Bc8 34. Kf2 Bf5
+      35. Ra7 g6 36. Ra6+ Kc5 37. Ke1 Nf4 38. g3 Nxh3 39. Kd2 Kb5 40. Rd6 Kc5 41. Ra6
+      Nf2 42. g4 Bd3 43. Re6 1/2-1/2
+    PGN
+    pgn = Chess::Pgn.new
+    pgn.load_from_string(pgn_string, check_moves: true)
+    assert_nil pgn.event
+    assert_nil pgn.site
+    assert_nil pgn.round
+    assert_nil pgn.date
+    assert_nil pgn.white
+    assert_nil pgn.black
+    assert_nil pgn.black
+    assert_nil pgn.result
+    assert_equal 'Re6', pgn.moves.last
+  end
 end

data/test/test_stalemate.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   TestHelper.pgns('stalemate').each do |file|
     name = File.basename(file, '.pgn')
     define_method "test_stalemate_#{name}" do
@@ -11,5 +10,4 @@ class ChessTest < Minitest::Test
       assert_equal(game.result, '1/2-1/2')
     end
   end
-
 end

data/test/test_threefold_repetition.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class ChessTest < Minitest::Test
-
   TestHelper.pgns('threefold_repetition').each do |file|
     name = File.basename(file, '.pgn')
     define_method "test_threefold_repetition_#{name}" do
@@ -10,5 +9,4 @@ class ChessTest < Minitest::Test
       assert(game.threefold_repetition?)
     end
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chess
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Enrico Pilotto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-11 00:00:00.000000000 Z
+date: 2019-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,42 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '12'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.71'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.71'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.10'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.10'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +103,7 @@ extensions:
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -1340,8 +1369,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: chess
-rubygems_version: 2.6.13
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: A fast chess library to play chess with Ruby.