chefstyle 1.4.5 → 1.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47af66209187f3a802f47d1f8ff8288aab5ddc78a608217b46d7ae18e58d7c47
-  data.tar.gz: 765e364cacf5e1e600f47be32c9ff0fdd42a7963e2c7ceaed7c6afaa75cdd718
+  metadata.gz: 81eae99d4d4720c3b5fe9eb983ec9ea96a6bd875ad544d6cdef0eb14b38fab6a
+  data.tar.gz: a699c9cc4ce4a50c290f3a4c10ba9e0b1744eac6e0a810fd6b65f500e5d3ae87
 SHA512:
-  metadata.gz: 65645e67536a598db99d8d4c91440cee1bdc9473f01ea251f4c7544e1d864f19eaa041c84c437b2254cf7cf7fe6be28e3817874e0bcfcb9d0e20b411ce55ab12
-  data.tar.gz: c5d93ab780c5cd2ed2fccef4156870d8b2d045aa95cd0a2f45934f7fdc780702fd2f6d3c968d0f72fdec5475a59d4b847c83d14f5abd7b9177cc1ab2d4014acc
+  metadata.gz: a6db95fd2c908acec863ecc7ce92f7701446741ac0ac51844ab1ec17bf6ce7607c0e9ec8cdd73ee59d9305ee91ada32d58862d639327ff578e3c8a82f9515fbb
+  data.tar.gz: d20b03025fbcea9f8f05b58ab2164bc6ddd6864b90f43df4f3c10dad463cb3530bc809f74bef8c9a25effdcf90c5f055fe5d1272f458fcbcf9ee4eba61b6616d

data/config/chefstyle.yml

@@ -1,5 +1,6 @@
 AllCops:
   TargetRubyVersion: 2.4
+  SuggestExtensions: false
 
 #
 # Bundler
@@ -243,6 +244,7 @@ Layout/EmptyLineAfterGuardClause:
   Enabled: true
 Layout/EmptyLineBetweenDefs:
   Enabled: true
+  AllowAdjacentOneLineDefs: true
 Layout/EmptyLines:
   Enabled: true
 Layout/EmptyLinesAroundAccessModifier:
@@ -669,26 +671,42 @@ Style/ExpandPathArguments:
 Lint/RedundantSafeNavigation:
   Enabled: true
 
-ChefRuby/Ruby27KeywordArgumentWarnings:
+# Eases readability
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+# unnecessary complexity
+Lint/RedundantWithObject:
+  Enabled: true
+
+# unnecessary complexity
+Lint/RedundantWithIndex:
+  Enabled: true
+
+# avoid requiring twice
+Lint/DuplicateRequire:
+  Enabled: true
+
+Chef/Ruby/Ruby27KeywordArgumentWarnings:
   Description: Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
   Enabled: true
   VersionAdded: '1.3.0'
 
-ChefRuby/UnlessDefinedRequire:
+Chef/Ruby/UnlessDefinedRequire:
   Description: Workaround RubyGems' slow requires by only running require if the constant isn't already defined
   Enabled: true
   VersionAdded: '1.3.0'
   Include:
     - 'lib/**/*'
 
-ChefRuby/GemspecRequireRubygems:
+Chef/Ruby/GemspecRequireRubygems:
   Description: Rubygems does not need to be required in a Gemspec
   Enabled: true
   VersionAdded: '1.3.0'
   Include:
     - '**/*.gemspec'
 
-ChefRuby/RequireNetHttps:
+Chef/Ruby/RequireNetHttps:
   Description: net/https is deprecated and just includes net/http and openssl. We should include those directly instead
   Enabled: true
   VersionAdded: '1.3.0'

data/config/disable_all.yml

@@ -229,6 +229,8 @@ Lint/DeprecatedOpenSSLConstant:
   Enabled: false
 Lint/DisjunctiveAssignmentInConstructor:
   Enabled: false
+Lint/DuplicateBranch:
+  Enabled: false
 Lint/DuplicateCaseCondition:
   Enabled: false
 Lint/DuplicateElsifCondition:
@@ -237,6 +239,8 @@ Lint/DuplicateHashKey:
   Enabled: false
 Lint/DuplicateMethods:
   Enabled: false
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: false
 Lint/DuplicateRequire:
   Enabled: false
 Lint/DuplicateRescueException:
@@ -245,6 +249,10 @@ Lint/EachWithObjectArgument:
   Enabled: false
 Lint/ElseLayout:
   Enabled: false
+Lint/EmptyBlock:
+  Enabled: false
+Lint/EmptyClass:
+  Enabled: false
 Lint/EmptyConditionalBody:
   Enabled: false
 Lint/EmptyEnsure:
@@ -303,6 +311,8 @@ Lint/NestedPercentLiteral:
   Enabled: false
 Lint/NextWithoutAccumulator:
   Enabled: false
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: false
 Lint/NonDeterministicRequireOrder:
   Enabled: false
 Lint/NonLocalExitFromIterator:
@@ -373,6 +383,8 @@ Lint/SuppressedException:
   Enabled: false
 Lint/Syntax:
   Enabled: false
+Lint/ToEnumArguments:
+  Enabled: false
 Lint/ToJSON:
   Enabled: false
 Lint/TopLevelReturnWithArgument:
@@ -381,8 +393,12 @@ Lint/TrailingCommaInAttributeDeclaration:
   Enabled: false
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
+Lint/UnexpectedBlockArity:
+  Enabled: false
 Lint/UnifiedInteger:
   Enabled: false
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: false
 Lint/UnreachableCode:
   Enabled: false
 Lint/UnreachableLoop:
@@ -467,6 +483,8 @@ Style/Alias:
   Enabled: false
 Style/AndOr:
   Enabled: false
+Style/ArgumentsForwarding:
+  Enabled: false
 Style/ArrayCoercion:
   Enabled: false
 Style/ArrayJoin:
@@ -505,6 +523,8 @@ Style/ClassMethodsDefinitions:
   Enabled: false
 Style/ClassVars:
   Enabled: false
+Style/CollectionCompact:
+  Enabled: false
 Style/CollectionMethods:
   Enabled: false
 Style/ColonMethodCall:
@@ -537,6 +557,8 @@ Style/DocumentationMethod:
   Enabled: false
 Style/Documentation:
   Enabled: false
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
 Style/DoubleCopDisableDirective:
   Enabled: false
 Style/DoubleNegation:
@@ -641,6 +663,8 @@ Style/RedundantSelfAssignment:
   Enabled: false
 Style/SoleNestedConditional:
   Enabled: false
+Style/StaticClass:
+  Enabled: false
 Style/MethodCalledOnDoEndBlock:
   Enabled: false
 Style/MethodDefParentheses:
@@ -677,6 +701,8 @@ Style/MutableConstant:
   Enabled: false
 Style/NegatedIf:
   Enabled: false
+Style/NegatedIfElseCondition:
+  Enabled: false
 Style/NegatedUnless:
   Enabled: false
 Style/NegatedWhile:
@@ -691,6 +717,8 @@ Style/Next:
   Enabled: false
 Style/NilComparison:
   Enabled: false
+Style/NilLambda:
+  Enabled: false
 Style/NonNilCheck:
   Enabled: false
 Style/Not:
@@ -729,6 +757,8 @@ Style/RaiseArgs:
   Enabled: false
 Style/RandomWithOffset:
   Enabled: false
+Style/RedundantArgument:
+  Enabled: false
 Style/RedundantBegin:
   Enabled: false
 Style/RedundantCapitalW:
@@ -807,6 +837,8 @@ Style/Strip:
   Enabled: false
 Style/StructInheritance:
   Enabled: false
+Style/SwapValues:
+  Enabled: false
 Style/SymbolArray:
   Enabled: false
 Style/SymbolLiteral:

data/config/upstream.yml

@@ -139,6 +139,16 @@ AllCops:
   # from the lock file.) If the Ruby version is still unresolved, RuboCop will
   # use the oldest officially supported Ruby version (currently Ruby 2.4).
   TargetRubyVersion: ~
+  # Determines if a notification for extension libraries should be shown when
+  # rubocop is run. Keys are the name of the extension, and values are an array
+  # of gems in the Gemfile that the extension is suggested for, if not already
+  # included.
+  SuggestExtensions:
+    rubocop-rails: [rails]
+    rubocop-rspec: [rspec, rspec-rails]
+    rubocop-minitest: [minitest]
+    rubocop-sequel: [sequel]
+    rubocop-rake: [rake]
 
 #################### Bundler ###############################
 
@@ -313,7 +323,7 @@ Layout/AssignmentIndentation:
 
 Layout/BeginEndAlignment:
   Description: 'Align ends corresponding to begins correctly.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
   # The value `start_of_line` means that `end` should be aligned the start of the line
   # where the `begin` keyword is.
@@ -459,10 +469,14 @@ Layout/EmptyLineAfterMultilineCondition:
     - https://github.com/airbnb/ruby#multiline-if-newline
 
 Layout/EmptyLineBetweenDefs:
-  Description: 'Use empty lines between defs.'
+  Description: 'Use empty lines between class/module/method defs.'
   StyleGuide: '#empty-lines-between-methods'
   Enabled: true
   VersionAdded: '0.49'
+  VersionChanged: '1.4'
+  EmptyLineBetweenMethodDefs: true
+  EmptyLineBetweenClassDefs: true
+  EmptyLineBetweenModuleDefs: true
   # If `true`, this parameter means that single line method definitions don't
   # need an empty line between them.
   AllowAdjacentOneLineDefs: false
@@ -496,7 +510,7 @@ Layout/EmptyLinesAroundArguments:
 Layout/EmptyLinesAroundAttributeAccessor:
   Description: "Keep blank lines around attribute accessors."
   StyleGuide: '#empty-lines-around-attribute-accessor'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.83'
   VersionChanged: '0.84'
   AllowAliasSyntax: true
@@ -891,8 +905,8 @@ Layout/LineLength:
   StyleGuide: '#max-line-length'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: '0.84'
-  AutoCorrect: false
+  VersionChanged: '1.4'
+  AutoCorrect: true
   Max: 120
   # To make it possible to copy or click on URIs in the code, we allow lines
   # containing a URI to be longer than Max.
@@ -1145,7 +1159,7 @@ Layout/SpaceAroundKeyword:
 
 Layout/SpaceAroundMethodCallOperator:
   Description: 'Checks method call operators to not have spaces around them.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.82'
 
 Layout/SpaceAroundOperators:
@@ -1176,7 +1190,7 @@ Layout/SpaceBeforeBlockBraces:
   SupportedStylesForEmptyBraces:
     - space
     - no_space
-  VersionChanged: '0.52.1'
+  VersionChanged: '0.52'
 
 Layout/SpaceBeforeComma:
   Description: 'No spaces before commas.'
@@ -1334,8 +1348,8 @@ Layout/TrailingWhitespace:
   StyleGuide: '#no-trailing-whitespace'
   Enabled: true
   VersionAdded: '0.49'
-  VersionChanged: '0.83'
-  AllowInHeredoc: true
+  VersionChanged: '1.0'
+  AllowInHeredoc: false
 
 #################### Lint ##################################
 ### Warnings
@@ -1379,7 +1393,7 @@ Lint/BigDecimalNew:
 
 Lint/BinaryOperatorWithIdenticalOperands:
   Description: 'This cop checks for places where binary operator has identical operands.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -1398,8 +1412,13 @@ Lint/CircularArgumentReference:
 Lint/ConstantDefinitionInBlock:
   Description: 'Do not define constants within a block.'
   StyleGuide: '#no-constant-definition-in-block'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
+  VersionChanged: '1.3'
+  # `enums` for Typed Enums via T::Enum in Sorbet.
+  # https://sorbet.org/docs/tenum
+  AllowedMethods:
+    - enums
 
 Lint/ConstantResolution:
   Description: 'Check that constants are fully qualified with `::`.'
@@ -1415,6 +1434,22 @@ Lint/Debugger:
   Enabled: true
   VersionAdded: '0.14'
   VersionChanged: '0.49'
+  DebuggerReceivers:
+    - binding
+    - Kernel
+    - Pry
+  DebuggerMethods:
+    - debugger
+    - byebug
+    - remote_byebug
+    - pry
+    - remote_pry
+    - pry_remote
+    - console
+    - rescue
+    - save_and_open_page
+    - save_and_open_screenshot
+    - irb
 
 Lint/DeprecatedClassMethods:
   Description: 'Check for deprecated class method calls.'
@@ -1423,7 +1458,7 @@ Lint/DeprecatedClassMethods:
 
 Lint/DeprecatedOpenSSLConstant:
   Description: "Don't use algorithm constants for `OpenSSL::Cipher` and `OpenSSL::Digest`."
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.84'
 
 Lint/DisjunctiveAssignmentInConstructor:
@@ -1433,6 +1468,11 @@ Lint/DisjunctiveAssignmentInConstructor:
   VersionAdded: '0.62'
   VersionChanged: '0.88'
 
+Lint/DuplicateBranch:
+  Description: Checks that there are no repeated bodies within `if/unless`, `case-when` and `rescue` constructs.
+  Enabled: pending
+  VersionAdded: '1.3'
+
 Lint/DuplicateCaseCondition:
   Description: 'Do not repeat values in case conditionals.'
   Enabled: true
@@ -1440,7 +1480,7 @@ Lint/DuplicateCaseCondition:
 
 Lint/DuplicateElsifCondition:
   Description: 'Do not repeat conditions used in if `elsif`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
 
 Lint/DuplicateHashKey:
@@ -1454,14 +1494,19 @@ Lint/DuplicateMethods:
   Enabled: true
   VersionAdded: '0.29'
 
+Lint/DuplicateRegexpCharacterClassElement:
+  Description: 'Checks for duplicate elements in Regexp character classes.'
+  Enabled: pending
+  VersionAdded: '1.1'
+
 Lint/DuplicateRequire:
   Description: 'Check for duplicate `require`s and `require_relative`s.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Lint/DuplicateRescueException:
   Description: 'Checks that there are no repeated exceptions used in `rescue` expressions.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/EachWithObjectArgument:
@@ -1473,10 +1518,25 @@ Lint/ElseLayout:
   Description: 'Check for odd code arrangement in an else block.'
   Enabled: true
   VersionAdded: '0.17'
+  VersionChanged: '1.2'
+
+Lint/EmptyBlock:
+  Description: 'This cop checks for blocks without a body.'
+  Enabled: pending
+  VersionAdded: '1.1'
+  VersionChanged: '1.3'
+  AllowComments: true
+  AllowEmptyLambdas: true
+
+Lint/EmptyClass:
+  Description: 'Checks for classes and metaclasses without a body.'
+  Enabled: pending
+  VersionAdded: '1.3'
+  AllowComments: false
 
 Lint/EmptyConditionalBody:
   Description: 'This cop checks for the presence of `if`, `elsif` and `unless` branches without a body.'
-  Enabled: 'pending'
+  Enabled: true
   AllowComments: true
   VersionAdded: '0.89'
 
@@ -1493,7 +1553,7 @@ Lint/EmptyExpression:
 
 Lint/EmptyFile:
   Description: 'Enforces that Ruby source files are not empty.'
-  Enabled: pending
+  Enabled: true
   AllowComments: true
   VersionAdded: '0.90'
 
@@ -1531,7 +1591,7 @@ Lint/FlipFlop:
 Lint/FloatComparison:
   Description: 'Checks for the presence of precise comparison of floating point numbers.'
   StyleGuide: '#float-comparison'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/FloatOutOfRange:
@@ -1549,7 +1609,7 @@ Lint/FormatParameterMismatch:
 Lint/HashCompareByIdentity:
   Description: 'Prefer using `Hash#compare_by_identity` than using `object_id` for keys.'
   StyleGuide: '#identity-comparison'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.93'
 
@@ -1563,7 +1623,7 @@ Lint/HeredocMethodCallPosition:
 
 Lint/IdentityComparison:
   Description: 'Prefer `equal?` over `==` when comparing `object_id`.'
-  Enabled: pending
+  Enabled: true
   StyleGuide: '#identity-comparison'
   VersionAdded: '0.91'
 
@@ -1616,7 +1676,8 @@ Lint/Loop:
   StyleGuide: '#loop-with-break'
   Enabled: true
   VersionAdded: '0.9'
-  VersionChanged: '0.89'
+  VersionChanged: '1.3'
+  Safe: false
 
 Lint/MissingCopEnableDirective:
   Description: 'Checks for a `# rubocop:enable` after `# rubocop:disable`.'
@@ -1635,19 +1696,21 @@ Lint/MissingSuper:
   Description: >-
                   This cop checks for the presence of constructors and lifecycle callbacks
                   without calls to `super`'.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
+  VersionChanged: '1.4'
 
 Lint/MixedRegexpCaptureTypes:
   Description: 'Do not mix named captures and numbered captures in a Regexp literal.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Lint/MultipleComparison:
   Description: "Use `&&` operator to compare multiple values."
   Enabled: true
   VersionAdded: '0.47'
-  VersionChanged: '0.77'
+  VersionChanged: '1.1'
+  AllowMethodComparison: true
 
 Lint/NestedMethodDefinition:
   Description: 'Do not use nested method definitions.'
@@ -1667,6 +1730,11 @@ Lint/NextWithoutAccumulator:
   Enabled: true
   VersionAdded: '0.36'
 
+Lint/NoReturnInBeginEndBlocks:
+  Description: 'Do not `return` inside `begin..end` blocks in assignment contexts.'
+  Enabled: pending
+  VersionAdded: '1.2'
+
 Lint/NonDeterministicRequireOrder:
   Description: 'Always sort arrays returned by Dir.glob when requiring files.'
   Enabled: true
@@ -1682,8 +1750,12 @@ Lint/NumberConversion:
   Description: 'Checks unsafe usage of number conversion methods.'
   Enabled: false
   VersionAdded: '0.53'
-  VersionChanged: '0.70'
+  VersionChanged: '1.1'
   SafeAutoCorrect: false
+  IgnoredMethods: []
+  IgnoredClasses:
+    - Time
+    - DateTime
 
 Lint/OrderedMagicComments:
   Description: 'Checks the proper ordering of magic comments and whether a magic comment is not placed before a shebang.'
@@ -1692,7 +1764,7 @@ Lint/OrderedMagicComments:
 
 Lint/OutOfRangeRegexpRef:
   Description: 'Checks for out of range reference for Regexp because it always returns nil.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -1721,7 +1793,7 @@ Lint/PercentSymbolArray:
 Lint/RaiseException:
   Description: Checks for `raise` or `fail` statements which are raising `Exception` class.
   StyleGuide: '#raise-exception'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.81'
   VersionChanged: '0.86'
@@ -1755,7 +1827,7 @@ Lint/RedundantRequireStatement:
 
 Lint/RedundantSafeNavigation:
   Description: 'Checks for redundant safe navigation calls.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.93'
   AllowedMethods:
     - instance_of?
@@ -1808,7 +1880,7 @@ Lint/RescueException:
   StyleGuide: '#no-blind-rescues'
   Enabled: true
   VersionAdded: '0.9'
-  VersionChanged: '0.27.1'
+  VersionChanged: '0.27'
 
 Lint/RescueType:
   Description: 'Avoid rescuing from non constants that could result in a `TypeError`.'
@@ -1862,7 +1934,7 @@ Lint/ScriptPermission:
 
 Lint/SelfAssignment:
   Description: 'Checks for self-assignments.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/SendWithMixinArgument:
@@ -1893,7 +1965,7 @@ Lint/ShadowingOuterLocalVariable:
 
 Lint/StructNewOverride:
   Description: 'Disallow overriding the `Struct` built-in methods via `Struct.new`.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.81'
 
 Lint/SuppressedException:
@@ -1910,6 +1982,11 @@ Lint/Syntax:
   VersionAdded: '0.9'
 
 
+Lint/ToEnumArguments:
+  Description: 'This cop ensures that `to_enum`/`enum_for`, called for the current method, has correct arguments.'
+  Enabled: pending
+  VersionAdded: '1.1'
+
 Lint/ToJSON:
   Description: 'Ensure #to_json includes an optional argument.'
   Enabled: true
@@ -1917,12 +1994,12 @@ Lint/ToJSON:
 
 Lint/TopLevelReturnWithArgument:
   Description: 'This cop detects top level return statements with argument.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/TrailingCommaInAttributeDeclaration:
   Description: 'This cop checks for trailing commas in attribute declarations.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Lint/UnderscorePrefixedVariableName:
@@ -1931,11 +2008,34 @@ Lint/UnderscorePrefixedVariableName:
   VersionAdded: '0.21'
   AllowKeywordBlockArguments: false
 
+Lint/UnexpectedBlockArity:
+  Description: 'Looks for blocks that have fewer arguments that the calling method expects.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '1.5'
+  Methods:
+    chunk_while: 2
+    each_with_index: 2
+    each_with_object: 2
+    inject: 2
+    max: 2
+    min: 2
+    minmax: 2
+    reduce: 2
+    slice_when: 2
+    sort: 2
+
 Lint/UnifiedInteger:
   Description: 'Use Integer instead of Fixnum or Bignum.'
   Enabled: true
   VersionAdded: '0.43'
 
+Lint/UnmodifiedReduceAccumulator:
+  Description: Checks for `reduce` or `inject` blocks that do not update the accumulator each iteration.
+  Enabled: pending
+  VersionAdded: '1.1'
+  VersionChanged: '1.5'
+
 Lint/UnreachableCode:
   Description: 'Unreachable code.'
   Enabled: true
@@ -1943,7 +2043,7 @@ Lint/UnreachableCode:
 
 Lint/UnreachableLoop:
   Description: 'This cop checks for loops that will have at most one iteration.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/UnusedBlockArgument:
@@ -2002,7 +2102,7 @@ Lint/UselessElseWithoutRescue:
 
 Lint/UselessMethodDefinition:
   Description: 'Checks for useless method definitions.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
   Safe: false
   AllowComments: true
@@ -2010,13 +2110,14 @@ Lint/UselessMethodDefinition:
 Lint/UselessSetterCall:
   Description: 'Checks for useless setter call to a local variable.'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.13'
-  VersionChanged: '0.80'
+  VersionChanged: '1.2'
   Safe: false
 
 Lint/UselessTimes:
   Description: 'Checks for useless `Integer#times` calls.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
   Safe: false
 
@@ -2037,21 +2138,23 @@ Metrics/AbcSize:
     - https://en.wikipedia.org/wiki/ABC_Software_Metric
   Enabled: true
   VersionAdded: '0.27'
-  VersionChanged: '0.81'
+  VersionChanged: '1.5'
   # The ABC size is a calculated magnitude, so this number can be an Integer or
   # a Float.
   IgnoredMethods: []
+  CountRepeatedAttributes: true
   Max: 17
 
 Metrics/BlockLength:
   Description: 'Avoid long blocks with many lines.'
   Enabled: true
   VersionAdded: '0.44'
-  VersionChanged: '0.87'
+  VersionChanged: '1.5'
   CountComments: false  # count full line comments?
   Max: 25
   CountAsOne: []
-  ExcludedMethods:
+  ExcludedMethods: [] # deprecated, retained for backwards compatibility
+  IgnoredMethods:
     # By default, exclude the `#refine` method, as it tends to have larger
     # associated blocks.
     - refine
@@ -2092,11 +2195,12 @@ Metrics/MethodLength:
   StyleGuide: '#short-methods'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: '0.87'
+  VersionChanged: '1.5'
   CountComments: false  # count full line comments?
   Max: 10
   CountAsOne: []
-  ExcludedMethods: []
+  ExcludedMethods: [] # deprecated, retained for backwards compatibility
+  IgnoredMethods: []
 
 Metrics/ModuleLength:
   Description: 'Avoid modules longer than 100 lines of code.'
@@ -2112,8 +2216,10 @@ Metrics/ParameterLists:
   StyleGuide: '#too-many-params'
   Enabled: true
   VersionAdded: '0.25'
+  VersionChanged: '1.5'
   Max: 5
   CountKeywordArgs: true
+  MaxOptionalParameters: 3
 
 Metrics/PerceivedComplexity:
   Description: >-
@@ -2155,6 +2261,7 @@ Naming/BinaryOperatorParameterName:
   StyleGuide: '#other-arg'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.2'
 
 Naming/BlockParameterName:
   Description: >-
@@ -2261,6 +2368,7 @@ Naming/HeredocDelimiterCase:
   StyleGuide: '#heredoc-delimiters'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.2'
   EnforcedStyle: uppercase
   SupportedStyles:
     - lowercase
@@ -2279,7 +2387,7 @@ Naming/MemoizedInstanceVariableName:
     Memoized method name should match memo instance variable name.
   Enabled: true
   VersionAdded: '0.53'
-  VersionChanged: '0.58'
+  VersionChanged: '1.2'
   EnforcedStyleForLeadingUnderscores: disallowed
   SupportedStylesForLeadingUnderscores:
     - disallowed
@@ -2377,14 +2485,25 @@ Naming/VariableName:
     - camelCase
 
 Naming/VariableNumber:
-  Description: 'Use the configured style when numbering variables.'
+  Description: 'Use the configured style when numbering symbols, methods and variables.'
+  StyleGuide: '#snake-case-symbols-methods-vars-with-numbers'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.4'
   EnforcedStyle: normalcase
   SupportedStyles:
     - snake_case
     - normalcase
     - non_integer
+  CheckMethodNames: true
+  CheckSymbols: true
+  AllowedIdentifiers:
+    - capture3     # Open3.capture3
+    - iso8601      # Time#iso8601
+    - rfc1123_date # CGI.rfc1123_date
+    - rfc822       # Time#rfc822
+    - rfc2822      # Time#rfc2822
+    - rfc3339      # DateTime.rfc3339
 
 #################### Security ##############################
 
@@ -2415,9 +2534,10 @@ Security/MarshalLoad:
   VersionAdded: '0.47'
 
 Security/Open:
-  Description: 'The use of Kernel#open represents a serious security risk.'
+  Description: 'The use of `Kernel#open` and `URI.open` represent a serious security risk.'
   Enabled: true
   VersionAdded: '0.53'
+  VersionChanged: '1.0'
   Safe: false
 
 Security/YAMLLoad:
@@ -2444,7 +2564,7 @@ Style/AccessModifierDeclarations:
 
 Style/AccessorGrouping:
   Description: 'Checks for grouping of accessors in `class` and `module` bodies.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
   EnforcedStyle: grouped
   SupportedStyles:
@@ -2477,6 +2597,13 @@ Style/AndOr:
     - always
     - conditionals
 
+Style/ArgumentsForwarding:
+  Description: 'Use arguments forwarding.'
+  StyleGuide: '#arguments-forwarding'
+  Enabled: pending
+  AllowOnlyRestArgument: true
+  VersionAdded: '1.1'
+
 Style/ArrayCoercion:
   Description: >-
                   Use Array() instead of explicit Array check or [*var], when dealing
@@ -2533,7 +2660,7 @@ Style/BisectedAttrAccessor:
   Description: >-
                 Checks for places where `attr_reader` and `attr_writer`
                 for the same method can be combined into single `attr_accessor`.
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
 
 Style/BlockComments:
@@ -2672,7 +2799,7 @@ Style/CaseEquality:
 Style/CaseLikeIf:
   Description: 'This cop identifies places where `if-elsif` constructions can be replaced with `case-when`.'
   StyleGuide: '#case-vs-if-else'
-  Enabled: 'pending'
+  Enabled: true
   Safe: false
   VersionAdded: '0.88'
 
@@ -2725,7 +2852,7 @@ Style/ClassCheck:
 Style/ClassEqualityComparison:
   Description: 'Enforces the use of `Object#instance_of?` instead of class comparison for equality.'
   StyleGuide: '#instance-of-vs-class-comparison'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.93'
   IgnoredMethods:
     - ==
@@ -2755,6 +2882,13 @@ Style/ClassVars:
   Enabled: true
   VersionAdded: '0.13'
 
+Style/CollectionCompact:
+  Description: 'Use `{Array,Hash}#{compact,compact!}` instead of custom logic to reject nils.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '1.2'
+  VersionChanged: '1.3'
+
 # Align with the style guide.
 Style/CollectionMethods:
   Description: 'Preferred collection methods.'
@@ -2793,7 +2927,7 @@ Style/CombinableLoops:
   Description: >-
                   Checks for places where multiple consecutive loops over the same data
                   can be combined into a single loop.
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.90'
 
@@ -2818,17 +2952,18 @@ Style/CommandLiteral:
 Style/CommentAnnotation:
   Description: >-
                  Checks formatting of special comments
-                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
+                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE).
   StyleGuide: '#annotate-keywords'
   Enabled: true
   VersionAdded: '0.10'
-  VersionChanged: '0.31'
+  VersionChanged: '1.3'
   Keywords:
     - TODO
     - FIXME
     - OPTIMIZE
     - HACK
     - REVIEW
+    - NOTE
 
 Style/CommentedKeyword:
   Description: 'Do not place comments on the same line as certain keywords.'
@@ -2917,6 +3052,15 @@ Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
   VersionAdded: '0.82'
 
+Style/DocumentDynamicEvalDefinition:
+  Description: >-
+                When using `class_eval` (or other `eval`) with string interpolation,
+                add a comment block showing its appearance if interpolated.
+  StyleGuide: '#eval-comment-docs'
+  Enabled: pending
+  VersionAdded: '1.1'
+  VersionChanged: '1.3'
+
 Style/Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: true
@@ -2944,7 +3088,7 @@ Style/DoubleNegation:
   StyleGuide: '#no-bang-bang'
   Enabled: true
   VersionAdded: '0.19'
-  VersionChanged: '0.84'
+  VersionChanged: '1.2'
   EnforcedStyle: allowed_in_returns
   SafeAutoCorrect: false
   SupportedStyles:
@@ -3046,7 +3190,7 @@ Style/ExplicitBlockArgument:
                   Consider using explicit block argument to avoid writing block literal
                   that just passes its arguments to another block.
   StyleGuide: '#block-argument'
-  Enabled: pending
+  Enabled: true
   # May change the yielding arity.
   Safe: false
   VersionAdded: '0.89'
@@ -3054,7 +3198,7 @@ Style/ExplicitBlockArgument:
 Style/ExponentialNotation:
   Description: 'When using exponential notation, favor a mantissa between 1 (inclusive) and 10 (exclusive).'
   StyleGuide: '#exponential-notation'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.82'
   EnforcedStyle: scientific
   SupportedStyles:
@@ -3109,8 +3253,12 @@ Style/FormatStringToken:
     # Prefer simple looking "template" style tokens like `%{name}`, `%{age}`
     - template
     - unannotated
+  # `MaxUnannotatedPlaceholdersAllowed` defines the number of `unannotated`
+  # style token in a format string to be allowed when enforced style is not
+  # `unannotated`.
+  MaxUnannotatedPlaceholdersAllowed: 1
   VersionAdded: '0.49'
-  VersionChanged: '0.75'
+  VersionChanged: '1.0'
 
 Style/FrozenStringLiteralComment:
   Description: >-
@@ -3137,7 +3285,7 @@ Style/FrozenStringLiteralComment:
 Style/GlobalStdStream:
   Description: 'Enforces the use of `$stdout/$stderr/$stdin` instead of `STDOUT/STDERR/STDIN`.'
   StyleGuide: '#global-stdout'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
   SafeAutoCorrect: false
 
@@ -3165,7 +3313,7 @@ Style/HashAsLastArrayItem:
                  Checks for presence or absence of braces around hash literal as a last
                  array item depending on configuration.
   StyleGuide: '#hash-literal-as-last-array-item'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
   EnforcedStyle: braces
   SupportedStyles:
@@ -3175,7 +3323,7 @@ Style/HashAsLastArrayItem:
 Style/HashEachMethods:
   Description: 'Use Hash#each_key and Hash#each_value.'
   StyleGuide: '#hash-each'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.80'
   Safe: false
 
@@ -3183,7 +3331,7 @@ Style/HashLikeCase:
   Description: >-
                   Checks for places where `case-when` represents a simple 1:1
                   mapping and can be replaced with a hash lookup.
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
   # `MinBranchesCount` defines the number of branches `case` needs to have
   # to trigger this cop
@@ -3214,14 +3362,14 @@ Style/HashSyntax:
 
 Style/HashTransformKeys:
   Description: 'Prefer `transform_keys` over `each_with_object`, `map`, or `to_h`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.80'
   VersionChanged: '0.90'
   Safe: false
 
 Style/HashTransformValues:
   Description: 'Prefer `transform_values` over `each_with_object`, `map`, or `to_h`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.80'
   VersionChanged: '0.90'
   Safe: false
@@ -3239,6 +3387,7 @@ Style/IfInsideElse:
   Enabled: true
   AllowIfModifier: false
   VersionAdded: '0.36'
+  VersionChanged: '1.3'
 
 Style/IfUnlessModifier:
   Description: >-
@@ -3271,12 +3420,14 @@ Style/ImplicitRuntimeError:
   VersionAdded: '0.41'
 
 Style/InfiniteLoop:
-  Description: 'Use Kernel#loop for infinite loops.'
+  Description: >-
+                 Use Kernel#loop for infinite loops.
+                 This cop is unsafe in the body may raise a `StopIteration` exception.
+  Safe: false
   StyleGuide: '#infinite-loop'
   Enabled: true
   VersionAdded: '0.26'
   VersionChanged: '0.61'
-  SafeAutoCorrect: true
 
 Style/InlineComment:
   Description: 'Avoid trailing inline comments.'
@@ -3328,7 +3479,7 @@ Style/IpAddresses:
 Style/KeywordParametersOrder:
   Description: 'Enforces that optional keyword parameters are placed at the end of the parameters list.'
   StyleGuide: '#keyword-parameters-order'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Style/Lambda:
@@ -3530,6 +3681,7 @@ Style/MultipleComparison:
                  use Array#include? instead.
   Enabled: true
   VersionAdded: '0.49'
+  VersionChanged: '1.1'
 
 Style/MutableConstant:
   Description: 'Do not assign mutable objects to constants.'
@@ -3564,6 +3716,13 @@ Style/NegatedIf:
     - prefix
     - postfix
 
+Style/NegatedIfElseCondition:
+  Description: >-
+                This cop checks for uses of `if-else` and ternary operators with a negated condition
+                which can be simplified by inverting condition and swapping branches.
+  Enabled: pending
+  VersionAdded: '1.2'
+
 Style/NegatedUnless:
   Description: 'Favor if over unless for negative conditions.'
   StyleGuide: '#if-for-negatives'
@@ -3651,6 +3810,11 @@ Style/NilComparison:
     - predicate
     - comparison
 
+Style/NilLambda:
+  Description: 'Prefer `-> {}` to `-> { nil }`.'
+  Enabled: pending
+  VersionAdded: '1.3'
+
 Style/NonNilCheck:
   Description: 'Checks for redundant nil checks.'
   StyleGuide: '#no-non-nil-checks'
@@ -3753,7 +3917,7 @@ Style/OptionalArguments:
 Style/OptionalBooleanParameter:
   Description: 'Use keyword arguments when defining method with boolean argument.'
   StyleGuide: '#boolean-keyword-arguments'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
   AllowedMethods:
@@ -3800,7 +3964,7 @@ Style/PercentLiteralDelimiters:
     '%r': '{}'
     '%w': '[]'
     '%W': '[]'
-  VersionChanged: '0.48.1'
+  VersionChanged: '0.48'
 
 Style/PercentQLiterals:
   Description: 'Checks if uses of %Q/%q match the configured preference.'
@@ -3841,11 +4005,12 @@ Style/RaiseArgs:
   StyleGuide: '#exception-class-messages'
   Enabled: true
   VersionAdded: '0.14'
-  VersionChanged: '0.40'
+  VersionChanged: '1.2'
   EnforcedStyle: exploded
   SupportedStyles:
     - compact # raise Exception.new(msg)
     - exploded # raise Exception, msg
+  AllowedCompactTypes: []
 
 Style/RandomWithOffset:
   Description: >-
@@ -3855,9 +4020,20 @@ Style/RandomWithOffset:
   Enabled: true
   VersionAdded: '0.52'
 
+Style/RedundantArgument:
+  Description: 'Check for a redundant argument passed to certain methods.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '1.4'
+  Methods:
+    # Array#join
+    join: ''
+    # String#split
+    split: ' '
+
 Style/RedundantAssignment:
   Description: 'Checks for redundant assignment before returning.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
 
 Style/RedundantBegin:
@@ -3894,7 +4070,7 @@ Style/RedundantFetchBlock:
                   Use `fetch(key, value)` instead of `fetch(key) { value }`
                   when value has Numeric, Rational, Complex, Symbol or String type, `false`, `true`, `nil` or is a constant.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#hashfetch-with-argument-vs-hashfetch--block-code'
-  Enabled: 'pending'
+  Enabled: true
   Safe: false
   # If enabled, this cop will autocorrect usages of
   # `fetch` being called with block returning a constant.
@@ -3907,7 +4083,7 @@ Style/RedundantFileExtensionInRequire:
                   Checks for the presence of superfluous `.rb` extension in
                   the filename provided to `require` and `require_relative`.
   StyleGuide: '#no-explicit-rb-to-require'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
 
 Style/RedundantFreeze:
@@ -3934,12 +4110,12 @@ Style/RedundantPercentQ:
 
 Style/RedundantRegexpCharacterClass:
   Description: 'Checks for unnecessary single-element Regexp character classes.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Style/RedundantRegexpEscape:
   Description: 'Checks for redundant escapes in Regexps.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Style/RedundantReturn:
@@ -3960,7 +4136,7 @@ Style/RedundantSelf:
 
 Style/RedundantSelfAssignment:
   Description: 'Checks for places where redundant assignments are made for in place modification methods.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.90'
 
@@ -4088,7 +4264,7 @@ Style/SignalException:
 
 Style/SingleArgumentDig:
   Description: 'Avoid using single argument dig method.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
   Safe: false
 
@@ -4115,7 +4291,7 @@ Style/SingleLineMethods:
 
 Style/SlicingWithRange:
   Description: 'Checks array slicing is done with endless ranges when suitable.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.83'
   Safe: false
 
@@ -4123,8 +4299,9 @@ Style/SoleNestedConditional:
   Description: >-
                   Finds sole nested conditional nodes
                   which can be merged into outer conditional node.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
+  VersionChanged: '1.5'
   AllowModifier: false
 
 Style/SpecialGlobalVars:
@@ -4149,6 +4326,13 @@ Style/StabbyLambdaParentheses:
     - require_parentheses
     - require_no_parentheses
 
+Style/StaticClass:
+  Description: 'Prefer modules to classes with only class methods.'
+  StyleGuide: '#modules-vs-classes'
+  Enabled: false
+  Safe: false
+  VersionAdded: '1.3'
+
 Style/StderrPuts:
   Description: 'Use `warn` instead of `$stderr.puts`.'
   StyleGuide: '#warn'
@@ -4158,7 +4342,7 @@ Style/StderrPuts:
 Style/StringConcatenation:
   Description: 'Checks for places where string concatenation can be replaced with string interpolation.'
   StyleGuide: '#string-interpolation'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -4199,7 +4383,7 @@ Style/StringMethods:
   Description: 'Checks if configured preferred methods are used over non-preferred.'
   Enabled: false
   VersionAdded: '0.34'
-  VersionChanged: '0.34.2'
+  VersionChanged: '0.34'
   # Mapping from undesired method to desired_method
   # e.g. to use `to_sym` over `intern`:
   #
@@ -4221,6 +4405,13 @@ Style/StructInheritance:
   VersionAdded: '0.29'
   VersionChanged: '0.86'
 
+Style/SwapValues:
+  Description: 'This cop enforces the use of shorthand-style swapping of 2 variables.'
+  StyleGuide: '#values-swapping'
+  Enabled: pending
+  VersionAdded: '1.1'
+  SafeAutoCorrect: false
+
 Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: '#percent-i'
@@ -4243,7 +4434,7 @@ Style/SymbolProc:
   Enabled: true
   Safe: false
   VersionAdded: '0.26'
-  VersionChanged: '0.64'
+  VersionChanged: '1.5'
   # A list of method names to be ignored by the check.
   # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
   IgnoredMethods:

data/lib/chefstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Chefstyle
-  VERSION = "1.4.5"
-  RUBOCOP_VERSION = "0.93.1"
+  VERSION = "1.5.7"
+  RUBOCOP_VERSION = "1.5.2"
 end

data/lib/rubocop/cop/chef/ruby/gemspec_require_rubygems.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Rubygems does not need to be required in a Gemspec. It's already loaded out of the box in Ruby now.
         class GemspecRequireRubygems < Base
           extend RuboCop::Cop::AutoCorrector

data/lib/rubocop/cop/chef/ruby/require_net_https.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # net/https is deprecated and just includes net/http and openssl. We should include those directly instead.
         #
         # @example

data/lib/rubocop/cop/chef/ruby/ruby_27_keyword_argument_warnings.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
         #
         # @example

data/lib/rubocop/cop/chef/ruby/unless_defined_require.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Rubygems is VERY slow to require gems even if they've already been loaded. To work around this
         # wrap your require statement with an `if defined?()` check.
         #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.5.7
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-12 00:00:00.000000000 Z
+date: 2020-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.5.2
 description: 
 email:
 - oss@chef.io