chefstyle 1.4.3 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c8fc8e2962659e925a493a6f047c5bc497e4a02cc6a2b01f7e0291325030d42
-  data.tar.gz: c0c5b937798636ddf7d098d02d26b3cff23d11f26017e393cfbc33c89031c0e9
+  metadata.gz: bbf6452b0cab1ef46383080fe18fa78d21aa00066abc1df2bbc0705a6721d753
+  data.tar.gz: be21de8c4bc2f9681e8da6f23f0cff755e50b4a4300e84b03df4d2bbd92f829a
 SHA512:
-  metadata.gz: 0a5b1c1f423ed919f78bd2438328d42f99afd80eff4929207efd46a0ce588a73524e9ef8d14e1f790b7d0db375abeaf1aca8646395ce4d18345ebb846a8281b1
-  data.tar.gz: 6ae21c6628190f2a371f831a39dfef3277111e2dc3c3c88686151d856b1c96f1bd2c7fbada5b04200948eed557255b94c88851c17b151697e828c5551ddfad99
+  metadata.gz: e77886f2e3067aa56a3202803dba4ac0d5f18533f0dc2d65c0bc5431fe17be09e9a00126f157bfb12d81649c4001a4d4eb2420ef672f80af28c7ec719d6dd0e7
+  data.tar.gz: dbb8488366023a4d1986e5694cb7a09b38683b5392d8e6ca4a520cdd11b1bc73597a46b5af180aba81cd20e8e96dffcd0dd19bf545221feab9a54f9d121415e6

data/config/chefstyle.yml

@@ -665,26 +665,46 @@ Style/Dir:
 Style/ExpandPathArguments:
   Enabled: true
 
-ChefRuby/Ruby27KeywordArgumentWarnings:
+# more code you don't need
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
+# Eases readability
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+# unnecessary complexity
+Lint/RedundantWithObject:
+  Enabled: true
+
+# unnecessary complexity
+Lint/RedundantWithIndex:
+  Enabled: true
+
+# avoid requiring twice
+Lint/DuplicateRequire:
+  Enabled: true
+
+Chef/Ruby/Ruby27KeywordArgumentWarnings:
   Description: Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
   Enabled: true
   VersionAdded: '1.3.0'
 
-ChefRuby/UnlessDefinedRequire:
+Chef/Ruby/UnlessDefinedRequire:
   Description: Workaround RubyGems' slow requires by only running require if the constant isn't already defined
   Enabled: true
   VersionAdded: '1.3.0'
   Include:
     - 'lib/**/*'
 
-ChefRuby/GemspecRequireRubygems:
+Chef/Ruby/GemspecRequireRubygems:
   Description: Rubygems does not need to be required in a Gemspec
   Enabled: true
   VersionAdded: '1.3.0'
   Include:
     - '**/*.gemspec'
 
-ChefRuby/RequireNetHttps:
+Chef/Ruby/RequireNetHttps:
   Description: net/https is deprecated and just includes net/http and openssl. We should include those directly instead
   Enabled: true
   VersionAdded: '1.3.0'

data/config/disable_all.yml

@@ -229,6 +229,8 @@ Lint/DeprecatedOpenSSLConstant:
   Enabled: false
 Lint/DisjunctiveAssignmentInConstructor:
   Enabled: false
+Lint/DuplicateBranch:
+  Enabled: false
 Lint/DuplicateCaseCondition:
   Enabled: false
 Lint/DuplicateElsifCondition:
@@ -237,6 +239,8 @@ Lint/DuplicateHashKey:
   Enabled: false
 Lint/DuplicateMethods:
   Enabled: false
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: false
 Lint/DuplicateRequire:
   Enabled: false
 Lint/DuplicateRescueException:
@@ -245,6 +249,10 @@ Lint/EachWithObjectArgument:
   Enabled: false
 Lint/ElseLayout:
   Enabled: false
+Lint/EmptyBlock:
+  Enabled: false
+Lint/EmptyClass:
+  Enabled: false
 Lint/EmptyConditionalBody:
   Enabled: false
 Lint/EmptyEnsure:
@@ -269,6 +277,8 @@ Lint/FloatOutOfRange:
   Enabled: false
 Lint/FormatParameterMismatch:
   Enabled: false
+Lint/HashCompareByIdentity:
+  Enabled: false
 Lint/HeredocMethodCallPosition:
   Enabled: false
 Lint/IdentityComparison:
@@ -301,6 +311,8 @@ Lint/NestedPercentLiteral:
   Enabled: false
 Lint/NextWithoutAccumulator:
   Enabled: false
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: false
 Lint/NonDeterministicRequireOrder:
   Enabled: false
 Lint/NonLocalExitFromIterator:
@@ -327,6 +339,8 @@ Lint/RedundantCopEnableDirective:
   Enabled: false
 Lint/RedundantRequireStatement:
   Enabled: false
+Lint/RedundantSafeNavigation:
+  Enabled: false
 Lint/RedundantSplatExpansion:
   Enabled: false
 Lint/RedundantStringCoercion:
@@ -369,6 +383,8 @@ Lint/SuppressedException:
   Enabled: false
 Lint/Syntax:
   Enabled: false
+Lint/ToEnumArguments:
+  Enabled: false
 Lint/ToJSON:
   Enabled: false
 Lint/TopLevelReturnWithArgument:
@@ -379,6 +395,8 @@ Lint/UnderscorePrefixedVariableName:
   Enabled: false
 Lint/UnifiedInteger:
   Enabled: false
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: false
 Lint/UnreachableCode:
   Enabled: false
 Lint/UnreachableLoop:
@@ -463,6 +481,8 @@ Style/Alias:
   Enabled: false
 Style/AndOr:
   Enabled: false
+Style/ArgumentsForwarding:
+  Enabled: false
 Style/ArrayCoercion:
   Enabled: false
 Style/ArrayJoin:
@@ -493,12 +513,16 @@ Style/ClassAndModuleChildren:
   Enabled: false
 Style/ClassCheck:
   Enabled: false
+Style/ClassEqualityComparison:
+  Enabled: false
 Style/ClassMethods:
   Enabled: false
 Style/ClassMethodsDefinitions:
   Enabled: false
 Style/ClassVars:
   Enabled: false
+Style/CollectionCompact:
+  Enabled: false
 Style/CollectionMethods:
   Enabled: false
 Style/ColonMethodCall:
@@ -531,6 +555,8 @@ Style/DocumentationMethod:
   Enabled: false
 Style/Documentation:
   Enabled: false
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
 Style/DoubleCopDisableDirective:
   Enabled: false
 Style/DoubleNegation:
@@ -635,6 +661,8 @@ Style/RedundantSelfAssignment:
   Enabled: false
 Style/SoleNestedConditional:
   Enabled: false
+Style/StaticClass:
+  Enabled: false
 Style/MethodCalledOnDoEndBlock:
   Enabled: false
 Style/MethodDefParentheses:
@@ -671,6 +699,8 @@ Style/MutableConstant:
   Enabled: false
 Style/NegatedIf:
   Enabled: false
+Style/NegatedIfElseCondition:
+  Enabled: false
 Style/NegatedUnless:
   Enabled: false
 Style/NegatedWhile:
@@ -685,6 +715,8 @@ Style/Next:
   Enabled: false
 Style/NilComparison:
   Enabled: false
+Style/NilLambda:
+  Enabled: false
 Style/NonNilCheck:
   Enabled: false
 Style/Not:
@@ -801,6 +833,8 @@ Style/Strip:
   Enabled: false
 Style/StructInheritance:
   Enabled: false
+Style/SwapValues:
+  Enabled: false
 Style/SymbolArray:
   Enabled: false
 Style/SymbolLiteral:

data/config/upstream.yml

@@ -313,7 +313,7 @@ Layout/AssignmentIndentation:
 
 Layout/BeginEndAlignment:
   Description: 'Align ends corresponding to begins correctly.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
   # The value `start_of_line` means that `end` should be aligned the start of the line
   # where the `begin` keyword is.
@@ -496,7 +496,7 @@ Layout/EmptyLinesAroundArguments:
 Layout/EmptyLinesAroundAttributeAccessor:
   Description: "Keep blank lines around attribute accessors."
   StyleGuide: '#empty-lines-around-attribute-accessor'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.83'
   VersionChanged: '0.84'
   AllowAliasSyntax: true
@@ -891,7 +891,7 @@ Layout/LineLength:
   StyleGuide: '#max-line-length'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: '0.84'
+  VersionChanged: '1.3'
   AutoCorrect: false
   Max: 120
   # To make it possible to copy or click on URIs in the code, we allow lines
@@ -1145,7 +1145,7 @@ Layout/SpaceAroundKeyword:
 
 Layout/SpaceAroundMethodCallOperator:
   Description: 'Checks method call operators to not have spaces around them.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.82'
 
 Layout/SpaceAroundOperators:
@@ -1176,7 +1176,7 @@ Layout/SpaceBeforeBlockBraces:
   SupportedStylesForEmptyBraces:
     - space
     - no_space
-  VersionChanged: '0.52.1'
+  VersionChanged: '0.52'
 
 Layout/SpaceBeforeComma:
   Description: 'No spaces before commas.'
@@ -1334,8 +1334,8 @@ Layout/TrailingWhitespace:
   StyleGuide: '#no-trailing-whitespace'
   Enabled: true
   VersionAdded: '0.49'
-  VersionChanged: '0.83'
-  AllowInHeredoc: true
+  VersionChanged: '1.0'
+  AllowInHeredoc: false
 
 #################### Lint ##################################
 ### Warnings
@@ -1379,7 +1379,7 @@ Lint/BigDecimalNew:
 
 Lint/BinaryOperatorWithIdenticalOperands:
   Description: 'This cop checks for places where binary operator has identical operands.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -1398,8 +1398,13 @@ Lint/CircularArgumentReference:
 Lint/ConstantDefinitionInBlock:
   Description: 'Do not define constants within a block.'
   StyleGuide: '#no-constant-definition-in-block'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
+  VersionChanged: '1.3'
+  # `enums` for Typed Enums via T::Enum in Sorbet.
+  # https://sorbet.org/docs/tenum
+  AllowedMethods:
+    - enums
 
 Lint/ConstantResolution:
   Description: 'Check that constants are fully qualified with `::`.'
@@ -1415,6 +1420,22 @@ Lint/Debugger:
   Enabled: true
   VersionAdded: '0.14'
   VersionChanged: '0.49'
+  DebuggerReceivers:
+    - binding
+    - Kernel
+    - Pry
+  DebuggerMethods:
+    - debugger
+    - byebug
+    - remote_byebug
+    - pry
+    - remote_pry
+    - pry_remote
+    - console
+    - rescue
+    - save_and_open_page
+    - save_and_open_screenshot
+    - irb
 
 Lint/DeprecatedClassMethods:
   Description: 'Check for deprecated class method calls.'
@@ -1423,7 +1444,7 @@ Lint/DeprecatedClassMethods:
 
 Lint/DeprecatedOpenSSLConstant:
   Description: "Don't use algorithm constants for `OpenSSL::Cipher` and `OpenSSL::Digest`."
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.84'
 
 Lint/DisjunctiveAssignmentInConstructor:
@@ -1433,6 +1454,11 @@ Lint/DisjunctiveAssignmentInConstructor:
   VersionAdded: '0.62'
   VersionChanged: '0.88'
 
+Lint/DuplicateBranch:
+  Description: Checks that there are no repeated bodies within `if/unless`, `case-when` and `rescue` constructs.
+  Enabled: pending
+  VersionAdded: '1.3'
+
 Lint/DuplicateCaseCondition:
   Description: 'Do not repeat values in case conditionals.'
   Enabled: true
@@ -1440,7 +1466,7 @@ Lint/DuplicateCaseCondition:
 
 Lint/DuplicateElsifCondition:
   Description: 'Do not repeat conditions used in if `elsif`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
 
 Lint/DuplicateHashKey:
@@ -1454,14 +1480,19 @@ Lint/DuplicateMethods:
   Enabled: true
   VersionAdded: '0.29'
 
+Lint/DuplicateRegexpCharacterClassElement:
+  Description: 'Checks for duplicate elements in Regexp character classes.'
+  Enabled: pending
+  VersionAdded: '1.1'
+
 Lint/DuplicateRequire:
   Description: 'Check for duplicate `require`s and `require_relative`s.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Lint/DuplicateRescueException:
   Description: 'Checks that there are no repeated exceptions used in `rescue` expressions.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/EachWithObjectArgument:
@@ -1473,10 +1504,25 @@ Lint/ElseLayout:
   Description: 'Check for odd code arrangement in an else block.'
   Enabled: true
   VersionAdded: '0.17'
+  VersionChanged: '1.2'
+
+Lint/EmptyBlock:
+  Description: 'This cop checks for blocks without a body.'
+  Enabled: pending
+  VersionAdded: '1.1'
+  VersionChanged: '1.3'
+  AllowComments: true
+  AllowEmptyLambdas: true
+
+Lint/EmptyClass:
+  Description: 'Checks for classes and metaclasses without a body.'
+  Enabled: pending
+  VersionAdded: '1.3'
+  AllowComments: false
 
 Lint/EmptyConditionalBody:
   Description: 'This cop checks for the presence of `if`, `elsif` and `unless` branches without a body.'
-  Enabled: 'pending'
+  Enabled: true
   AllowComments: true
   VersionAdded: '0.89'
 
@@ -1493,7 +1539,7 @@ Lint/EmptyExpression:
 
 Lint/EmptyFile:
   Description: 'Enforces that Ruby source files are not empty.'
-  Enabled: pending
+  Enabled: true
   AllowComments: true
   VersionAdded: '0.90'
 
@@ -1531,7 +1577,7 @@ Lint/FlipFlop:
 Lint/FloatComparison:
   Description: 'Checks for the presence of precise comparison of floating point numbers.'
   StyleGuide: '#float-comparison'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/FloatOutOfRange:
@@ -1546,6 +1592,13 @@ Lint/FormatParameterMismatch:
   Enabled: true
   VersionAdded: '0.33'
 
+Lint/HashCompareByIdentity:
+  Description: 'Prefer using `Hash#compare_by_identity` than using `object_id` for keys.'
+  StyleGuide: '#identity-comparison'
+  Enabled: true
+  Safe: false
+  VersionAdded: '0.93'
+
 Lint/HeredocMethodCallPosition:
   Description: >-
                  Checks for the ordering of a method call where
@@ -1556,7 +1609,7 @@ Lint/HeredocMethodCallPosition:
 
 Lint/IdentityComparison:
   Description: 'Prefer `equal?` over `==` when comparing `object_id`.'
-  Enabled: pending
+  Enabled: true
   StyleGuide: '#identity-comparison'
   VersionAdded: '0.91'
 
@@ -1609,7 +1662,8 @@ Lint/Loop:
   StyleGuide: '#loop-with-break'
   Enabled: true
   VersionAdded: '0.9'
-  VersionChanged: '0.89'
+  VersionChanged: '1.3'
+  Safe: false
 
 Lint/MissingCopEnableDirective:
   Description: 'Checks for a `# rubocop:enable` after `# rubocop:disable`.'
@@ -1628,19 +1682,20 @@ Lint/MissingSuper:
   Description: >-
                   This cop checks for the presence of constructors and lifecycle callbacks
                   without calls to `super`'.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/MixedRegexpCaptureTypes:
   Description: 'Do not mix named captures and numbered captures in a Regexp literal.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Lint/MultipleComparison:
   Description: "Use `&&` operator to compare multiple values."
   Enabled: true
   VersionAdded: '0.47'
-  VersionChanged: '0.77'
+  VersionChanged: '1.1'
+  AllowMethodComparison: true
 
 Lint/NestedMethodDefinition:
   Description: 'Do not use nested method definitions.'
@@ -1660,6 +1715,11 @@ Lint/NextWithoutAccumulator:
   Enabled: true
   VersionAdded: '0.36'
 
+Lint/NoReturnInBeginEndBlocks:
+  Description: 'Do not `return` inside `begin..end` blocks in assignment contexts.'
+  Enabled: pending
+  VersionAdded: '1.2'
+
 Lint/NonDeterministicRequireOrder:
   Description: 'Always sort arrays returned by Dir.glob when requiring files.'
   Enabled: true
@@ -1675,8 +1735,12 @@ Lint/NumberConversion:
   Description: 'Checks unsafe usage of number conversion methods.'
   Enabled: false
   VersionAdded: '0.53'
-  VersionChanged: '0.70'
+  VersionChanged: '1.1'
   SafeAutoCorrect: false
+  IgnoredMethods: []
+  IgnoredClasses:
+    - Time
+    - DateTime
 
 Lint/OrderedMagicComments:
   Description: 'Checks the proper ordering of magic comments and whether a magic comment is not placed before a shebang.'
@@ -1685,7 +1749,7 @@ Lint/OrderedMagicComments:
 
 Lint/OutOfRangeRegexpRef:
   Description: 'Checks for out of range reference for Regexp because it always returns nil.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -1714,7 +1778,7 @@ Lint/PercentSymbolArray:
 Lint/RaiseException:
   Description: Checks for `raise` or `fail` statements which are raising `Exception` class.
   StyleGuide: '#raise-exception'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.81'
   VersionChanged: '0.86'
@@ -1746,6 +1810,19 @@ Lint/RedundantRequireStatement:
   Enabled: true
   VersionAdded: '0.76'
 
+Lint/RedundantSafeNavigation:
+  Description: 'Checks for redundant safe navigation calls.'
+  Enabled: true
+  VersionAdded: '0.93'
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+  Safe: false
+
 Lint/RedundantSplatExpansion:
   Description: 'Checks for splat unnecessarily being called on literals.'
   Enabled: true
@@ -1788,7 +1865,7 @@ Lint/RescueException:
   StyleGuide: '#no-blind-rescues'
   Enabled: true
   VersionAdded: '0.9'
-  VersionChanged: '0.27.1'
+  VersionChanged: '0.27'
 
 Lint/RescueType:
   Description: 'Avoid rescuing from non constants that could result in a `TypeError`.'
@@ -1842,7 +1919,7 @@ Lint/ScriptPermission:
 
 Lint/SelfAssignment:
   Description: 'Checks for self-assignments.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/SendWithMixinArgument:
@@ -1873,7 +1950,7 @@ Lint/ShadowingOuterLocalVariable:
 
 Lint/StructNewOverride:
   Description: 'Disallow overriding the `Struct` built-in methods via `Struct.new`.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.81'
 
 Lint/SuppressedException:
@@ -1890,6 +1967,11 @@ Lint/Syntax:
   VersionAdded: '0.9'
 
 
+Lint/ToEnumArguments:
+  Description: 'This cop ensures that `to_enum`/`enum_for`, called for the current method, has correct arguments.'
+  Enabled: pending
+  VersionAdded: '1.1'
+
 Lint/ToJSON:
   Description: 'Ensure #to_json includes an optional argument.'
   Enabled: true
@@ -1897,12 +1979,12 @@ Lint/ToJSON:
 
 Lint/TopLevelReturnWithArgument:
   Description: 'This cop detects top level return statements with argument.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/TrailingCommaInAttributeDeclaration:
   Description: 'This cop checks for trailing commas in attribute declarations.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Lint/UnderscorePrefixedVariableName:
@@ -1916,6 +1998,11 @@ Lint/UnifiedInteger:
   Enabled: true
   VersionAdded: '0.43'
 
+Lint/UnmodifiedReduceAccumulator:
+  Description: Checks for `reduce` or `inject` blocks that do not update the accumulator each iteration.
+  Enabled: pending
+  VersionAdded: '1.1'
+
 Lint/UnreachableCode:
   Description: 'Unreachable code.'
   Enabled: true
@@ -1923,7 +2010,7 @@ Lint/UnreachableCode:
 
 Lint/UnreachableLoop:
   Description: 'This cop checks for loops that will have at most one iteration.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
 
 Lint/UnusedBlockArgument:
@@ -1982,7 +2069,7 @@ Lint/UselessElseWithoutRescue:
 
 Lint/UselessMethodDefinition:
   Description: 'Checks for useless method definitions.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
   Safe: false
   AllowComments: true
@@ -1990,13 +2077,14 @@ Lint/UselessMethodDefinition:
 Lint/UselessSetterCall:
   Description: 'Checks for useless setter call to a local variable.'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.13'
-  VersionChanged: '0.80'
+  VersionChanged: '1.2'
   Safe: false
 
 Lint/UselessTimes:
   Description: 'Checks for useless `Integer#times` calls.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.91'
   Safe: false
 
@@ -2135,6 +2223,7 @@ Naming/BinaryOperatorParameterName:
   StyleGuide: '#other-arg'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.2'
 
 Naming/BlockParameterName:
   Description: >-
@@ -2241,6 +2330,7 @@ Naming/HeredocDelimiterCase:
   StyleGuide: '#heredoc-delimiters'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.2'
   EnforcedStyle: uppercase
   SupportedStyles:
     - lowercase
@@ -2259,7 +2349,7 @@ Naming/MemoizedInstanceVariableName:
     Memoized method name should match memo instance variable name.
   Enabled: true
   VersionAdded: '0.53'
-  VersionChanged: '0.58'
+  VersionChanged: '1.2'
   EnforcedStyleForLeadingUnderscores: disallowed
   SupportedStylesForLeadingUnderscores:
     - disallowed
@@ -2357,14 +2447,19 @@ Naming/VariableName:
     - camelCase
 
 Naming/VariableNumber:
-  Description: 'Use the configured style when numbering variables.'
+  Description: 'Use the configured style when numbering symbols, methods and variables.'
+  StyleGuide: '#snake-case-symbols-methods-vars-with-numbers'
   Enabled: true
   VersionAdded: '0.50'
+  VersionChanged: '1.3'
   EnforcedStyle: normalcase
   SupportedStyles:
     - snake_case
     - normalcase
     - non_integer
+  CheckMethodNames: true
+  CheckSymbols: true
+  AllowedIdentifiers: []
 
 #################### Security ##############################
 
@@ -2395,9 +2490,10 @@ Security/MarshalLoad:
   VersionAdded: '0.47'
 
 Security/Open:
-  Description: 'The use of Kernel#open represents a serious security risk.'
+  Description: 'The use of `Kernel#open` and `URI.open` represent a serious security risk.'
   Enabled: true
   VersionAdded: '0.53'
+  VersionChanged: '1.0'
   Safe: false
 
 Security/YAMLLoad:
@@ -2424,7 +2520,7 @@ Style/AccessModifierDeclarations:
 
 Style/AccessorGrouping:
   Description: 'Checks for grouping of accessors in `class` and `module` bodies.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
   EnforcedStyle: grouped
   SupportedStyles:
@@ -2457,6 +2553,13 @@ Style/AndOr:
     - always
     - conditionals
 
+Style/ArgumentsForwarding:
+  Description: 'Use arguments forwarding.'
+  StyleGuide: '#arguments-forwarding'
+  Enabled: pending
+  AllowOnlyRestArgument: true
+  VersionAdded: '1.1'
+
 Style/ArrayCoercion:
   Description: >-
                   Use Array() instead of explicit Array check or [*var], when dealing
@@ -2513,7 +2616,7 @@ Style/BisectedAttrAccessor:
   Description: >-
                 Checks for places where `attr_reader` and `attr_writer`
                 for the same method can be combined into single `attr_accessor`.
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
 
 Style/BlockComments:
@@ -2652,7 +2755,7 @@ Style/CaseEquality:
 Style/CaseLikeIf:
   Description: 'This cop identifies places where `if-elsif` constructions can be replaced with `case-when`.'
   StyleGuide: '#case-vs-if-else'
-  Enabled: 'pending'
+  Enabled: true
   Safe: false
   VersionAdded: '0.88'
 
@@ -2702,6 +2805,16 @@ Style/ClassCheck:
     - is_a?
     - kind_of?
 
+Style/ClassEqualityComparison:
+  Description: 'Enforces the use of `Object#instance_of?` instead of class comparison for equality.'
+  StyleGuide: '#instance-of-vs-class-comparison'
+  Enabled: true
+  VersionAdded: '0.93'
+  IgnoredMethods:
+    - ==
+    - equal?
+    - eql?
+
 Style/ClassMethods:
   Description: 'Use self when defining module/class methods.'
   StyleGuide: '#def-self-class-methods'
@@ -2725,6 +2838,13 @@ Style/ClassVars:
   Enabled: true
   VersionAdded: '0.13'
 
+Style/CollectionCompact:
+  Description: 'Use `{Array,Hash}#{compact,compact!}` instead of custom logic to reject nils.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '1.2'
+  VersionChanged: '1.3'
+
 # Align with the style guide.
 Style/CollectionMethods:
   Description: 'Preferred collection methods.'
@@ -2763,7 +2883,7 @@ Style/CombinableLoops:
   Description: >-
                   Checks for places where multiple consecutive loops over the same data
                   can be combined into a single loop.
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.90'
 
@@ -2788,17 +2908,18 @@ Style/CommandLiteral:
 Style/CommentAnnotation:
   Description: >-
                  Checks formatting of special comments
-                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
+                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE).
   StyleGuide: '#annotate-keywords'
   Enabled: true
   VersionAdded: '0.10'
-  VersionChanged: '0.31'
+  VersionChanged: '1.3'
   Keywords:
     - TODO
     - FIXME
     - OPTIMIZE
     - HACK
     - REVIEW
+    - NOTE
 
 Style/CommentedKeyword:
   Description: 'Do not place comments on the same line as certain keywords.'
@@ -2887,6 +3008,15 @@ Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
   VersionAdded: '0.82'
 
+Style/DocumentDynamicEvalDefinition:
+  Description: >-
+                When using `class_eval` (or other `eval`) with string interpolation,
+                add a comment block showing its appearance if interpolated.
+  StyleGuide: '#eval-comment-docs'
+  Enabled: pending
+  VersionAdded: '1.1'
+  VersionChanged: '1.3'
+
 Style/Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: true
@@ -2914,7 +3044,7 @@ Style/DoubleNegation:
   StyleGuide: '#no-bang-bang'
   Enabled: true
   VersionAdded: '0.19'
-  VersionChanged: '0.84'
+  VersionChanged: '1.2'
   EnforcedStyle: allowed_in_returns
   SafeAutoCorrect: false
   SupportedStyles:
@@ -3016,7 +3146,7 @@ Style/ExplicitBlockArgument:
                   Consider using explicit block argument to avoid writing block literal
                   that just passes its arguments to another block.
   StyleGuide: '#block-argument'
-  Enabled: pending
+  Enabled: true
   # May change the yielding arity.
   Safe: false
   VersionAdded: '0.89'
@@ -3024,7 +3154,7 @@ Style/ExplicitBlockArgument:
 Style/ExponentialNotation:
   Description: 'When using exponential notation, favor a mantissa between 1 (inclusive) and 10 (exclusive).'
   StyleGuide: '#exponential-notation'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.82'
   EnforcedStyle: scientific
   SupportedStyles:
@@ -3079,8 +3209,12 @@ Style/FormatStringToken:
     # Prefer simple looking "template" style tokens like `%{name}`, `%{age}`
     - template
     - unannotated
+  # `MaxUnannotatedPlaceholdersAllowed` defines the number of `unannotated`
+  # style token in a format string to be allowed when enforced style is not
+  # `unannotated`.
+  MaxUnannotatedPlaceholdersAllowed: 1
   VersionAdded: '0.49'
-  VersionChanged: '0.75'
+  VersionChanged: '1.0'
 
 Style/FrozenStringLiteralComment:
   Description: >-
@@ -3107,7 +3241,7 @@ Style/FrozenStringLiteralComment:
 Style/GlobalStdStream:
   Description: 'Enforces the use of `$stdout/$stderr/$stdin` instead of `STDOUT/STDERR/STDIN`.'
   StyleGuide: '#global-stdout'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
   SafeAutoCorrect: false
 
@@ -3135,7 +3269,7 @@ Style/HashAsLastArrayItem:
                  Checks for presence or absence of braces around hash literal as a last
                  array item depending on configuration.
   StyleGuide: '#hash-literal-as-last-array-item'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
   EnforcedStyle: braces
   SupportedStyles:
@@ -3145,7 +3279,7 @@ Style/HashAsLastArrayItem:
 Style/HashEachMethods:
   Description: 'Use Hash#each_key and Hash#each_value.'
   StyleGuide: '#hash-each'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.80'
   Safe: false
 
@@ -3153,7 +3287,7 @@ Style/HashLikeCase:
   Description: >-
                   Checks for places where `case-when` represents a simple 1:1
                   mapping and can be replaced with a hash lookup.
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
   # `MinBranchesCount` defines the number of branches `case` needs to have
   # to trigger this cop
@@ -3184,14 +3318,14 @@ Style/HashSyntax:
 
 Style/HashTransformKeys:
   Description: 'Prefer `transform_keys` over `each_with_object`, `map`, or `to_h`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.80'
   VersionChanged: '0.90'
   Safe: false
 
 Style/HashTransformValues:
   Description: 'Prefer `transform_values` over `each_with_object`, `map`, or `to_h`.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.80'
   VersionChanged: '0.90'
   Safe: false
@@ -3209,6 +3343,7 @@ Style/IfInsideElse:
   Enabled: true
   AllowIfModifier: false
   VersionAdded: '0.36'
+  VersionChanged: '1.3'
 
 Style/IfUnlessModifier:
   Description: >-
@@ -3241,12 +3376,14 @@ Style/ImplicitRuntimeError:
   VersionAdded: '0.41'
 
 Style/InfiniteLoop:
-  Description: 'Use Kernel#loop for infinite loops.'
+  Description: >-
+                 Use Kernel#loop for infinite loops.
+                 This cop is unsafe in the body may raise a `StopIteration` exception.
+  Safe: false
   StyleGuide: '#infinite-loop'
   Enabled: true
   VersionAdded: '0.26'
   VersionChanged: '0.61'
-  SafeAutoCorrect: true
 
 Style/InlineComment:
   Description: 'Avoid trailing inline comments.'
@@ -3298,7 +3435,7 @@ Style/IpAddresses:
 Style/KeywordParametersOrder:
   Description: 'Enforces that optional keyword parameters are placed at the end of the parameters list.'
   StyleGuide: '#keyword-parameters-order'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.90'
 
 Style/Lambda:
@@ -3500,6 +3637,7 @@ Style/MultipleComparison:
                  use Array#include? instead.
   Enabled: true
   VersionAdded: '0.49'
+  VersionChanged: '1.1'
 
 Style/MutableConstant:
   Description: 'Do not assign mutable objects to constants.'
@@ -3534,6 +3672,13 @@ Style/NegatedIf:
     - prefix
     - postfix
 
+Style/NegatedIfElseCondition:
+  Description: >-
+                This cop checks for uses of `if-else` and ternary operators with a negated condition
+                which can be simplified by inverting condition and swapping branches.
+  Enabled: pending
+  VersionAdded: '1.2'
+
 Style/NegatedUnless:
   Description: 'Favor if over unless for negative conditions.'
   StyleGuide: '#if-for-negatives'
@@ -3621,6 +3766,11 @@ Style/NilComparison:
     - predicate
     - comparison
 
+Style/NilLambda:
+  Description: 'Prefer `-> {}` to `-> { nil }`.'
+  Enabled: pending
+  VersionAdded: '1.3'
+
 Style/NonNilCheck:
   Description: 'Checks for redundant nil checks.'
   StyleGuide: '#no-non-nil-checks'
@@ -3723,7 +3873,7 @@ Style/OptionalArguments:
 Style/OptionalBooleanParameter:
   Description: 'Use keyword arguments when defining method with boolean argument.'
   StyleGuide: '#boolean-keyword-arguments'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
   AllowedMethods:
@@ -3770,7 +3920,7 @@ Style/PercentLiteralDelimiters:
     '%r': '{}'
     '%w': '[]'
     '%W': '[]'
-  VersionChanged: '0.48.1'
+  VersionChanged: '0.48'
 
 Style/PercentQLiterals:
   Description: 'Checks if uses of %Q/%q match the configured preference.'
@@ -3811,11 +3961,12 @@ Style/RaiseArgs:
   StyleGuide: '#exception-class-messages'
   Enabled: true
   VersionAdded: '0.14'
-  VersionChanged: '0.40'
+  VersionChanged: '1.2'
   EnforcedStyle: exploded
   SupportedStyles:
     - compact # raise Exception.new(msg)
     - exploded # raise Exception, msg
+  AllowedCompactTypes: []
 
 Style/RandomWithOffset:
   Description: >-
@@ -3827,7 +3978,7 @@ Style/RandomWithOffset:
 
 Style/RedundantAssignment:
   Description: 'Checks for redundant assignment before returning.'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.87'
 
 Style/RedundantBegin:
@@ -3864,7 +4015,7 @@ Style/RedundantFetchBlock:
                   Use `fetch(key, value)` instead of `fetch(key) { value }`
                   when value has Numeric, Rational, Complex, Symbol or String type, `false`, `true`, `nil` or is a constant.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#hashfetch-with-argument-vs-hashfetch--block-code'
-  Enabled: 'pending'
+  Enabled: true
   Safe: false
   # If enabled, this cop will autocorrect usages of
   # `fetch` being called with block returning a constant.
@@ -3877,7 +4028,7 @@ Style/RedundantFileExtensionInRequire:
                   Checks for the presence of superfluous `.rb` extension in
                   the filename provided to `require` and `require_relative`.
   StyleGuide: '#no-explicit-rb-to-require'
-  Enabled: 'pending'
+  Enabled: true
   VersionAdded: '0.88'
 
 Style/RedundantFreeze:
@@ -3904,12 +4055,12 @@ Style/RedundantPercentQ:
 
 Style/RedundantRegexpCharacterClass:
   Description: 'Checks for unnecessary single-element Regexp character classes.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Style/RedundantRegexpEscape:
   Description: 'Checks for redundant escapes in Regexps.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.85'
 
 Style/RedundantReturn:
@@ -3930,7 +4081,7 @@ Style/RedundantSelf:
 
 Style/RedundantSelfAssignment:
   Description: 'Checks for places where redundant assignments are made for in place modification methods.'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.90'
 
@@ -4058,7 +4209,7 @@ Style/SignalException:
 
 Style/SingleArgumentDig:
   Description: 'Avoid using single argument dig method.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
   Safe: false
 
@@ -4085,7 +4236,7 @@ Style/SingleLineMethods:
 
 Style/SlicingWithRange:
   Description: 'Checks array slicing is done with endless ranges when suitable.'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.83'
   Safe: false
 
@@ -4093,7 +4244,7 @@ Style/SoleNestedConditional:
   Description: >-
                   Finds sole nested conditional nodes
                   which can be merged into outer conditional node.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '0.89'
   AllowModifier: false
 
@@ -4119,6 +4270,13 @@ Style/StabbyLambdaParentheses:
     - require_parentheses
     - require_no_parentheses
 
+Style/StaticClass:
+  Description: 'Prefer modules to classes with only class methods.'
+  StyleGuide: '#modules-vs-classes'
+  Enabled: false
+  Safe: false
+  VersionAdded: '1.3'
+
 Style/StderrPuts:
   Description: 'Use `warn` instead of `$stderr.puts`.'
   StyleGuide: '#warn'
@@ -4128,7 +4286,7 @@ Style/StderrPuts:
 Style/StringConcatenation:
   Description: 'Checks for places where string concatenation can be replaced with string interpolation.'
   StyleGuide: '#string-interpolation'
-  Enabled: pending
+  Enabled: true
   Safe: false
   VersionAdded: '0.89'
 
@@ -4169,7 +4327,7 @@ Style/StringMethods:
   Description: 'Checks if configured preferred methods are used over non-preferred.'
   Enabled: false
   VersionAdded: '0.34'
-  VersionChanged: '0.34.2'
+  VersionChanged: '0.34'
   # Mapping from undesired method to desired_method
   # e.g. to use `to_sym` over `intern`:
   #
@@ -4191,6 +4349,13 @@ Style/StructInheritance:
   VersionAdded: '0.29'
   VersionChanged: '0.86'
 
+Style/SwapValues:
+  Description: 'This cop enforces the use of shorthand-style swapping of 2 variables.'
+  StyleGuide: '#values-swapping'
+  Enabled: pending
+  VersionAdded: '1.1'
+  SafeAutoCorrect: false
+
 Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: '#percent-i'

data/lib/chefstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Chefstyle
-  VERSION = "1.4.3"
-  RUBOCOP_VERSION = "0.92.0"
+  VERSION = "1.5.2"
+  RUBOCOP_VERSION = "1.3.1"
 end

data/lib/rubocop/cop/chef/ruby/gemspec_require_rubygems.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Rubygems does not need to be required in a Gemspec. It's already loaded out of the box in Ruby now.
         class GemspecRequireRubygems < Base
           extend RuboCop::Cop::AutoCorrector

data/lib/rubocop/cop/chef/ruby/require_net_https.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # net/https is deprecated and just includes net/http and openssl. We should include those directly instead.
         #
         # @example

data/lib/rubocop/cop/chef/ruby/ruby_27_keyword_argument_warnings.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
         #
         # @example

data/lib/rubocop/cop/chef/ruby/unless_defined_require.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefRuby
+      module Ruby
         # Rubygems is VERY slow to require gems even if they've already been loaded. To work around this
         # wrap your require statement with an `if defined?()` check.
         #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.5.2
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-29 00:00:00.000000000 Z
+date: 2020-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: 1.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: 1.3.1
 description: 
 email:
 - oss@chef.io