chefstyle 1.4.0 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 066e8ac793f64512443174f9e09c8919b03bbe9559a16a041e8d986f95de3278
-  data.tar.gz: 72e56fd44dac3fd344959b2920611ead077ff18b2517b6b2fedd545375041190
+  metadata.gz: 8f8855b643a12f7609e03fe4fef4bec806eacfc1b609ad3f927fa2750be52c5d
+  data.tar.gz: 1d2af7269153108d67ce8d02503a6b32226a182907436b80cc57b6583c612386
 SHA512:
-  metadata.gz: ef9db45e45112086e38e265ceb5c745010c18265b4b12e0096b38112ad91dca303cf9f469e2f8fdb60d73659ead6eb2a59591a440554a59a6b4f9b4494d1c9f8
-  data.tar.gz: ebd7a40b197ec5f97f19b5ed4f57af9e74254fb05641cda8734719c43e9b89aaf2a3fab937d118be2f1808a43f0c77f2151548808be9d0dba45e94e7bc8cacf9
+  metadata.gz: ab7bc2f6b2f3e22d060be4e6e30eacfc171e7fb5bee4f1ac11ca5a4b6cf190745fe79c20b0b4d65c9bee5d0d4b61431a3bedbd7a08a8db4c2a18d6f634af4a25
+  data.tar.gz: 7b34f9396e79b75b88a726c6b14fb25138197eb087a4bba9dbf31c93eb33a314a8b76ecc1c963c3182981cf99e64595dd766d37a66a9c992de7159775cd5d473

data/config/upstream.yml

@@ -2463,7 +2463,7 @@ Style/ArrayCoercion:
                   with a variable you want to treat as an Array, but you're not certain it's an array.
   StyleGuide: '#array-coercion'
   Safe: false
-  Enabled: 'pending'
+  Enabled: false
   VersionAdded: '0.88'
 
 Style/ArrayJoin:
@@ -2863,7 +2863,8 @@ Style/DateTime:
   StyleGuide: '#date--time'
   Enabled: false
   VersionAdded: '0.51'
-  VersionChanged: '0.59'
+  VersionChanged: '0.92'
+  SafeAutoCorrect: false
   AllowCoercion: false
 
 Style/DefWithParentheses:
@@ -3283,11 +3284,16 @@ Style/IpAddresses:
   Description: "Don't include literal IP addresses in code."
   Enabled: false
   VersionAdded: '0.58'
-  VersionChanged: '0.77'
+  VersionChanged: '0.91'
   # Allow addresses to be permitted
   AllowedAddresses:
     - "::"
     # :: is a valid IPv6 address, but could potentially be legitimately in code
+  Exclude:
+    - '**/*.gemfile'
+    - '**/Gemfile'
+    - '**/gems.rb'
+    - '**/*.gemspec'
 
 Style/KeywordParametersOrder:
   Description: 'Enforces that optional keyword parameters are placed at the end of the parameters list.'
@@ -3720,6 +3726,8 @@ Style/OptionalBooleanParameter:
   Enabled: pending
   Safe: false
   VersionAdded: '0.89'
+  AllowedMethods:
+    - respond_to_missing?
 
 Style/OrAssignment:
   Description: 'Recommend usage of double pipe equals (||=) where applicable.'
@@ -3988,6 +3996,8 @@ Style/SafeNavigation:
                   This cop transforms usages of a method call safeguarded by
                   a check for the existence of the object to
                   safe navigation (`&.`).
+                  Auto-correction is unsafe as it assumes the object will
+                  be `nil` or truthy, but never `false`.
   Enabled: true
   VersionAdded: '0.43'
   VersionChanged: '0.77'
@@ -4000,6 +4010,7 @@ Style/SafeNavigation:
     - presence
     - try
     - try!
+  SafeAutoCorrect: false
 
 Style/Sample:
   Description: >-

data/lib/chefstyle.rb

@@ -5,9 +5,6 @@ require_relative "chefstyle/version"
 gem "rubocop", "= #{Chefstyle::RUBOCOP_VERSION}"
 require "rubocop"
 
-# @TODO remove this monkeypatch after we upgrade from 0.91.0
-require_relative "rubocop/monkey_patches/rescue_ensure_alignment"
-
 module RuboCop
   class ConfigLoader
     RUBOCOP_HOME.gsub!(

data/lib/chefstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Chefstyle
-  VERSION = "1.4.0"
-  RUBOCOP_VERSION = "0.91.0"
+  VERSION = "1.4.2"
+  RUBOCOP_VERSION = "0.92.0"
 end

data/lib/rubocop/cop/chef/ruby/unless_defined_require.rb

@@ -34,7 +34,7 @@ module RuboCop
             "base64" => "Base64",
             "benchmark" => "Benchmark",
             "cgi" => "CGI",
-            "chef-utils" => "ChefUtils",
+            "chef-utils" => "ChefUtils::CANARY",
             "chef-utils/dist" => "ChefUtils::Dist",
             "csv" => "CSV",
             "digest" => "Digest",
@@ -99,6 +99,7 @@ module RuboCop
             "yard" => "YARD",
             "zip" => "Zip",
             "zlib" => "Zlib",
+            "pastel" => "Pastel",
           }.freeze
 
           def_node_matcher :require?, <<-PATTERN

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.2
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-17 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.91.0
+        version: 0.92.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.91.0
+        version: 0.92.0
 description: 
 email:
 - oss@chef.io
@@ -46,7 +46,6 @@ files:
 - lib/rubocop/cop/chef/ruby/require_net_https.rb
 - lib/rubocop/cop/chef/ruby/ruby_27_keyword_argument_warnings.rb
 - lib/rubocop/cop/chef/ruby/unless_defined_require.rb
-- lib/rubocop/monkey_patches/rescue_ensure_alignment.rb
 homepage: https://github.com/chef/chefstyle
 licenses:
 - Apache-2.0

data/lib/rubocop/monkey_patches/rescue_ensure_alignment.rb

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-module RuboCop
-  module Cop
-    module Layout
-      class RescueEnsureAlignment < Base
-        # @TODO remove this monkeypatch after we upgrade from RuboCop 0.91.0
-        def begin_end_alignment_style
-          # FIXME: Workaround for pending status for `Layout/BeginEndAlignment` cop
-          #        When RuboCop 1.0 is released, please replace it with the following condition.
-          #
-          # config.for_cop('Layout/BeginEndAlignment')['Enabled'] &&
-          #   config.for_cop('Layout/BeginEndAlignment')['EnforcedStyleAlignWith']
-          if config.for_all_cops["NewCops"] == "enable" ||
-              config.for_cop("Layout/BeginEndAlignment")["Enabled"] &&
-                  config.for_cop("Layout/BeginEndAlignment")["Enabled"] != "pending"
-            config.for_cop("Layout/BeginEndAlignment")["EnforcedStyleAlignWith"]
-          end
-        end
-      end
-    end
-  end
-end