chefstyle 0.6.0 → 0.8.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. checksums.yaml +5 -5
  2. data/config/chefstyle.yml +45 -9
  3. data/config/disable_all.yml +120 -22
  4. data/config/disabled.yml +18 -9
  5. data/config/enabled.yml +1154 -918
  6. data/config/upstream.yml +257 -121
  7. data/lib/chefstyle/version.rb +2 -2
  8. metadata +5 -5
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA1:
3
- metadata.gz: 5f7556a1ab53ae453e093ba28ade212f4c99d782
4
- data.tar.gz: 8657b898606ccdeeacbc62d11ba3b6d33241361a
2
+ SHA256:
3
+ metadata.gz: 1f1328268c0f7916775b3004e5f3d708016455ebfae86fb7b8eae512425b505c
4
+ data.tar.gz: 46214fd26c9461e2f133825e4a7244ecc673f391526b03f9983edf3e2d4ae13c
5
5
  SHA512:
6
- metadata.gz: 6f1f5426ef2fa82b9510742ca0254b9f4b8f97de19bc1f9dbb02b851b38c4c0a5b92be47f98b0025d57002ec291405de70f9d99d3cf0e06bd72a7b6a84e881e1
7
- data.tar.gz: e95b36d4bd4df7760c28bfe74c4e60824f764ca52bfbfdcc216d06340481abd799dddb29921cd705d3739c5dba17d0e9b4c973d44a7fdc59c45144a6d6a6d99f
6
+ metadata.gz: 222af4973c132b1efca844a12bb462dc7900339863a661f3a75f0bfb18280f73574145bbeb0dbd360e14dc1188dd72267f54af8b2671d01ba8a1b896f2b77525
7
+ data.tar.gz: 81d07b51a8599d1f917622103c3959136cd4eb15fff33cd9b529c332c5f7757b81d5bf7ac5461f71655f7465152a0439ca4f2b79a644ca2a9b631a291879a7b6
data/config/chefstyle.yml CHANGED
@@ -14,6 +14,12 @@ Bundler/DuplicatedGem:
14
14
 
15
15
  Lint/AmbiguousOperator:
16
16
  Enabled: true
17
+ Lint/AmbiguousBlockAssociation:
18
+ Enabled: true
19
+ Lint/AmbiguousRegexpLiteral:
20
+ Enabled: true
21
+ Lint/AssignmentInCondition:
22
+ Enabled: true
17
23
  Lint/BlockAlignment:
18
24
  Enabled: true
19
25
  Lint/CircularArgumentReference:
@@ -24,6 +30,8 @@ Lint/Debugger:
24
30
  Enabled: true
25
31
  Lint/DefEndAlignment:
26
32
  Enabled: true
33
+ Lint/DeprecatedClassMethods:
34
+ Enabled: true
27
35
  Lint/DuplicateCaseCondition:
28
36
  Enabled: true
29
37
  Lint/DuplicateMethods:
@@ -40,6 +48,8 @@ Lint/EmptyExpression:
40
48
  Enabled: true
41
49
  Lint/EmptyInterpolation:
42
50
  Enabled: true
51
+ Lint/EmptyWhen:
52
+ Enabled: true
43
53
  Lint/EndAlignment:
44
54
  Enabled: true
45
55
  Lint/EndInMethod:
@@ -54,6 +64,8 @@ Lint/ImplicitStringConcatenation:
54
64
  Enabled: true
55
65
  Lint/InheritException:
56
66
  Enabled: true
67
+ Lint/IneffectiveAccessModifier:
68
+ Enabled: true
57
69
  Lint/InvalidCharacterLiteral:
58
70
  Enabled: true
59
71
  Lint/LiteralInCondition:
@@ -70,14 +82,22 @@ Lint/NextWithoutAccumulator:
70
82
  Enabled: true
71
83
  Lint/NonLocalExitFromIterator:
72
84
  Enabled: true
85
+ Lint/ParenthesesAsGroupedExpression:
86
+ Enabled: true
87
+ Lint/PercentStringArray:
88
+ Enabled: true
73
89
  Lint/PercentSymbolArray:
74
- Eanbled: true
90
+ Enabled: true
75
91
  Lint/RandOne:
76
92
  Enabled: true
77
93
  Lint/RequireParentheses:
78
94
  Enabled: true
79
95
  Lint/SafeNavigationChain:
80
96
  Enabled: true
97
+ Lint/ShadowedException:
98
+ Enabled: true
99
+ Lint/ShadowingOuterLocalVariable:
100
+ Enabled: true
81
101
  Lint/StringConversionInInterpolation:
82
102
  Enabled: true
83
103
  Lint/UnderscorePrefixedVariableName:
@@ -86,10 +106,14 @@ Lint/UnifiedInteger:
86
106
  Enabled: true
87
107
  Lint/UnneededDisable:
88
108
  Enabled: true
109
+ Lint/UnneededSplatExpansion:
110
+ Enabled: true
89
111
  Lint/UnreachableCode:
90
112
  Enabled: true
91
113
  Lint/UselessAccessModifier:
92
114
  Enabled: true
115
+ Lint/UselessAssignment:
116
+ Enabled: true
93
117
  Lint/UselessComparison:
94
118
  Enabled: true
95
119
  Lint/UselessElseWithoutRescue:
@@ -116,10 +140,6 @@ Lint/HandleExceptions:
116
140
  Lint/RescueException:
117
141
  Enabled: false
118
142
 
119
- # we have lots of not-insecure uses of eval
120
- Security/Eval:
121
- Enabled: false
122
-
123
143
  # disabling this will make it easier to stage chefstyle rollouts
124
144
  Lint/UnneededDisable:
125
145
  Enabled: false
@@ -206,6 +226,13 @@ Rails/TimeZone:
206
226
  Rails/Validation:
207
227
  Enabled: true
208
228
 
229
+ #
230
+ # Security
231
+ #
232
+
233
+ Security/Eval:
234
+ Enabled: true
235
+
209
236
  #
210
237
  # Metrics
211
238
  #
@@ -246,7 +273,7 @@ Style/AndOr:
246
273
  Enabled: true
247
274
  Style/ArrayJoin:
248
275
  Enabled: true
249
- Style/AsciiIdentifiers:
276
+ Naming/AsciiIdentifiers:
250
277
  Enabled: true
251
278
  Style/Attr:
252
279
  Enabled: true
@@ -262,7 +289,7 @@ Style/ColonMethodCall:
262
289
  Enabled: true
263
290
  Style/CommandLiteral:
264
291
  Enabled: true
265
- Style/ConstantName:
292
+ Naming/ConstantName:
266
293
  Enabled: true
267
294
  Style/DefWithParentheses:
268
295
  Enabled: true
@@ -282,6 +309,7 @@ Style/EndBlock:
282
309
  Enabled: true
283
310
  Layout/EndOfLine:
284
311
  Enabled: true
312
+ EnforcedStyle: lf
285
313
  Style/EvenOdd:
286
314
  Enabled: true
287
315
  Layout/ExtraSpacing:
@@ -455,7 +483,7 @@ Style/UnneededCapitalW:
455
483
  Enabled: true
456
484
  #Style/UnneededPercentQ: # would like to enable this one but its buggy as of 0.35.1
457
485
  # Enabled: true
458
- Style/VariableName:
486
+ Naming/VariableName:
459
487
  Enabled: true
460
488
  Style/VariableInterpolation:
461
489
  Enabled: true
@@ -556,7 +584,7 @@ Layout/MultilineArrayBraceLayout:
556
584
  Enabled: false
557
585
 
558
586
  # This rule isn't smart enough to figure out accessors vs. things that set stuff on the system (e.g. set_member method in group providers)
559
- Style/AccessorMethodName:
587
+ Naming/AccessorMethodName:
560
588
  Enabled: false
561
589
 
562
590
  # Perl backrefs are just fine and the alternative is a lot of typing.
@@ -566,3 +594,11 @@ Style/PerlBackrefs:
566
594
  # This has an annoying auto-fix which fails to `require "english"` and then fails silently
567
595
  Style/SpecialGlobalVars:
568
596
  Enabled: false
597
+
598
+ # This cop is horrible and I hate the code it produces (even though I tend to like GuardClauses in lots of cases)
599
+ Style/GuardClause:
600
+ Enabled: false
601
+
602
+ # Let authors order gems however makes sense
603
+ Bundler/OrderedGems:
604
+ Enabled: false
data/config/disable_all.yml CHANGED
@@ -1,8 +1,16 @@
1
1
  ---
2
2
  Bundler/DuplicatedGem:
3
3
  Enabled: false
4
+ Bundler/InsecureProtocolSource:
5
+ Enabled: false
4
6
  Bundler/OrderedGems:
5
7
  Enabled: false
8
+ Gemspec/DuplicatedAssignment:
9
+ Enabled: false
10
+ Gemspec/OrderedDependencies:
11
+ Enabled: false
12
+ Gemspec/RequiredRubyVersion:
13
+ Enabled: false
6
14
  Layout/AccessModifierIndentation:
7
15
  Enabled: false
8
16
  Layout/AlignArray:
@@ -15,6 +23,8 @@ Layout/BlockEndNewline:
15
23
  Enabled: false
16
24
  Layout/CaseIndentation:
17
25
  Enabled: false
26
+ Layout/ClassStructure:
27
+ Enabled: false
18
28
  Layout/ClosingParenthesisIndentation:
19
29
  Enabled: false
20
30
  Layout/CommentIndentation:
@@ -29,6 +39,8 @@ Layout/EmptyLineBetweenDefs:
29
39
  Enabled: false
30
40
  Layout/EmptyLinesAroundAccessModifier:
31
41
  Enabled: false
42
+ Layout/EmptyLinesAroundArguments:
43
+ Enabled: false
32
44
  Layout/EmptyLinesAroundBeginBody:
33
45
  Enabled: false
34
46
  Layout/EmptyLinesAroundBlockBody:
@@ -123,9 +135,9 @@ Layout/SpaceInLambdaLiteral:
123
135
  Enabled: false
124
136
  Layout/SpaceInsideArrayPercentLiteral:
125
137
  Enabled: false
126
- Layout/SpaceInsideBlockBraces:
138
+ Layout/SpaceInsideArrayLiteralBrackets:
127
139
  Enabled: false
128
- Layout/SpaceInsideBrackets:
140
+ Layout/SpaceInsideBlockBraces:
129
141
  Enabled: false
130
142
  Layout/SpaceInsideHashLiteralBraces:
131
143
  Enabled: false
@@ -135,6 +147,8 @@ Layout/SpaceInsidePercentLiteralDelimiters:
135
147
  Enabled: false
136
148
  Layout/SpaceInsideRangeLiteral:
137
149
  Enabled: false
150
+ Layout/SpaceInsideReferenceBrackets:
151
+ Enabled: false
138
152
  Layout/SpaceInsideStringInterpolation:
139
153
  Enabled: false
140
154
  Layout/Tab:
@@ -153,6 +167,8 @@ Lint/AssignmentInCondition:
153
167
  Enabled: false
154
168
  Lint/BlockAlignment:
155
169
  Enabled: false
170
+ Lint/BooleanSymbol:
171
+ Enabled: false
156
172
  Lint/CircularArgumentReference:
157
173
  Enabled: false
158
174
  Lint/ConditionPosition:
@@ -199,18 +215,22 @@ Lint/InheritException:
199
215
  Enabled: false
200
216
  Lint/IneffectiveAccessModifier:
201
217
  Enabled: false
202
- Lint/InvalidCharacterLiteral:
218
+ Lint/InterpolationCheck:
203
219
  Enabled: false
204
- Lint/LiteralInCondition:
220
+ Lint/LiteralAsCondition:
205
221
  Enabled: false
206
222
  Lint/LiteralInInterpolation:
207
223
  Enabled: false
208
224
  Lint/Loop:
209
225
  Enabled: false
226
+ Lint/MissingCopEnableDirective:
227
+ Enabled: false
210
228
  Lint/MultipleCompare:
211
229
  Enabled: false
212
230
  Lint/NestedMethodDefinition:
213
231
  Enabled: false
232
+ Lint/NestedPercentLiteral:
233
+ Enabled: false
214
234
  Lint/NextWithoutAccumulator:
215
235
  Enabled: false
216
236
  Lint/NonLocalExitFromIterator:
@@ -223,28 +243,42 @@ Lint/PercentSymbolArray:
223
243
  Enabled: false
224
244
  Lint/RandOne:
225
245
  Enabled: false
246
+ Lint/RedundantWithIndex:
247
+ Enabled: false
248
+ Lint/RedundantWithObject:
249
+ Enabled: false
250
+ Lint/RegexpAsCondition:
251
+ Enabled: false
226
252
  Lint/RequireParentheses:
227
253
  Enabled: false
228
254
  Lint/RescueException:
229
255
  Enabled: false
230
256
  Lint/RescueType:
231
257
  Enabled: false
258
+ Lint/ReturnInVoidContext:
259
+ Enabled: false
232
260
  Lint/SafeNavigationChain:
233
261
  Enabled: false
234
262
  Lint/ScriptPermission:
235
263
  Enabled: false
264
+ Lint/ShadowedArgument:
265
+ Enabled: false
236
266
  Lint/ShadowedException:
237
267
  Enabled: false
238
268
  Lint/ShadowingOuterLocalVariable:
239
269
  Enabled: false
240
270
  Lint/StringConversionInInterpolation:
241
271
  Enabled: false
272
+ Lint/Syntax:
273
+ Enabled: false
242
274
  Lint/UnderscorePrefixedVariableName:
243
275
  Enabled: false
244
276
  Lint/UnifiedInteger:
245
277
  Enabled: false
246
278
  Lint/UnneededDisable:
247
279
  Enabled: false
280
+ Lint/UnneededRequireStatement:
281
+ Enabled: false
248
282
  Lint/UnneededSplatExpansion:
249
283
  Enabled: false
250
284
  Lint/UnreachableCode:
@@ -253,6 +287,10 @@ Lint/UnusedBlockArgument:
253
287
  Enabled: false
254
288
  Lint/UnusedMethodArgument:
255
289
  Enabled: false
290
+ Lint/UriEscapeUnescape:
291
+ Enabled: false
292
+ Lint/UriRegexp:
293
+ Enabled: false
256
294
  Lint/UselessAccessModifier:
257
295
  Enabled: false
258
296
  Lint/UselessAssignment:
@@ -285,6 +323,30 @@ Metrics/ParameterLists:
285
323
  Enabled: false
286
324
  Metrics/PerceivedComplexity:
287
325
  Enabled: false
326
+ Naming/AccessorMethodName:
327
+ Enabled: false
328
+ Naming/AsciiIdentifiers:
329
+ Enabled: false
330
+ Naming/ClassAndModuleCamelCase:
331
+ Enabled: false
332
+ Naming/ConstantName:
333
+ Enabled: false
334
+ Naming/FileName:
335
+ Enabled: false
336
+ Naming/HeredocDelimiterCase:
337
+ Enabled: false
338
+ Naming/HeredocDelimiterNaming:
339
+ Enabled: false
340
+ Naming/MethodName:
341
+ Enabled: false
342
+ Naming/BinaryOperatorParameterName:
343
+ Enabled: false
344
+ Naming/PredicateName:
345
+ Enabled: false
346
+ Naming/VariableName:
347
+ Enabled: false
348
+ Naming/VariableNumber:
349
+ Enabled: false
288
350
  Performance/Caller:
289
351
  Enabled: false
290
352
  Performance/CaseWhenSplat:
@@ -333,7 +395,9 @@ Performance/StringReplacement:
333
395
  Enabled: false
334
396
  Performance/TimesMap:
335
397
  Enabled: false
336
- Style/AccessorMethodName:
398
+ Performance/UnfreezeString:
399
+ Enabled: false
400
+ Performance/UriDefaultParser:
337
401
  Enabled: false
338
402
  Style/Alias:
339
403
  Enabled: false
@@ -343,8 +407,6 @@ Style/ArrayJoin:
343
407
  Enabled: false
344
408
  Style/AsciiComments:
345
409
  Enabled: false
346
- Style/AsciiIdentifiers:
347
- Enabled: false
348
410
  Style/Attr:
349
411
  Enabled: false
350
412
  Style/AutoResourceCleanup:
@@ -363,8 +425,6 @@ Style/CaseEquality:
363
425
  Enabled: false
364
426
  Style/CharacterLiteral:
365
427
  Enabled: false
366
- Style/ClassAndModuleCamelCase:
367
- Enabled: false
368
428
  Style/ClassAndModuleChildren:
369
429
  Enabled: false
370
430
  Style/ClassCheck:
@@ -377,19 +437,23 @@ Style/CollectionMethods:
377
437
  Enabled: false
378
438
  Style/ColonMethodCall:
379
439
  Enabled: false
440
+ Style/ColonMethodDefinition:
441
+ Enabled: false
380
442
  Style/CommandLiteral:
381
443
  Enabled: false
382
444
  Style/CommentAnnotation:
383
445
  Enabled: false
384
- Style/ConditionalAssignment:
446
+ Style/CommentedKeyword:
385
447
  Enabled: false
386
- Style/ConstantName:
448
+ Style/ConditionalAssignment:
387
449
  Enabled: false
388
450
  Style/Copyright:
389
451
  Enabled: false
452
+ Style/DateTime:
453
+ Enabled: false
390
454
  Style/DefWithParentheses:
391
455
  Enabled: false
392
- Style/PreferredHashMethods:
456
+ Style/Dir:
393
457
  Enabled: false
394
458
  Style/DocumentationMethod:
395
459
  Enabled: false
@@ -401,10 +465,14 @@ Style/EachForSimpleLoop:
401
465
  Enabled: false
402
466
  Style/EachWithObject:
403
467
  Enabled: false
468
+ Style/EmptyBlockParameter:
469
+ Enabled: false
404
470
  Style/EmptyCaseCondition:
405
471
  Enabled: false
406
472
  Style/EmptyElse:
407
473
  Enabled: false
474
+ Style/EmptyLambdaParameter:
475
+ Enabled: false
408
476
  Style/EmptyLiteral:
409
477
  Enabled: false
410
478
  Style/EmptyMethod:
@@ -413,9 +481,9 @@ Style/Encoding:
413
481
  Enabled: false
414
482
  Style/EndBlock:
415
483
  Enabled: false
416
- Style/EvenOdd:
484
+ Style/EvalWithLocation:
417
485
  Enabled: false
418
- Style/FileName:
486
+ Style/EvenOdd:
419
487
  Enabled: false
420
488
  Style/FlipFlop:
421
489
  Enabled: false
@@ -465,14 +533,16 @@ Style/MethodCalledOnDoEndBlock:
465
533
  Enabled: false
466
534
  Style/MethodDefParentheses:
467
535
  Enabled: false
468
- Style/MethodName:
469
- Enabled: false
470
536
  Style/MethodMissing:
471
537
  Enabled: false
538
+ Style/MinMax:
539
+ Enabled: false
472
540
  Style/MissingElse:
473
541
  Enabled: false
474
542
  Style/MixinGrouping:
475
543
  Enabled: false
544
+ Style/MixinUsage:
545
+ Enabled: false
476
546
  Style/ModuleFunction:
477
547
  Enabled: false
478
548
  Style/MultilineBlockChain:
@@ -515,7 +585,7 @@ Style/NumericPredicate:
515
585
  Enabled: false
516
586
  Style/OneLineConditional:
517
587
  Enabled: false
518
- Style/OpMethod:
588
+ Style/OrAssignment:
519
589
  Enabled: false
520
590
  Style/OptionHash:
521
591
  Enabled: false
@@ -531,12 +601,14 @@ Style/PercentQLiterals:
531
601
  Enabled: false
532
602
  Style/PerlBackrefs:
533
603
  Enabled: false
534
- Style/PredicateName:
604
+ Style/PreferredHashMethods:
535
605
  Enabled: false
536
606
  Style/Proc:
537
607
  Enabled: false
538
608
  Style/RaiseArgs:
539
609
  Enabled: false
610
+ Style/RandomWithOffset:
611
+ Enabled: false
540
612
  Style/RedundantBegin:
541
613
  Enabled: false
542
614
  Style/RedundantException:
@@ -549,10 +621,16 @@ Style/RedundantReturn:
549
621
  Enabled: false
550
622
  Style/RedundantSelf:
551
623
  Enabled: false
624
+ Style/RedundantConditional:
625
+ Enabled: false
552
626
  Style/RegexpLiteral:
553
627
  Enabled: false
554
628
  Style/RescueModifier:
555
629
  Enabled: false
630
+ Style/RescueStandardError:
631
+ Enabled: false
632
+ Style/ReturnNil:
633
+ Enabled: false
556
634
  Style/SafeNavigation:
557
635
  Enabled: false
558
636
  Style/SelfAssignment:
@@ -571,6 +649,10 @@ Style/SpecialGlobalVars:
571
649
  Enabled: false
572
650
  Style/StabbyLambdaParentheses:
573
651
  Enabled: false
652
+ Style/StderrPuts:
653
+ Enabled: false
654
+ Style/StringHashKeys:
655
+ Enabled: false
574
656
  Style/StringLiterals:
575
657
  Enabled: false
576
658
  Style/StringLiteralsInInterpolation:
@@ -587,10 +669,14 @@ Style/SymbolProc:
587
669
  Enabled: false
588
670
  Style/TernaryParentheses:
589
671
  Enabled: false
672
+ Style/TrailingBodyOnMethodDefinition:
673
+ Enabled: false
590
674
  Style/TrailingCommaInArguments:
591
675
  Enabled: false
592
676
  Style/TrailingCommaInLiteral:
593
677
  Enabled: false
678
+ Style/TrailingMethodEndStatement:
679
+ Enabled: false
594
680
  Style/TrailingUnderscoreVariable:
595
681
  Enabled: false
596
682
  Style/TrivialAccessors:
@@ -605,10 +691,6 @@ Style/UnneededPercentQ:
605
691
  Enabled: false
606
692
  Style/VariableInterpolation:
607
693
  Enabled: false
608
- Style/VariableName:
609
- Enabled: false
610
- Style/VariableNumber:
611
- Enabled: false
612
694
  Style/WhenThen:
613
695
  Enabled: false
614
696
  Style/WhileUntilDo:
@@ -631,6 +713,8 @@ Rails/ApplicationRecord:
631
713
  Enabled: false
632
714
  Rails/Blank:
633
715
  Enabled: false
716
+ Rails/CreateTableWithTimestamps:
717
+ Enabled: false
634
718
  Rails/Date:
635
719
  Enabled: false
636
720
  Rails/DynamicFindBy:
@@ -641,6 +725,8 @@ Rails/DelegateAllowBlank:
641
725
  Enabled: false
642
726
  Rails/EnumUniqueness:
643
727
  Enabled: false
728
+ Rails/EnvironmentComparison:
729
+ Enabled: false
644
730
  Rails/Exit:
645
731
  Enabled: false
646
732
  Rails/FilePath:
@@ -651,8 +737,14 @@ Rails/FindEach:
651
737
  Enabled: false
652
738
  Rails/HasAndBelongsToMany:
653
739
  Enabled: false
740
+ Rails/HasManyOrHasOneDependent:
741
+ Enabled: false
654
742
  Rails/HttpPositionalArguments:
655
743
  Enabled: false
744
+ Rails/InverseOf:
745
+ Enabled: false
746
+ Rails/LexicallyScopedActionFilter:
747
+ Enabled: false
656
748
  Rails/NotNullColumn:
657
749
  Enabled: false
658
750
  Rails/OutputSafety:
@@ -661,10 +753,14 @@ Rails/Output:
661
753
  Enabled: false
662
754
  Rails/PluralizationGrammar:
663
755
  Enabled: false
756
+ Rails/Presence:
757
+ Enabled: false
664
758
  Rails/Present:
665
759
  Enabled: false
666
760
  Rails/ReadWriteAttribute:
667
761
  Enabled: false
762
+ Rails/RedundantReceiverInWithOptions:
763
+ Enabled: false
668
764
  Rails/RequestReferer:
669
765
  Enabled: false
670
766
  Rails/ReversibleMigration:
@@ -683,6 +779,8 @@ Rails/TimeZone:
683
779
  Enabled: false
684
780
  Rails/UniqBeforePluck:
685
781
  Enabled: false
782
+ Rails/UnknownEnv:
783
+ Enabled: false
686
784
  Rails/Validation:
687
785
  Enabled: false
688
786
  Security/Eval: