chefstyle 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e36119557a7ee68b26c0579b016eb49d8b45efb1
-  data.tar.gz: cbd0eb104b18c33a736a0d04578a66b5356b7956
+  metadata.gz: 59f6eeec9124e1a5b410c337a2f397960cbecb40
+  data.tar.gz: 7700043724c67630b39c5610ccac56e0bd6d7953
 SHA512:
-  metadata.gz: 253b7750ba82166bc75cd13b86092ec1e786580c9be52b3ddd623f64436e8bf565dde7a3e7a32ea03f82b19f44dd93f3357e0bab179f2acb0f52b47f4beac9e5
-  data.tar.gz: 97f068a3685777d12e82911652337adcea73a2eaa63da79434fbb384667f65bb703d9a36f392774d9faed10abd488dc0ee6946d906fc8a8e441ca31ba61ad70d
+  metadata.gz: b2770939d4ebc8e963867abcd588c3796b2096288cccf1b81d4136bf8bcffd8613537392415632b8d2f552ce7abf1f77aaa02a9344fffe72f6156d903229ebf7
+  data.tar.gz: 8d85d02ec98ab91bdcadd783c3a603542a8fc2c17f909f762865eb5430b7f7775362c1b5ea211dd38751c323397e6dfa04223257f1fbf37b0c4014588a3c503c

data/config/chefstyle.yml

@@ -1,4 +1,3 @@
-
 #
 # Lint
 #
@@ -81,18 +80,32 @@ Lint/RescueException:
 # Performance
 #
 
+Performance/CaseCmp:
+  Enabled: true
 Performance/CaseWhenSplat:
   Enabled: true
+Performance/Detect:
+  Enabled: true
 Performance/FixedSize:
   Enabled: true
 Performance/FlatMap:
   Enabled: true
+Performance/RangeInclude:
+  Enabled: true
+Performance/RedundantBlockCall:
+  Enabled: true
+Performance/RedundantMatch:
+  Enabled: true
+Performance/RedundantMerge:
+  Enabled: true
 Performance/ReverseEach:
   Enabled: true
 Performance/Sample:
   Enabled: true
 Performance/Size:
   Enabled: true
+Performance/StringReplacement:
+  Enabled: true
 
 #
 # Rails
@@ -102,8 +115,6 @@ Rails/ActionFilter:
   Enabled: true
 Rails/Date:
   Enabled: true
-Rails/DefaultScope:
-  Enabled: true
 Rails/Delegate:
   Enabled: true
 Rails/FindBy:
@@ -157,6 +168,8 @@ Metrics/PerceivedComplexity:
 
 Style/AlignHash:
   Enabled: true
+Style/AndOr:
+  Enabled: true
 Style/ArrayJoin:
   Enabled: true
 Style/AsciiIdentifiers:
@@ -265,7 +278,7 @@ Style/SpaceBeforeBlockBraces:
   Enabled: true
 Style/SpaceBeforeFirstArg:
   Enabled: true
-Style/SpaceBeforeModifierKeyword:
+Style/SpaceAroundKeyword:
   Enabled: true
 Style/SpaceInsideBlockBraces:
   Enabled: true
@@ -285,8 +298,10 @@ Style/Tab:
   Enabled: true
 Style/TrailingBlankLines:
   Enabled: true
+Style/TrailingCommaInArguments:
+  Enabled: true
 # rubocop's default gets this completely backwards
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
 Style/TrailingUnderscoreVariable:
@@ -314,7 +329,7 @@ Style/Documentation:
   Enabled: false
 
 # this makes whitespace formatting of DSL code impossible
-Style/SingleSpaceBeforeFirstArg:
+Style/SpaceBeforeFirstArg:
   Enabled: false
 
 # whitespace in expressions is useful to enhance readability

data/config/disable_all.yml

@@ -299,6 +299,8 @@ Style/IfInsideElse:
   Enabled: false
 Style/IfUnlessModifier:
   Enabled: false
+Style/IfUnlessModifierOfIfUnless:
+  Enabled: false
 Style/IfWithSemicolon:
   Enabled: false
 Style/IndentArray:

data/config/disabled.yml

@@ -123,7 +123,3 @@ Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-i'
   Enabled: false
-
-Lint/LiteralInInterpolation:
-  Description: 'Avoid interpolating literals in strings'
-  AutoCorrect: false

data/config/enabled.yml

@@ -159,9 +159,6 @@ Style/ConditionalAssignment:
                  assignment to a variable and variable comparison instead
                  of assigning that variable inside of each branch.
   Enabled: true
-  SingleLineConditionsOnly: true
-  # Whether the cop should register offenses for conditionals whose branches
-  # contain more than one statement a piece
 
 Style/ConstantName:
   Description: 'Constants should use SCREAMING_SNAKE_CASE.'
@@ -324,6 +321,11 @@ Style/IfUnlessModifier:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier'
   Enabled: true
 
+Style/IfUnlessModifierOfIfUnless:
+  Description: >-
+                 Avoid modifier if/unless usage on conditionals.
+  Enabled: true
+
 Style/IfWithSemicolon:
   Description: 'Do not use if x; .... Use the ternary operator instead.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-semicolon-ifs'
@@ -1173,6 +1175,11 @@ Performance/Count:
                   Use `count` instead of `select...size`, `reject...size`,
                   `select...count`, `reject...count`, `select...length`,
                   and `reject...length`.
+  # This cop has known compatibility issues with `ActiveRecord` and other
+  # frameworks. ActiveRecord's `count` ignores the block that is passed to it.
+  # For more information, see the documentation in the cop itself.
+  # If you understand the known risk, you can disable `SafeMode`.
+  SafeMode: true
   Enabled: true
 
 Performance/Detect:
@@ -1180,6 +1187,11 @@ Performance/Detect:
                   Use `detect` instead of `select.first`, `find_all.first`,
                   `select.last`, and `find_all.last`.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerabledetect-vs-enumerableselectfirst-code'
+  # This cop has known compatibility issues with `ActiveRecord` and other
+  # frameworks. `ActiveRecord` does not implement a `detect` method and `find`
+  # has its own meaning. Correcting `ActiveRecord` methods with this cop
+  # should be considered unsafe.
+  SafeMode: true
   Enabled: true
 
 Performance/DoubleStartEndWith:

data/config/upstream.yml

@@ -344,6 +344,19 @@ Style/CommentAnnotation:
     - HACK
     - REVIEW
 
+Style/ConditionalAssignment:
+  EnforcedStyle: assign_to_condition
+  SupportedStyles:
+    - assign_to_condition
+    - assign_inside_condition
+  # When configured to `assign_to_condition`, `SingleLineConditionsOnly`
+  # will only register an offense when all branches of a condition are
+  # a single line.
+  # When configured to `assign_inside_condition`, `SingleLineConditionsOnly`
+  # will only register an offense for assignment to a condition that has
+  # at least one multiline branch.
+  SingleLineConditionsOnly: true
+
 # Checks that you have put a copyright in a comment before any code.
 #
 # You can override the default Notice in your .rubocop.yml file.
@@ -892,7 +905,7 @@ Style/TrivialAccessors:
   #
   # This way you can uncover "hidden" attributes in your code.
   ExactNameMatch: true
-  AllowPredicates: false
+  AllowPredicates: true
   # Allows trivial writers that don't end in an equal sign. e.g.
   #
   # def on_exception(action)
@@ -989,6 +1002,19 @@ Metrics/PerceivedComplexity:
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
+# checks whether the end keywords are aligned properly for `do` `end` blocks.
+Lint/BlockAlignment:
+  # The value `start_of_block` means that the `end` should be aligned with line
+  # where the `do` keyword appears.
+  # The value `start_of_line` means it should be aligned with the whole 
+  # expression's starting line.
+  # The value `either` means both are allowed.
+  AlignWith: either
+  SupportedStyles:
+    - either
+    - start_of_block
+    - start_of_line
+
 # Align ends correctly.
 Lint/EndAlignment:
   # The value `keyword` means that `end` should be aligned with the matching

data/lib/chefstyle/version.rb

@@ -1,4 +1,4 @@
 module Chefstyle
-  VERSION = "0.3.0".freeze
-  RUBOCOP_VERSION = "0.37.2".freeze
+  VERSION = "0.3.1".freeze
+  RUBOCOP_VERSION = "0.39.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Thom May
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-18 00:00:00.000000000 Z
+date: 2016-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.39.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.39.0
 description: 
 email:
 - thom@chef.io
@@ -111,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Rubocop configuration for Chef's ruby projects