cheffish 1.4.1 → 1.4.2

data/spec/unit/get_private_key_spec.rb

@@ -1,131 +1,131 @@
-require 'support/spec_support'
-require 'cheffish/rspec/chef_run_support'
-
-describe Cheffish do
-  let(:directory_that_exists) {
-    Dir.mktmpdir("cheffish-rspec")
-  }
-
-  let(:directory_that_does_not_exist) {
-    dir = Dir.mktmpdir("cheffish-rspec")
-    FileUtils.remove_entry dir
-    dir
-  }
-
-  let(:private_key_contents) { "contents of private key" }
-
-  let(:private_key_pem_contents) { "contents of private key pem" }
-
-  let(:private_key_garbage_contents) { "da vinci virus" }
-
-  def setup_key
-    key_file = File.expand_path("ned_stark", directory_that_exists)
-    File.open(key_file, "w+") do |f|
-      f.write private_key_contents
-    end
-    key_file
-  end
-
-  def setup_pem_key
-    key_file = File.expand_path("ned_stark.pem", directory_that_exists)
-    File.open(key_file, "w+") do |f|
-      f.write private_key_pem_contents
-    end
-    key_file
-  end
-
-  def setup_garbage_key
-    key_file = File.expand_path("ned_stark.pem.bak", directory_that_exists)
-    File.open(key_file, "w+") do |f|
-      f.write private_key_garbage_contents
-    end
-    key_file
-  end
-
-  shared_examples_for "returning the contents of the key file if it finds one" do
-    it "returns nil if it cannot find the private key file" do
-      expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
-    end
-
-    it "returns the contents of the key if it doesn't have an extension" do
-      setup_key
-      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_contents)
-    end
-
-    it "returns the contents of the key if it has an extension" do
-      setup_pem_key
-      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_pem_contents)
-    end
-
-    # we arbitrarily prefer "ned_stark" over "ned_stark.pem" for deterministic behavior
-    it "returns the contents of the key that does not have an extension if both exist" do
-      setup_key
-      setup_pem_key
-      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_contents)
-    end
-  end
-
-  describe "#get_private_key" do
-    context "when private_key_paths has a directory which is empty" do
-      let(:config) {
-        { :private_key_paths => [ directory_that_exists ] }
-      }
-
-      it_behaves_like "returning the contents of the key file if it finds one"
-
-      context "when it also has a garbage file" do
-        before { setup_garbage_key }
-
-        it "does not return the da vinci virus if we find only the garbage file" do
-          setup_garbage_key
-          expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
-        end
-
-        it_behaves_like "returning the contents of the key file if it finds one"
-      end
-
-    end
-
-    context "when private_key_paths leads with a directory that does not exist and then an empty directory" do
-      let(:config) {
-        { :private_key_paths => [ directory_that_does_not_exist, directory_that_exists ] }
-      }
-
-      it_behaves_like "returning the contents of the key file if it finds one"
-    end
-
-    context "when private_keys is empty" do
-      let(:config) {
-        { :private_keys => {} }
-      }
-
-      it "returns nil" do
-        expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
-      end
-    end
-
-    context "when private_keys contains the path to a key" do
-      let(:name) { "ned_stark" }
-      let(:config) {
-        { :private_keys => {name => setup_key} }
-      }
-
-      it "returns the contents of the key file" do
-        setup_key
-        expect(Cheffish.get_private_key(name, config)).to eq(private_key_contents)
-      end
-    end
-
-    context "when private_keys contains the path to a key" do
-      let(:name) { "ned_stark" }
-      let(:key) {double("key", :to_pem => private_key_contents)}
-      let(:config) {
-        { :private_keys => {name => key} }
-      }
-
-      it "returns the contents of the key file" do
-        expect(Cheffish.get_private_key(name, config)).to eq(private_key_contents)
-      end
-    end
-  end
-end
+require 'support/spec_support'
+require 'cheffish/rspec/chef_run_support'
+
+describe Cheffish do
+  let(:directory_that_exists) {
+    Dir.mktmpdir("cheffish-rspec")
+  }
+
+  let(:directory_that_does_not_exist) {
+    dir = Dir.mktmpdir("cheffish-rspec")
+    FileUtils.remove_entry dir
+    dir
+  }
+
+  let(:private_key_contents) { "contents of private key" }
+
+  let(:private_key_pem_contents) { "contents of private key pem" }
+
+  let(:private_key_garbage_contents) { "da vinci virus" }
+
+  def setup_key
+    key_file = File.expand_path("ned_stark", directory_that_exists)
+    File.open(key_file, "w+") do |f|
+      f.write private_key_contents
+    end
+    key_file
+  end
+
+  def setup_pem_key
+    key_file = File.expand_path("ned_stark.pem", directory_that_exists)
+    File.open(key_file, "w+") do |f|
+      f.write private_key_pem_contents
+    end
+    key_file
+  end
+
+  def setup_garbage_key
+    key_file = File.expand_path("ned_stark.pem.bak", directory_that_exists)
+    File.open(key_file, "w+") do |f|
+      f.write private_key_garbage_contents
+    end
+    key_file
+  end
+
+  shared_examples_for "returning the contents of the key file if it finds one" do
+    it "returns nil if it cannot find the private key file" do
+      expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
+    end
+
+    it "returns the contents of the key if it doesn't have an extension" do
+      setup_key
+      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_contents)
+    end
+
+    it "returns the contents of the key if it has an extension" do
+      setup_pem_key
+      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_pem_contents)
+    end
+
+    # we arbitrarily prefer "ned_stark" over "ned_stark.pem" for deterministic behavior
+    it "returns the contents of the key that does not have an extension if both exist" do
+      setup_key
+      setup_pem_key
+      expect(Cheffish.get_private_key("ned_stark", config)).to eq(private_key_contents)
+    end
+  end
+
+  describe "#get_private_key" do
+    context "when private_key_paths has a directory which is empty" do
+      let(:config) {
+        { :private_key_paths => [ directory_that_exists ] }
+      }
+
+      it_behaves_like "returning the contents of the key file if it finds one"
+
+      context "when it also has a garbage file" do
+        before { setup_garbage_key }
+
+        it "does not return the da vinci virus if we find only the garbage file" do
+          setup_garbage_key
+          expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
+        end
+
+        it_behaves_like "returning the contents of the key file if it finds one"
+      end
+
+    end
+
+    context "when private_key_paths leads with a directory that does not exist and then an empty directory" do
+      let(:config) {
+        { :private_key_paths => [ directory_that_does_not_exist, directory_that_exists ] }
+      }
+
+      it_behaves_like "returning the contents of the key file if it finds one"
+    end
+
+    context "when private_keys is empty" do
+      let(:config) {
+        { :private_keys => {} }
+      }
+
+      it "returns nil" do
+        expect(Cheffish.get_private_key("ned_stark", config)).to be_nil
+      end
+    end
+
+    context "when private_keys contains the path to a key" do
+      let(:name) { "ned_stark" }
+      let(:config) {
+        { :private_keys => {name => setup_key} }
+      }
+
+      it "returns the contents of the key file" do
+        setup_key
+        expect(Cheffish.get_private_key(name, config)).to eq(private_key_contents)
+      end
+    end
+
+    context "when private_keys contains the path to a key" do
+      let(:name) { "ned_stark" }
+      let(:key) {double("key", :to_pem => private_key_contents)}
+      let(:config) {
+        { :private_keys => {name => key} }
+      }
+
+      it "returns the contents of the key file" do
+        expect(Cheffish.get_private_key(name, config)).to eq(private_key_contents)
+      end
+    end
+  end
+end

data/spec/unit/recipe_run_wrapper_spec.rb

@@ -1,37 +1,37 @@
-require 'support/spec_support'
-require 'cheffish/rspec/chef_run_support'
-# require 'cheffish/rspec/recipe_run_wrapper'
-
-module MyModule
-  def respond_to_missing?(name, *args)
-    if name == :allowable_method
-      true
-    else
-      false
-    end
-  end
-end
-
-describe Cheffish::RSpec::RecipeRunWrapper do
-  extend Cheffish::RSpec::ChefRunSupport
-
-  let(:run_wrapper) {
-    Cheffish::RSpec::RecipeRunWrapper.new(chef_config) do
-      log "test recipe in specs"
-    end
-  }
-
-  context "defines #respond_to_missing? on the client" do
-    it "calls the new super.respond_to_missing" do
-      run_wrapper.client.extend MyModule
-      expect(run_wrapper.client.respond_to?(:allowable_method)).to be_truthy
-      expect(run_wrapper.client.respond_to?(:not_an_allowable_method)).to be_falsey
-    end
-  end
-
-  context "does not define #respond_to_missing? on the client" do
-    it "calls the original super.respond_to_missing" do
-      expect(run_wrapper.client.respond_to?(:nonexistent_method)).to be_falsey
-    end
-  end
-end
+require 'support/spec_support'
+require 'cheffish/rspec/chef_run_support'
+# require 'cheffish/rspec/recipe_run_wrapper'
+
+module MyModule
+  def respond_to_missing?(name, *args)
+    if name == :allowable_method
+      true
+    else
+      false
+    end
+  end
+end
+
+describe Cheffish::RSpec::RecipeRunWrapper do
+  extend Cheffish::RSpec::ChefRunSupport
+
+  let(:run_wrapper) {
+    Cheffish::RSpec::RecipeRunWrapper.new(chef_config) do
+      log "test recipe in specs"
+    end
+  }
+
+  context "defines #respond_to_missing? on the client" do
+    it "calls the new super.respond_to_missing" do
+      run_wrapper.client.extend MyModule
+      expect(run_wrapper.client.respond_to?(:allowable_method)).to be_truthy
+      expect(run_wrapper.client.respond_to?(:not_an_allowable_method)).to be_falsey
+    end
+  end
+
+  context "does not define #respond_to_missing? on the client" do
+    it "calls the original super.respond_to_missing" do
+      expect(run_wrapper.client.respond_to?(:nonexistent_method)).to be_falsey
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cheffish
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - John Keiser
@@ -167,8 +167,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: A library to manipulate Chef in Chef.
 test_files: []
+has_rdoc: